[Koha-bugs] [Bug 2806] issuingbranch isn't used
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2806 --- Comment #2 from Owen Leonard --- (In reply to Liz Rea from comment #1) > Which still leaves the question, populate issuingbranch or just depend on > items.branchcode and remove issuingbranch? Since items.branchcode is updated with the branchcode of the issuing branch, and then issues.branchcode is updated with the same value, what is the point of having a second field, issues.issuingbranch? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2806] issuingbranch isn't used
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2806 Liz Rea changed: What|Removed |Added Status|NEW |In Discussion CC||wizzy...@gmail.com --- Comment #1 from Liz Rea --- Owen is correct, the issuingbranch is being recorded as the holding branch (items.branchcode). Which still leaves the question, populate issuingbranch or just depend on items.branchcode and remove issuingbranch? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2806] issuingbranch isn't used
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2806 Jonathan Druart changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2806] issuingbranch isn't used
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2806 Jonathan Druart changed: What|Removed |Added Assignee|gmcha...@gmail.com |jonathan.dru...@biblibre.co ||m CC||jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2806] issuingbranch isn't used
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2806 --- Comment #3 from Jonathan Druart --- Created attachment 36124 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36124&action=edit Bug 2806: Remove issuingbranch columns This column is not in used in the Koha code and could be removed. Test plan: Verify the branch is correctly displayed on the circulation history (members/readingrec.pl) and that both reports Most-cisulated items (cat_issues_top.pl) and Avg checkout (issues_avg_stats.pl) work as before. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2806] issuingbranch isn't used
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2806 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #36124|0 |1 is obsolete|| --- Comment #4 from Bernardo Gonzalez Kriegel --- Created attachment 36499 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36499&action=edit [SIGNED-OFF] Bug 2806: Remove issuingbranch columns This column is not in used in the Koha code and could be removed. Test plan: Verify the branch is correctly displayed on the circulation history (members/readingrec.pl) and that both reports Most-cisulated items (cat_issues_top.pl) and Avg checkout (issues_avg_stats.pl) work as before. Signed-off-by: Bernardo Gonzalez Kriegel No problems found. Fixed wrong table name on updatedatabase.pl and a tab char. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2806] issuingbranch isn't used
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2806 Bernardo Gonzalez Kriegel changed: What|Removed |Added CC||bgkrie...@gmail.com Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2806] issuingbranch isn't used
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2806 Katrin Fischer changed: What|Removed |Added Attachment #36499|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 36559 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36559&action=edit [PASSED QA] Bug 2806: Remove issuingbranch columns This column is not in used in the Koha code and could be removed. Test plan: Verify the branch is correctly displayed on the circulation history (members/readingrec.pl) and that both reports Most-cisulated items (cat_issues_top.pl) and Avg checkout (issues_avg_stats.pl) work as before. Signed-off-by: Bernardo Gonzalez Kriegel No problems found. Fixed wrong table name on updatedatabase.pl and a tab char. Signed-off-by: Katrin Fischer Passes tests and QA script. Checked issues and returns are still working correctly. There is no mention of issuingbranch in the codebase. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2806] issuingbranch isn't used
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2806 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2806] issuingbranch isn't used
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2806 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #6 from Tomás Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
