[Koha-bugs] [Bug 28078] Add option to ignore hold counts when checking CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28078 Victor Grousset/tuxayo changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC||vic...@tuxayo.net --- Comment #15 from Victor Grousset/tuxayo --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28078] Add option to ignore hold counts when checking CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28078 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com Version(s)|21.05.00,20.11.06 |21.05.00,20.11.06,20.05.12 released in|| Status|Pushed to stable|Pushed to oldstable --- Comment #14 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28078] Add option to ignore hold counts when checking CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28078 Fridolin Somers changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|21.05.00|21.05.00,20.11.06 released in|| --- Comment #13 from Fridolin Somers --- Pushed to 20.11.x for 20.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28078] Add option to ignore hold counts when checking CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28078 --- Comment #12 from Joonas Kylmälä --- (In reply to Fridolin Somers from comment #11) > + should not check if there are too many holds as we only csre about > reservability > > Is it a typo for "care" ? yup. > This is more enhancement than bug no ? This is a dependency to fix a bug. The bug fix is in bug 28013. The issues caused by this bug were reported also in other bugs, like bug 26659. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28078] Add option to ignore hold counts when checking CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28078 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #11 from Fridolin Somers --- + should not check if there are too many holds as we only csre about reservability Is it a typo for "care" ? This is more enhancement than bug no ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28078] Add option to ignore hold counts when checking CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28078 --- Comment #10 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28078] Add option to ignore hold counts when checking CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28078 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||21.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28078] Add option to ignore hold counts when checking CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28078 --- Comment #9 from Joonas Kylmälä --- Passing QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28078] Add option to ignore hold counts when checking CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28078 --- Comment #8 from Joonas Kylmälä --- Created attachment 119264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119264=edit Bug 28078: (follow-up) Add param check to 'itemAlreadyOnHold' test Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28078] Add option to ignore hold counts when checking CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28078 Joonas Kylmälä changed: What|Removed |Added Attachment #119143|0 |1 is obsolete|| Attachment #119220|0 |1 is obsolete|| --- Comment #7 from Joonas Kylmälä --- Created attachment 119263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119263=edit Bug 28078: Add 'ignore_hold_counts' param to CanItemBeReserved This patch adds an optional param 'ignore_hold_counts' to the routine, while still forbidding holds when 0 are allowed To test: 1 - prove -v t/db_dependent/Holds.t Signed-off-by: David Nind JK: Commit message amended: Fixed title formatting Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28078] Add option to ignore hold counts when checking CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28078 Joonas Kylmälä changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28078] Add option to ignore hold counts when checking CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28078 Andrew Nugged changed: What|Removed |Added CC||nug...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28078] Add option to ignore hold counts when checking CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28078 --- Comment #6 from Nick Clemens --- Created attachment 119220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119220=edit Bug 28078: (follow-up) Add param check to 'itemAlreadyOnHold' test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28078] Add option to ignore hold counts when checking CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28078 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28078] Add option to ignore hold counts when checking CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28078
Joonas Kylmälä changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #5 from Joonas Kylmälä ---
(In reply to Nick Clemens from comment #4)
> (In reply to Joonas Kylmälä from comment #3)
> > Let me come back to this later but I'm pretty sure we cannot do this because
> > (at least how the parameter is used in the bug 28013) it wouldn't follow
> > circulation rules. We have libraries intentionally defining the amounts of
> > holds a patron in a specific patron category and in a specific library can
> > do to a specific item type. See also Bug 26659.
>
> I see what you are saying, the way I understand it is this:
> In CanBookBeRenewed we call CanItemBeReserved to see if the item could fill
> the reserve
>
> Those are two different questions:
>
> CanItemBeReserved answers the question: "Can the patron place a hold on this
> item?"
>
> What we are asking in CanBookBeRenewed is: "Can this item fill any hold for
> this patron?"
>
> In the first question the number of holds the patron currently has should be
> taken into account as the end result would be adding one more
>
> In the second question the number of holds don't matter, because we will not
> add any holds, we just want to know if we can fill the hold
>
>
> The other solution is two subroutines:
> CanItemBeReserved
> CanItemFillHold
>
> Note: We do have Koha::Holds->get_items_that_can_fill, however, that leaves
> out checks on transfer limits and counts of holds
Interesting. I see now you added the condition
> && (!$params->{ignore_hold_counts} || $allowedreserves == 0 )
so it still keeps follows the circulation rules also when allowedreserves rules
is 0. Maybe doing the check on also how many hold requests the patron has to
the biblio or item is not relevant here as you said.
However, I think this patch should also skip the itemAlreadyOnHold return value
for this to work on item-level holds as well, could you please re-do the patch?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28078] Add option to ignore hold counts when checking CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28078 --- Comment #4 from Nick Clemens --- (In reply to Joonas Kylmälä from comment #3) > Let me come back to this later but I'm pretty sure we cannot do this because > (at least how the parameter is used in the bug 28013) it wouldn't follow > circulation rules. We have libraries intentionally defining the amounts of > holds a patron in a specific patron category and in a specific library can > do to a specific item type. See also Bug 26659. I see what you are saying, the way I understand it is this: In CanBookBeRenewed we call CanItemBeReserved to see if the item could fill the reserve Those are two different questions: CanItemBeReserved answers the question: "Can the patron place a hold on this item?" What we are asking in CanBookBeRenewed is: "Can this item fill any hold for this patron?" In the first question the number of holds the patron currently has should be taken into account as the end result would be adding one more In the second question the number of holds don't matter, because we will not add any holds, we just want to know if we can fill the hold The other solution is two subroutines: CanItemBeReserved CanItemFillHold Note: We do have Koha::Holds->get_items_that_can_fill, however, that leaves out checks on transfer limits and counts of holds -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28078] Add option to ignore hold counts when checking CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28078 Joonas Kylmälä changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26659 CC||joonas.kylm...@helsinki.fi --- Comment #3 from Joonas Kylmälä --- Let me come back to this later but I'm pretty sure we cannot do this because (at least how the parameter is used in the bug 28013) it wouldn't follow circulation rules. We have libraries intentionally defining the amounts of holds a patron in a specific patron category and in a specific library can do to a specific item type. See also Bug 26659. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28078] Add option to ignore hold counts when checking CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28078 David Nind changed: What|Removed |Added Attachment #119124|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 119143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119143=edit Bug 28078 - Add 'ignore_hold_counts' param to CanItemBeReserved This patch adds an optional param 'ignore_hold_counts' to the routine, while still forbidding holds when 0 are allowed To test: 1 - prove -v t/db_dependent/Holds.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28078] Add option to ignore hold counts when checking CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28078 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28078] Add option to ignore hold counts when checking CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28078 --- Comment #1 from Nick Clemens --- Created attachment 119124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119124=edit Bug 28078 - Add 'ignore_hold_counts' param to CanItemBeReserved This patch adds an optional param 'ignore_hold_counts' to the routine, while still forbidding holds when 0 are allowed To test: 1 - prove -v t/db_dependent/Holds.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28078] Add option to ignore hold counts when checking CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28078 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28078] Add option to ignore hold counts when checking CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28078 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | Blocks||28013 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013 [Bug 28013] Improvements to CanBookBeRenewed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
