[Koha-bugs] [Bug 28086] Email address shown on OpacMaintenancePage should use ReplytoDefault if set

2021-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28086

--- Comment #16 from Katrin Fischer  ---
(In reply to Tomás Cohen Arazi from comment #15)
> I think we should have a new configuration for this particular use case
> (email address to be displayed in OPAC when some error needs to be reported).
> 
> If I was to pick one, I would say the admin address is the right one, and
> libraries should set different values for each branch. But I see Katrin's
> point/need.

It's not only my need actually. I think as the reply-to address is used when
you reply to emails, it makes a lot of sense to use it first. If you don't want
to use it, you don't have to set it at all. I believe this is all the
configuration we need here. It's optional and probably will only be set when
you have a use case that requires it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28086] Email address shown on OpacMaintenancePage should use ReplytoDefault if set

2021-05-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28086

--- Comment #15 from Tomás Cohen Arazi  ---
I think we should have a new configuration for this particular use case (email
address to be displayed in OPAC when some error needs to be reported).

If I was to pick one, I would say the admin address is the right one, and
libraries should set different values for each branch. But I see Katrin's
point/need.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28086] Email address shown on OpacMaintenancePage should use ReplytoDefault if set

2021-05-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28086

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |minor

--- Comment #14 from Katrin Fischer  ---
Actually more of a bugfix I think - in our case at the moment always a
'noreply@' is shown.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28086] Email address shown on OpacMaintenancePage should use ReplytoDefault if set

2021-04-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28086

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #13 from Fridolin Somers  ---
Enhancement not pushed to 20.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28086] Email address shown on OpacMaintenancePage should use ReplytoDefault if set

2021-04-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28086
Bug 28086 depends on bug 27940, which changed state.

Bug 27940 Summary: Fix missing email in OpacMaintenance page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27940

   What|Removed |Added

 Status|Pushed to oldstable |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28086] Email address shown on OpacMaintenancePage should use ReplytoDefault if set

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28086

David Nind  changed:

   What|Removed |Added

  Text to go in the||This enhancement changes
  release notes||the OPAC maintenance page*
   ||so that it uses the email
   ||address from the
   ||ReplyToDefault system
   ||preference, if it is set,
   ||for the "please contact the
   ||site administrator" email
   ||link.
   ||
   ||If ReplyToDefault is
   ||not set, it will use
   ||KohaAdminEmailAddress.
   ||
   ||If
   ||both ReplytoDefault and
   ||KohaAdminEmailAddress are
   ||not set, no link is shown.
   ||
   ||* Displays when the
   ||OpacMaintenance system
   ||preference is set to
   ||"Show".
   Keywords||Manual

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28086] Email address shown on OpacMaintenancePage should use ReplytoDefault if set

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28086

--- Comment #12 from Jonathan Druart  
---
Pushed to master for 21.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28086] Email address shown on OpacMaintenancePage should use ReplytoDefault if set

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28086

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)|With this change the email  |21.05.00
released in|address configured in the   |
   |ReplyToDefault will display |
   |on the OPAC maintenance |
   |page if set. If not set,|
   |the email address   |
   |configured in   |
   |KohaAdminEmailAddress will  |
   |be used as before.  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28086] Email address shown on OpacMaintenancePage should use ReplytoDefault if set

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28086

--- Comment #11 from Katrin Fischer  ---
(In reply to Jonathan Druart from comment #10)
> I am not sure I understand the point of having KohaAdminEmailAddress a
> fallback for ReplytoDefault everywhere. In that case why do we keep
> KohaAdminEmailAddress?

E-mail configuration varies widely. If a library has set a reply-to you can
assume they want to use it in these cases. If they have left it empty, we
should use KohaAdminEmailAdress.

Reply-to is mostly much needed for support companies. If you are self hosting
using your own institution's mail server, you won't need it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28086] Email address shown on OpacMaintenancePage should use ReplytoDefault if set

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28086

--- Comment #10 from Jonathan Druart  
---
I am not sure I understand the point of having KohaAdminEmailAddress a fallback
for ReplytoDefault everywhere. In that case why do we keep
KohaAdminEmailAddress?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28086] Email address shown on OpacMaintenancePage should use ReplytoDefault if set

2021-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28086

--- Comment #9 from Katrin Fischer  ---
(In reply to Jonathan Druart from comment #6)
> Hum, pondering. Why the OPAC maintenance only?
> 
> Why not this one as well for instance?
> Koha/Patron/Password/Recovery.pm:my $kohaEmail = $library->branchemail
> || C4::Context->preference('KohaAdminEmailAddress');  # send from patron's
> branch or Koha Admin

Pondering why this still works for us, I think something happens in 
sub _send_message_by_email to that. Jonathan, can you maybe verify and let me
know if I should file another bug?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28086] Email address shown on OpacMaintenancePage should use ReplytoDefault if set

2021-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28086

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #119568|0   |1
is obsolete||

--- Comment #8 from Katrin Fischer  ---
Created attachment 119802
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119802&action=edit
Bug 28086: OpacMaintenance page should use ReplytoDefault if set

This patch changes the OPAC maintenance template so that it checks for a
value in the ReplyToDefault system preference when displaying the
"please contact the site administrator" email link.

Also changed: If neither ReplytoDefault nor KohaAdminEmailAddress is
defined, it won't show the link at all.

To test, apply the patch and set the OpacMaintenance preference to
"Show."

 - In the OPAC you should see the "System Maintenance" page.
 - Test this page with various settings:
   - ReplytoDefault and KohaAdminEmailAddress both populated.
   - Only ReplytoDefault
   - Only KohaAdminEmailAddress
   - Neither.

 Confirm that the correct email address is used in each case.

Signed-off-by: David Nind 

Signed-off-by: Jonathan Druart 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28086] Email address shown on OpacMaintenancePage should use ReplytoDefault if set

2021-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28086

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28086] Email address shown on OpacMaintenancePage should use ReplytoDefault if set

2021-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28086

Katrin Fischer  changed:

   What|Removed |Added

 Version(s)||With this change the email
released in||address configured in the
   ||ReplyToDefault will display
   ||on the OPAC maintenance
   ||page if set. If not set,
   ||the email address
   ||configured in
   ||KohaAdminEmailAddress will
   ||be used as before.
   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28086] Email address shown on OpacMaintenancePage should use ReplytoDefault if set

2021-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28086

--- Comment #7 from Katrin Fischer  ---
(In reply to Jonathan Druart from comment #6)
> Hum, pondering. Why the OPAC maintenance only?
> 
> Why not this one as well for instance?
> Koha/Patron/Password/Recovery.pm:my $kohaEmail = $library->branchemail
> || C4::Context->preference('KohaAdminEmailAddress');  # send from patron's
> branch or Koha Admin

Yes please, if we have missed other cases, we should do them too. But I
recommend not fixing them all in the same bug to keep things moving.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28086] Email address shown on OpacMaintenancePage should use ReplytoDefault if set

2021-04-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28086

Jonathan Druart  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28086] Email address shown on OpacMaintenancePage should use ReplytoDefault if set

2021-04-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28086

--- Comment #6 from Jonathan Druart  
---
Hum, pondering. Why the OPAC maintenance only?

Why not this one as well for instance?
Koha/Patron/Password/Recovery.pm:my $kohaEmail = $library->branchemail ||
C4::Context->preference('KohaAdminEmailAddress');  # send from patron's branch
or Koha Admin

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28086] Email address shown on OpacMaintenancePage should use ReplytoDefault if set

2021-04-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28086

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #119564|0   |1
is obsolete||

--- Comment #5 from Jonathan Druart  
---
Created attachment 119568
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119568&action=edit
Bug 28086: OpacMaintenance page should use ReplytoDefault if set

This patch changes the OPAC maintenance template so that it checks for a
value in the ReplyToDefault system preference when displaying the
"please contact the site administrator" email link.

Also changed: If neither ReplytoDefault nor KohaAdminEmailAddress is
defined, it won't show the link at all.

To test, apply the patch and set the OpacMaintenance preference to
"Show."

 - In the OPAC you should see the "System Maintenance" page.
 - Test this page with various settings:
   - ReplytoDefault and KohaAdminEmailAddress both populated.
   - Only ReplytoDefault
   - Only KohaAdminEmailAddress
   - Neither.

 Confirm that the correct email address is used in each case.

Signed-off-by: David Nind 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28086] Email address shown on OpacMaintenancePage should use ReplytoDefault if set

2021-04-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28086

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28086] Email address shown on OpacMaintenancePage should use ReplytoDefault if set

2021-04-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28086

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||release-notes-needed
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28086] Email address shown on OpacMaintenancePage should use ReplytoDefault if set

2021-04-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28086

David Nind  changed:

   What|Removed |Added

 Attachment #119561|0   |1
is obsolete||

--- Comment #4 from David Nind  ---
Created attachment 119564
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119564&action=edit
Bug 28086: OpacMaintenance page should use ReplytoDefault if set

This patch changes the OPAC maintenance template so that it checks for a
value in the ReplyToDefault system preference when displaying the
"please contact the site administrator" email link.

Also changed: If neither ReplytoDefault nor KohaAdminEmailAddress is
defined, it won't show the link at all.

To test, apply the patch and set the OpacMaintenance preference to
"Show."

 - In the OPAC you should see the "System Maintenance" page.
 - Test this page with various settings:
   - ReplytoDefault and KohaAdminEmailAddress both populated.
   - Only ReplytoDefault
   - Only KohaAdminEmailAddress
   - Neither.

 Confirm that the correct email address is used in each case.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28086] Email address shown on OpacMaintenancePage should use ReplytoDefault if set

2021-04-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28086

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28086] Email address shown on OpacMaintenancePage should use ReplytoDefault if set

2021-04-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28086

Owen Leonard  changed:

   What|Removed |Added

 Attachment #119325|0   |1
is obsolete||

--- Comment #3 from Owen Leonard  ---
Created attachment 119561
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119561&action=edit
Bug 28086: OpacMaintenance page should use ReplytoDefault if set

This patch changes the OPAC maintenance template so that it checks for a
value in the ReplyToDefault system preference when displaying the
"please contact the site administrator" email link.

Also changed: If neither ReplytoDefault nor KohaAdminEmailAddress is
defined, it won't show the link at all.

To test, apply the patch and set the OpacMaintenance preference to
"Show."

 - In the OPAC you should see the "System Maintenance" page.
 - Test this page with various settings:
   - ReplytoDefault and KohaAdminEmailAddress both populated.
   - Only ReplytoDefault
   - Only KohaAdminEmailAddress
   - Neither.

 Confirm that the correct email address is used in each case.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28086] Email address shown on OpacMaintenancePage should use ReplytoDefault if set

2021-04-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28086

Owen Leonard  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28086] Email address shown on OpacMaintenancePage should use ReplytoDefault if set

2021-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28086

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #2 from David Nind  ---
I can't apply the patch for some reason:

Applying: Bug 28086: OpacMaintenance page should use ReplytoDefault if set
error: sha1 information is lacking or useless
(koha-tmpl/opac-tmpl/bootstrap/en/modules/maintenance.tt).
error: could not build fake ancestor
Patch failed at 0001 Bug 28086: OpacMaintenance page should use ReplytoDefault
if set

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28086] Email address shown on OpacMaintenancePage should use ReplytoDefault if set

2021-04-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28086

--- Comment #1 from Owen Leonard  ---
Created attachment 119325
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119325&action=edit
Bug 28086: OpacMaintenance page should use ReplytoDefault if set

This patch changes the OPAC maintenance template so that it checks for a
value in the ReplyToDefault system preference when displaying the
"please contact the site administrator" email link.

Also changed: If neither ReplytoDefault nor KohaAdminEmailAddress is
defined, it won't show the link at all.

To test, apply the patch and set the OpacMaintenance preference to
"Show."

 - In the OPAC you should see the "System Maintenance" page.
 - Test this page with various settings:
   - ReplytoDefault and KohaAdminEmailAddress both populated.
   - Only ReplytoDefault
   - Only KohaAdminEmailAddress
   - Neither.

 Confirm that the correct email address is used in each case.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28086] Email address shown on OpacMaintenancePage should use ReplytoDefault if set

2021-04-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28086

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28086] Email address shown on OpacMaintenancePage should use ReplytoDefault if set

2021-04-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28086

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28086] Email address shown on OpacMaintenancePage should use ReplytoDefault if set

2021-04-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28086

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||27940


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27940
[Bug 27940] Fix missing email in OpacMaintenance page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/