[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #38 from Katrin Fischer --- One more: img.alt = "Cover image"; -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #37 from Katrin Fischer --- I believe there might be some problematic constructions for translation in the JavaScript, but need to investigate further: lightbox_descriptions.push("Custom cover image"); lightbox_descriptions.push(_("Image from Google Books (see the original image)").format($(img).data('link'))); -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #36 from Katrin Fischer --- (In reply to Jonathan Druart from comment #35) > (In reply to Katrin Fischer from comment #34) > > You are right, I was a little too fast. But why include them in the first > > place? > > To ease testing, especially for sandboxes. You can now do the yarn build bit on the sandboxes, but of course not everybody might know that. I was more thinking about the conflicts causing problems there. There is always something that can go wrong I guess :) I shoudl have taken a better look here at the conflict anyway. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #35 from Jonathan Druart --- (In reply to Katrin Fischer from comment #34) > You are right, I was a little too fast. But why include them in the first > place? To ease testing, especially for sandboxes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #34 from Katrin Fischer --- You are right, I was a little too fast. But why include them in the first place? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Jonathan Druart changed: What|Removed |Added Attachment #122784|0 |1 is obsolete|| --- Comment #33 from Jonathan Druart --- Created attachment 123178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123178=edit Bug 28180: CSS changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Signed Off --- Comment #32 from Jonathan Druart --- (In reply to Katrin Fischer from comment #31) > Can you please fix the conflicts? > CONFLICT (content): Merge conflict in > koha-tmpl/opac-tmpl/bootstrap/css/opac.css > CONFLICT (content): Merge conflict in > koha-tmpl/opac-tmpl/bootstrap/css/opac-rtl.css Those are conflicts on the "Compiled CSS patch". The patch can be skipped and the patch regenerated with "yarn build && yarn build --view=opac" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #31 from Katrin Fischer --- Can you please fix the conflicts? Using index info to reconstruct a base tree... M koha-tmpl/opac-tmpl/bootstrap/css/opac-rtl.css M koha-tmpl/opac-tmpl/bootstrap/css/opac.css Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/css/opac.css CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/css/opac.css Auto-merging koha-tmpl/opac-tmpl/bootstrap/css/opac-rtl.css CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/css/opac-rtl.css error: Failed to merge in the changes. Patch failed at 0001 Bug 28180: CSS changes The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #30 from Jonathan Druart --- Your follow-up is working great, Owen. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #29 from Jonathan Druart --- Created attachment 122784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122784=edit Bug 28180: CSS changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Jonathan Druart changed: What|Removed |Added Attachment #120805|0 |1 is obsolete|| --- Comment #28 from Jonathan Druart --- Created attachment 122783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122783=edit Bug 28180: (follow-up) Updates to styling of lightbox controls This patch adds style changes like the ones made in Bug 28179. It also addresses a bug with the way the verify_images() function was firing. I've moved the function outside of document.ready() and added a call to it on window load, consistent with how it works in the staff client. I've removed a redundant call to verify_images() from the footer include file, opac-bottom.inc. The cosmetic changes replace the Chocolat image icons with new SVG assets based on Bootstrap Icons (https://icons.getbootstrap.com/). The color changes I think help the controls to be more visible. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #27 from Owen Leonard --- Created attachment 120805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120805=edit Bug 28180: (follow-up) Updates to styling of lightbox controls This patch adds style changes like the ones made in Bug 28179. It also addresses a bug with the way the verify_images() function was firing. I've moved the function outside of document.ready() and added a call to it on window load, consistent with how it works in the staff client. I've removed a redundant call to verify_images() from the footer include file, opac-bottom.inc. The cosmetic changes replace the Chocolat image icons with new SVG assets based on Bootstrap Icons (https://icons.getbootstrap.com/). The color changes I think help the controls to be more visible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Owen Leonard changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #26 from Jonathan Druart --- (In reply to Katrin Fischer from comment #23) Both fixed! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #25 from Jonathan Druart --- Created attachment 120754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120754=edit Bug 28180: Restore NO_LOCAL_JACKET This is a patch to squash. No idea what it got removed previously -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #24 from Jonathan Druart --- Created attachment 120753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120753=edit Bug 28180: (follow-up) Remove console.log -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #23 from Katrin Fischer --- I am seeing a failure in the QA script, can you please check: FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt OK filters FAIL forbidden patterns forbidden pattern: console.log (line 1754) Also and more importantly, with this patch covers on result list are broken: Uncaught ReferenceError: NO_LOCAL_JACKET is not defined GetCoverFromBibnumber http://localhost:8080/opac-tmpl/bootstrap/js/localcovers_20.1200047.js:25 jQuery 2 GetCoverFromBibnumber http://localhost:8080/opac-tmpl/bootstrap/js/localcovers_20.1200047.js:21 http://localhost:8080/cgi-bin/koha/opac-search.pl?idx==perl_search=1:3137 jQuery 2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #22 from Jonathan Druart --- Signed-off-by patches attached on behalf of the sponsor. The sandbox's signoff process picked the name of the creator of the sandbox instead of the one filled in on the signoff form. Also, the status has not been adjusted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #21 from Jonathan Druart --- Created attachment 120470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120470=edit Bug 28180: Bug fix - cannot select cover-nav button when on top of the .contentblock Found a bug and ended up with this solution, suggestions welcomed! example with OpenLibrary with isbn=9780670026623, the image is a bit higher than others and then the cover-nav buttons are on top of .contentblock and cannot be clicked Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Rasmus Leißner -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #20 from Jonathan Druart --- Created attachment 120469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120469=edit Bug 28180: Reintroduce and adjust Baker and Taylor Test plan: 1. Turn on BakerTaylorEnabled and fill BakerTaylorUsername/BakerTaylorPassword (if you don't have, ask me) 2. Display the cover images in the gallery Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Rasmus Leißner -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #19 from Jonathan Druart --- Created attachment 120468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120468=edit Bug 28180: Reintroduce and adjust OpenLibrary 1. Turn on OpenLibraryCovers 2. Display the cover images in the gallery Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Rasmus Leißner -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #18 from Jonathan Druart --- Created attachment 120467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120467=edit Bug 28180: Reintroduce and adjust Google Jackets Test plan: 1. Turn on GoogleJackets 2. Display the cover images in the gallery Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Rasmus Leißner -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #17 from Jonathan Druart --- Created attachment 120466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120466=edit Bug 28180: Reintroduce and adjust Syndetics Test plan: 1. Enable SyndeticsEnabled and SyndeticsCoverImages 2. Display the cover images in the gallery Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Rasmus Leißner -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #16 from Jonathan Druart --- Created attachment 120465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120465=edit Bug 28180: Add a lightbox gallery to display cover images - detail page, OPAC interface This patch is the OPAC version of Bug 28179: Add a lightbox gallery to display cover images - detail page, staff interface But there were several difficulties as the staff and OPAC code diverged a lot. First we are going to apply the different enhancements that have been made staff-side: - Display all the local cover image on the bibliographic detail pages (before this patch only the first one was displayed) - The slider functionality added by bug 25031 Test plan: All the cover images are affected, all the different sources will be tested. All the steps will be done on the same bibliographic record. 1. Local cover images a. Turn on OPACLocalCoverImages and AllowMultipleCover b. Add several local cover images to a bibliographic record c. Add several local cover images to an item d. Click on an image and confirm that it is displayed in a gallery and you can navigate see all the images attached to the bibliographic record e. Same for items 2. Adlibris a. Turn on AdlibrisCoversEnabled b. Edit the biliographic record and add an ISBN that will return a cover image for this service (9780670026623 for instance) c. Display the cover images in the gallery d. Note the link to the adlibris.com website at the bottom 3. Amazon a. Turn on OPACAmazonCoverImages b. Display the cover images in the gallery 4. Coce a. Turn on OpacCoce, set CoceHost to "http://coce.tamil.fr:8080; and select some values for CoceProviders. b. Display the cover images in the gallery 5. Custom cover images a. Turn on OPACCustomCoverImages and set CustomCoverImagesURL to https://covers.openlibrary.org/b/isbn/{isbn}-M.jpg of anything else meaningful b. Display the cover images in the gallery QA Note: Other sources have been removed by this patch but will be re-added by follow-ups Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Rasmus Leißner -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Jonathan Druart changed: What|Removed |Added Attachment #120444|0 |1 is obsolete|| Attachment #120445|0 |1 is obsolete|| Attachment #120446|0 |1 is obsolete|| Attachment #120447|0 |1 is obsolete|| Attachment #120448|0 |1 is obsolete|| Attachment #120449|0 |1 is obsolete|| Attachment #120450|0 |1 is obsolete|| --- Comment #15 from Jonathan Druart --- Created attachment 120464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120464=edit Bug 28180: Add Chocolat to OPAC See Bug 28179: Add the Chocolat gallery lightbox JS library Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Rasmus Leißner -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #119924|0 |1 is obsolete|| --- Comment #14 from PTFS Europe Sandboxes --- Created attachment 120450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120450=edit Bug 28180: Bug fix - cannot select cover-nav button when on top of the .contentblock Found a bug and ended up with this solution, suggestions welcomed! example with OpenLibrary with isbn=9780670026623, the image is a bit higher than others and then the cover-nav buttons are on top of .contentblock and cannot be clicked Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: joubu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #119923|0 |1 is obsolete|| --- Comment #13 from PTFS Europe Sandboxes --- Created attachment 120449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120449=edit Bug 28180: Reintroduce and adjust Baker and Taylor Test plan: 1. Turn on BakerTaylorEnabled and fill BakerTaylorUsername/BakerTaylorPassword (if you don't have, ask me) 2. Display the cover images in the gallery Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: joubu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #119922|0 |1 is obsolete|| --- Comment #12 from PTFS Europe Sandboxes --- Created attachment 120448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120448=edit Bug 28180: Reintroduce and adjust OpenLibrary 1. Turn on OpenLibraryCovers 2. Display the cover images in the gallery Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: joubu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #119921|0 |1 is obsolete|| --- Comment #11 from PTFS Europe Sandboxes --- Created attachment 120447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120447=edit Bug 28180: Reintroduce and adjust Google Jackets Test plan: 1. Turn on GoogleJackets 2. Display the cover images in the gallery Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: joubu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #119920|0 |1 is obsolete|| --- Comment #10 from PTFS Europe Sandboxes --- Created attachment 120446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120446=edit Bug 28180: Reintroduce and adjust Syndetics Test plan: 1. Enable SyndeticsEnabled and SyndeticsCoverImages 2. Display the cover images in the gallery Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: joubu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #119919|0 |1 is obsolete|| --- Comment #9 from PTFS Europe Sandboxes --- Created attachment 120445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120445=edit Bug 28180: Add a lightbox gallery to display cover images - detail page, OPAC interface This patch is the OPAC version of Bug 28179: Add a lightbox gallery to display cover images - detail page, staff interface But there were several difficulties as the staff and OPAC code diverged a lot. First we are going to apply the different enhancements that have been made staff-side: - Display all the local cover image on the bibliographic detail pages (before this patch only the first one was displayed) - The slider functionality added by bug 25031 Test plan: All the cover images are affected, all the different sources will be tested. All the steps will be done on the same bibliographic record. 1. Local cover images a. Turn on OPACLocalCoverImages and AllowMultipleCover b. Add several local cover images to a bibliographic record c. Add several local cover images to an item d. Click on an image and confirm that it is displayed in a gallery and you can navigate see all the images attached to the bibliographic record e. Same for items 2. Adlibris a. Turn on AdlibrisCoversEnabled b. Edit the biliographic record and add an ISBN that will return a cover image for this service (9780670026623 for instance) c. Display the cover images in the gallery d. Note the link to the adlibris.com website at the bottom 3. Amazon a. Turn on OPACAmazonCoverImages b. Display the cover images in the gallery 4. Coce a. Turn on OpacCoce, set CoceHost to "http://coce.tamil.fr:8080; and select some values for CoceProviders. b. Display the cover images in the gallery 5. Custom cover images a. Turn on OPACCustomCoverImages and set CustomCoverImagesURL to https://covers.openlibrary.org/b/isbn/{isbn}-M.jpg of anything else meaningful b. Display the cover images in the gallery QA Note: Other sources have been removed by this patch but will be re-added by follow-ups Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: joubu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #119918|0 |1 is obsolete|| --- Comment #8 from PTFS Europe Sandboxes --- Created attachment 120444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120444=edit Bug 28180: Add Chocolat to OPAC See Bug 28179: Add the Chocolat gallery lightbox JS library Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: joubu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #7 from Jonathan Druart --- Created attachment 119924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119924=edit Bug 28180: Bug fix - cannot select cover-nav button when on top of the .contentblock Found a bug and ended up with this solution, suggestions welcomed! example with OpenLibrary with isbn=9780670026623, the image is a bit higher than others and then the cover-nav buttons are on top of .contentblock and cannot be clicked Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #6 from Jonathan Druart --- Created attachment 119923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119923=edit Bug 28180: Reintroduce and adjust Baker and Taylor Test plan: 1. Turn on BakerTaylorEnabled and fill BakerTaylorUsername/BakerTaylorPassword (if you don't have, ask me) 2. Display the cover images in the gallery Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #5 from Jonathan Druart --- Created attachment 119922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119922=edit Bug 28180: Reintroduce and adjust OpenLibrary 1. Turn on OpenLibraryCovers 2. Display the cover images in the gallery Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #4 from Jonathan Druart --- Created attachment 119921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119921=edit Bug 28180: Reintroduce and adjust Google Jackets Test plan: 1. Turn on GoogleJackets 2. Display the cover images in the gallery Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #3 from Jonathan Druart --- Created attachment 119920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119920=edit Bug 28180: Reintroduce and adjust Syndetics Test plan: 1. Enable SyndeticsEnabled and SyndeticsCoverImages 2. Display the cover images in the gallery Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #2 from Jonathan Druart --- Created attachment 119919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119919=edit Bug 28180: Add a lightbox gallery to display cover images - detail page, OPAC interface This patch is the OPAC version of Bug 28179: Add a lightbox gallery to display cover images - detail page, staff interface But there were several difficulties as the staff and OPAC code diverged a lot. First we are going to apply the different enhancements that have been made staff-side: - Display all the local cover image on the bibliographic detail pages (before this patch only the first one was displayed) - The slider functionality added by bug 25031 Test plan: All the cover images are affected, all the different sources will be tested. All the steps will be done on the same bibliographic record. 1. Local cover images a. Turn on OPACLocalCoverImages and AllowMultipleCover b. Add several local cover images to a bibliographic record c. Add several local cover images to an item d. Click on an image and confirm that it is displayed in a gallery and you can navigate see all the images attached to the bibliographic record e. Same for items 2. Adlibris a. Turn on AdlibrisCoversEnabled b. Edit the biliographic record and add an ISBN that will return a cover image for this service (9780670026623 for instance) c. Display the cover images in the gallery d. Note the link to the adlibris.com website at the bottom 3. Amazon a. Turn on OPACAmazonCoverImages b. Display the cover images in the gallery 4. Coce a. Turn on OpacCoce, set CoceHost to "http://coce.tamil.fr:8080; and select some values for CoceProviders. b. Display the cover images in the gallery 5. Custom cover images a. Turn on OPACCustomCoverImages and set CustomCoverImagesURL to https://covers.openlibrary.org/b/isbn/{isbn}-M.jpg of anything else meaningful b. Display the cover images in the gallery QA Note: Other sources have been removed by this patch but will be re-added by follow-ups Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #1 from Jonathan Druart --- Created attachment 119918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119918=edit Bug 28180: Add Chocolat to OPAC See Bug 28179: Add the Chocolat gallery lightbox JS library Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Jonathan Druart changed: What|Removed |Added Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/