[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2024-05-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

David Cook  changed:

   What|Removed |Added

 Blocks|36966   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36966
[Bug 36966] Fix links for local cover images for items on staff detail page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2024-05-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

David Cook  changed:

   What|Removed |Added

 Blocks||36966


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36966
[Bug 36966] Fix links for local cover images for items on staff detail page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2023-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Owen Leonard  changed:

   What|Removed |Added

 Blocks||35633


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35633
[Bug 35633] Upgrade Chocolat JS library from v1.1.0 to v1.1.2
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2022-08-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Alex Buckley  changed:

   What|Removed |Added

 Blocks||31446


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31446
[Bug 31446] Optionally hide lightbox_descriptions from OPAC lightbox gallery
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2022-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

David Cook  changed:

   What|Removed |Added

 CC||kmk...@anantcorp.com

--- Comment #98 from David Cook  ---
*** Bug 7187 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2022-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

David Cook  changed:

   What|Removed |Added

 CC||koha.sek...@gmail.com

--- Comment #97 from David Cook  ---
*** Bug 7709 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2022-07-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Alex Buckley  changed:

   What|Removed |Added

 Blocks||31217


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31217
[Bug 31217] Fix Coce JavaScript to hide single-pixel cover images in the OPAC
lightbox gallery
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2022-07-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||31207


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31207
[Bug 31207] The OPAC Shelf browser fails to display local cover images
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Andreas Roussos  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=31207

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2022-07-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Owen Leonard  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=26933

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2022-01-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||29803


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803
[Bug 29803] Locally stored cover images do not show in detail page for
individual biblio, but do show in listing for multiple biblios
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Jonathan Druart  changed:

   What|Removed |Added

   Severity|enhancement |new feature

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

--- Comment #96 from Katrin Fischer  ---
Maybe another candidate for 'new feature'?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Jonathan Druart  changed:

   What|Removed |Added

  Text to go in the|This enhancement to the |This enhancement to the
  release notes|OPAC enables the display of |OPAC enables the display of
   |multiple cover images on|multiple cover images on
   |the detail page for a   |the detail page for a
   |record in a light box.  |record or items in a
   |Previously only one image   |gallery.
   |was displayed.  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com
   Keywords|release-notes-needed|
  Text to go in the||This enhancement to the
  release notes||OPAC enables the display of
   ||multiple cover images on
   ||the detail page for a
   ||record in a light box.
   ||Previously only one image
   ||was displayed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Kyle M Hall  changed:

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 Resolution|--- |FIXED
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180
Bug 28180 depends on bug 29200, which changed state.

Bug 29200 Summary: Remove Adlibris cover service
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29200

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

--- Comment #95 from Jonathan Druart  ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Jonathan Druart  changed:

   What|Removed |Added

 Version(s)||21.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #126520|0   |1
is obsolete||

--- Comment #94 from Katrin Fischer  ---
Created attachment 126610
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126610=edit
Bug 28180: Remove adlibris conflict

Can be squashed when pushed

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #126519|0   |1
is obsolete||

--- Comment #93 from Katrin Fischer  ---
Created attachment 126609
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126609=edit
Bug 28180: Fix bug with first image does not exist

This was first written for Adlibris, before its removal from the
codebase.
But this patch maybe still be useful for other services (if first and no
image).

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #126518|0   |1
is obsolete||

--- Comment #92 from Katrin Fischer  ---
Created attachment 126608
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126608=edit
Bug 28180: Correctly guess if images have been loaded

window.load won't assure us that the images loaded using JS code are
correctly loaded.

This patch adds a flag to the different providers when the images are
fully loaded.

Note that the img.naturalHeight check is not working for google jackets
and is actually not needed (test with a bib record with and without
google jacket and confirm that it's working as expected).

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #126517|0   |1
is obsolete||

--- Comment #91 from Katrin Fischer  ---
Created attachment 126607
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126607=edit
Bug 28180: Fix collision with existing verify_images

At the OPAC we already had a verify_images JS function in amazonimages.js
It's preferable to use another function name.
This patch replace our verify_images with verify_cover_images and apply
the change to the staff code as well.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #126516|0   |1
is obsolete||

--- Comment #90 from Katrin Fischer  ---
Created attachment 126606
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126606=edit
Bug 28180: Fix some non-translatable strings

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #126515|0   |1
is obsolete||

--- Comment #89 from Katrin Fischer  ---
Created attachment 126605
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126605=edit
Bug 28180: (follow-up) Updates to styling of lightbox controls

This patch adds style changes like the ones made in Bug 28179. It also
addresses a bug with the way the verify_images() function was firing.
I've moved the function outside of document.ready() and added a call to
it on window load, consistent with how it works in the staff client.

I've removed a redundant call to verify_images() from the footer include
file, opac-bottom.inc.

The cosmetic changes replace the Chocolat image icons with new SVG
assets based on Bootstrap Icons (https://icons.getbootstrap.com/). The
color changes I think help the controls to be more visible.

Signed-off-by: Jonathan Druart 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #126514|0   |1
is obsolete||

--- Comment #88 from Katrin Fischer  ---
Created attachment 126604
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126604=edit
Bug 28180: Restore NO_LOCAL_JACKET

This is a patch to squash. No idea what it got removed previously

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #126513|0   |1
is obsolete||

--- Comment #87 from Katrin Fischer  ---
Created attachment 126603
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126603=edit
Bug 28180: (follow-up) Remove console.log

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #126512|0   |1
is obsolete||

--- Comment #86 from Katrin Fischer  ---
Created attachment 126602
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126602=edit
Bug 28180: Bug fix - cannot select cover-nav button when on top of the
.contentblock

Found a bug and ended up with this solution, suggestions welcomed!

example with OpenLibrary with isbn=9780670026623, the image is a bit
higher than others and then the cover-nav buttons are on top of
.contentblock and cannot be clicked

Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at,
presseshop.ch)

Signed-off-by: Rasmus Leißner 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #126511|0   |1
is obsolete||

--- Comment #85 from Katrin Fischer  ---
Created attachment 126601
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126601=edit
Bug 28180: Reintroduce and adjust Baker and Taylor

Test plan:
1. Turn on BakerTaylorEnabled and fill BakerTaylorUsername/BakerTaylorPassword
(if you don't have, ask me)
2. Display the cover images in the gallery

Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at,
presseshop.ch)

Signed-off-by: Rasmus Leißner 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #126510|0   |1
is obsolete||

--- Comment #84 from Katrin Fischer  ---
Created attachment 126600
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126600=edit
Bug 28180: Reintroduce and adjust OpenLibrary

1. Turn on OpenLibraryCovers
2. Display the cover images in the gallery

Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at,
presseshop.ch)

Signed-off-by: Rasmus Leißner 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #126509|0   |1
is obsolete||

--- Comment #83 from Katrin Fischer  ---
Created attachment 126599
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126599=edit
Bug 28180: Reintroduce and adjust Google Jackets

Test plan:
1. Turn on GoogleJackets
2. Display the cover images in the gallery

Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at,
presseshop.ch)

Signed-off-by: Rasmus Leißner 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #126508|0   |1
is obsolete||

--- Comment #82 from Katrin Fischer  ---
Created attachment 126598
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126598=edit
Bug 28180: Reintroduce and adjust Syndetics

Test plan:
1. Enable SyndeticsEnabled and SyndeticsCoverImages
2. Display the cover images in the gallery

Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at,
presseshop.ch)

Signed-off-by: Rasmus Leißner 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #126507|0   |1
is obsolete||

--- Comment #81 from Katrin Fischer  ---
Created attachment 126597
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126597=edit
Bug 28180: Add a lightbox gallery to display cover images - detail page, OPAC
interface

This patch is the OPAC version of
  Bug 28179: Add a lightbox gallery to display cover images - detail page,
staff interface

But there were several difficulties as the staff and OPAC code diverged
a lot.
First we are going to apply the different enhancements that have been
made staff-side:
- Display all the local cover image on the bibliographic detail pages
(before this patch only the first one was displayed)
- The slider functionality added by bug 25031

Test plan:
All the cover images are affected, all the different sources will be
tested.
All the steps will be done on the same bibliographic record.
1. Local cover images
 a. Turn on OPACLocalCoverImages and AllowMultipleCover
 b. Add several local cover images to a bibliographic record
 c. Add several local cover images to an item
 d. Click on an image and confirm that it is displayed in a gallery and
 you can navigate see all the images attached to the bibliographic
 record
 e. Same for items
2. Adlibris
 a. Turn on AdlibrisCoversEnabled
 b. Edit the biliographic record and add an ISBN that will return a
 cover image for this service (9780670026623 for instance)
 c. Display the cover images in the gallery
 d. Note the link to the adlibris.com website at the bottom
3. Amazon
 a. Turn on OPACAmazonCoverImages
 b. Display the cover images in the gallery
4. Coce
 a. Turn on OpacCoce, set CoceHost to "http://coce.tamil.fr:8080;
 and select some values for CoceProviders.
 b. Display the cover images in the gallery
5. Custom cover images
 a. Turn on OPACCustomCoverImages and set CustomCoverImagesURL to
https://covers.openlibrary.org/b/isbn/{isbn}-M.jpg
 of anything else meaningful
 b. Display the cover images in the gallery

QA Note: Other sources have been removed by this patch but will be
re-added by follow-ups

Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at,
presseshop.ch)

Signed-off-by: Rasmus Leißner 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #126506|0   |1
is obsolete||

--- Comment #80 from Katrin Fischer  ---
Created attachment 126596
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126596=edit
Bug 28180: Add Chocolat to OPAC

See Bug 28179: Add the Chocolat gallery lightbox JS library

Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at,
presseshop.ch)

Signed-off-by: Rasmus Leißner 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

--- Comment #79 from Jonathan Druart  ---
Rebased on top of bug 29200.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

--- Comment #78 from Jonathan Druart  ---
Created attachment 126520
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126520=edit
Bug 28180: Remove adlibris conflict

Can be squashed when pushed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

--- Comment #77 from Jonathan Druart  ---
Created attachment 126519
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126519=edit
Bug 28180: Fix bug with first image does not exist

This was first written for Adlibris, before its removal from the
codebase.
But this patch maybe still be useful for other services (if first and no
image).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

--- Comment #76 from Jonathan Druart  ---
Created attachment 126518
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126518=edit
Bug 28180: Correctly guess if images have been loaded

window.load won't assure us that the images loaded using JS code are
correctly loaded.

This patch adds a flag to the different providers when the images are
fully loaded.

Note that the img.naturalHeight check is not working for google jackets
and is actually not needed (test with a bib record with and without
google jacket and confirm that it's working as expected).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

--- Comment #75 from Jonathan Druart  ---
Created attachment 126517
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126517=edit
Bug 28180: Fix collision with existing verify_images

At the OPAC we already had a verify_images JS function in amazonimages.js
It's preferable to use another function name.
This patch replace our verify_images with verify_cover_images and apply
the change to the staff code as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

--- Comment #74 from Jonathan Druart  ---
Created attachment 126516
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126516=edit
Bug 28180: Fix some non-translatable strings

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

--- Comment #73 from Jonathan Druart  ---
Created attachment 126515
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126515=edit
Bug 28180: (follow-up) Updates to styling of lightbox controls

This patch adds style changes like the ones made in Bug 28179. It also
addresses a bug with the way the verify_images() function was firing.
I've moved the function outside of document.ready() and added a call to
it on window load, consistent with how it works in the staff client.

I've removed a redundant call to verify_images() from the footer include
file, opac-bottom.inc.

The cosmetic changes replace the Chocolat image icons with new SVG
assets based on Bootstrap Icons (https://icons.getbootstrap.com/). The
color changes I think help the controls to be more visible.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

--- Comment #72 from Jonathan Druart  ---
Created attachment 126514
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126514=edit
Bug 28180: Restore NO_LOCAL_JACKET

This is a patch to squash. No idea what it got removed previously

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

--- Comment #71 from Jonathan Druart  ---
Created attachment 126513
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126513=edit
Bug 28180: (follow-up) Remove console.log

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

--- Comment #70 from Jonathan Druart  ---
Created attachment 126512
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126512=edit
Bug 28180: Bug fix - cannot select cover-nav button when on top of the
.contentblock

Found a bug and ended up with this solution, suggestions welcomed!

example with OpenLibrary with isbn=9780670026623, the image is a bit
higher than others and then the cover-nav buttons are on top of
.contentblock and cannot be clicked

Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at,
presseshop.ch)

Signed-off-by: Rasmus Leißner 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

--- Comment #69 from Jonathan Druart  ---
Created attachment 126511
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126511=edit
Bug 28180: Reintroduce and adjust Baker and Taylor

Test plan:
1. Turn on BakerTaylorEnabled and fill BakerTaylorUsername/BakerTaylorPassword
(if you don't have, ask me)
2. Display the cover images in the gallery

Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at,
presseshop.ch)

Signed-off-by: Rasmus Leißner 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

--- Comment #68 from Jonathan Druart  ---
Created attachment 126510
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126510=edit
Bug 28180: Reintroduce and adjust OpenLibrary

1. Turn on OpenLibraryCovers
2. Display the cover images in the gallery

Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at,
presseshop.ch)

Signed-off-by: Rasmus Leißner 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

--- Comment #67 from Jonathan Druart  ---
Created attachment 126509
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126509=edit
Bug 28180: Reintroduce and adjust Google Jackets

Test plan:
1. Turn on GoogleJackets
2. Display the cover images in the gallery

Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at,
presseshop.ch)

Signed-off-by: Rasmus Leißner 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

--- Comment #66 from Jonathan Druart  ---
Created attachment 126508
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126508=edit
Bug 28180: Reintroduce and adjust Syndetics

Test plan:
1. Enable SyndeticsEnabled and SyndeticsCoverImages
2. Display the cover images in the gallery

Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at,
presseshop.ch)

Signed-off-by: Rasmus Leißner 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

--- Comment #65 from Jonathan Druart  ---
Created attachment 126507
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126507=edit
Bug 28180: Add a lightbox gallery to display cover images - detail page, OPAC
interface

This patch is the OPAC version of
  Bug 28179: Add a lightbox gallery to display cover images - detail page,
staff interface

But there were several difficulties as the staff and OPAC code diverged
a lot.
First we are going to apply the different enhancements that have been
made staff-side:
- Display all the local cover image on the bibliographic detail pages
(before this patch only the first one was displayed)
- The slider functionality added by bug 25031

Test plan:
All the cover images are affected, all the different sources will be
tested.
All the steps will be done on the same bibliographic record.
1. Local cover images
 a. Turn on OPACLocalCoverImages and AllowMultipleCover
 b. Add several local cover images to a bibliographic record
 c. Add several local cover images to an item
 d. Click on an image and confirm that it is displayed in a gallery and
 you can navigate see all the images attached to the bibliographic
 record
 e. Same for items
2. Adlibris
 a. Turn on AdlibrisCoversEnabled
 b. Edit the biliographic record and add an ISBN that will return a
 cover image for this service (9780670026623 for instance)
 c. Display the cover images in the gallery
 d. Note the link to the adlibris.com website at the bottom
3. Amazon
 a. Turn on OPACAmazonCoverImages
 b. Display the cover images in the gallery
4. Coce
 a. Turn on OpacCoce, set CoceHost to "http://coce.tamil.fr:8080;
 and select some values for CoceProviders.
 b. Display the cover images in the gallery
5. Custom cover images
 a. Turn on OPACCustomCoverImages and set CustomCoverImagesURL to
https://covers.openlibrary.org/b/isbn/{isbn}-M.jpg
 of anything else meaningful
 b. Display the cover images in the gallery

QA Note: Other sources have been removed by this patch but will be
re-added by follow-ups

Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at,
presseshop.ch)

Signed-off-by: Rasmus Leißner 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #120464|0   |1
is obsolete||
 Attachment #120465|0   |1
is obsolete||
 Attachment #120466|0   |1
is obsolete||
 Attachment #120467|0   |1
is obsolete||
 Attachment #120468|0   |1
is obsolete||
 Attachment #120469|0   |1
is obsolete||
 Attachment #120470|0   |1
is obsolete||
 Attachment #120753|0   |1
is obsolete||
 Attachment #120754|0   |1
is obsolete||
 Attachment #122783|0   |1
is obsolete||
 Attachment #123792|0   |1
is obsolete||
 Attachment #123793|0   |1
is obsolete||
 Attachment #126041|0   |1
is obsolete||
 Attachment #126042|0   |1
is obsolete||

--- Comment #64 from Jonathan Druart  ---
Created attachment 126506
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126506=edit
Bug 28180: Add Chocolat to OPAC

See Bug 28179: Add the Chocolat gallery lightbox JS library

Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at,
presseshop.ch)

Signed-off-by: Rasmus Leißner 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||29200


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29200
[Bug 29200] Remove Adlibris cover service
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

--- Comment #63 from Jonathan Druart  ---
(In reply to Katrin Fischer from comment #60)
> I am not sure I fully understand your comment, but I think this is a real
> regression that will get unhappy comments. Google images are supposedly
> widely used and they disappear from the detail pages now :(
> 
> In my test case there always was a custom image - do you mean local? It
> happened for the record with the local image too - I had 3 shown in results
> and only 2 missing Google) in the detail page. So not sure that's the issue.

I did recreate on Firefox, not chrome (usually using Firefox, but the cache
didn't want to clear correctly this morning when I tried).
That should be fixed now!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

--- Comment #62 from Jonathan Druart  ---
Created attachment 126042
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126042=edit
Bug 28180: Fix bug with AdLibris

If Adlibris is first and there is no image

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #123794|0   |1
is obsolete||
 Attachment #125666|0   |1
is obsolete||

--- Comment #61 from Jonathan Druart  ---
Created attachment 126041
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126041=edit
Bug 28180: Correctly guess if images have been loaded

window.load won't assure us that the images loaded using JS code are
correctly loaded.

This patch adds a flag to the different providers when the images are
fully loaded.

Note that the img.naturalHeight check is not working for google jackets
and is actually not needed (test with a bib record with and without
google jacket and confirm that it's working as expected).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

--- Comment #60 from Katrin Fischer  ---
I am not sure I fully understand your comment, but I think this is a real
regression that will get unhappy comments. Google images are supposedly widely
used and they disappear from the detail pages now :(

In my test case there always was a custom image - do you mean local? It
happened for the record with the local image too - I had 3 shown in results and
only 2 missing Google) in the detail page. So not sure that's the issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

--- Comment #59 from Jonathan Druart  ---
What you describe make me think the JS cache was not cleared.
With this change we have a problem when there is no custom image (for
instance), as we don't longer test the height of the images. When the custom
image won't exist, the cover slider will display an empty slide for the custom
image. But this won't be easy to fix (we cannot have the previous patch "Bug
28180: Fix bug with AdLibris" AND keep the current behavior). It works for the
staff interface because we don't have all those services, but the code is not
working correctly for OPAC. I would not consider it a blocker.

But what you describe is not expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

--- Comment #58 from Jonathan Druart  ---
Hi Katrin, I don't recreate the problem you have.
I've create a sandbox with your settings:
https://opac-bz28180.sandboxes.biblibre.eu/cgi-bin/koha/opac-search.pl?idx==perl_search=1
"Perl DBI" has a local cover image (biblionumber=13).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

--- Comment #57 from Katrin Fischer  ---
Same behaviour when using the "next" button for navigating between the results,
initial page load is always without the Google cover. Requires an explicit
refresh.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #56 from Katrin Fischer  ---
I am very sorry, but I think I found another inconsistency:

CustomCoverImages
LocalCoverImages
AllowMultipleCovers 
GoogleJackets

1) On the results page: CustomCover (a random image url), local cover and
Google cover.
2) Switch to detail page: Only custom and local cover show.
3) Reload page with F5: Google cover appears.

Same test plan applies to results without a local cover.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

--- Comment #55 from Katrin Fischer  ---
Finally back to this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #124819|0   |1
is obsolete||

--- Comment #54 from Jonathan Druart  ---
Created attachment 125666
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125666=edit
Bug 28180: Fix bug with AdLibris

If Adlibris is first and there is no image

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-09-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #53 from Jonathan Druart  ---
Hi Katrin, thanks!
You found a bug in a very specific combination. AdLibris is loaded first but
there is no image there (is the service broken currently?).
The code copied from staff is broken. As we have much more cover services OPAC
side the bugs are easier to catch.
I think this last patch is improving the situation but I cannot guarantee it
will always work.
To be honest I've always tested with local cover images (as it's why this
enhancement has been sponsored), and it was always working when a cover image
is attached.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-09-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

--- Comment #52 from Jonathan Druart  ---
Created attachment 124819
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124819=edit
Bug 28180: Fix bug with AdLibris

If Adlibris is first and there is no image

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-09-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

--- Comment #51 from Katrin Fischer  ---
Hm, I later realized that this was not meant to change results, but only the
detail page. Previous comments apply to the results list.

On the detail page for me none of the 3 mentioned cover services covers show :(

Example: search for "perl" > Programming Perl
- 2 covers and the adlibris link on results
- no cover at all on detail page

Switch back to master, git stash, restart_all:
- Adlibris still broken on results
- covers show on results and detail page

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-09-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-09-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

--- Comment #50 from Katrin Fischer  ---
Patches still apply, but something has been broken since my last test run.

What I did so far:

- Made sure master was current
- restart_all, ran database updates
- Applied patches, no conflicts
- restart_all again
- yarn build --view opac


1) Turned on Adlibris covers.

Instead of the covers, only a link shows in the result list and detail pages.

2) Additionally activated Google covers.

The covers show, but not within the lightbox display.

3) Added Amazon covers

Now I see up to 2 covers, but next to each other, still no lightbox.


Did a patch get lost here? :(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-09-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

--- Comment #49 from Jonathan Druart  ---
Patches still apply, CSS changes need to be rebuilt with `yarn build
--view=opac`

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-09-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #123178|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

--- Comment #48 from Jonathan Druart  ---
I think this patch is the way to go.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

--- Comment #47 from Jonathan Druart  ---
Created attachment 123794
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123794=edit
Bug 28180: Correctly guess if images have been loaded

window.load won't assure us that the images loaded using JS code are
correctly loaded.

This patch adds a flag to the different providers when the images are
fully loaded.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Signed Off

--- Comment #46 from Jonathan Druart  ---
It's a problem in master as well (staff-side) and highlighted at the OPAC as we
have more images coming from external providers.

The code to hide the non-existent images does not work as we expect.
In my case, a new laptop (faster) make the problem more obvious, the JS code is
processed faster than before and we remove the div that contain images from
amazon, google, etc. because the images are not loaded yet.

I think we should fix that on a separate bug report to fix the staff side at
the same time. And obviously this new enhancement won't be pushed until it's
fixed.

You can continue testing with the following (non optimal) patch:

diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
index 03f41fe8317..93b3c682f61 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
@@ -1620,7 +1620,7 @@
 }
 }
 } else {
-div.remove();
+//div.remove();
 }
 });

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #123790|0   |1
is obsolete||

--- Comment #45 from Jonathan Druart  ---
Created attachment 123793
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123793=edit
Bug 28180: Fix collision with existing verify_images

At the OPAC we already had a verify_images JS function in amazonimages.js
It's preferable to use another function name.
This patch replace our verify_images with verify_cover_images and apply
the change to the staff code as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

--- Comment #44 from Jonathan Druart  ---
Created attachment 123792
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123792=edit
Bug 28180: Fix some non-translatable strings

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

--- Comment #43 from Jonathan Druart  ---
Created attachment 123790
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123790=edit
Bug 28180: Fix collision with existing verify_images

At the OPAC we already had a verify_images JS function in amazonimages.js
It's preferable to use another function name.
This patch replace our verify_images with verify_cover_images and apply
the change to the staff code as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

--- Comment #42 from Jonathan Druart  ---
(In reply to Katrin Fischer from comment #39)
> There is something weird, if multiple cover providers are activated:
> 
> - Turn on OpenLibrary covers
> - Turn on Amazon covers
> - Search for "perl"
> - Most books will show 2 covers in results and in the detail pages
> - Example: CGI programming with Perl
> - Turn on Google covers
> - Result list shows 3
> - Detail page: only Amazon

Found it! There is 2 functions "verify_images", and one (the existing one) is
coming from amazonimages.js!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

--- Comment #41 from Katrin Fischer  ---
Please check comment#39.

Also:

1) Link to source

At the bottom of the lightbox view it says:

[provider] cover image (see the original image)

I wonder if we could make it clearer here that we are linking to the provider's
page as this is an external link where you will leave the library's website.
And it won't only be the image you get to.

Maybe something along the lines of:
(see the original image on the [provider]'s website)

A native speaker might come up with a better wording :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

--- Comment #40 from Katrin Fischer  ---
(In reply to Katrin Fischer from comment #37)
> I believe there might be some problematic constructions for translation in
> the JavaScript, but need to investigate further:
> 
> lightbox_descriptions.push("Custom cover image");
> lightbox_descriptions.push(_("Image from Google Books (see the
> original image)").format($(img).data('link')));

They appear to work, at least seeing the strings in the po file.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

--- Comment #39 from Katrin Fischer  ---
There is something weird, if multiple cover providers are activated:

- Turn on OpenLibrary covers
- Turn on Amazon covers
- Search for "perl"
- Most books will show 2 covers in results and in the detail pages
- Example: CGI programming with Perl
- Turn on Google covers
- Result list shows 3
- Detail page: only Amazon

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Katrin Fischer  changed:

   What|Removed |Added

Summary|Use a lightbox gallery to   |Use a lightbox gallery to
   |display the images - detail |display the images on the
   |page, OPAC interface|detail pages in OPAC

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/