[Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output

2022-02-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com
 Status|Pushed to stable|RESOLVED
 Resolution|--- |FIXED

--- Comment #27 from Andrew Fuerste-Henry  ---
Enhancement, not backported to 21.05.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output

2022-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

Kyle M Hall  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 CC||k...@bywatersolutions.com
 Version(s)|22.05.00|22.05.00,21.11.03
released in||

--- Comment #26 from Kyle M Hall  ---
Pushed to 21.11.x for 21.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

--- Comment #25 from Katrin Fischer  ---
I think in general the institution should pick what they what want to be listed
as. Not everyone has an official English name to use.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output

2022-01-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

--- Comment #24 from Fridolin Somers  ---
I've mailled them directly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output

2022-01-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

--- Comment #23 from Jonathan Druart  ---
(In reply to Fridolin Somers from comment #22)
> I've added the sponsor to release-tools.
> There was already "Université Jean Moulin Lyon 3", but prefer english
> version.
> So always patch with line :
> 
> Sponsored-by: University Lyon 3

Did you ask them? They are in the mailmap as "Université de Lyon 3".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output

2022-01-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

--- Comment #22 from Fridolin Somers  ---
I've added the sponsor to release-tools.
There was already "Université Jean Moulin Lyon 3", but prefer english version.
So always patch with line :

Sponsored-by: University Lyon 3

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output

2022-01-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

Fridolin Somers  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
 CC||fridolin.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output

2022-01-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

--- Comment #21 from Fridolin Somers  ---
Pushed to master for 22.05, thanks to everybody involved 濾

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output

2022-01-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

Fridolin Somers  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||22.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output

2022-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

--- Comment #20 from Tomás Cohen Arazi  ---
Created attachment 129491
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129491=edit
Bug 28238: (follow-up) Add itemcallnumber to ILS-DI GetAvailability output for
unavailable items

Providing the call number for ILS-DI GetAvailability output is useful
for libraries that use discovery tools. Patrons often don't check
further for the call number, and then they don't have it when they look
for the item. It could also be use full to have this call number when
the item isn't available (to make a request for it for instance).

Test plan:
1. Enable the ILS-DI system preference
2. Locate a record with multiple items and make sure they have call
   numbers for each item and that some are unavailable
3. Test these URLs:
  
[OPACBASEURL]/cgi-bin/koha/ilsdi.pl?service=GetAvailability=[BIBLIONUMBER]_type=biblio
   and
  
[OPACBASEURL]/cgi-bin/koha/ilsdi.pl?service=GetAvailability=[ITEMNUMBER]_type=item
   (Where the [OPACBASEURL] is the OPAC URL of your test instance,
   [BIBLIONUMBER] and [ITEMNUMBER] are a record number and item number of
   your choice.)
4. Apply the patch
5. Run the queries from step 3 again - all the results should now have
   the tag itemcallnumber (not only the available's ones)
   Example: 840.08 COR R

Sponsored-by: University Lyon 3

https://bugs.koha-community.org/show_bug.cgi?id=28238

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output

2022-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

--- Comment #19 from Tomás Cohen Arazi  ---
Created attachment 129490
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129490=edit
Bug 28238: Add itemcallnumber to ils-di GetAvailability output

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output

2022-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

--- Comment #18 from Tomás Cohen Arazi  ---
Created attachment 129489
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129489=edit
Bug 28238: Add tests

Add specific tests for the tag itemcallnumber in GetAvailability output.

Sponsored-by: University Lyon 3

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output

2022-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #127478|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output

2022-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #127132|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output

2022-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #127131|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output

2022-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output

2022-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

Tomás Cohen Arazi  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com
   |y.org   |
 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output

2021-11-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #127130|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output

2021-11-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

marion.dur...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output

2021-11-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

--- Comment #17 from marion.dur...@biblibre.com ---
Created attachment 127478
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127478=edit
Bug 28238: (follow-up) Add tests

Add specific tests for the tag itemcallnumber in GetAvailability output.

Sponsored-by: University Lyon 3

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output

2021-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com
 Status|Passed QA   |Failed QA

--- Comment #16 from Jonathan Druart  ---
(In reply to Katrin Fischer from comment #15)
> I am inclined to pass this change as is, but we are missing a specific test
> for the new feature. Maybe someone would be willing to step up here?

Yes, I am sorry, no more exceptions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output

2021-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

--- Comment #15 from Katrin Fischer  ---
Overall this patch is quite clean, examples and documentation have been updated
and existing patches still pass:

prove t/db_dependent/ILSDI_Services.t 
t/db_dependent/ILSDI_Services.t .. ok 
All tests successful.
Files=1, Tests=10, 12 wallclock secs ( 0.02 usr  0.03 sys +  8.42 cusr  1.12
csys =  9.59 CPU)
Result: PASS

I am inclined to pass this change as is, but we are missing a specific test for
the new feature. Maybe someone would be willing to step up here?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output

2021-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

--- Comment #14 from Katrin Fischer  ---
Created attachment 127132
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127132=edit
Bug 28238: (follow-up) Add itemcallnumber to ILS-DI GetAvailability output for
unavailable items

Providing the call number for ILS-DI GetAvailability output is useful
for libraries that use discovery tools. Patrons often don't check
further for the call number, and then they don't have it when they look
for the item. It could also be use full to have this call number when
the item isn't available (to make a request for it for instance).

Test plan:
1. Enable the ILS-DI system preference
2. Locate a record with multiple items and make sure they have call
   numbers for each item and that some are unavailable
3. Test these URLs:
  
[OPACBASEURL]/cgi-bin/koha/ilsdi.pl?service=GetAvailability=[BIBLIONUMBER]_type=biblio
   and
  
[OPACBASEURL]/cgi-bin/koha/ilsdi.pl?service=GetAvailability=[ITEMNUMBER]_type=item
   (Where the [OPACBASEURL] is the OPAC URL of your test instance,
   [BIBLIONUMBER] and [ITEMNUMBER] are a record number and item number of
   your choice.)
4. Apply the patch
5. Run the queries from step 3 again - all the results should now have
   the tag itemcallnumber (not only the available's ones)
   Example: 840.08 COR R

Sponsored-by: University Lyon 3

https://bugs.koha-community.org/show_bug.cgi?id=28238

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output

2021-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

--- Comment #13 from Katrin Fischer  ---
Created attachment 127131
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127131=edit
Bug 28238: Add itemcallnumber to ils-di GetAvailability output

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output

2021-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #126947|0   |1
is obsolete||
 Attachment #126948|0   |1
is obsolete||

--- Comment #12 from Katrin Fischer  ---
Created attachment 127130
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127130=edit
Bug 29374: Don't crash if search engine returns a deleted record

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output

2021-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output

2021-10-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

--- Comment #11 from marion.dur...@biblibre.com ---
(In reply to David Nind from comment #10)
> I amended the commit message for the follow up so that it has the correct
> bug number.

Thank you David for the correction. 
I obsoleted the patch with the wrong bug number.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output

2021-10-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

marion.dur...@biblibre.com changed:

   What|Removed |Added

 Attachment #126909|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output

2021-10-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

David Nind  changed:

   What|Removed |Added

  Text to go in the||This enhancement adds the
  release notes||item call number to the
   ||ILS-DI GetAvailability
   ||output. This is useful for
   ||libraries that use
   ||discovery tools as patrons
   ||often don't check further
   ||for the call number, and
   ||then they don't have it
   ||when they look for the
   ||item.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output

2021-10-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

--- Comment #10 from David Nind  ---
I amended the commit message for the follow up so that it has the correct bug
number.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output

2021-10-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

--- Comment #9 from David Nind  ---
Created attachment 126948
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126948=edit
Bug 28238: (follow-up) Add itemcallnumber to ILS-DI GetAvailability output for
unavailable items

Providing the call number for ILS-DI GetAvailability output is useful
for libraries that use discovery tools. Patrons often don't check
further for the call number, and then they don't have it when they look
for the item. It could also be use full to have this call number when
the item isn't available (to make a request for it for instance).

Test plan:
1. Enable the ILS-DI system preference
2. Locate a record with multiple items and make sure they have call
   numbers for each item and that some are unavailable
3. Test these URLs:
  
[OPACBASEURL]/cgi-bin/koha/ilsdi.pl?service=GetAvailability=[BIBLIONUMBER]_type=biblio
   and
  
[OPACBASEURL]/cgi-bin/koha/ilsdi.pl?service=GetAvailability=[ITEMNUMBER]_type=item
   (Where the [OPACBASEURL] is the OPAC URL of your test instance,
   [BIBLIONUMBER] and [ITEMNUMBER] are a record number and item number of
   your choice.)
4. Apply the patch
5. Run the queries from step 3 again - all the results should now have
   the tag itemcallnumber (not only the available's ones)
   Example: 840.08 COR R

Sponsored-by: University Lyon 3

https://bugs.koha-community.org/show_bug.cgi?id=28238

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output

2021-10-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

David Nind  changed:

   What|Removed |Added

 Attachment #121399|0   |1
is obsolete||

--- Comment #8 from David Nind  ---
Created attachment 126947
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126947=edit
Bug 28238 Add itemcallnumber to ils-di GetAvailability output

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output

2021-10-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output

2021-10-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

marion.dur...@biblibre.com changed:

   What|Removed |Added

 CC||marion.dur...@biblibre.com
 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output

2021-10-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

--- Comment #7 from marion.dur...@biblibre.com ---
Created attachment 126909
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126909=edit
Bug 28328: (follow-up) Add itemcallnumber to ILS-DI GetAvailability output for
unavailable items

Providing the call number for ILS-DI GetAvailability output is useful
for libraries that use discovery tools. Patrons often don't check
further for the call number, and then they don't have it when they look
for the item. It could also be use full to have this call number when
the item isn't available (to make a request for it for instance).

Test plan:
1. Enable the ILS-DI system preference
2. Locate a record with multiple items and make sure they have call
   numbers for each item and that some are unavailable
3. Test these URLs:
  
[OPACBASEURL]/cgi-bin/koha/ilsdi.pl?service=GetAvailability=[BIBLIONUMBER]_type=biblio
   and
  
[OPACBASEURL]/cgi-bin/koha/ilsdi.pl?service=GetAvailability=[ITEMNUMBER]_type=item
   (Where the [OPACBASEURL] is the OPAC URL of your test instance,
   [BIBLIONUMBER] and [ITEMNUMBER] are a record number and item number of
   your choice.)
4. Apply the patch
5. Run the queries from step 3 again - all the results should now have
   the tag itemcallnumber (not only the available's ones)
   Example: 840.08 COR R

Sponsored-by: University Lyon 3

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output

2021-07-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

Katrin Fischer  changed:

   What|Removed |Added

Summary|Add itemcallnumber to   |Add itemcallnumber to
   |ils-di GetAvailability  |ILS-DI GetAvailability
   |output  |output

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28238] Add itemcallnumber to ils-di GetAvailability output

2021-07-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Signed Off  |Failed QA

--- Comment #6 from Nick Clemens  ---
If we are going to add it, I think we should return it even if item is
unavailable - perhaps the patron wants to make a request for it, or to check
the surrounding shelves if their item is not available.

Consistency is nice when we can attain it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28238] Add itemcallnumber to ils-di GetAvailability output

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

Katrin Fischer  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@univ-lyon3.fr
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28238] Add itemcallnumber to ils-di GetAvailability output

2021-05-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

David Nind  changed:

   What|Removed |Added

 Attachment #120242|0   |1
is obsolete||

--- Comment #5 from David Nind  ---
Comment on attachment 120242
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120242
Add itemcallnumber to ilsdi GetAvailability output

For some reason I created an additional patch when signing off!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28238] Add itemcallnumber to ils-di GetAvailability output

2021-05-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #4 from David Nind  ---
Testing notes (koha-testing-docker):
- Enabled ILS-DI
- Locate a record with multiple items to test with
- Made sure the items had call numbers
- Followed test plan

Note - the QA team may want the commit message formatted according to the
commit message guidelines: https://wiki.koha-community.org/wiki/Commit_messages

Here is my attempt:

Bug 28328: Add itemcallnumber to ILS-DI GetAvailability output

Providing the call number for ILS-DI GetAvailability output is useful for
libraries that use discovery tools. Patrons often don't check further for the
call number, and then they don't have it when they look for the item.

Test plan:
1. Enable the ILS-DI system preference
2. Locate a record with multiple items and make sure they have call numbers for
each item
3. Test these URLs:
  
[OPACBASEURL]/cgi-bin/koha/ilsdi.pl?service=GetAvailability=[BIBLIONUMBER]_type=biblio
   and
  
[OPACBASEURL]/cgi-bin/koha/ilsdi.pl?service=GetAvailability=[ITEMNUMBER]_type=item
   (Where the [OPACBASEURL] is the OPAC URL of your test instance,
[BIBLIONUMBER] and [ITEMNUMBER] are a record number and item number of your
choice.)
4. Apply the patch
5. Run the queries from step 3 again - the results should now have an extra tag
itemcallnumber. 
   Example: 840.08 COR R
6. Sign off!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28238] Add itemcallnumber to ils-di GetAvailability output

2021-05-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

--- Comment #3 from David Nind  ---
Created attachment 121399
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121399=edit
Bug 28238 Add itemcallnumber to ils-di GetAvailability output

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28238] Add itemcallnumber to ils-di GetAvailability output

2021-05-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28238] Add itemcallnumber to ils-di GetAvailability output

2021-05-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

--- Comment #2 from Koha Team University Lyon 3  ---
Test plan :

To see the output of getavailability service, run the following url in your
browser :

[OPACBASEURL]/cgi-bin/koha/ilsdi.pl?service=GetAvailability=[BIBLIONUMBER]_type=biblio
or this one
[OPACBASEURL]/cgi-bin/koha/ilsdi.pl?service=GetAvailability=[ITEMNUMBER]_type=item

where the [OPACBASEURL] is the opac url of your test instance, [BIBLIONUMBER]
and [ITEMNUMBER] a record number and itemnumber of your choice.

After applying the patch, you'll see an extra tag itemcallnumber. 
Exemple :
840.08 COR R

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28238] Add itemcallnumber to ils-di GetAvailability output

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

Koha Team University Lyon 3  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28238] Add itemcallnumber to ils-di GetAvailability output

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

Koha Team University Lyon 3  changed:

   What|Removed |Added

 CC||k...@univ-lyon3.fr

--- Comment #1 from Koha Team University Lyon 3  ---
Created attachment 120242
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120242=edit
Add itemcallnumber to ilsdi GetAvailability output

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/