[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen

2021-08-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Pushed to oldstable |RESOLVED
 CC||vic...@tuxayo.net
 Resolution|--- |FIXED

--- Comment #24 from Victor Grousset/tuxayo  ---
Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen

2021-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)|21.11.00,21.05.03   |21.11.00,21.05.03,20.11.09
released in||
 Status|Pushed to stable|Pushed to oldstable
 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #23 from Fridolin Somers  ---
Since Bug 28455 is in 20.11.x, I choose to backport this one also.

I skipped "Update wording of syspref", I does not apply because text is
different. I this it is not very important.

Pushed to 20.11.x for 20.11.09

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen

2021-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630

Kyle M Hall  changed:

   What|Removed |Added

 Version(s)|21.11.00|21.11.00,21.05.03
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen

2021-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to stable

--- Comment #22 from Kyle M Hall  ---
Pushed to 21.05.x for 21.05.03 by request.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen

2021-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen

2021-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen

2021-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630

Kyle M Hall  changed:

   What|Removed |Added

 Status|REOPENED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen

2021-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630

Kyle M Hall  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen

2021-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630

Kyle M Hall  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to master|RESOLVED
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen

2021-08-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630

--- Comment #21 from Jonathan Druart  ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen

2021-08-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||21.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen

2021-08-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630

--- Comment #20 from Jonathan Druart  ---
Created attachment 123454
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123454&action=edit
Bug 28630: Improve date comparisons in tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen

2021-08-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630

Martin Renvoize  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen

2021-08-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122546|0   |1
is obsolete||

--- Comment #19 from Martin Renvoize  ---
Created attachment 123450
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123450&action=edit
Bug 28630: (follow-up) Update wording of syspref

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen

2021-08-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122545|0   |1
is obsolete||

--- Comment #18 from Martin Renvoize  ---
Created attachment 123449
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123449&action=edit
Bug 28630: Add unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen

2021-08-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122544|0   |1
is obsolete||

--- Comment #17 from Martin Renvoize  ---
Created attachment 123448
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123448&action=edit
Bug 28630: Add track_login_daily to ILSDI::AuthenticatePatron

This patch adds a call to track_login_daily for the AuthenticatePatron
method in ILSDI.

Many libraries use this ILSDI endpoint for electron book borrowing and
need to maintain the lastseen based on this type of lending.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen

2021-08-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Patch doesn't apply
 CC||jonathan.druart+koha@gmail.
   ||com

--- Comment #16 from Jonathan Druart  ---
There is a conflict on the last patch, Martin can you have a look please?
Should be easy for a native English speaker :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen

2021-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen

2021-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #122492|0   |1
is obsolete||

--- Comment #15 from Marcel de Rooy  ---
Created attachment 122546
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122546&action=edit
Bug 28630: (follow-up) Update wording of syspref

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen

2021-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #122491|0   |1
is obsolete||

--- Comment #14 from Marcel de Rooy  ---
Created attachment 122545
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122545&action=edit
Bug 28630: Add unit tests

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen

2021-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #122490|0   |1
is obsolete||

--- Comment #13 from Marcel de Rooy  ---
Created attachment 122544
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122544&action=edit
Bug 28630: Add track_login_daily to ILSDI::AuthenticatePatron

This patch adds a call to track_login_daily for the AuthenticatePatron
method in ILSDI.

Many libraries use this ILSDI endpoint for electron book borrowing and
need to maintain the lastseen based on this type of lending.

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen

2021-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen

2021-06-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630

--- Comment #12 from Andrew Fuerste-Henry  ---
Tested and signed off, but I should have thought sooner about how this was
going to run into bug 28455, also signed off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen

2021-06-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #122478|0   |1
is obsolete||

--- Comment #11 from Andrew Fuerste-Henry  ---
Created attachment 122492
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122492&action=edit
Bug 28630: (follow-up) Update wording of syspref

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen

2021-06-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #122477|0   |1
is obsolete||

--- Comment #10 from Andrew Fuerste-Henry  ---
Created attachment 122491
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122491&action=edit
Bug 28630: Add unit tests

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen

2021-06-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #122476|0   |1
is obsolete||

--- Comment #9 from Andrew Fuerste-Henry  ---
Created attachment 122490
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122490&action=edit
Bug 28630: Add track_login_daily to ILSDI::AuthenticatePatron

This patch adds a call to track_login_daily for the AuthenticatePatron
method in ILSDI.

Many libraries use this ILSDI endpoint for electron book borrowing and
need to maintain the lastseen based on this type of lending.

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen

2021-06-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen

2021-06-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630

Andrew Fuerste-Henry  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=28455

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen

2021-06-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen

2021-06-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630

--- Comment #8 from Martin Renvoize  ---
(In reply to Andrew Fuerste-Henry from comment #4)
> In bug 28467 I just updated the working on TrackLastPatronActivity to
> accurately describe the current behavior. Please include an update there to
> tell people it now includes ILS-DI.

I've added a follow-up with the wording change, thanks for pointing it out :)

> The comment Magnus links off to also mentions API actions. I agree we should
> also cover that with lastseen. I don't see a separate bug for that. Martin,
> are you up for folding that in here?

Whilst I sort of agree with Magnus, there isn't really an
'IdentifyUser/AuthenticateUser' route in the API as yet and as such not a clear
location to tie this too.. the REST API is still more closely tied to third
part integrators acting on someone's behalf and doesn't really denote a user
interaction which I feel lastseen is for.  So yeah.. I'd wait until such a time
that OAuth code grant or similar is introduced which would more clearly denote
an actual user login.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen

2021-06-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630

--- Comment #7 from Martin Renvoize  ---
Created attachment 122478
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122478&action=edit
Bug 28630: (follow-up) Update wording of syspref

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen

2021-06-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122422|0   |1
is obsolete||

--- Comment #6 from Martin Renvoize  ---
Created attachment 122477
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122477&action=edit
Bug 28630: Add unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen

2021-06-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122421|0   |1
is obsolete||

--- Comment #5 from Martin Renvoize  ---
Created attachment 122476
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122476&action=edit
Bug 28630: Add track_login_daily to ILSDI::AuthenticatePatron

This patch adds a call to track_login_daily for the AuthenticatePatron
method in ILSDI.

Many libraries use this ILSDI endpoint for electron book borrowing and
need to maintain the lastseen based on this type of lending.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen

2021-06-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen

2021-06-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630

--- Comment #4 from Andrew Fuerste-Henry  ---
In bug 28467 I just updated the working on TrackLastPatronActivity to
accurately describe the current behavior. Please include an update there to
tell people it now includes ILS-DI.

The comment Magnus links off to also mentions API actions. I agree we should
also cover that with lastseen. I don't see a separate bug for that. Martin, are
you up for folding that in here?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen

2021-06-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630

Sally  changed:

   What|Removed |Added

 CC||sally.healey@cheshireshared
   ||services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen

2021-06-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||15504


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
[Bug 15504] Track Patron's Last Activity
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen

2021-06-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630

--- Comment #3 from Martin Renvoize  ---
Created attachment 122422
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122422&action=edit
Bug 28630: Add unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen

2021-06-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630

Magnus Enger  changed:

   What|Removed |Added

 CC||mag...@libriotech.no
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=15504

--- Comment #2 from Magnus Enger  ---
See also bug 15504, comment 28 and comment 29.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen

2021-06-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630

Martin Renvoize  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com
   ||,
   ||david.roberts@ptfs-europe.c
   ||om,
   ||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen

2021-06-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630

Martin Renvoize  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe
   |ity.org |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen

2021-06-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630

Martin Renvoize  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen

2021-06-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630

--- Comment #1 from Martin Renvoize  ---
Created attachment 122421
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122421&action=edit
Bug 28630: Add track_login_daily to ILSDI::AuthenticatePatron

This patch adds a call to track_login_daily for the AuthenticatePatron
method in ILSDI.

Many libraries use this ILSDI endpoint for electron book borrowing and
need to maintain the lastseen based on this type of lending.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/