[Koha-bugs] [Bug 28698] News for all displays in all locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28698 Victor Grousset/tuxayo changed: What|Removed |Added Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|21.05.08|21.05.08,20.11.14 released in|| --- Comment #15 from Victor Grousset/tuxayo --- Backported: Pushed to 20.11.x branch for 20.11.14 > 4) without patch you see in location of 'opacheader', 'opacnavright' ... the > content of the news Indeed, that's very messy! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28698] News for all displays in all locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28698 --- Comment #14 from Katrin Fischer --- I can confirm the bug in 20.11 - we have seen it a few times when updating. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28698] News for all displays in all locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28698 Fridolin Somers changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22544 Depends on|22544 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 [Bug 22544] Move C4:NewsChannels to Koha namespace -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28698] News for all displays in all locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28698 --- Comment #13 from Fridolin Somers --- Yes, this is only for <= 21.05.x I removed dependency. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28698] News for all displays in all locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28698 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #12 from Victor Grousset/tuxayo --- This ticket depend on an enhancement from 21.11 But it was backported to 21.05 . Does that mean 20.11 should be affected as well? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28698] News for all displays in all locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28698 Andrew Fuerste-Henry changed: What|Removed |Added Status|Passed QA |Pushed to oldstable Version(s)||21.05.08 released in|| CC||and...@bywatersolutions.com --- Comment #11 from Andrew Fuerste-Henry --- Pushed to 21.05.x for 21.05.08 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28698] News for all displays in all locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28698 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28698] News for all displays in all locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28698 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28698] News for all displays in all locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28698 Tomás Cohen Arazi changed: What|Removed |Added Attachment #128098|0 |1 is obsolete|| --- Comment #10 from Tomás Cohen Arazi --- Created attachment 128678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128678&action=edit Bug 28698: Fix news for all displays in all locations Some news are used for custom text with a specific language, for example "opacheader". The bug is that in these locations, news for all (staff and opac) are displayed. This is because GetNewsToDisplay uses SQL : opac_news.lang = '' OR opac_news.lang = ? This patch is a quick fix. This feature maybe needs a big revamping. Test plan : 1) Remove any news 2) Create a news with empty 'Display location' and some content 3) Display OPAC interface 4) without patch you see in location of 'opacheader', 'opacnavright' ... the content of the news 5) With patch you see content of the news only in news table 6) Create a news for opacheader 7) Check it appears in correct language Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28698] News for all displays in all locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28698 David Nind changed: What|Removed |Added Text to go in the||This corrects the display release notes||of news items in the OPAC - ||if a location was not ||selected when creating a ||news item it was displaying ||in all locations (news, ||header, right, and so on). ||It also now displays in the ||right location for any ||language. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28698] News for all displays in all locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28698 David Nind changed: What|Removed |Added Attachment #122698|0 |1 is obsolete|| --- Comment #9 from David Nind --- Created attachment 128098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128098&action=edit Bug 28698: Fix news for all displays in all locations Some news are used for custom text with a specific language, for example "opacheader". The bug is that in these locations, news for all (staff and opac) are displayed. This is because GetNewsToDisplay uses SQL : opac_news.lang = '' OR opac_news.lang = ? This patch is a quick fix. This feature maybe needs a big revamping. Test plan : 1) Remove any news 2) Create a news with empty 'Display location' and some content 3) Display OPAC interface 4) without patch you see in location of 'opacheader', 'opacnavright' ... the content of the news 5) With patch you see content of the news only in news table 6) Create a news for opacheader 7) Check it appears in correct language Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28698] News for all displays in all locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28698 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28698] News for all displays in all locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28698 --- Comment #8 from David Nind --- (In reply to Fridolin Somers from comment #7) > Did you test on master ? > This is only for <= 21.05.x I tested in 21.05. I've retested and I'm seeing the problem now - I had to browse around a few pages, then it appeared in the places it shouldn't (but it didn't initially with the browser cache cleared). Sign-off on the way! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28698] News for all displays in all locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28698 --- Comment #7 from Fridolin Somers --- (In reply to David Nind from comment #6) > I'm only seeing the news item displayed in the normal news location in the > OPAC. > > Do I need another language installed and enabled? Did you test on master ? This is only for <= 21.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28698] News for all displays in all locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28698 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #6 from David Nind --- I'm only seeing the news item displayed in the normal news location in the OPAC. Do I need another language installed and enabled? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28698] News for all displays in all locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28698 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #5 from Lucas Gass --- (In reply to Jonathan Druart from comment #4) > Don't we need it for 21.05? Yes! I think this can be very useful for 21.05 and below. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28698] News for all displays in all locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28698 Jonathan Druart changed: What|Removed |Added Status|REOPENED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28698] News for all displays in all locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28698 Jonathan Druart changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #4 from Jonathan Druart --- Don't we need it for 21.05? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28698] News for all displays in all locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28698 Fridolin Somers changed: What|Removed |Added Depends on||22544 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 [Bug 22544] Move C4:NewsChannels to Koha namespace -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28698] News for all displays in all locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28698 Fridolin Somers changed: What|Removed |Added Resolution|--- |FIXED Status|Needs Signoff |RESOLVED --- Comment #3 from Fridolin Somers --- (In reply to Jonathan Druart from comment #2) > Fridolin, bug 22544 removed C4::NewsChannels, and I think it fixes it. I confirm. > > Note that I am about to provide a patch on bug 24387 to clean that area a > bit. Ahhh super. So I close. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28698] News for all displays in all locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28698 Jonathan Druart changed: What|Removed |Added Version|master |21.05 CC||jonathan.druart+koha@gmail. ||com --- Comment #2 from Jonathan Druart --- Fridolin, bug 22544 removed C4::NewsChannels, and I think it fixes it. Note that I am about to provide a patch on bug 24387 to clean that area a bit. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28698] News for all displays in all locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28698 --- Comment #1 from Fridolin Somers --- Created attachment 122698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122698&action=edit Bug 28698: Fix news for all displays in all locations Some news are used for custom text with a specific language, for example "opacheader". The bug is that in these locations, news for all (staff and opac) are displayed. This is because GetNewsToDisplay uses SQL : opac_news.lang = '' OR opac_news.lang = ? This patch is a quick fix. This feature maybe needs a big revamping. Test plan : 1) Remove any news 2) Create a news with empty 'Display location' and some content 3) Display OPAC interface 4) without patch you see in location of 'opacheader', 'opacnavright' ... the content of the news 5) With patch you see content of the news only in news table 6) Create a news for opacheader 7) Check it appears in correct language -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28698] News for all displays in all locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28698 Fridolin Somers changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28698] News for all displays in all locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28698 Fridolin Somers changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|oleon...@myacpl.org |fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
