[Koha-bugs] [Bug 28764] Sorting not correct in pagination on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28764 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #12 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28764] Sorting not correct in pagination on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28764 Fridolin Somers changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable CC||fridolin.som...@biblibre.co ||m Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09 released in|| --- Comment #11 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28764] Sorting not correct in pagination on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28764 Kyle M Hall changed: What|Removed |Added Version(s)|21.11.00|21.11.00,21.05.03 released in|| Status|Pushed to master|Pushed to stable CC||k...@bywatersolutions.com --- Comment #10 from Kyle M Hall --- Pushed to 21.05.x for 21.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28764] Sorting not correct in pagination on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28764 --- Comment #9 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28764] Sorting not correct in pagination on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28764 Jonathan Druart changed: What|Removed |Added Version(s)||21.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28764] Sorting not correct in pagination on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28764 --- Comment #8 from Marcel de Rooy --- Created attachment 123652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123652=edit Bug 28764: (QA follow-up) Add comment, remove two defined's If we no longer offer the sortfield with :asc actively, we should probably write it somewhere too. Replaced a few defined tests by empty test. No need to split empty string or zero etc. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28764] Sorting not correct in pagination on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28764 Marcel de Rooy changed: What|Removed |Added Attachment #123297|0 |1 is obsolete|| --- Comment #7 from Marcel de Rooy --- Created attachment 123651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123651=edit Bug 28764: Alter sort dropdown to use direction parameter This code is odd -we build a select in the template, then turn it into a list of links using javascript This patch adds a direction data element and uses it while building the links Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28764] Sorting not correct in pagination on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28764 Marcel de Rooy changed: What|Removed |Added Attachment #123207|0 |1 is obsolete|| --- Comment #6 from Marcel de Rooy --- Created attachment 123650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123650=edit Bug 28764: Parse direction parameter in public list view This patch adds a check for a 'direction' paramter in list sorting. It maintains the existing syntax for sorting 'sortfield=field:direction' but adds support for the form used in paginations and more commonly thtoughout Koha' sortfield=field=direction' To test: 1 - Create a public list 2 - Add enough items to generate two pages (40 worked for me) 3 - View the list and enforce sorting by date added descending: sortfield=dateadded:desc 4 - Note the titles shown 5 - Click to second page using the pagination bar 6 - Note the same titles are shown, in a reversed order 7 - Apply patch 8 - repeat 305 9 - Second page is sorted correctly! Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28764] Sorting not correct in pagination on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28764 Marcel de Rooy changed: What|Removed |Added Patch complexity|Trivial patch |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28764] Sorting not correct in pagination on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28764 --- Comment #5 from Nick Clemens --- (In reply to Marcel de Rooy from comment #3) > This is a bit confusing. We overrule the sortfield parameter which is still > used in Koha by direction. > > When I am in Your Lists, I click Sort and get a URL with sortfield=title:desc > > If direction is the way to go, please be more thorough. I think the follow up is something like you wanted? We could remove the old style all together, but I felt libraries could have existing links that we should not break. Rewriting the code here to build the dropdown sorting list more straightforward is beyond scope I think. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28764] Sorting not correct in pagination on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28764 --- Comment #4 from Nick Clemens --- Created attachment 123297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123297=edit Bug 28764: Alter sort dropdown to use direction parameter This code is odd -we build a select in the template, then turn it into a list of links using javascript This patch adds a direction data element and uses it while building the links -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28764] Sorting not correct in pagination on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28764 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28764] Sorting not correct in pagination on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28764 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #3 from Marcel de Rooy --- This is a bit confusing. We overrule the sortfield parameter which is still used in Koha by direction. When I am in Your Lists, I click Sort and get a URL with sortfield=title:desc If direction is the way to go, please be more thorough. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28764] Sorting not correct in pagination on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28764 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28764] Sorting not correct in pagination on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28764 Owen Leonard changed: What|Removed |Added Attachment #123205|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 123207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123207=edit Bug 28764: Parse direction parameter in public list view This patch adds a check for a 'direction' paramter in list sorting. It maintains the existing syntax for sorting 'sortfield=field:direction' but adds support for the form used in paginations and more commonly thtoughout Koha' sortfield=field=direction' To test: 1 - Create a public list 2 - Add enough items to generate two pages (40 worked for me) 3 - View the list and enforce sorting by date added descending: sortfield=dateadded:desc 4 - Note the titles shown 5 - Click to second page using the pagination bar 6 - Note the same titles are shown, in a reversed order 7 - Apply patch 8 - repeat 305 9 - Second page is sorted correctly! Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28764] Sorting not correct in pagination on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28764 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28764] Sorting not correct in pagination on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28764 Nick Clemens changed: What|Removed |Added Assignee|oleon...@myacpl.org |n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28764] Sorting not correct in pagination on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28764 --- Comment #1 from Nick Clemens --- Created attachment 123205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123205=edit Bug 28764: Parse direction parameter in public list view This patch adds a check for a 'direction' paramter in list sorting. It maintains the existing syntax for sorting 'sortfield=field:direction' but adds support for the form used in paginations and more commonly thtoughout Koha' sortfield=field=direction' To test: 1 - Create a public list 2 - Add enough items to generate two pages (40 worked for me) 3 - View the list and enforce sorting by date added descending: sortfield=dateadded:desc 4 - Note the titles shown 5 - Click to second page using the pagination bar 6 - Note the same titles are shown, in a reversed order 7 - Apply patch 8 - repeat 305 9 - Second page is sorted correctly! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28764] Sorting not correct in pagination on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28764 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
