[Koha-bugs] [Bug 28845] OpacAddMastheadLibraryPulldown does not respect multibranchlimit in OPAC_SEARCH_LIMIT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28845 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #11 from Victor Grousset/tuxayo --- Can't backport to 20.05.x due to a conflict. The relevant code isn't there ([% IF lsg.id == opac_name %]) Help needed if someone is interested in the backport. I couldn't reproduce but I'm not sure if I did it right or if 20.05.x isn't affected. On request I can try with 20.11.x to check if did the test plan correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28845] OpacAddMastheadLibraryPulldown does not respect multibranchlimit in OPAC_SEARCH_LIMIT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28845 Fridolin Somers changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable CC||fridolin.som...@biblibre.co ||m Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.11 released in|| --- Comment #10 from Fridolin Somers --- Pushed to 20.11.x for 20.11.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28845] OpacAddMastheadLibraryPulldown does not respect multibranchlimit in OPAC_SEARCH_LIMIT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28845 Kyle M Hall changed: What|Removed |Added Version(s)|21.11.00|21.11.00,21.05.05 released in|| CC||k...@bywatersolutions.com Status|Pushed to master|Pushed to stable --- Comment #9 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28845] OpacAddMastheadLibraryPulldown does not respect multibranchlimit in OPAC_SEARCH_LIMIT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28845 --- Comment #8 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28845] OpacAddMastheadLibraryPulldown does not respect multibranchlimit in OPAC_SEARCH_LIMIT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28845 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||21.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28845] OpacAddMastheadLibraryPulldown does not respect multibranchlimit in OPAC_SEARCH_LIMIT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28845 Joonas Kylmälä changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |joonas.kylm...@iki.fi |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28845] OpacAddMastheadLibraryPulldown does not respect multibranchlimit in OPAC_SEARCH_LIMIT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28845 --- Comment #7 from Joonas Kylmälä --- Created attachment 124792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124792=edit Bug 28845: (follow-up) Retain selection when using advanced search Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28845] OpacAddMastheadLibraryPulldown does not respect multibranchlimit in OPAC_SEARCH_LIMIT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28845 Joonas Kylmälä changed: What|Removed |Added Attachment #123828|0 |1 is obsolete|| Attachment #124573|0 |1 is obsolete|| --- Comment #6 from Joonas Kylmälä --- Created attachment 124791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124791=edit Bug 28845: Match against the full limit string, not just the group id To test: 1 - Add to OPAC virtual host in apache conf: SetEnv OPAC_SEARCH_LIMIT branch:multibranch-1 SetEnv OPAC_LIMIT_OVERRIDE 1 RequestHeader add X-Koha-SetEnv "OPAC_SEARCH_LIMIT branch:multibranchlimit-1" RequestHeader add X-Koha-SetEnv "OPAC_LIMIT_OVERRIDE 1" 2 - Enable system preference OpacAddMastheadLibraryPulldown 3 - Create a library group enabled as OPAC search group (or make sure existing group 1 is an OPAC search group) 4 - Load the opac - dropdown does not pree-select the search group 5 - Apply patch 6 - Relaod opac - group is pre-selected! Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28845] OpacAddMastheadLibraryPulldown does not respect multibranchlimit in OPAC_SEARCH_LIMIT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28845 Joonas Kylmälä changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28845] OpacAddMastheadLibraryPulldown does not respect multibranchlimit in OPAC_SEARCH_LIMIT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28845 --- Comment #5 from Nick Clemens --- (In reply to Joonas Kylmälä from comment #3) > This patch breaks the group selection in OPAC advanced search, i.e. with > this patch applied if you go to the URL > > http://localhost:8080/cgi-bin/koha/opac-search. > pl?advsearch=1_search=1=1_by=relevance=Search > > > then the group doesn't get selected in the search menu. Updated, stole a change from 28847 :-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28845] OpacAddMastheadLibraryPulldown does not respect multibranchlimit in OPAC_SEARCH_LIMIT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28845 --- Comment #4 from Nick Clemens --- Created attachment 124573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124573=edit Bug 28845: (follow-up) Retain selection when using advanced search -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28845] OpacAddMastheadLibraryPulldown does not respect multibranchlimit in OPAC_SEARCH_LIMIT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28845 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28845] OpacAddMastheadLibraryPulldown does not respect multibranchlimit in OPAC_SEARCH_LIMIT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28845 Joonas Kylmälä changed: What|Removed |Added Status|Signed Off |Failed QA CC||joonas.kylm...@iki.fi --- Comment #3 from Joonas Kylmälä --- This patch breaks the group selection in OPAC advanced search, i.e. with this patch applied if you go to the URL http://localhost:8080/cgi-bin/koha/opac-search.pl?advsearch=1_search=1=1_by=relevance=Search then the group doesn't get selected in the search menu. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28845] OpacAddMastheadLibraryPulldown does not respect multibranchlimit in OPAC_SEARCH_LIMIT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28845 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #123799|0 |1 is obsolete|| --- Comment #2 from Andrew Fuerste-Henry --- Created attachment 123828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123828=edit Bug 28845: Match against the full limit string, not just the group id To test: 1 - Add to OPAC virtual host in apache conf: SetEnv OPAC_SEARCH_LIMIT branch:multibranch-1 SetEnv OPAC_LIMIT_OVERRIDE 1 RequestHeader add X-Koha-SetEnv "OPAC_SEARCH_LIMIT branch:multibranchlimit-1" RequestHeader add X-Koha-SetEnv "OPAC_LIMIT_OVERRIDE 1" 2 - Enable system preference OpacAddMastheadLibraryPulldown 3 - Create a library group enabled as OPAC search group (or make sure existing group 1 is an OPAC search group) 4 - Load the opac - dropdown does not pree-select the search group 5 - Apply patch 6 - Relaod opac - group is pre-selected! Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28845] OpacAddMastheadLibraryPulldown does not respect multibranchlimit in OPAC_SEARCH_LIMIT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28845 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28845] OpacAddMastheadLibraryPulldown does not respect multibranchlimit in OPAC_SEARCH_LIMIT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28845 Nick Clemens changed: What|Removed |Added Blocks||28847 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28845] OpacAddMastheadLibraryPulldown does not respect multibranchlimit in OPAC_SEARCH_LIMIT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28845 Nick Clemens changed: What|Removed |Added Assignee|oleon...@myacpl.org |n...@bywatersolutions.com CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28845] OpacAddMastheadLibraryPulldown does not respect multibranchlimit in OPAC_SEARCH_LIMIT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28845 --- Comment #1 from Nick Clemens --- Created attachment 123799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123799=edit Bug 28845: Match against the full limit string, not just the group id To test: 1 - Add to OPAC virtual host in apache conf: SetEnv OPAC_SEARCH_LIMIT branch:multibranch-1 SetEnv OPAC_LIMIT_OVERRIDE 1 RequestHeader add X-Koha-SetEnv "OPAC_SEARCH_LIMIT branch:multibranchlimit-1" RequestHeader add X-Koha-SetEnv "OPAC_LIMIT_OVERRIDE 1" 2 - Enable system preference OpacAddMastheadLibraryPulldown 3 - Create a library group enabled as OPAC search group (or make sure existing group 1 is an OPAC search group) 4 - Load the opac - dropdown does not pree-select the search group 5 - Apply patch 6 - Relaod opac - group is pre-selected! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28845] OpacAddMastheadLibraryPulldown does not respect multibranchlimit in OPAC_SEARCH_LIMIT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28845 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
