[Koha-bugs] [Bug 28853] Textarea in biblio record editor breaks authority plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28853 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #9 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28853] Textarea in biblio record editor breaks authority plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28853 Andrew Fuerste-Henry changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable CC||and...@bywatersolutions.com Version(s)|22.05.00,21.11.01 |22.05.00,21.11.01,21.05.08 released in|| --- Comment #8 from Andrew Fuerste-Henry --- Pushed to 21.05.x for 21.05.08 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28853] Textarea in biblio record editor breaks authority plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28853 David Nind changed: What|Removed |Added CC||da...@davidnind.com Text to go in the||This fixes an issue when release notes||adding or editing record ||subfields using the ||authority plugin and it has ||a value with more than 100 ||characters. (When a ||subfield has more than 100 ||characters it changes to a ||text area rather than a ||standard input field, this ||caused JavaScript issues ||when using authority terms ||over 100 characters.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28853] Textarea in biblio record editor breaks authority plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28853 Kyle M Hall changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||k...@bywatersolutions.com Version(s)|22.05.00|22.05.00,21.11.01 released in|| --- Comment #7 from Kyle M Hall --- Pushed to 21.11.x for 21.11.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28853] Textarea in biblio record editor breaks authority plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28853 Fridolin Somers changed: What|Removed |Added Version(s)||22.05.00 released in|| Status|Passed QA |Pushed to master --- Comment #6 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28853] Textarea in biblio record editor breaks authority plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28853
Jonathan Druart changed:
What|Removed |Added
Attachment #127348|0 |1
is obsolete||
--- Comment #5 from Jonathan Druart ---
Created attachment 128161
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128161=edit
Bug 28853: Fix authority plugin when textarea in biblio record editor
In biblio record editor, when subfield value contains more than 100 characters
the editor uses a textarea instead of an input.
On a field using authority plugin, this breaks the JavaScript because it only
searches for input tags :
In
/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/blinddetail-biblio-search.tt
:
> this.getElementsByTagName('input')[1].value = values[i];
Test plan :
1) Prepare :
1.1) Create a new biblio record with a field using authority plugin, for
example 606
1.2) Do not use authority plugin but enter in 606$x more than 100 chars
1.3) Save record
1.4) Create a new autority for 606 biblio field with $a and a $x containing
more than 100 chars
2) Test 1 :
2.1) Edit again the biblio record, you see a text area for 606$x
2.2) Use authority plugin on field 606
2.3) Search and choose the new autority
2.4) Check $a,$x and $9 are well filled
3) Test 2 :
3.1) Empty field 606
3.2) Create a second $x subfield and fill it with a random value
3.3) Use authority plugin again on field 606
3.4) Search and choose the new autority
3.5) Check $a and $9 are well filled
3.6) Check first $x contains the value from autority and second $x is empty
Signed-off-by: Florian Bontemps
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28853] Textarea in biblio record editor breaks authority plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28853 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28853] Textarea in biblio record editor breaks authority plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28853 Florian changed: What|Removed |Added CC||florian.bontemps@biblibre.c ||om --- Comment #4 from Florian --- I know Fridolin and i work in the same company but this patch has gone unattended for a couple months now. Feel free to ask for another signoff if needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28853] Textarea in biblio record editor breaks authority plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28853
Florian changed:
What|Removed |Added
Attachment #123819|0 |1
is obsolete||
--- Comment #3 from Florian ---
Created attachment 127348
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127348=edit
Bug 28853: Fix authority plugin when textarea in biblio record editor
In biblio record editor, when subfield value contains more than 100 characters
the editor uses a textarea instead of an input.
On a field using authority plugin, this breaks the JavaScript because it only
searches for input tags :
In
/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/blinddetail-biblio-search.tt
:
> this.getElementsByTagName('input')[1].value = values[i];
Test plan :
1) Prepare :
1.1) Create a new biblio record with a field using authority plugin, for
example 606
1.2) Do not use authority plugin but enter in 606$x more than 100 chars
1.3) Save record
1.4) Create a new autority for 606 biblio field with $a and a $x containing
more than 100 chars
2) Test 1 :
2.1) Edit again the biblio record, you see a text area for 606$x
2.2) Use authority plugin on field 606
2.3) Search and choose the new autority
2.4) Check $a,$x and $9 are well filled
3) Test 2 :
3.1) Empty field 606
3.2) Create a second $x subfield and fill it with a random value
3.3) Use authority plugin again on field 606
3.4) Search and choose the new autority
3.5) Check $a and $9 are well filled
3.6) Check first $x contains the value from autority and second $x is empty
Signed-off-by: Florian Bontemps
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28853] Textarea in biblio record editor breaks authority plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28853 Florian changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28853] Textarea in biblio record editor breaks authority plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28853 Fridolin Somers changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28812 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28853] Textarea in biblio record editor breaks authority plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28853
--- Comment #2 from Fridolin Somers ---
Created attachment 123819
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123819=edit
Bug 28853: Fix authority plugin when textarea in biblio record editor
In biblio record editor, when subfield value contains more than 100 characters
the editor uses a textarea instead of an input.
On a field using authority plugin, this breaks the JavaScript because it only
searches for input tags :
In
/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/blinddetail-biblio-search.tt
:
> this.getElementsByTagName('input')[1].value = values[i];
Test plan :
1) Prepare :
1.1) Create a new biblio record this a field using authority plugin, for
example 606
1.2) Do not use authority plugin but enter in 606$x more than 100 chars
1.3) Save record
1.4) Create a new autority for 606 biblio field with $a and a $x containing
more than 100 chars
2) Test 1 :
2.1) Edit again the biblio record, you see a text area for 606$x
2.2) Use authority plugin on field 606
2.3) Search and choose the new autority
2.4) Check $a,$x and $9 are well filled
3) Test 2 :
3.1) Empty field 606
3.2) Create a second $x subfield and fill it with a random value
3.3) Use authority plugin again on field 606
3.4) Search and choose the new autority
3.5) Check $a and $9 are well filled
3.6) Check first $x contains the value from autority and second $x is empty
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28853] Textarea in biblio record editor breaks authority plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28853 Fridolin Somers changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28853] Textarea in biblio record editor breaks authority plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28853
--- Comment #1 from Fridolin Somers ---
BTW :
This JavaScript code is a mix of JQuery and old style.
It seams it is not very solid and several parts are repeated, like :
> var re = new RegExp('^subfield' + subfield_name,'g');
> var subfields = $(field_start).children('ul').children('li').filter(
> function() {
> return this.id.match(re);
> });
This would need a big revamping.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28853] Textarea in biblio record editor breaks authority plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28853 Fridolin Somers changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
