[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Tomás Cohen Arazi changed: What|Removed |Added Blocks||36458 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36458 [Bug 36458] Koha::Item->return_claim method name is not correct -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Julian Maurice changed: What|Removed |Added Blocks||35963 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35963 [Bug 35963] Problem using some filters in the bundled items table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #521 from Martin Renvoize --- (In reply to Marcel de Rooy from comment #520) > (In reply to Jonathan Druart from comment #519) > > Note that's not the problem. We should not add the AV if one exists for > > "Missing from bundle", the IGNORE won't work here, and we will keep add one > > other "Missing from bundle". > > Agreed. IGNORE just ignores :) We could do better. Bug 34881 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What|Removed |Added Blocks||34881 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34881 [Bug 34881] Database update for bug 28854 isn't fully idempotent -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #520 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #519) > Note that's not the problem. We should not add the AV if one exists for > "Missing from bundle", the IGNORE won't work here, and we will keep add one > other "Missing from bundle". Agreed. IGNORE just ignores :) We could do better. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854
--- Comment #519 from Jonathan Druart ---
(In reply to Marcel de Rooy from comment #518)
> Martin, should the dbrev be changed as follows:
>
> diff --git a/installer/data/mysql/db_revs/220600015.pl
> b/installer/data/mysql/db_revs/220600015.pl
> index 89dc2d628b..11298b6860 100755
> --- a/installer/data/mysql/db_revs/220600015.pl
> +++ b/installer/data/mysql/db_revs/220600015.pl
> @@ -26,7 +26,7 @@ return {
> $lost_val++;
>
> $dbh->do(qq{
> - INSERT INTO authorised_values (category,authorised_value,lib)
> VALUES ('LOST',$lost_val,'Missing from bundle')
> + INSERT IGNORE INTO authorised_values
> (category,authorised_value,lib) VALUES ('LOST',$lost_val,'Missing from
> bundle')
> });
> say $out "Missing from bundle LOST AV added";
>
> @@ -34,7 +34,7 @@ return {
> $nfl_val++;
>
> $dbh->do(qq{
> - INSERT INTO authorised_values (category,authorised_value,lib)
> VALUES ('NOT_LOAN',$nfl_val,'Added to bundle')
> + INSERT IGNORE INTO authorised_values
> (category,authorised_value,lib) VALUES ('NOT_LOAN',$nfl_val,'Added to
> bundle')
> });
> say $out "Added to bundle NOT_LOAN AV added";
>
>
> The dbrev crashes on a FK constraint when run twice in the context of bug
> 34683
Note that's not the problem. We should not add the AV if one exists for
"Missing from bundle", the IGNORE won't work here, and we will keep add one
other "Missing from bundle".
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854
--- Comment #518 from Marcel de Rooy ---
Martin, should the dbrev be changed as follows:
diff --git a/installer/data/mysql/db_revs/220600015.pl
b/installer/data/mysql/db_revs/220600015.pl
index 89dc2d628b..11298b6860 100755
--- a/installer/data/mysql/db_revs/220600015.pl
+++ b/installer/data/mysql/db_revs/220600015.pl
@@ -26,7 +26,7 @@ return {
$lost_val++;
$dbh->do(qq{
- INSERT INTO authorised_values (category,authorised_value,lib)
VALUES ('LOST',$lost_val,'Missing from bundle')
+ INSERT IGNORE INTO authorised_values
(category,authorised_value,lib) VALUES ('LOST',$lost_val,'Missing from bundle')
});
say $out "Missing from bundle LOST AV added";
@@ -34,7 +34,7 @@ return {
$nfl_val++;
$dbh->do(qq{
- INSERT INTO authorised_values (category,authorised_value,lib)
VALUES ('NOT_LOAN',$nfl_val,'Added to bundle')
+ INSERT IGNORE INTO authorised_values
(category,authorised_value,lib) VALUES ('NOT_LOAN',$nfl_val,'Added to bundle')
});
say $out "Added to bundle NOT_LOAN AV added";
The dbrev crashes on a FK constraint when run twice in the context of bug 34683
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #517 from Katrin Fischer --- *** Bug 28602 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What|Removed |Added Blocks|33827 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33827 [Bug 33827] The option to skip bundle verification at checkin should be syspref driven -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What|Removed |Added Blocks||33827 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33827 [Bug 33827] The option to skip bundle verification at checkin should be syspref driven -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #516 from Jonathan Druart --- (In reply to Jonathan Druart from comment #515) > (In reply to Martin Renvoize from comment #269) > > (In reply to Katrin Fischer from comment #224) > > > d) Should we be able to change contents of a bundle while it is checked > > > out? > > > At the moment it's possible. Maybe a 'safety question'? > > > (question/suggestion) > > > > Fixed in follow-up. > > This is not working, there is some code in the template to disable the > buttons but it does not work. I have a patch to fix it, but I am wondering > if it is correct to disable the edition of a bundle item that is checked out. > > There is no code server-side to prevent that (and so it's currently > possible). > > Should we fix or remove this restriction? See bug 33817. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #515 from Jonathan Druart --- (In reply to Martin Renvoize from comment #269) > (In reply to Katrin Fischer from comment #224) > > d) Should we be able to change contents of a bundle while it is checked out? > > At the moment it's possible. Maybe a 'safety question'? > > (question/suggestion) > > Fixed in follow-up. This is not working, there is some code in the template to disable the buttons but it does not work. I have a patch to fix it, but I am wondering if it is correct to disable the edition of a bundle item that is checked out. There is no code server-side to prevent that (and so it's currently possible). Should we fix or remove this restriction? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Jonathan Druart changed: What|Removed |Added Blocks|31082 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31082 [Bug 31082] Add tooltip to buttons when item bundles cannot be changed while checked out -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Jonathan Druart changed: What|Removed |Added Blocks||33817 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33817 [Bug 33817] Composition or an item bundle can be changed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #514 from Marcel de Rooy --- Few observations while testing a dependent report: [1] When I have a bundle with 2 items, checkout and checkin (only one barcode), I see the following on opac-detail for the missing item: Missing from bundle Added to bundle In bundle: Learning Perl / This message is not very clear (at the least). Should we replace this by Missing from bundle X ? [2] Similarly, the other item says: Added to bundle In bundle: Learning Perl / Could it be clearer to say just the latter here (In bundle X) ? [3] Furthermore, I note that the parent biblo record that contains the host item, does not show that this item is a bundle. Should we somehow indicate that ? [4] Things can get even more confusing when we add two host items to one parent record. If those two items contain various items, they are all referenced by the same name (biblio title of parent record). But these are different bundles. [5] Elaborating on point 5: If you have two bundles on same biblio record, the normal display on intranet of the biblio record crashes on the second bundle: GET /api/v1/items/2525/bundled_items: unhandled exception (Mojo::Exception)<> NOTE: This was the case with the patches of 29099 but also WITHOUT ! I have the impression that this area needs more attention still. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #513 from Marcel de Rooy --- CREATE TABLE `item_bundles` ( `item` int(11) NOT NULL, Why didnt we call that itemnumber? And why not an autoincrement id here too btw? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Julian Maurice changed: What|Removed |Added Blocks||33035 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33035 [Bug 33035] Add volume column in the item bundle table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #512 from Martin Renvoize --- Bug 32802 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #511 from Martin Renvoize --- (In reply to Jonathan Druart from comment #510) > All that bundle JS code in detail.tt could have been moved to a dedicated js > file to keep the template under 2k lines :D True.. it grew and grew and grew. I'll create a follow-up bug and handle that -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #510 from Jonathan Druart --- All that bundle JS code in detail.tt could have been moved to a dedicated js file to keep the template under 2k lines :D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What|Removed |Added Text to go in the|This new feature adds the |This new feature adds the release notes|ability to create item |ability to create item |bundles for loans. |bundles for loans. | | |One can |One can |create a new collection |create a new collection |level biblio record and add |level biblio record and add |items to it as normal. |items to it as normal. |Those items can then be |Those items can then be |converted to bundles by |converted to bundles by |adding existing items to|adding existing items to |them using their barcodes. |them using their barcodes. |The items will be marked as |The items will be marked as |'not for loan' in their |'not for loan' in their |original parent records. |original parent records. || |Bundle items follow normal |Bundle items follow normal |circulation rules for |circulation rules for |checkout. Upon check-in a |checkout. Upon check-in a |new verification step is|new verification step is |added where by the |added where by the |librarian is expected to|librarian is expected to |scan each constituent item |scan each constituent item |to varify it's presence in |to varify it's presence in |the bundle. If an item is |the bundle. If an item is |missing from the bundle it |missing from the bundle it |is marked as lost with a|is marked as lost with a |new lost - Missing from |new lost - Missing from |bundle value. If an item |bundle value. If an item |is found that is not|is found that is not |expected to be in the |expected to be in the |bundle it it highlighted to |bundle it it highlighted to |the librarian after |the librarian after |check-in so it can be |check-in so it can be |placed to one side. |placed to one side. || ||**Sponsored by** *PTFS ||Europe* -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Julian Maurice changed: What|Removed |Added Blocks||32134 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32134 [Bug 32134] Show the bundle size when checked out -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #509 from Martin Renvoize --- Documentation converted from google doc and merged. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What|Removed |Added Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Julian Maurice changed: What|Removed |Added Blocks||32121 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 [Bug 32121] Show an alert when adding a checked out item to an item bundle -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #508 from Katrin Fischer --- I notice a lot of nice additions to this are hiding in the 'Blocks' list here! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Julian Maurice changed: What|Removed |Added Blocks||31615 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31615 [Bug 31615] Allow checkin of items bundles without verifying their contents -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED|Needs documenting Documentation||Martin Renvoize contact|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Lucas Gass changed: What|Removed |Added Resolution|--- |FIXED CC||lu...@bywatersolutions.com Status|Pushed to master|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Tomás Cohen Arazi changed: What|Removed |Added Keywords|additional_work_needed | --- Comment #507 from Tomás Cohen Arazi --- Follow-up pushed to master. Thanks for addressing it promptly, Martin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #506 from Martin Renvoize --- Created attachment 139347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139347&action=edit Bug 28854: (follow-up) Remove errant warning Oops, I left in a bare warn from debugging.. this simply removes it; it is unrequired. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #505 from Martin Renvoize --- Oops, I'll work on this today.. apologies I missed it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Bug 28854 depends on bug 31085, which changed state. Bug 31085 Summary: The return claims table no longer reloads on resolution https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31085 What|Removed |Added Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Bug 28854 depends on bug 31087, which changed state. Bug 31087 Summary: Undefined notes in returns claims get stringified to 'null' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31087 What|Removed |Added Status|Pushed to stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #504 from Jonathan Druart --- New error/warning in test output t/db_dependent/Koha/Item.t .. 5/25 DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Duplicate entry '987-988' for key 'PRIMARY' at /kohadevbox/koha/Koha/Item.pm line 1601 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Nick Clemens changed: What|Removed |Added Blocks||31192 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31192 [Bug 31192] Checking in an unkown barcode causes error -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What|Removed |Added Keywords||additional_work_needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What|Removed |Added Attachment #137684|0 |1 is obsolete|| --- Comment #503 from Martin Renvoize --- Created attachment 137685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137685&action=edit Bug 28854: (follow-up) Replace unique constraint in return claims This patch fixes the failing test for the return claims api. We add a new unique constraint to replace the one we removed earlier in the patchset. One should not be able to create a duplicate return claim for the same issue of an item. Test plan 1) Run the database update 2) Confirm that t/db_dependent/api/v1/return_claims.t now passes 3) Confirm that t/db_dependent/api/v1/items.t continues to pass 4) Bonus points, confirm that bundle checkin still works when items are missing Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #502 from Martin Renvoize --- Follow-up attached to fix the failing introduced here on master. Not sure why I didn't think about this constraint replacement in the first place, it's a nice improvement over the simple removal I did before and shouldn't have any negative side effects on the feature introduced here. The follow-up includes an atomic update and the kohaschema change but does not include the dbic schema build ;P -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #501 from Martin Renvoize --- Created attachment 137684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137684&action=edit Bug 28854: (follow-up) Replace unique constraint in return claims This patch fixes the failing test for the return claims api. We add a new unique constraint to replace the one we removed earlier in the patchset. One should not be able to create a duplicate return claim for the same issue of an item. Test plan 1) Run the database update 2) Confirm that t/db_dependent/api/v1/return_claims.t now passes 3) Confirm that t/db_dependent/api/v1/items.t continues to pass 4) Bonus points, confirm that bundle checkin still works when items are missing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #500 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #499 from Kyle M Hall --- Created attachment 137571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137571&action=edit Bug 28854: (QA follow-up) Fix DB revision for AV's above 10 The authorised_value field is a varchar and so 'MAX' will sort '9' above '10' and cause issues if you have more than 9 AV values already for LOST or NOT_LOAN. This patch adds a 'CAST' to the field so we can use MAX correctly. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #498 from Kyle M Hall --- Created attachment 137570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137570&action=edit Bug 28854: (QA follow-up) Remove duplicate key test We now allow duplication of issue_id accross the return claims table (to allow for the case where a bundle item has been loaned and thus multiple claims can result from the same checkout. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #497 from Kyle M Hall --- Created attachment 137569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137569&action=edit Bug 28854: (QA follow-up) Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #496 from Kyle M Hall --- Created attachment 137568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137568&action=edit Bug 28854: (follow-up) Remove fields from from bundle items This patch removes the itemtype and collection code fields from the bundle items table. We will add the itemtype back in at a later date with a new bug as the display code needs some careful consideration and we felt that doing that work inline here would be an unrequired blocker. Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #495 from Kyle M Hall --- Created attachment 137567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137567&action=edit Bug 28854: (QA follow-up) Add missing TT filters Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #494 from Kyle M Hall --- Created attachment 137566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137566&action=edit Bug 28854: (follow-up) Add handling for part_numbers/names This patch adds part number/name handling to the new biblio-format js include. This will add such details to bundle management tables. Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #493 from Kyle M Hall --- Created attachment 137565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137565&action=edit Bug 28854: (follow-up) Link to 'In bundle' on OPAC This patch adds the 'In bundle: Link' to the OPAC to mirror what we have on the staff client. Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #492 from Kyle M Hall --- Created attachment 137564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137564&action=edit Bug 28854: (follow-up) Restore block styling on bundled span This patch restores a css rule that we lost during rebases that makes the 'bundled' span that appears for bundled items on their respective details pages so that the 'In bundle: ' text in the status field of the table appears beneath the 'Not for loan (Added to bundle)' text. Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #491 from Kyle M Hall --- Created attachment 137563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137563&action=edit Bug 28854: (follow-up) Make 'Manage bundle' button a 'toggle' This patch adds and removes the 'active' class to the 'Manage bundle' button such that it correctly reflects whether the manage area is expanded or not for the bundle item. Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #490 from Kyle M Hall --- Created attachment 137562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137562&action=edit Bug 28854: (follow-up) Add bundle item status to manage button This patch adds the item counts (Present|Lost) to the 'Manage bundle' button in the catalogue details page. Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #489 from Kyle M Hall --- Created attachment 137561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137561&action=edit Bug 28854: (follow-up) Restore last seen date formatting We lost the date formatting somewhere along the line with rebases, this patch restores the call to $date for last seen date. Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #488 from Kyle M Hall --- Created attachment 137560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137560&action=edit Bug 28854: (follow-up) Link bundle items to thier biblios This patch splits out the title formatting from the bundle item title display into it's own new js-biblio-format include file and adds biblio linking options. Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #487 from Kyle M Hall --- Created attachment 137559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137559&action=edit Bug 28854: (follow-up) Disable bundle editing for checked out This patch disables the add and remove options under bundle management when the bundled item in question is checked out. Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #486 from Kyle M Hall --- Created attachment 137558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137558&action=edit Bug 28854: (follow-up) Use barcodedecode in Koha::REST::V1::Items This removes any leading or trailing whitespace from the external id passed Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #485 from Kyle M Hall --- Created attachment 137557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137557&action=edit Bug 28854: (follow-up) Improve error for item not found Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #484 from Kyle M Hall --- Created attachment 137556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137556&action=edit Bug 28854: (follow-up) Fix typo in templates and test plan * aready > already * 61 > 62 Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #483 from Kyle M Hall --- Created attachment 137555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137555&action=edit Bug 28854: (follow-up) Move preferences to "Item bundles" Move the preferences into a section under 'Circulation' called 'Item bundles' Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #482 from Kyle M Hall --- Created attachment 137554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137554&action=edit Bug 28854: (follow-up) Rename column configuration to barcode This patch updates the column configuration from 'external_id' to 'barcode' Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #481 from Kyle M Hall --- Created attachment 137553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137553&action=edit Bug 28854: (follow-up) Translations fixes This patch wraps and unwraps strings appropriately for trasnlation. Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #480 from Kyle M Hall --- Created attachment 137552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137552&action=edit Bug 28854: Add default AV and Syspref values This patch adds the new AV and System Preferences to the installer. Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #479 from Kyle M Hall --- Created attachment 137551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137551&action=edit Bug 28854: Unit tests - chargelostitem This patch adds unit tests for the changes to chargelositem to ensure bundle charging works as expected setting the correct issue_id. Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #478 from Kyle M Hall --- Created attachment 137550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137550&action=edit Bug 28854: Unit test for AddReturn addition This patch adds tests for the AddReturn change that adds an 'InBundle' message to the return. Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #477 from Kyle M Hall --- Created attachment 137549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137549&action=edit Bug 28854: Unit test for Koha::Item additions This patch adds unit tests for the new methods added to Koha::Item including: * return_claim * return_claims * is_bundle * in_bundle * bundle_host * bundle_items * add_to_bundle * remove_from_bundle Test plan 1) Run t/db_dependent/Koha/Item.t Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #476 from Kyle M Hall --- Created attachment 137548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137548&action=edit Bug 28854: (follow-up) Use Koha::Item->itemtype introduced with bug 20469 Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #475 from Kyle M Hall --- Created attachment 137547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137547&action=edit Bug 28854: (QA follow-up) Fix QA tool complaints * Typo in code comment * Permissions on atomicupdate * Missing TT filter in template * Spelling in template Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #474 from Kyle M Hall --- Created attachment 137546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137546&action=edit Bug 28854: Make barcode comparison case insensative Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #473 from Kyle M Hall --- Created attachment 137545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137545&action=edit Bug 28854: (follow-up) Only count rows in the body This patch fixes the count to only include table rows in the body, i.e. skip the header row. Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #472 from Kyle M Hall --- Created attachment 137544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137544&action=edit Bug 28854: Add modal after checkin to print missing items list This patch adds a further modal to the post checkin alert to allow the user to print a view and print a list of items that went missing at this checkin to allow for replacements to be picked. Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #471 from Kyle M Hall --- Created attachment 137543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137543&action=edit Bug 28854: Add 'Remove from bundle' dialogue to details display This patch adds the counterpart of the 'Add to bundle' modal prompt for adding items to bundles from the catalogue details display. It allows for scanning barcodes to remove them from a bundle. Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #470 from Kyle M Hall --- Created attachment 137542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137542&action=edit Bug 28854: Add count of scanned items to verification modal Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #469 from Kyle M Hall --- Created attachment 137541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137541&action=edit Bug 28854: Highlight when a scanned item is unexpected Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #468 from Kyle M Hall --- Created attachment 137540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137540&action=edit Bug 28854: Enable claims return view when BundleLostValue is set This patch adds the alternation of BundleLostValue to enable the return claims functionality when Bundles are enbled. Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #467 from Kyle M Hall --- Created attachment 137538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137538&action=edit Bug 28854: Improve lost details display for bundle items This patch adds the return claim details to the bundle item status display on the catalogue details page. Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #466 from Kyle M Hall --- Created attachment 137537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137537&action=edit Bug 28854: Add ordering to checkin validation modal This enhancement adds simple dataTable ordering to the verification modal table at bundle checkin time. Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #465 from Kyle M Hall --- Created attachment 137536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137536&action=edit Bug 28854: Add option to print content list after verification We already allowed the user to view and print an updated content list after a varification showed that items were missing from the bundle. This patch adds the option to view and print the list even if the content has been varified to have not changed. Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #464 from Kyle M Hall --- Created attachment 137535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137535&action=edit Bug 28854: Simplified status handling for bundle inventory check Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #463 from Kyle M Hall --- Created attachment 137534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137534&action=edit Bug 28854: Record and display who lost the item This patch records the bundle issue from which an item is marked as lost so that we may use that to infer who lost the item (for later charges and display). Test plan 0) Apply all patches up to this point 1) Checkout a bundle to a user 2) Checkin the bundle and do not scan one of the barcodes at confirmation * Note that the item not scanned is marked as lost 3) Navigate to the biblio for the lost item and note that it is marked as lost. 4) Navigate to the biblio for the collection and expand the collection item that contains the lost item. Note the item is marked as lost and checkout details are listed. 5) Checkin the lost item * The item should be marked as found and the return_claims line should be marked as resolved. Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #462 from Kyle M Hall --- Created attachment 137533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137533&action=edit Bug 28854: DBIC Update ReturnClaim Schema Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #461 from Kyle M Hall --- Created attachment 137532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137532&action=edit Bug 28854: Drop unique index on issue_id in return claims With the introduction of circulating items within a bundle set, we can now loose multiple items from the bundle from the same issue. Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #460 from Kyle M Hall --- Created attachment 137531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137531&action=edit Bug 28854: Highlight bundle rows to clarify UI Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #459 from Kyle M Hall --- Created attachment 137530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137530&action=edit Bug 28854: Update circulation functionality for bundles This patch updates the circulation system to account for bundle checkins. We add a content verification step to ensure bundle content is all present at checkin and we use this comparison to mark missing items as lost. Test plan 0) Apply patches up to this point 1) Checkin an item that belongs to a bundle * An alert should be triggered noting that the item belongs to a bundle * The option to remove the item from the bundle should be clear * Click remove should result in the alert dissapearing and the item having been removed from the bundle. 2) Checkin an item bundle * A modal confirmation dialog should appear requesting each item barcode be scanned * As items are scanned they should be highlighted in yellow in the bundle content table * Upon submission; * The user will be alerted to any unexpected items that were scanned and told to put them to one side. * The user will be alerted that any missing items in the validation will have been marked as lost. * The bundle item will be marked as checked in. Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #458 from Kyle M Hall --- Created attachment 137529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137529&action=edit Bug 28854: Expose functionality to attach items to bundles This patch adds methods the the Koha::Item object for managing item bundling operations and then exposes those methods via the REST API. We include the new `BundleNotLoanValue` preference for setting not for loan values when an item is added to a bundle. Finally, we expose bundle management via the catalogue details page. Test plan: 0) Apply patches up to this point and run the database update 1) Configuration: `BundleNotLoanValue` should have been set by the database update and point to a newly added AV value. 2) Creating a new bundle * Add a new bib record * Mark the bib record as a 'collection' type by setting leader position 7 to 'c' * Add a new item to this bib record * You should see a new 'Manage bundle' button available in the 'Actions' column of the Holdings table. * Clicking 'Manage bundle' should expand the table to include a new row directly beneath this one. * Use the new 'Add to bundle' button that appears in this row to trigger a modal that allows entering the barcode of items you wish to add to the bundle * Upon closing the modal, the bundle content table should reload and contain your newly associated items. * You can subsequently remove an item from a bundle using the new 'Remove' button. 3) Not for loan * Items that have been added into a bundle should now appear as 'Not for loan' from their original biblio record and note which bundle they belong to. 4) Error cases * Try adding an item that already belongs to a bundle to another bundle: Note an error is displayed in the modal form. 5) The bundles feature can be disabled by unsetting the `BundleNotLoanValue` system preference. Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #457 from Kyle M Hall --- Created attachment 137528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137528&action=edit Bug 28854: DBIC Schema Updates Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Kyle M Hall changed: What|Removed |Added Attachment #137461|0 |1 is obsolete|| Attachment #137462|0 |1 is obsolete|| Attachment #137463|0 |1 is obsolete|| Attachment #137464|0 |1 is obsolete|| Attachment #137465|0 |1 is obsolete|| Attachment #137466|0 |1 is obsolete|| Attachment #137467|0 |1 is obsolete|| Attachment #137468|0 |1 is obsolete|| Attachment #137469|0 |1 is obsolete|| Attachment #137470|0 |1 is obsolete|| Attachment #137471|0 |1 is obsolete|| Attachment #137472|0 |1 is obsolete|| Attachment #137473|0 |1 is obsolete|| Attachment #137474|0 |1 is obsolete|| Attachment #137475|0 |1 is obsolete|| Attachment #137476|0 |1 is obsolete|| Attachment #137477|0 |1 is obsolete|| Attachment #137478|0 |1 is obsolete|| Attachment #137479|0 |1 is obsolete|| Attachment #137480|0 |1 is obsolete|| Attachment #137481|0 |1 is obsolete|| Attachment #137482|0 |1 is obsolete|| Attachment #137483|0 |1 is obsolete|| Attachment #137484|0 |1 is obsolete|| Attachment #137485|0 |1 is obsolete|| Attachment #137486|0 |1 is obsolete|| Attachment #137487|0 |1 is obsolete|| Attachment #137488|0 |1 is obsolete|| Attachment #137489|0 |1 is obsolete|| Attachment #137490|0 |1 is obsolete|| Attachment #137491|0 |1 is obsolete|| Attachment #137492|0 |1 is obsolete|| Attachment #137493|0 |1 is obsolete|| Attachment #137494|0 |1 is obsolete|| Attachment #137495|0 |1 is obsolete|| Attachment #137496|0 |1 is obsolete|| Attachment #137497|0 |1 is obsolete|| Attachment #137498|0 |1 is obsolete|| Attachment #137499|0 |1 is obsolete|| Attachment #137500|0 |1 is obsolete|| Attachment #137501|0 |1 is obsolete|| Attachment #137506|0 |1 is obsolete|| Attachment #137524|0 |1 is obsolete|| Attachment #137525|0 |1 is obsolete|| --- Comment #456 from Kyle M Hall --- Created attachment 137527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137527&action=edit Bug 28854: Database update Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes.
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #455 from Martin Renvoize --- Created attachment 137525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137525&action=edit Bug 28854: (QA follow-up) Fix DB revision for AV's above 10 The authorised_value field is a varchar and so 'MAX' will sort '9' above '10' and cause issues if you have more than 9 AV values already for LOST or NOT_LOAN. This patch adds a 'CAST' to the field so we can use MAX correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #454 from Martin Renvoize --- Created attachment 137524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137524&action=edit Bug 28854: (QA follow-up) Remove duplicate key test We now allow duplication of issue_id accross the return claims table (to allow for the case where a bundle item has been loaned and thus multiple claims can result from the same checkout. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #453 from Kyle M Hall --- > > Why the switch from effective_itemtype() to itemtype()? > > So.. the change here is actually so we can have access to the Item object > lower down in the function.. the switch from finding the itemtype object > directly to using the Koha::Item level accessor method means we get back the > effective_itemtype object directly via the accessor. See > Koha::Item->itemtype ;P Thanks! I see now! I missed that subroutine when I was looking for it! > Huh.. this is a copy/paste from Koha::Object::store (Yes, I'd like to move > it into DBIC at some point, but didn't feel it was appropriate here).. the > `\W?` is there.. just after `for column` in the regex.. not sure I follow > your question here I'm afraid. I missed where the \W was by focusing only on the patch and not the surrounding code. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #452 from Martin Renvoize --- (In reply to Kyle M Hall from comment #450) > I'm getting failures from t/db_dependent/Koha/Checkouts/ReturnClaim.t > In addition, can you address the two small things from my splinter review? Hmm.. I can't seem to get the test to fail.. did you run the DB update/get any errors when you ran the DB update? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854
--- Comment #451 from Martin Renvoize ---
(In reply to Kyle M Hall from comment #448)
> Comment on attachment 137503 [details] [review]
> Bug 28854: Squashed Patch Set for Reading
>
> Review of attachment 137503 [details] [review]:
> -
>
> ::: C4/Accounts.pm
> @@ +70,5 @@
> > sub chargelostitem {
> > my $dbh = C4::Context->dbh();
> > my ($borrowernumber, $itemnumber, $amount, $description) = @_;
> > +my $item = Koha::Items->find($itemnumber);
> > +my $itype = $item->itemtype;
>
> Why the switch from effective_itemtype() to itemtype()?
So.. the change here is actually so we can have access to the Item object lower
down in the function.. the switch from finding the itemtype object directly to
using the Koha::Item level accessor method means we get back the
effective_itemtype object directly via the accessor. See Koha::Item->itemtype
;P
>
> ::: Koha/Item.pm
> @@ +1611,5 @@
> > +}
> > +elsif ( $_->{msg} =~
> > +/Incorrect (?\w+) value: '(?.*)' for column
> > \W?(?\S+)/
> > + )
> > +{# The optional \W in the regex might be a quote or
> > backtick
>
> There is no \W in the regex. Wish it changed, or maybe the W should be lower
> case?
Huh.. this is a copy/paste from Koha::Object::store (Yes, I'd like to move it
into DBIC at some point, but didn't feel it was appropriate here).. the `\W?`
is there.. just after `for column` in the regex.. not sure I follow your
question here I'm afraid.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #450 from Kyle M Hall --- I'm getting failures from t/db_dependent/Koha/Checkouts/ReturnClaim.t In addition, can you address the two small things from my splinter review? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What|Removed |Added Blocks||31130 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31130 [Bug 31130] Display collection code in bundle management table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #449 from Kyle M Hall --- Created attachment 137506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137506&action=edit Bug 28854: (QA follow-up) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854
--- Comment #448 from Kyle M Hall ---
Comment on attachment 137503
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137503
Bug 28854: Squashed Patch Set for Reading
Review of attachment 137503:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=28854&attachment=137503)
-
::: C4/Accounts.pm
@@ +70,5 @@
> sub chargelostitem {
> my $dbh = C4::Context->dbh();
> my ($borrowernumber, $itemnumber, $amount, $description) = @_;
> +my $item = Koha::Items->find($itemnumber);
> +my $itype = $item->itemtype;
Why the switch from effective_itemtype() to itemtype()?
::: Koha/Item.pm
@@ +1611,5 @@
> +}
> +elsif ( $_->{msg} =~
> +/Incorrect (?\w+) value: '(?.*)' for column \W?(?\S+)/
> + )
> +{# The optional \W in the regex might be a quote or backtick
There is no \W in the regex. Wish it changed, or maybe the W should be lower
case?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Kyle M Hall changed: What|Removed |Added Attachment #137503|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #447 from Kyle M Hall --- Created attachment 137503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137503&action=edit Bug 28854: Squashed Patch Set for Reading Bug 28854: Database update Signed-off-by: Katrin Fischer Bug 28854: DBIC Schema Updates Signed-off-by: Katrin Fischer Bug 28854: Expose functionality to attach items to bundles This patch adds methods the the Koha::Item object for managing item bundling operations and then exposes those methods via the REST API. We include the new `BundleNotLoanValue` preference for setting not for loan values when an item is added to a bundle. Finally, we expose bundle management via the catalogue details page. Test plan: 0) Apply patches up to this point and run the database update 1) Configuration: `BundleNotLoanValue` should have been set by the database update and point to a newly added AV value. 2) Creating a new bundle * Add a new bib record * Mark the bib record as a 'collection' type by setting leader position 7 to 'c' * Add a new item to this bib record * You should see a new 'Manage bundle' button available in the 'Actions' column of the Holdings table. * Clicking 'Manage bundle' should expand the table to include a new row directly beneath this one. * Use the new 'Add to bundle' button that appears in this row to trigger a modal that allows entering the barcode of items you wish to add to the bundle * Upon closing the modal, the bundle content table should reload and contain your newly associated items. * You can subsequently remove an item from a bundle using the new 'Remove' button. 3) Not for loan * Items that have been added into a bundle should now appear as 'Not for loan' from their original biblio record and note which bundle they belong to. 4) Error cases * Try adding an item that already belongs to a bundle to another bundle: Note an error is displayed in the modal form. 5) The bundles feature can be disabled by unsetting the `BundleNotLoanValue` system preference. Signed-off-by: Katrin Fischer Bug 28854: Update circulation functionality for bundles This patch updates the circulation system to account for bundle checkins. We add a content verification step to ensure bundle content is all present at checkin and we use this comparison to mark missing items as lost. Test plan 0) Apply patches up to this point 1) Checkin an item that belongs to a bundle * An alert should be triggered noting that the item belongs to a bundle * The option to remove the item from the bundle should be clear * Click remove should result in the alert dissapearing and the item having been removed from the bundle. 2) Checkin an item bundle * A modal confirmation dialog should appear requesting each item barcode be scanned * As items are scanned they should be highlighted in yellow in the bundle content table * Upon submission; * The user will be alerted to any unexpected items that were scanned and told to put them to one side. * The user will be alerted that any missing items in the validation will have been marked as lost. * The bundle item will be marked as checked in. Signed-off-by: Katrin Fischer Bug 28854: Highlight bundle rows to clarify UI Signed-off-by: Katrin Fischer Bug 28854: Drop unique index on issue_id in return claims With the introduction of circulating items within a bundle set, we can now loose multiple items from the bundle from the same issue. Signed-off-by: Katrin Fischer Bug 28854: DBIC Update ReturnClaim Schema Signed-off-by: Katrin Fischer Bug 28854: Record and display who lost the item This patch records the bundle issue from which an item is marked as lost so that we may use that to infer who lost the item (for later charges and display). Test plan 0) Apply all patches up to this point 1) Checkout a bundle to a user 2) Checkin the bundle and do not scan one of the barcodes at confirmation * Note that the item not scanned is marked as lost 3) Navigate to the biblio for the lost item and note that it is marked as lost. 4) Navigate to the biblio for the collection and expand the collection item that contains the lost item. Note the item is marked as lost and checkout details are listed. 5) Checkin the lost item * The item should be marked as found and the return_claims line should be marked as resolved. Signed-off-by: Katrin Fischer Bug 28854: Simplified status handling for bundle inventory check Signed-off-by: Katrin Fischer Bug 28854: Add option to print content list after verification We already allowed the user to view and print an updated content list after a varification showed that items were missing from the bundle. This patch adds the option to view and print the list even if the content has been varified to have not changed. Signed-off-
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What|Removed |Added Summary|Add ability to create |Add ability to create |bundles of items|bundles of items for ||circulation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
