[Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Caroline Cyr La Rose changed: What|Removed |Added Documentation||Caroline Cyr La Rose contact|| Documentation||https://gitlab.com/koha-com submission||munity/koha-manual/-/merge_ ||requests/973 CC||caroline.cyr-la-rose@inlibr ||o.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 David Nind changed: What|Removed |Added Status|Needs documenting |RESOLVED CC||da...@davidnind.com Resolution|--- |FIXED --- Comment #46 from David Nind --- Database change - no update required to the manual. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Status|Pushed to main |Needs documenting --- Comment #45 from Fridolin Somers --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@gmail.com --- Comment #44 from Jonathan Druart --- A "datatype" column would have been more flexible here IMO. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #43 from Katrin Fischer --- (In reply to Martin Renvoize from comment #42) > Follow-up pushed. Thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Martin Renvoize changed: What|Removed |Added Keywords|additional_work_needed | --- Comment #42 from Martin Renvoize --- Follow-up pushed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #41 from Martin Renvoize --- Created attachment 166906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166906&action=edit Bug 28869: (RM follow-up) Add missing field in api definition We missed adding the new field to the api definition for authorised_value_category. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Katrin Fischer changed: What|Removed |Added Keywords||additional_work_needed --- Comment #40 from Katrin Fischer --- Something appears missing here, tests are exploding. Can you please double check my pushed DBIC change and anything missing for REST API maybe? > Error: Properties not allowed: is_integer_only. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #39 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to main Version(s)||24.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #38 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #37) > * Would it not have been enough to name it: is_integer? :) Good question. No strong opinion. Since we normally allow string values, the only comes from that perspective. > * The database update is missing the AFTER/BEFORE. I've added it. Thanks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #37 from Katrin Fischer --- Some notes: * Would it not have been enough to name it: is_integer? :) * The database update is missing the AFTER/BEFORE. I've added it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #36 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #35) > Can someone quickly check on these QA script failures for me please? > > FAIL Koha/AuthorisedValue.pm >FAIL valid > Constant subroutine Koha::AuthorisedValue::NUM_PATTERN redefined > Constant subroutine Koha::AuthorisedValue::NUM_PATTERN_JS > redefined Comment14 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #35 from Katrin Fischer --- Can someone quickly check on these QA script failures for me please? FAIL Koha/AuthorisedValue.pm FAIL valid Constant subroutine Koha::AuthorisedValue::NUM_PATTERN redefined Constant subroutine Koha::AuthorisedValue::NUM_PATTERN_JS redefined -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Martin Renvoize changed: What|Removed |Added Attachment #164001|0 |1 is obsolete|| --- Comment #34 from Martin Renvoize --- Created attachment 166702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166702&action=edit Bug 28869: (follow-up) Switch to cud-edit_category for CSRF No test plan. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Martin Renvoize changed: What|Removed |Added Attachment #164000|0 |1 is obsolete|| --- Comment #33 from Martin Renvoize --- Created attachment 166701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166701&action=edit Bug 28869: Unit tests Test plan: Run t/db_dependent/AuthorisedValues.t Signed-off-by: Marcel de Rooy Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Martin Renvoize changed: What|Removed |Added Attachment #163999|0 |1 is obsolete|| --- Comment #32 from Martin Renvoize --- Created attachment 166700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166700&action=edit Bug 28869: (follow-up) Add html restriction for tinyint Several item fields are signed tinyints, connected to authorised value categories like NOT_LOAN etc. They only accept -128 up to 127. Signed-off-by: Marcel de Rooy Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Martin Renvoize changed: What|Removed |Added Attachment #163998|0 |1 is obsolete|| --- Comment #31 from Martin Renvoize --- Created attachment 166699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166699&action=edit Bug 28869: Implement authorised_value_categories.is_integer_only Test plan: Add category with/without integer restriction. Test adding/editing values. Signed-off-by: Marcel de Rooy Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Martin Renvoize changed: What|Removed |Added Attachment #163997|0 |1 is obsolete|| --- Comment #30 from Martin Renvoize --- Created attachment 166698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166698&action=edit Bug 28869: DBIx schema changes for AuthorisedValueCategory Note: Also adds boolean flag in the custom part! Signed-off-by: Marcel de Rooy Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Martin Renvoize changed: What|Removed |Added Attachment #163996|0 |1 is obsolete|| --- Comment #29 from Martin Renvoize --- Created attachment 166697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166697&action=edit Bug 28869: Database revision Test plan: Run updatedatabase.pl Signed-off-by: Marcel de Rooy Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com, ||pedro.amo...@ptfs-europe.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #28 from Marcel de Rooy --- Rebased and added CSRF follow-up -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #27 from Marcel de Rooy --- Created attachment 164001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164001&action=edit Bug 28869: (follow-up) Switch to cud-edit_category for CSRF No test plan. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Marcel de Rooy changed: What|Removed |Added Attachment #162416|0 |1 is obsolete|| --- Comment #26 from Marcel de Rooy --- Created attachment 164000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164000&action=edit Bug 28869: Unit tests Test plan: Run t/db_dependent/AuthorisedValues.t Signed-off-by: Marcel de Rooy Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Marcel de Rooy changed: What|Removed |Added Attachment #162415|0 |1 is obsolete|| --- Comment #25 from Marcel de Rooy --- Created attachment 163999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163999&action=edit Bug 28869: (follow-up) Add html restriction for tinyint Several item fields are signed tinyints, connected to authorised value categories like NOT_LOAN etc. They only accept -128 up to 127. Signed-off-by: Marcel de Rooy Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Marcel de Rooy changed: What|Removed |Added Attachment #162414|0 |1 is obsolete|| --- Comment #24 from Marcel de Rooy --- Created attachment 163998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163998&action=edit Bug 28869: Implement authorised_value_categories.is_integer_only Test plan: Add category with/without integer restriction. Test adding/editing values. Signed-off-by: Marcel de Rooy Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Marcel de Rooy changed: What|Removed |Added Attachment #162413|0 |1 is obsolete|| --- Comment #23 from Marcel de Rooy --- Created attachment 163997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163997&action=edit Bug 28869: DBIx schema changes for AuthorisedValueCategory Note: Also adds boolean flag in the custom part! Signed-off-by: Marcel de Rooy Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Marcel de Rooy changed: What|Removed |Added Attachment #162412|0 |1 is obsolete|| --- Comment #22 from Marcel de Rooy --- Created attachment 163996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163996&action=edit Bug 28869: Database revision Test plan: Run updatedatabase.pl Signed-off-by: Marcel de Rooy Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Marcel de Rooy changed: What|Removed |Added Depends on|35959 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35959 [Bug 35959] Inconsistent hierarchy during C3 merge of class 'Koha::AuthorisedValue' (and a few other modules) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Bug 28869 depends on bug 35959, which changed state. Bug 35959 Summary: Inconsistent hierarchy during C3 merge of class 'Koha::AuthorisedValue' (and a few other modules) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35959 What|Removed |Added Status|Signed Off |RESOLVED Resolution|--- |MOVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Status|Needs Signoff |Signed Off --- Comment #21 from Victor Grousset/tuxayo --- It works :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #161749|0 |1 is obsolete|| --- Comment #20 from Victor Grousset/tuxayo --- Created attachment 162416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162416&action=edit Bug 28869: Unit tests Test plan: Run t/db_dependent/AuthorisedValues.t Signed-off-by: Marcel de Rooy Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #161748|0 |1 is obsolete|| --- Comment #19 from Victor Grousset/tuxayo --- Created attachment 162415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162415&action=edit Bug 28869: (follow-up) Add html restriction for tinyint Several item fields are signed tinyints, connected to authorised value categories like NOT_LOAN etc. They only accept -128 up to 127. Signed-off-by: Marcel de Rooy Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #161747|0 |1 is obsolete|| --- Comment #18 from Victor Grousset/tuxayo --- Created attachment 162414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162414&action=edit Bug 28869: Implement authorised_value_categories.is_integer_only Test plan: Add category with/without integer restriction. Test adding/editing values. Signed-off-by: Marcel de Rooy Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #161746|0 |1 is obsolete|| --- Comment #17 from Victor Grousset/tuxayo --- Created attachment 162413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162413&action=edit Bug 28869: DBIx schema changes for AuthorisedValueCategory Note: Also adds boolean flag in the custom part! Signed-off-by: Marcel de Rooy Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #161745|0 |1 is obsolete|| --- Comment #16 from Victor Grousset/tuxayo --- Created attachment 162412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162412&action=edit Bug 28869: Database revision Test plan: Run updatedatabase.pl Signed-off-by: Marcel de Rooy Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #15 from Marcel de Rooy --- For suggesting further improvements and extending this development, please go to the omnibus on bug 35990. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #14 from Marcel de Rooy --- === Note for QA WARN Koha/Schema/Result/AuthorisedValueCategory.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 16, now: 18) => PLEASE IGNORE (from automated build) FAIL Koha/AuthorisedValue.pm FAIL valid Constant subroutine Koha::AuthorisedValue::NUM_PATTERN redefined Constant subroutine Koha::AuthorisedValue::NUM_PATTERN_JS redefined => PLEASE IGNORE (false failures for constants, related to module dependencies outside report scope). Note too that qa tools should say WARN here and not FAIL. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #13 from Marcel de Rooy --- Created attachment 161749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161749&action=edit Bug 28869: Unit tests Test plan: Run t/db_dependent/AuthorisedValues.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #12 from Marcel de Rooy --- Created attachment 161748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161748&action=edit Bug 28869: (follow-up) Add html restriction for tinyint Several item fields are signed tinyints, connected to authorised value categories like NOT_LOAN etc. They only accept -128 up to 127. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #11 from Marcel de Rooy --- Created attachment 161747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161747&action=edit Bug 28869: Implement authorised_value_categories.is_integer_only Test plan: Add category with/without integer restriction. Test adding/editing values. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #10 from Marcel de Rooy --- Created attachment 161746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161746&action=edit Bug 28869: DBIx schema changes for AuthorisedValueCategory Note: Also adds boolean flag in the custom part! Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #9 from Marcel de Rooy --- Created attachment 161745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161745&action=edit Bug 28869: Database revision Test plan: Run updatedatabase.pl Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Marcel de Rooy changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28869] Optionally restrict authorised values to tinyint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Marcel de Rooy changed: What|Removed |Added Summary|If authorized values for|Optionally restrict |STACK (shelving control |authorised values to |number) are > 127 things|tinyint |explode | --- Comment #8 from Marcel de Rooy --- Renaming title from If authorized values for STACK (shelving control number) are > 127 things explode to Optionally restrict authorised values to tinyint -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
