[Koha-bugs] [Bug 28934] Correct markup of GDPR consent in OPAC patron entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28934] Correct markup of GDPR consent in OPAC patron entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934 --- Comment #1 from Owen Leonard --- Created attachment 124322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124322&action=edit Bug 28934: Correct markup of GDPR consent in OPAC patron entry This patch makes changes to the markup around the GDPR consent checkbox in the OPAC self-registration / update page to make it more consistent with other form fields on the page. The patch also adds some missing attributes which are required to enable JavaScript validation of the checkbox. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Administration -> System preferences and Enable the system preference PatronSelfRegistration. - Set the system preference GDPR_Policy to "Enforce". - Go to the OPAC and click the "Register here" link. - Under the "GDPR consent" heading near the bottom of the page, confirm that the "I agree" checkbox lines up with other form fields on the page, and that the "Required" label lines up below it. - Submit the form without checking the GDPR consent checkbox. - The form should not be submitted, and a "This field is required" message should appear next to the checkbox label. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28934] Correct markup of GDPR consent in OPAC patron entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934 Hayley Pelham changed: What|Removed |Added CC||hayleypel...@catalyst.net.n ||z --- Comment #2 from Hayley Pelham --- Created attachment 124441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124441&action=edit Issue with GDPR checkbox at smaller widths and with Required field text -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28934] Correct markup of GDPR consent in OPAC patron entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934 Hayley Pelham changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #3 from Hayley Pelham --- Hi Owen, This looks good at larger browser widths and the checkbox and Required text lines up with the rest of the form, but at smaller browser widths the checkbox becomes misaligned, and when the form is submitted without checking the checkbox and the This field is required text appears, some weird interaction happens. I have attached a screenshot illustrating this issue. Cheers, Hayley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28934] Correct markup of GDPR consent in OPAC patron entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28934] Correct markup of GDPR consent in OPAC patron entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934 Owen Leonard changed: What|Removed |Added Attachment #124322|0 |1 is obsolete|| --- Comment #4 from Owen Leonard --- Created attachment 124830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124830&action=edit Bug 28934: Correct markup of GDPR consent in OPAC patron entry This patch makes changes to the markup around the GDPR consent checkbox in the OPAC self-registration / update page to make it more consistent with other form fields on the page. The patch also adds some missing attributes which are required to enable JavaScript validation of the checkbox. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Administration -> System preferences and Enable the system preference PatronSelfRegistration. - Set the system preference GDPR_Policy to "Enforce". - Go to the OPAC and click the "Register here" link. - Under the "GDPR consent" heading near the bottom of the page, confirm that the "I agree" checkbox lines up with other form fields on the page, and that the "Required" label lines up below it. - Submit the form without checking the GDPR consent checkbox. - The form should not be submitted, and a "This field is required" message should appear next to the checkbox label. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28934] Correct markup of GDPR consent in OPAC patron entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934 Hayley Pelham changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28934] Correct markup of GDPR consent in OPAC patron entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934 Hayley Pelham changed: What|Removed |Added Attachment #124830|0 |1 is obsolete|| --- Comment #5 from Hayley Pelham --- Created attachment 124852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124852&action=edit Bug 28934: Correct markup of GDPR consent in OPAC patron entry This patch makes changes to the markup around the GDPR consent checkbox in the OPAC self-registration / update page to make it more consistent with other form fields on the page. The patch also adds some missing attributes which are required to enable JavaScript validation of the checkbox. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Administration -> System preferences and Enable the system preference PatronSelfRegistration. - Set the system preference GDPR_Policy to "Enforce". - Go to the OPAC and click the "Register here" link. - Under the "GDPR consent" heading near the bottom of the page, confirm that the "I agree" checkbox lines up with other form fields on the page, and that the "Required" label lines up below it. - Submit the form without checking the GDPR consent checkbox. - The form should not be submitted, and a "This field is required" message should appear next to the checkbox label. Signed-off-by: Hayley Pelham -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28934] Correct markup of GDPR consent in OPAC patron entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@iki.fi Status|Signed Off |Failed QA --- Comment #6 from Joonas Kylmälä --- (In reply to Hayley Pelham from comment #5) > Created attachment 124852 [details] [review] > Bug 28934: Correct markup of GDPR consent in OPAC patron entry > > This patch makes changes to the markup around the GDPR consent checkbox > in the OPAC self-registration / update page to make it more consistent > with other form fields on the page. > > The patch also adds some missing attributes which are required to enable > JavaScript validation of the checkbox. > > To test, apply the patch and rebuild the OPAC CSS > (https://wiki.koha-community.org/wiki/ > Working_with_SCSS_in_the_OPAC_and_staff_client). > > - Go to Administration -> System preferences and Enable the system > preference PatronSelfRegistration. > - Set the system preference GDPR_Policy to "Enforce". > - Go to the OPAC and click the "Register here" link. > - Under the "GDPR consent" heading near the bottom of the page, > confirm that the "I agree" checkbox lines up with other form fields on > the page, and that the "Required" label lines up below it. > - Submit the form without checking the GDPR consent checkbox. > - The form should not be submitted, and a "This field is > required" message should appear next to the checkbox label. > > Signed-off-by: Hayley Pelham The alignment is still slightly off with this patch, noticable if you put the cursor to the input box above and then use down arrow to scroll to the checkbox. Also, I would prefer we would use consistent way to show the fields, i.e. always label and then the input form, this would make the alignment perfect as well. The gender field has also the same problem. I could send a patch to fix both of them. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28934] Correct markup of GDPR consent in OPAC patron entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934 Joonas Kylmälä changed: What|Removed |Added Assignee|oleon...@myacpl.org |joonas.kylm...@iki.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28934] Correct markup of GDPR consent in OPAC patron entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934 Joonas Kylmälä changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28934] Correct markup of GDPR consent in OPAC patron entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934 Joonas Kylmälä changed: What|Removed |Added Attachment #124852|0 |1 is obsolete|| --- Comment #7 from Joonas Kylmälä --- Created attachment 125032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125032&action=edit Bug 28934: Make the OPAC registration form design consistent The gender/sex and GDPR inputs were slightly misaligned (by 1.5em). Now they are aligned with the other inputs which have a width of 10em (9em width + margin 1em). The label assignments and required attributes for input elements are made also consistent. To test: 1) Enable GDPR_Policy syspref 2) Apply patch, run "yarn build --view opac", restart plack 3) Go to /cgi-bin/koha/opac-memberentry.pl 3) Check that the GDPR input box shows the required text now in red color 3) Check that the alignment of sex/gender and GDPR input matches with the other inputs perfectly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
