[Koha-bugs] [Bug 28960] EDI transfer_items uses a relationship where it's looking for a field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28960 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added CC||wainuiwitikapark@catalyst.n ||et.nz Version(s)|21.11.00,21.05.05,20.11.11, |21.11.00,21.05.05,20.11.11, released in|20.05.17|20.05.17,19.11.23 Status|Pushed to oldoldstable |Pushed to oldoldoldstable --- Comment #11 from wainuiwitikap...@catalyst.net.nz --- Backported to 19.11.x for 19.11.23 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28960] EDI transfer_items uses a relationship where it's looking for a field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28960 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Version(s)|21.11.00,21.05.05,20.11.11 |21.11.00,21.05.05,20.11.11, released in||20.05.17 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #10 from Victor Grousset/tuxayo --- Backported: Pushed to 20.05.x branch for 20.05.17 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28960] EDI transfer_items uses a relationship where it's looking for a field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28960 Fridolin Somers changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.11 released in|| CC||fridolin.som...@biblibre.co ||m --- Comment #9 from Fridolin Somers --- Pushed to 20.11.x for 20.11.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28960] EDI transfer_items uses a relationship where it's looking for a field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28960 Kyle M Hall changed: What|Removed |Added Version(s)|21.11.00|21.11.00,21.05.05 released in|| Status|Pushed to master|Pushed to stable --- Comment #8 from Kyle M Hall --- Pushed to 21.05.x for 21.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28960] EDI transfer_items uses a relationship where it's looking for a field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28960 --- Comment #7 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28960] EDI transfer_items uses a relationship where it's looking for a field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28960 Jonathan Druart changed: What|Removed |Added Version(s)||21.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28960] EDI transfer_items uses a relationship where it's looking for a field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28960 --- Comment #6 from Martin Renvoize --- :).. it's certainly on my list to switch over to objects.. but before that I need to blitz some tests.. why is EDI so darn hard! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28960] EDI transfer_items uses a relationship where it's looking for a field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28960 --- Comment #5 from Jonathan Druart --- I hadn't realized we weren't manipulating a Koha::Object. And my remark was silly anyway as $item->branchcode is working if $item is a Koha::Item. Sorry for the noise. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28960] EDI transfer_items uses a relationship where it's looking for a field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28960
--- Comment #4 from Martin Renvoize ---
(In reply to Jonathan Druart from comment #3)
> Isn't the correct fix to call $item->home_branch->branchcode?
>
> From Koha::Item
>
> sub home_branch {
> my ($self) = @_;
>
> $self->{_home_branch} ||= Koha::Libraries->find( $self->homebranch() );
>
> return $self->{_home_branch};
> }
There are two things with that.
1) $item is a DBIx::Class::Result and not a Koha::Item in EDI (Yes, we should
certainly convert to Koha Objects here at some point)
2) if all we need is the code, why call through another DB hitting accessor
rather than use the field in the first set directly?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28960] EDI transfer_items uses a relationship where it's looking for a field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28960
--- Comment #3 from Jonathan Druart ---
Isn't the correct fix to call $item->home_branch->branchcode?
From Koha::Item
sub home_branch {
my ($self) = @_;
$self->{_home_branch} ||= Koha::Libraries->find( $self->homebranch() );
return $self->{_home_branch};
}
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28960] EDI transfer_items uses a relationship where it's looking for a field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28960 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28960] EDI transfer_items uses a relationship where it's looking for a field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28960 Martin Renvoize changed: What|Removed |Added CC||jon.tur...@ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28960] EDI transfer_items uses a relationship where it's looking for a field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28960 Kyle M Hall changed: What|Removed |Added Attachment #124572|0 |1 is obsolete|| --- Comment #2 from Kyle M Hall --- Created attachment 124578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124578&action=edit Bug 28960: Explicitly call get_column This patch adds get_column to ensure we are returning a string value of a field rather than accidentally triggering a relationship accessor. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28960] EDI transfer_items uses a relationship where it's looking for a field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28960 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28960] EDI transfer_items uses a relationship where it's looking for a field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28960 Martin Renvoize changed: What|Removed |Added Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28960] EDI transfer_items uses a relationship where it's looking for a field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28960 Martin Renvoize changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28960] EDI transfer_items uses a relationship where it's looking for a field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28960 Martin Renvoize changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28960] EDI transfer_items uses a relationship where it's looking for a field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28960 Martin Renvoize changed: What|Removed |Added CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28960] EDI transfer_items uses a relationship where it's looking for a field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28960 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28960] EDI transfer_items uses a relationship where it's looking for a field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28960 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28960] EDI transfer_items uses a relationship where it's looking for a field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28960 --- Comment #1 from Martin Renvoize --- Created attachment 124572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124572&action=edit Bug 28960: Explicitly call get_column This patch adds get_column to ensure we are returning a string value of a field rather than accidentally triggering a relationship accessor. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
