[Koha-bugs] [Bug 28982] Use Flatpickr on onboarding pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982 Jonathan Druart changed: What|Removed |Added Blocks||29837 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29837 [Bug 29837] JS error during installer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28982] Use Flatpickr on onboarding pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982 Kyle M Hall changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to master|RESOLVED CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28982] Use Flatpickr on onboarding pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982 --- Comment #11 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28982] Use Flatpickr on onboarding pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||21.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28982] Use Flatpickr on onboarding pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982 Katrin Fischer changed: What|Removed |Added Attachment #125710|0 |1 is obsolete|| --- Comment #10 from Katrin Fischer --- Created attachment 127139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127139&action=edit Bug 28982: (follow-up) Ensure that date format is correctly checked This patch modifies the global calendar include so that it doesn't use the potentially-undefined template variable "dateformat." Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28982] Use Flatpickr on onboarding pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982 Katrin Fischer changed: What|Removed |Added Attachment #125503|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 127138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127138&action=edit Bug 28982: Use Flatpickr on onboarding pages This patch replaces the use of jQueryUI's datepicker in the onboarding templates. The addition of calendar.inc to the template requires that some additions be made to the installer's header files, adding the i18n JavaScript assets. jQueryUI-specific CSS is removed from installer.scss, and inclusion of Flatpickr's SCSS is added. To test, apply the patch and rebuild the staff client SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Start the installation process. - Continue through the installation process until you reach the stage in onboarding where you are creating a patron category. - The "Enrollment period -> Until" field should be a Flatpickr calendar widget. The widget should look and work correctly. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28982] Use Flatpickr on onboarding pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28982] Use Flatpickr on onboarding pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982 Bug 28982 depends on bug 28978, which changed state. Bug 28978 Summary: Convert installer CSS to SCSS https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28978 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28982] Use Flatpickr on onboarding pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982 Jonathan Druart changed: What|Removed |Added Blocks||29239 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 [Bug 29239] [OMNIBUS] Replace jQueryUI's timepicker with flatpickr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28982] Use Flatpickr on onboarding pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982 Owen Leonard changed: What|Removed |Added Blocks||29212 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 [Bug 29212] Use Flatpickr on OPAC pages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28982] Use Flatpickr on onboarding pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982 --- Comment #8 from Owen Leonard --- It wasn't that the dateformat preference wasn't available to the template before my follow-up, it was that the include file tried to reference a global JavaScript variable, "dateformat" which wasn't available. The revision makes it so that the system preference is correctly defined in JavaScript. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28982] Use Flatpickr on onboarding pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982 --- Comment #7 from Katrin Fischer --- Hi Owen, a little confused about the fix: When we are at the stage of "onboarding" the system preferences and possible also custom.sql changes for changing it (de-DE does) have already been run. So I think it should not be undefined at this point. Also, I believe it's not the hint that is off, but the input is displaying the database format, that is not our default ... so maybe a problem for a different bug actually? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28982] Use Flatpickr on onboarding pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982 Bug 28982 depends on bug 28937, which changed state. Bug 28937 Summary: Use Flatpickr on circulation and patron pages https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28982] Use Flatpickr on onboarding pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982 --- Comment #6 from Owen Leonard --- Created attachment 125710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125710&action=edit Bug 28982: (follow-up) Ensure that date format is correctly checked This patch modifies the global calendar include so that it doesn't use the potentially-undefined template variable "dateformat." -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28982] Use Flatpickr on onboarding pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982 Owen Leonard changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28982] Use Flatpickr on onboarding pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #5 from Katrin Fischer --- This appears to work quite well, but there is a small glitch I am wondering about: * Onboarding, where you set up a patron category * Set an until date for the expiration date * The date in the input field shows in the database format (2021-10-19) * Below is a format with: (MM/DD/) Could you please check? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28982] Use Flatpickr on onboarding pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982 Katrin Fischer changed: What|Removed |Added Attachment #125656|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28982] Use Flatpickr on onboarding pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982 --- Comment #4 from Katrin Fischer --- Created attachment 125656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125656&action=edit Bug 28978: Convert installer CSS to SCSS This patch creates a new SCSS file, installer.scss, from which installer.css will be compiled. Most of the resulting CSS is unchanged, but some minor sections were removed because they were obsolete. The jQueryUI-specific section isn't fully converted to SCSS because it's going to go away with the addition of Flatpickr. To test, apply the patch and rebuild the staff client SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Confirm that koha-tmpl/intranet-tmpl/prog/css/installer.css is updated. - Go through the complete web installation process, including onboarding, to confirm that everything is styled as before. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28982] Use Flatpickr on onboarding pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28982] Use Flatpickr on onboarding pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize --- All works for me.. Signing off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28982] Use Flatpickr on onboarding pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982 Martin Renvoize changed: What|Removed |Added Attachment #124716|0 |1 is obsolete|| --- Comment #2 from Martin Renvoize --- Created attachment 125503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125503&action=edit Bug 28982: Use Flatpickr on onboarding pages This patch replaces the use of jQueryUI's datepicker in the onboarding templates. The addition of calendar.inc to the template requires that some additions be made to the installer's header files, adding the i18n JavaScript assets. jQueryUI-specific CSS is removed from installer.scss, and inclusion of Flatpickr's SCSS is added. To test, apply the patch and rebuild the staff client SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Start the installation process. - Continue through the installation process until you reach the stage in onboarding where you are creating a patron category. - The "Enrollment period -> Until" field should be a Flatpickr calendar widget. The widget should look and work correctly. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28982] Use Flatpickr on onboarding pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982 Martin Renvoize changed: What|Removed |Added Depends on|28376 | CC||martin.renvoize@ptfs-europe ||.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 [Bug 28376] Replace obsolete jquery-ui-timepicker-addon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28982] Use Flatpickr on onboarding pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982 --- Comment #1 from Owen Leonard --- Created attachment 124716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124716&action=edit Bug 28982: Use Flatpickr on onboarding pages This patch replaces the use of jQueryUI's datepicker in the onboarding templates. The addition of calendar.inc to the template requires that some additions be made to the installer's header files, adding the i18n JavaScript assets. jQueryUI-specific CSS is removed from installer.scss, and inclusion of Flatpickr's SCSS is added. To test, apply the patch and rebuild the staff client SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Start the installation process. - Continue through the installation process until you reach the stage in onboarding where you are creating a patron category. - The "Enrollment period -> Until" field should be a Flatpickr calendar widget. The widget should look and work correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28982] Use Flatpickr on onboarding pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28982] Use Flatpickr on onboarding pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982 Owen Leonard changed: What|Removed |Added Depends on||28978 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28978 [Bug 28978] Convert installer CSS to SCSS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
