[Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #27 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 Andrew Fuerste-Henry changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable CC||and...@bywatersolutions.com Version(s)|22.05.00,21.11.01 |22.05.00,21.11.01,21.05.08 released in|| --- Comment #26 from Andrew Fuerste-Henry --- Pushed to 21.05.x for 21.05.08 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 David Nind changed: What|Removed |Added Keywords||Manual --- Comment #25 from David Nind --- Added Manual keyword for 22.05 bugs that I consider require documentation changes. See bug 29640 and the linked spreadsheet for additional details. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 David Nind changed: What|Removed |Added Text to go in the||This improves the release notes||accessibility of the OPAC ||by increasing the contrast ||ratio for buttons, making ||the button text easier to ||read. || ||As part of this ||change the OPAC SCSS was ||modified so that a "base ||theme color" variable is ||defined which can be used ||to color button backgrounds ||and similar elements. It ||also moves some other ||colors into variables and ||removes some unused CSS. CC||da...@davidnind.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Version(s)|22.05.00|22.05.00,21.11.01 released in|| Status|Pushed to master|Pushed to stable --- Comment #24 from Kyle M Hall --- Pushed to 21.11.x for 21.11.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 Fridolin Somers changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.05.00 released in|| CC||fridolin.som...@biblibre.co ||m --- Comment #23 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 Katrin Fischer changed: What|Removed |Added Attachment #126807|0 |1 is obsolete|| --- Comment #22 from Katrin Fischer --- Created attachment 127874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127874&action=edit Bug 29036: (follow-up) Improve the use of variables to keep colors consistent This patch modifies the OPAC SCSS so that a "base theme color" variable is defined which can be used to color button backgrounds and similar elements. The patch also moves some other colors into variables and removes some unused CSS. The Koha logo which is displayed in the upper left corner of the OPAC has been modified to use the same color. To test, apply the patch and repeat the previous test plan. Signed-off-by: jeremy breuillard Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 Katrin Fischer changed: What|Removed |Added Attachment #126806|0 |1 is obsolete|| --- Comment #21 from Katrin Fischer --- Created attachment 127873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127873&action=edit Bug 29036: Accessibility OPAC buttons don't have sufficient contrast This patch changed the base colour of OPAC buttons to increase the contrast ratio, improving accessibility and making the button text easier to read. To test: 1. Use an accessibility tool (e.g. Chrome's Lighthouse tool) to check the contrast ratio on the OPAC 2. Confirm that the OPAC buttons don't have sufficient colour contrast 3. Apply the patch and rebuild css: yarn build --view opac 4. Use the accessibility tool to confirm the button contrast ratio now meets minimum accessibility requirements 5. Check that the OPAC still looks ok after the changes Signed-off-by: Owen Leonard Signed-off-by: jeremy breuillard Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 --- Comment #20 from Katrin Fischer --- (In reply to Owen Leonard from comment #19) > The breadcrumbs problem turned out to be a local dependency issue, so I'm > moving this back to "Signed off." Oh, sorry for causing the hold up! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 Owen Leonard changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #19 from Owen Leonard --- The breadcrumbs problem turned out to be a local dependency issue, so I'm moving this back to "Signed off." -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 --- Comment #18 from Katrin Fischer --- Created attachment 127177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127177&action=edit Moved up dividers in breadcrumbs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 --- Comment #17 from Katrin Fischer --- (In reply to Owen Leonard from comment #15) > (In reply to Katrin Fischer from comment #14) > > > The first is much paler than the second. > > I think you're seeing the disabled state. Are any checkboxes checked? That was it, thx! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #16 from Katrin Fischer --- I am sorry, but there is a strange side effect on the newly changed breadcrumbs. the > is moved upwards and sits above the text with this patch set applied. I did: - Apply patch set - yarn build --view opac - restart_all -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 Owen Leonard changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 --- Comment #15 from Owen Leonard --- (In reply to Katrin Fischer from comment #14) > The first is much paler than the second. I think you're seeing the disabled state. Are any checkboxes checked? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 --- Comment #14 from Katrin Fischer --- I noticed a small inconsistency with the red buttons. Compare: * Patron account > Search history > Remove selected searches * Patron account > Your summary > Holds > Cancel The first is much paler than the second. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 Katrin Fischer changed: What|Removed |Added Attachment #126660|0 |1 is obsolete|| --- Comment #13 from Katrin Fischer --- Created attachment 126807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126807&action=edit Bug 29036: (follow-up) Improve the use of variables to keep colors consistent This patch modifies the OPAC SCSS so that a "base theme color" variable is defined which can be used to color button backgrounds and similar elements. The patch also moves some other colors into variables and removes some unused CSS. The Koha logo which is displayed in the upper left corner of the OPAC has been modified to use the same color. To test, apply the patch and repeat the previous test plan. Signed-off-by: jeremy breuillard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 Katrin Fischer changed: What|Removed |Added Attachment #126659|0 |1 is obsolete|| --- Comment #12 from Katrin Fischer --- Created attachment 126806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126806&action=edit Bug 29036: Accessibility OPAC buttons don't have sufficient contrast This patch changed the base colour of OPAC buttons to increase the contrast ratio, improving accessibility and making the button text easier to read. To test: 1. Use an accessibility tool (e.g. Chrome's Lighthouse tool) to check the contrast ratio on the OPAC 2. Confirm that the OPAC buttons don't have sufficient colour contrast 3. Apply the patch and rebuild css: yarn build --view opac 4. Use the accessibility tool to confirm the button contrast ratio now meets minimum accessibility requirements 5. Check that the OPAC still looks ok after the changes Signed-off-by: Owen Leonard Signed-off-by: jeremy breuillard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 --- Comment #11 from Owen Leonard --- Created attachment 126660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126660&action=edit Bug 29036: (follow-up) Improve the use of variables to keep colors consistent This patch modifies the OPAC SCSS so that a "base theme color" variable is defined which can be used to color button backgrounds and similar elements. The patch also moves some other colors into variables and removes some unused CSS. The Koha logo which is displayed in the upper left corner of the OPAC has been modified to use the same color. To test, apply the patch and repeat the previous test plan. Signed-off-by: jeremy breuillard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 Owen Leonard changed: What|Removed |Added Attachment #126055|0 |1 is obsolete|| Attachment #126056|0 |1 is obsolete|| --- Comment #10 from Owen Leonard --- Created attachment 126659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126659&action=edit Bug 29036: Accessibility OPAC buttons don't have sufficient contrast This patch changed the base colour of OPAC buttons to increase the contrast ratio, improving accessibility and making the button text easier to read. To test: 1. Use an accessibility tool (e.g. Chrome's Lighthouse tool) to check the contrast ratio on the OPAC 2. Confirm that the OPAC buttons don't have sufficient colour contrast 3. Apply the patch and rebuild css: yarn build --view opac 4. Use the accessibility tool to confirm the button contrast ratio now meets minimum accessibility requirements 5. Check that the OPAC still looks ok after the changes Signed-off-by: Owen Leonard Signed-off-by: jeremy breuillard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 Owen Leonard changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #9 from Katrin Fischer --- I am sorry, but can you please rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 29036: Accessibility OPAC buttons don't have sufficient contrast Applying: Bug 29036: (follow-up) Improve the use of variables to keep colors consistent error: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss). error: could not build fake ancestor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 Jérémy Breuillard changed: What|Removed |Added Attachment #126036|0 |1 is patch|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 Jérémy Breuillard changed: What|Removed |Added Attachment #126036|1 |0 is patch|| Attachment #126036|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 --- Comment #8 from Jérémy Breuillard --- Created attachment 126056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126056&action=edit Bug 29036: (follow-up) Improve the use of variables to keep colors consistent This patch modifies the OPAC SCSS so that a "base theme color" variable is defined which can be used to color button backgrounds and similar elements. The patch also moves some other colors into variables and removes some unused CSS. The Koha logo which is displayed in the upper left corner of the OPAC has been modified to use the same color. To test, apply the patch and repeat the previous test plan. Signed-off-by: jeremy breuillard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 Jérémy Breuillard changed: What|Removed |Added Attachment #125293|0 |1 is obsolete|| --- Comment #7 from Jérémy Breuillard --- Created attachment 126055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126055&action=edit Bug 29036: Accessibility OPAC buttons don't have sufficient contrast This patch changed the base colour of OPAC buttons to increase the contrast ratio, improving accessibility and making the button text easier to read. To test: 1. Use an accessibility tool (e.g. Chrome's Lighthouse tool) to check the contrast ratio on the OPAC 2. Confirm that the OPAC buttons don't have sufficient colour contrast 3. Apply the patch and rebuild css: yarn build --view opac 4. Use the accessibility tool to confirm the button contrast ratio now meets minimum accessibility requirements 5. Check that the OPAC still looks ok after the changes Signed-off-by: Owen Leonard Signed-off-by: jeremy breuillard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 Jérémy Breuillard changed: What|Removed |Added Attachment #125294|0 |1 is obsolete|| --- Comment #6 from Jérémy Breuillard --- Created attachment 126036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126036&action=edit Attachment to Bug 29036 - Accessibility: OPAC buttons don't have sufficient contrast Bug 29036: (follow-up) Improve the use of variables to keep colors consistent This patch modifies the OPAC SCSS so that a "base theme color" variable is defined which can be used to color button backgrounds and similar elements. The patch also moves some other colors into variables and removes some unused CSS. The Koha logo which is displayed in the upper left corner of the OPAC has been modified to use the same color. To test, apply the patch and repeat the previous test plan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 Jérémy Breuillard changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||jeremy.breuillard@biblibre. ||com --- Comment #5 from Jérémy Breuillard --- Changes done and patch applied, the difference is noticeable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 --- Comment #4 from Owen Leonard --- Created attachment 125294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125294&action=edit Bug 29036: (follow-up) Improve the use of variables to keep colors consistent This patch modifies the OPAC SCSS so that a "base theme color" variable is defined which can be used to color button backgrounds and similar elements. The patch also moves some other colors into variables and removes some unused CSS. The Koha logo which is displayed in the upper left corner of the OPAC has been modified to use the same color. To test, apply the patch and repeat the previous test plan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 Owen Leonard changed: What|Removed |Added Attachment #125080|0 |1 is obsolete|| --- Comment #3 from Owen Leonard --- Created attachment 125293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125293&action=edit Bug 29036: Accessibility OPAC buttons don't have sufficient contrast This patch changed the base colour of OPAC buttons to increase the contrast ratio, improving accessibility and making the button text easier to read. To test: 1. Use an accessibility tool (e.g. Chrome's Lighthouse tool) to check the contrast ratio on the OPAC 2. Confirm that the OPAC buttons don't have sufficient colour contrast 3. Apply the patch and rebuild css: yarn build --view opac 4. Use the accessibility tool to confirm the button contrast ratio now meets minimum accessibility requirements 5. Check that the OPAC still looks ok after the changes Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 Owen Leonard changed: What|Removed |Added Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 --- Comment #2 from Henry Bolshaw --- Created attachment 125080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125080&action=edit Bug_29036: Accessibility OPAC buttons don't have sufficient contrast This patch changed the base colour of OPAC buttons to increase the contrast ratio, improving accessibility and making the button text easier to read. To test: 1. Use an accessibility tool (e.g. Chrome's Lighthouse tool) to check the contrast ratio on the OPAC 2. Confirm that the OPAC buttons don't have sufficient colour contrast 3. Apply the patch and rebuild css: yarn build --view opac 4. Use the accessibility tool to confirm the button contrast ratio now meets minimum accessibility requirements 5. Check that the OPAC still looks ok after the changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 Henry Bolshaw changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 Henry Bolshaw changed: What|Removed |Added Blocks||28188 Status|NEW |ASSIGNED Assignee|oleon...@myacpl.org |bolsh...@parliament.uk Keywords||accessibility --- Comment #1 from Henry Bolshaw --- The Koha green we are using for the buttons isn't accessible with white text so we could change it to a green that is. Alternatively we could change the text to black (which keeps the Koha green) or choose a completely different button colour. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188 [Bug 28188] Accessibility: OPAC - the contrast ratio for text is insufficient [OMNIBUS] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/