[Koha-bugs] [Bug 29105] items responses do not respect effective_itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 Martin Renvoize changed: What|Removed |Added Attachment #125252|0 |1 is obsolete|| --- Comment #12 from Martin Renvoize --- Created attachment 137505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137505=edit Bug 29105: Add effective_itemtype handling to items api This patch adds effective_item_type_id to the items api. We overload the to_api method to append the effective_item_type_id field with that of the effective itemtype code. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29105] items responses do not respect effective_itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 Martin Renvoize changed: What|Removed |Added Attachment #125251|0 |1 is obsolete|| --- Comment #11 from Martin Renvoize --- Created attachment 137504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137504=edit Bug 29105: Unit test This patch adds a unit test for the addition of effective_item_type_id to the items responses. Test plan 1) Run the unit test prior to applying the second patch and confirm it fails 2) Apply the second patch and confirm the unit test now passes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29105] items responses do not respect effective_itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29105] items responses do not respect effective_itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 David Nind changed: What|Removed |Added CC||da...@davidnind.com Status|Needs Signoff |In Discussion --- Comment #10 from David Nind --- Changed status to 'In discussion', feel free to change the status back to NSO when it is ready for testing (including a test plan). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29105] items responses do not respect effective_itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #9 from Fridolin Somers --- +$self->notforloan( $self->itemtype->notforloan ) unless $self->notforloan; $self->notforloan may be 0 so we should use defined no ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29105] items responses do not respect effective_itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 --- Comment #8 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #7) > Hmm.. difficult. I can see where you're coming from... but I'd be tempted to > not require an embed to enable it's return and rather return it as a > standard field.. so itype + effective_itype fields both always present in > the result? Yes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29105] items responses do not respect effective_itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 --- Comment #7 from Martin Renvoize --- Hmm.. difficult. I can see where you're coming from... but I'd be tempted to not require an embed to enable it's return and rather return it as a standard field.. so itype + effective_itype fields both always present in the result? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29105] items responses do not respect effective_itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 --- Comment #6 from Tomás Cohen Arazi --- When dealing with an 'item' object it is legit to set item_type to null. Returning the effective (calculated if absent on the item) item type might confuse the consumer to think it has an item_type set. I'd prefer we add the option to embed the effective item_type like in: x-koha-embed: effective_item_type -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29105] items responses do not respect effective_itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 Martin Renvoize changed: What|Removed |Added CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29105] items responses do not respect effective_itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 Martin Renvoize changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29105] items responses do not respect effective_itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 --- Comment #5 from Martin Renvoize --- So this patch does one direction (i.e. results), but doesn't cater for searches using q_param yet. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29105] items responses do not respect effective_itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=29108 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29105] items responses do not respect effective_itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 Martin Renvoize changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29105] items responses do not respect effective_itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29105] items responses do not respect effective_itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 Martin Renvoize changed: What|Removed |Added Attachment #125235|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29105] items responses do not respect effective_itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 --- Comment #4 from Martin Renvoize --- Created attachment 125252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125252=edit Bug 29105: Add effective_itemtype handling to items api This patch adds effective_itemtype handling to the items api. We overload the to_api method to replace the itype column value with that of the effective itemtype code. We also add in the notforloan fallback that is apparent in catalogue/details.tt status templates. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29105] items responses do not respect effective_itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 --- Comment #3 from Martin Renvoize --- Created attachment 125251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125251=edit Bug 29105: Unit test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29105] items responses do not respect effective_itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 Tomás Cohen Arazi changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=29107 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29105] items responses do not respect effective_itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 Martin Renvoize changed: What|Removed |Added Assignee|tomasco...@gmail.com|martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29105] items responses do not respect effective_itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 --- Comment #2 from Martin Renvoize --- Created attachment 125235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125235=edit Bug 29105: Add effective_itemtype handling for Item API -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29105] items responses do not respect effective_itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 --- Comment #1 from Martin Renvoize --- I'm not sure how to tackle this, I think it will need a to_api or TO_JSON overload or something.? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29105] items responses do not respect effective_itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
