[Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31509 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #36 from Marcel de Rooy --- > additional_contents.code is used to group DB rows together. Each row > represent one content in a given language, and the code is used to know > they are translation of the lang='default' one. > > It's not really useful for the end user and we could hide it and > generate it. Opening a new bug to allow configuring this code somehow. I need some more flexibility on e.g. bug 31503. It adds a location PatronConsent but I need codes like PatronConsent_[suffix] where suffix points to a specific patron consent type. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Lucas Gass changed: What|Removed |Added Blocks||29693 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29693 [Bug 29693] CodeMirror broken on additional_contents.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Jonathan Druart changed: What|Removed |Added Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #35 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||21.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Martin Renvoize changed: What|Removed |Added Attachment #127857|0 |1 is obsolete|| --- Comment #34 from Martin Renvoize --- Created attachment 127990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127990&action=edit Bug 29113: Fix random assignation Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Martin Renvoize changed: What|Removed |Added Attachment #127856|0 |1 is obsolete|| --- Comment #33 from Martin Renvoize --- Created attachment 127989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127989&action=edit Bug 29113: Hide code for additional contents and generate it additional_contents.code is used to group DB rows together. Each row represent one content in a given language, and the code is used to know they are translation of the lang='default' one. It's not really useful for the end user and we could hide it and generate it. Test plan: Create/Edit/Delete additional contents (news and HTML customizations) and confirm that they are correctly grouped together. You need several languages installed to test this patch correctly. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Andrew Nugged changed: What|Removed |Added CC||nug...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #32 from Marcel de Rooy --- Works, but the 'code' could be nicer. Still time for another QAer today? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Marcel de Rooy changed: What|Removed |Added Attachment #127365|0 |1 is obsolete|| --- Comment #31 from Marcel de Rooy --- Created attachment 127857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127857&action=edit Bug 29113: Fix random assignation Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Marcel de Rooy changed: What|Removed |Added Attachment #125696|0 |1 is obsolete|| --- Comment #30 from Marcel de Rooy --- Created attachment 127856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127856&action=edit Bug 29113: Hide code for additional contents and generate it additional_contents.code is used to group DB rows together. Each row represent one content in a given language, and the code is used to know they are translation of the lang='default' one. It's not really useful for the end user and we could hide it and generate it. Test plan: Create/Edit/Delete additional contents (news and HTML customizations) and confirm that they are correctly grouped together. You need several languages installed to test this patch correctly. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113
--- Comment #29 from Jonathan Druart ---
(In reply to Marcel de Rooy from comment #28)
> +code => $code || 'tmp_code',
>
> Please explain.
The code is mandatory at DB level so we must add a temporary code during the
insert, then update it after
I feel like it should actually be 'tmp_code' always, at this point we are
creating a new entry and $code should never be set.
We could add the following change
diff --git a/tools/additional-contents.pl b/tools/additional-contents.pl
index e63a44a809a..59721e24b2a 100755
--- a/tools/additional-contents.pl
+++ b/tools/additional-contents.pl
@@ -159,7 +159,7 @@ elsif ( $op eq 'add_validate' ) {
my $additional_content = Koha::AdditionalContent->new(
{
category => $category,
-code => $code || 'tmp_code',
+code => 'tmp_code',
location => $location,
branchcode => $branchcode,
title => $title,
@@ -173,13 +173,11 @@ elsif ( $op eq 'add_validate' ) {
)->store;
eval {
$additional_content->store;
-unless ($code) {
-$additional_content->discard_changes;
-$code = $category eq 'news'
- ? 'News_' . $additional_content->idnew
- : $location . '_' . $additional_content->idnew;
-$additional_content->code($code)->store;
-}
+$additional_content->discard_changes;
+$code = $category eq 'news'
+ ? 'News_' . $additional_content->idnew
+ : $location . '_' . $additional_content->idnew;
+$additional_content->code($code)->store;
};
if ($@) {
$success = 0;
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #28 from Marcel de Rooy --- +code => $code || 'tmp_code', Please explain. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=29515 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #27 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #26) > (In reply to Jonathan Druart from comment #24) > > > additional_contents > > - id > > - category > > - published_on > > - updated_on > > - expirationdate > > - number > > > > Another table for translations: > > - fk > > - lang (or eventually fk to a lang table) > > - title > > - content > > This looks better. But this is not for now :D However I still think we should hide the code for 21.11. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #26 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #24) > additional_contents > - id > - category > - published_on > - updated_on > - expirationdate > - number > > Another table for translations: > - fk > - lang (or eventually fk to a lang table) > - title > - content This looks better. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Jonathan Druart changed: What|Removed |Added Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #25 from Jonathan Druart --- Can we move forward? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #24 from Jonathan Druart --- To go further: 1. We should add "pages" to this table (and so don't split the table or we will end up with 3 identical tables). This is related to bug 27527. 2. I actually think we should put the notice templates into this table (merge them at least) 3. What we need to avoid this code is to normalize and have 2 tables, linked together. additional_contents - id - category - published_on - updated_on - expirationdate - number Another table for translations: - fk - lang (or eventually fk to a lang table) - title - content And, this is similar to the itemtypes, av, etc. translation story. Translations in the DB must be reconsidered, but it's another topic... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #23 from Jonathan Druart --- (In reply to Martin Renvoize from comment #21) > Sorry, sha1 errors, I can't get this one to apply. > > My feeling is.. this hides an issue nicely as an interim measure.. I still > feel that we should split the features to allow them to develop > independently and at that point we can drop the superfluous 'code' field for > this particular use case. > > I'm still keen on 'News', 'Blocks' and 'Pages' at the end of the day Which issue is hidden? We need this column, even if we split the features (what would we gain?). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Jonathan Druart changed: What|Removed |Added Attachment #125861|0 |1 is obsolete|| --- Comment #22 from Jonathan Druart --- Created attachment 127365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127365&action=edit Bug 29113: Fix random assignation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #21 from Martin Renvoize --- Sorry, sha1 errors, I can't get this one to apply. My feeling is.. this hides an issue nicely as an interim measure.. I still feel that we should split the features to allow them to develop independently and at that point we can drop the superfluous 'code' field for this particular use case. I'm still keen on 'News', 'Blocks' and 'Pages' at the end of the day -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #20 from Martin Renvoize --- This is one of the reasons I was keen to have distinct tables for these features rather than combine them I think.. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387#c30 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #19 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #16) > (In reply to Jonathan Druart from comment #15) > > (In reply to Marcel de Rooy from comment #14) > > > If the title says that it is unnecessary, why not remove it? Or should you > > > better adjust the title? > > > > We need it, to group rows together (rows have different languages, but > > represent the same content). However the end users don't need it. > > Adjust the title then? > If title and commit messages are unclear, getting it further may be more > complicated? Done, commit message read good to me however. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Jonathan Druart changed: What|Removed |Added Summary|Required new "code" field |New "code" field for |for additional contents |additional contents is not |appears unnecessary |useful for the end users --- Comment #18 from Jonathan Druart --- (In reply to Jonathan Druart from comment #17) > (In reply to Marcel de Rooy from comment #13) > > (In reply to Jonathan Druart from comment #9) > > > Created attachment 125861 [details] [review] [review] [review] > > > Bug 29113: Fix random assignation > > > > Unclear commit message, no test plan > > Because of the sort we cannot shift. So we need to specify and retrieve > explicitly what we need (using $lang) Done, commit message read good to me however. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
