[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 Owen Leonard changed: What|Removed |Added Blocks||30711 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30711 [Bug 30711] Fix space in check for dateformat preference -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 Owen Leonard changed: What|Removed |Added Blocks||30550 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30550 [Bug 30550] OPAC recalls page tries to use jQueryUI datepicker -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 David Nind changed: What|Removed |Added Text to go in the||This enhancement replaces release notes||the jQueryUI date picker ||used on OPAC pages with ||Flatpickr. The jQueryUI ||date picker is no longer ||supported. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 Kyle M Hall changed: What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 --- Comment #26 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 Fridolin Somers changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 --- Comment #25 from Fridolin Somers --- Great, thanks a lot Owen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 --- Comment #24 from Owen Leonard --- Created attachment 130019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130019=edit Bug 29212: (follow-up) Restore "Clear date" text for "Suspend all holds" This patch restores the "Clear date to suspend indefinitely" link associated with the "Suspend all holds" date input field. The patch also introduces a generic ".clear-flatpickr" click handler for Flatpickr instances. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #23 from Fridolin Somers --- Great work :) I see patch '(follow-up) Update missing date input' removes the hint text 'Clear date to suspend indefinitely', after 'Suspend all holds' : - Clear date to suspend indefinitely Is it on purpose ? This text still exists in modal when suspending one hold. In my opinion, this hint should be grey and not a link, the red cross already does the clear action. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 --- Comment #22 from Katrin Fischer --- Thx Joubu - glad to see this one moving. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 --- Comment #21 from Jonathan Druart --- Created attachment 129642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129642=edit Bug 29212: (follow-up) Add futuredate attribute to date picker This patch adds the "futuredate" attribute to the "Hold not needed after" date field in the OPAC hold process. To test, apply the patch and log into the OPAC. - Locate a bibliographic record and being the process of placing a hold. - Click "Show more options" to display the date fields. - If the OPACAllowHoldDateInFuture system preferences is enabled: - Set "Hold starts on date" to a date in the future. - Trigger the date-picker in the "Hold not needed after" field: You should be limited to dates *after* the date you selected above. - If OPACAllowHoldDateInFuture is disabled: - The "Hold starts on date" will no longer be present. - Trigger the date-picker in the "Hold not needed after" field: You should be limited to dates after today. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 --- Comment #20 from Jonathan Druart --- Created attachment 129641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129641=edit Bug 29212: (follow-up) Fixes to suspend hold process This patch reworks the process of suspending an individual hold from the patron's hold list. Instead of repeating the modal markup in each line of the holds table, a single modal is re-used. A "focus: false" is added to the modal via a data-attribute in order to overcome problems with selecting months and using keyboard navigation in the calendar popup. To test, apply the patch and log into the OPAC as a user with holds. - View the holds tab under "Your summary." - Click the "Suspend" button next to one of the holds. - You should see a modal which shows the title of the item in question. - Test that the date picker works correctly: - Test selecting a month and year - Test selecting a date both with the mouse and by using arrow keys. - Test that you can clear the selected date both by clicking the X and by clicking the text link. - Select a date and close the modal without submitting the suspension. - Click the "Suspend" link on another title to confirm that the date picker still works correctly. - Submit a suspension and confirm that the it completes successfully. - Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 --- Comment #19 from Jonathan Druart --- Created attachment 129640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129640=edit Bug 29212: (follow-up) Update missing date input I missed the "Suspend all holds" date input in previous patches. Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 --- Comment #18 from Jonathan Druart --- Created attachment 129639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129639=edit Bug 29212: (follow-up) Incorporate linked date field code from Bug 29240 Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 Jonathan Druart changed: What|Removed |Added Attachment #126824|0 |1 is obsolete|| Attachment #126825|0 |1 is obsolete|| Attachment #126826|0 |1 is obsolete|| Attachment #127250|0 |1 is obsolete|| Attachment #129620|0 |1 is obsolete|| --- Comment #17 from Jonathan Druart --- Created attachment 129638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129638=edit Bug 29212: Use Flatpickr on OPAC pages This patch adds Flatpickr assets to the OPAC (JS and SCSS). A few pages are updated to use Flatpickr instead of jQueryUI datepickers. jQueryUI CSS files are updated because they contain some font family definitions which are simple to remove but overly complicated to override. Without this change some Font Awesome icons are broken when they appear inside jQueryUI widgets like tabs. We don't run the risk of having this change overwritten by a future jQueryUI upgrade because there won't be any more. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Log into the OPAC and check that date pickers on the following pages work correctly, including month selection, year selection, forward and back arrows, and "Clear date" controls: - Go to the "Your personal details" page. - Check the "Date of birth" field. - With SuspendHoldsOpac enabled, view the "Your summary" page for a patron with pending holds. - Click "Suspend" to confirm that the "Suspend until" datepicker works correctly for more than one hold. - From the catalog search results page, select multiple results and click the "Place hold" link. - On the hold confirmation page, click "Show more options" to test the "Hold starts on date" (with OPACAllowHoldDateInFuture enabled) and the "Hold not needed after" fields. Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 --- Comment #16 from Owen Leonard --- Created attachment 129620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129620=edit Bug 29212: (follow-up) Add futuredate attribute to date picker This patch adds the "futuredate" attribute to the "Hold not needed after" date field in the OPAC hold process. To test, apply the patch and log into the OPAC. - Locate a bibliographic record and being the process of placing a hold. - Click "Show more options" to display the date fields. - If the OPACAllowHoldDateInFuture system preferences is enabled: - Set "Hold starts on date" to a date in the future. - Trigger the date-picker in the "Hold not needed after" field: You should be limited to dates *after* the date you selected above. - If OPACAllowHoldDateInFuture is disabled: - The "Hold starts on date" will no longer be present. - Trigger the date-picker in the "Hold not needed after" field: You should be limited to dates after today. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 Owen Leonard changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.druart+koha@gmail. ||com --- Comment #15 from Jonathan Druart --- opac-reserve: date in the past can be selected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 Bug 29212 depends on bug 28982, which changed state. Bug 28982 Summary: Use Flatpickr on onboarding pages https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 --- Comment #14 from Owen Leonard --- Created attachment 127250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127250=edit Bug 29212: (follow-up) Fixes to suspend hold process This patch reworks the process of suspending an individual hold from the patron's hold list. Instead of repeating the modal markup in each line of the holds table, a single modal is re-used. A "focus: false" is added to the modal via a data-attribute in order to overcome problems with selecting months and using keyboard navigation in the calendar popup. To test, apply the patch and log into the OPAC as a user with holds. - View the holds tab under "Your summary." - Click the "Suspend" button next to one of the holds. - You should see a modal which shows the title of the item in question. - Test that the date picker works correctly: - Test selecting a month and year - Test selecting a date both with the mouse and by using arrow keys. - Test that you can clear the selected date both by clicking the X and by clicking the text link. - Select a date and close the modal without submitting the suspension. - Click the "Suspend" link on another title to confirm that the date picker still works correctly. - Submit a suspension and confirm that the it completes successfully. - -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 Owen Leonard changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #13 from Katrin Fischer --- There is something odd going on in the suspend holds modal. Dateformat: DD.MM. - Suspend individual hold from OPAC staff acount using the link in the table - Click into the date field and set a date, example: 16.11.2021 - Empty the field using the x a the end of the input (NOT the link) - Click on the calendar again - it's set to nowhere with month empty - Try to pick a month from the pull down - it's not working The date of birth on patron details page works correctly in comparison. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 David Nind changed: What|Removed |Added Attachment #126820|0 |1 is obsolete|| --- Comment #12 from David Nind --- Created attachment 126826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126826=edit Bug 29212: (follow-up) Update missing date input I missed the "Suspend all holds" date input in previous patches. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 David Nind changed: What|Removed |Added Attachment #126299|0 |1 is obsolete|| --- Comment #11 from David Nind --- Created attachment 126825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126825=edit Bug 29212: (follow-up) Incorporate linked date field code from Bug 29240 Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 David Nind changed: What|Removed |Added Attachment #126298|0 |1 is obsolete|| --- Comment #10 from David Nind --- Created attachment 126824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126824=edit Bug 29212: Use Flatpickr on OPAC pages This patch adds Flatpickr assets to the OPAC (JS and SCSS). A few pages are updated to use Flatpickr instead of jQueryUI datepickers. jQueryUI CSS files are updated because they contain some font family definitions which are simple to remove but overly complicated to override. Without this change some Font Awesome icons are broken when they appear inside jQueryUI widgets like tabs. We don't run the risk of having this change overwritten by a future jQueryUI upgrade because there won't be any more. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Log into the OPAC and check that date pickers on the following pages work correctly, including month selection, year selection, forward and back arrows, and "Clear date" controls: - Go to the "Your personal details" page. - Check the "Date of birth" field. - With SuspendHoldsOpac enabled, view the "Your summary" page for a patron with pending holds. - Click "Suspend" to confirm that the "Suspend until" datepicker works correctly for more than one hold. - From the catalog search results page, select multiple results and click the "Place hold" link. - On the hold confirmation page, click "Show more options" to test the "Hold starts on date" (with OPACAllowHoldDateInFuture enabled) and the "Hold not needed after" fields. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 --- Comment #9 from Owen Leonard --- (In reply to David Nind from comment #7) > Comment #2 still applies for me - date picker not working for suspend all > holds until ... (see screenshot) Sorry David that was pure carelessness on my part! Thanks for testing! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 --- Comment #8 from Owen Leonard --- Created attachment 126820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126820=edit Bug 29212: (follow-up) Update missing date input I missed the "Suspend all holds" date input in previous patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 David Nind changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 Bug 29212 depends on bug 29240, which changed state. Bug 29240 Summary: Flatpickr - error in the console when a date is selected https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 --- Comment #7 from David Nind --- Comment #2 still applies for me - date picker not working for suspend all holds until ... (see screenshot) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 --- Comment #6 from Owen Leonard --- Created attachment 126299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126299=edit Bug 29212: (follow-up) Incorporate linked date field code from Bug 29240 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 --- Comment #5 from Owen Leonard --- Created attachment 126298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126298=edit Bug 29212: Use Flatpickr on OPAC pages This patch adds Flatpickr assets to the OPAC (JS and SCSS). A few pages are updated to use Flatpickr instead of jQueryUI datepickers. jQueryUI CSS files are updated because they contain some font family definitions which are simple to remove but overly complicated to override. Without this change some Font Awesome icons are broken when they appear inside jQueryUI widgets like tabs. We don't run the risk of having this change overwritten by a future jQueryUI upgrade because there won't be any more. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Log into the OPAC and check that date pickers on the following pages work correctly, including month selection, year selection, forward and back arrows, and "Clear date" controls: - Go to the "Your personal details" page. - Check the "Date of birth" field. - With SuspendHoldsOpac enabled, view the "Your summary" page for a patron with pending holds. - Click "Suspend" to confirm that the "Suspend until" datepicker works correctly for more than one hold. - From the catalog search results page, select multiple results and click the "Place hold" link. - On the hold confirmation page, click "Show more options" to test the "Hold starts on date" (with OPACAllowHoldDateInFuture enabled) and the "Hold not needed after" fields. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 --- Comment #4 from Owen Leonard --- Sorry David, Bug 29240 provides a better solution for some of the linked date fields affected by this patch. I'll get a revised patch up soon. Thanks for testing! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 Owen Leonard changed: What|Removed |Added Depends on||29240 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29240 [Bug 29240] Flatpickr - error in the console when a date is selected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 --- Comment #3 from David Nind --- Ignore my previous comment - I post the screen shot just after you had obsoleted the patch! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #2 from David Nind --- Created attachment 126290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126290=edit Bug 29212 - Date picker not working For me the date picker is not working for suspend all holds until... It was working (using the jquery date picker) before applying the patch. It is working when you suspend the hold for an individual item. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 Owen Leonard changed: What|Removed |Added Attachment #126229|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 Jonathan Druart changed: What|Removed |Added Blocks||29239 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 [Bug 29239] [OMNIBUS] Replace jQueryUI's timepicker with flatpickr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 --- Comment #1 from Owen Leonard --- Created attachment 126229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126229=edit Bug 29212: Use Flatpickr on OPAC pages This patch adds Flatpickr assets to the OPAC (JS and SCSS). A few pages are updated to use Flatpickr instead of jQueryUI datepickers. jQueryUI CSS files are updated because they contain some font family definitions which are simple to remove but overly complicated to override. Without this change some Font Awesome icons are broken when they appear inside jQueryUI widgets like tabs. We don't run the risk of having this change overwritten by a future jQueryUI upgrade because there won't be any more. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Log into the OPAC and check that date pickers on the following pages work correctly, including month selection, year selection, forward and back arrows, and "Clear date" controls: - Go to the "Your personal details" page. - Check the "Date of birth" field. - With SuspendHoldsOpac enabled, view the "Your summary" page for a patron with pending holds. - Click "Suspend" to confirm that the "Suspend until" datepicker works correctly for more than one hold. - From the catalog search results page, select multiple results and click the "Place hold" link. - On the hold confirmation page, click "Show more options" to test the "Hold starts on date" (with OPACAllowHoldDateInFuture enabled) and the "Hold not needed after" fields. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
