[Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Bug 29230 depends on bug 29785, which changed state. Bug 29785 Summary: Koha::Object->messages must be renamed https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29785 What|Removed |Added Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #23 from Andrew Fuerste-Henry --- Doesn't apply cleanly to 21.05, please rebase if needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Owen Leonard changed: What|Removed |Added Blocks||30099 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30099 [Bug 30099] Error when accessing circulation.pl without patron parameter -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Kyle M Hall changed: What|Removed |Added Version(s)|22.05.00|22.05.00,21.11.03 released in|| Status|Pushed to master|Pushed to stable --- Comment #22 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 --- Comment #21 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Fridolin Somers changed: What|Removed |Added Version(s)||22.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 --- Comment #20 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #19) > Do we actually have a rule for empty test descriptions? :) IMO the descriptions are like comments, they should be there when it's not obvious. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 --- Comment #19 from Marcel de Rooy --- Do we actually have a rule for empty test descriptions? :) # Subtest: messages 1..4 ok 1 - No message yet ok 2 - There are two messages for this patron ok 3 ok 4 ok 14 - messages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230
Marcel de Rooy changed:
What|Removed |Added
Attachment #130044|0 |1
is obsolete||
--- Comment #18 from Marcel de Rooy ---
Created attachment 130097
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130097=edit
Bug 29230: Add Koha::Patron->messages
Add methods to return the messages attached to a patron.
It will add the capability to access them from notice templates.
Test plan:
Define some messages for a given patron
Go to the circulation page of the patron and confirm that they are still
displayed
Test the notice templates:
Add to HOLD_SLIP the following content
"""
[% SET messages = borrower.messages %]
[% IF messages.count %]
Messages:
[% FOR m IN messages.search( message_type => 'L' ) %]
[% m.message %]
[% END %]
[% END %]
"""
To display all the messages from staff ('L')
Adapt following your needs.
Signed-off-by: Fridolin Somers
Signed-off-by: Stina Hallin
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230
Jonathan Druart changed:
What|Removed |Added
Attachment #128162|0 |1
is obsolete||
--- Comment #17 from Jonathan Druart ---
Created attachment 130044
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130044=edit
Bug 29230: Add Koha::Patron->messages
Add methods to return the messages attached to a patron.
It will add the capability to access them from notice templates.
Test plan:
Define some messages for a given patron
Go to the circulation page of the patron and confirm that they are still
displayed
Test the notice templates:
Add to HOLD_SLIP the following content
"""
[% SET messages = borrower.messages %]
[% IF messages.count %]
Messages:
[% FOR m IN messages.search( message_type => 'L' ) %]
[% m.message %]
[% END %]
[% END %]
"""
To display all the messages from staff ('L')
Adapt following your needs.
Signed-off-by: Fridolin Somers
Signed-off-by: Stina Hallin
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED --- Comment #16 from Marcel de Rooy --- Back to blocked: base report fails qa. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 --- Comment #15 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #14) > Marcel, let me know if you are not going to work on this one in a short > term, please. Thanks! Thanks for your patience. I will have another look. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 --- Comment #14 from Tomás Cohen Arazi --- Marcel, let me know if you are not going to work on this one in a short term, please. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Tomás Cohen Arazi changed: What|Removed |Added Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Jonathan Druart changed: What|Removed |Added Status|Failed QA |BLOCKED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Jonathan Druart changed: What|Removed |Added Depends on||29785 --- Comment #13 from Jonathan Druart --- I opened bug 29785 to rename it. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29785 [Bug 29785] Koha::Object->messages must be renamed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 --- Comment #12 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #11) > (In reply to Marcel de Rooy from comment #10) > > Although it looks good to me on itself, we have a clash with > > Koha::Object::messages. > > > > cc: Tomas > > In my opinion Koha::Object->messages should be renamed. ->_messages maybe? Maybe, but you need to think of an accessor? Or maybe bug 29746 is the way to avoid it completely? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 --- Comment #11 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #10) > Although it looks good to me on itself, we have a clash with > Koha::Object::messages. > > cc: Tomas In my opinion Koha::Object->messages should be renamed. ->_messages maybe? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA CC||m.de.r...@rijksmuseum.nl, ||tomasco...@gmail.com --- Comment #10 from Marcel de Rooy --- Although it looks good to me on itself, we have a clash with Koha::Object::messages. cc: Tomas -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Katrin Fischer changed: What|Removed |Added Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Stina Hallin changed: What|Removed |Added CC||stina.hal...@ub.lu.se --- Comment #9 from Stina Hallin --- Signed off using a sandbox. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230
PTFS Europe Sandboxes changed:
What|Removed |Added
Attachment #127678|0 |1
is obsolete||
--- Comment #8 from PTFS Europe Sandboxes ---
Created attachment 128162
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128162=edit
Bug 29230: Add Koha::Patron->messages
Add methods to return the messages attached to a patron.
It will add the capability to access them from notice templates.
Test plan:
Define some messages for a given patron
Go to the circulation page of the patron and confirm that they are still
displayed
Test the notice templates:
Add to HOLD_SLIP the following content
"""
[% SET messages = borrower.messages %]
[% IF messages.count %]
Messages:
[% FOR m IN messages.search( message_type => 'L' ) %]
[% m.message %]
[% END %]
[% END %]
"""
To display all the messages from staff ('L')
Adapt following your needs.
Signed-off-by: Fridolin Somers
Signed-off-by: Stina Hallin
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230
Fridolin Somers changed:
What|Removed |Added
Attachment #126641|0 |1
is obsolete||
--- Comment #7 from Fridolin Somers ---
Created attachment 127678
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127678=edit
Bug 29230: Add Koha::Patron->messages
Add methods to return the messages attached to a patron.
It will add the capability to access them from notice templates.
Test plan:
Define some messages for a given patron
Go to the circulation page of the patron and confirm that they are still
displayed
Test the notice templates:
Add to HOLD_SLIP the following content
"""
[% SET messages = borrower.messages %]
[% IF messages.count %]
Messages:
[% FOR m IN messages.search( message_type => 'L' ) %]
[% m.message %]
[% END %]
[% END %]
"""
To display all the messages from staff ('L')
Adapt following your needs.
Signed-off-by: Fridolin Somers
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Fridolin Somers changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Jonathan Druart changed: What|Removed |Added Summary|borrowers.borrowernotes and |Patron's messages not |borrowers.opacnote fields |accessible from template |won't display in the|notices |HOLD_SLIP | Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com --- Comment #6 from Jonathan Druart --- This patch adds what's needed to access the messages from notice templates. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
