[Koha-bugs] [Bug 29257] Redundant slash in the URL appear during item level hold placing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29257 Jonathan Druart changed: What|Removed |Added Status|Signed Off |RESOLVED Resolution|--- |DUPLICATE --- Comment #9 from Jonathan Druart --- Will be fixed globally on bug 28782. *** This bug has been marked as a duplicate of bug 28782 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29257] Redundant slash in the URL appear during item level hold placing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29257 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #8 from Jonathan Druart --- (In reply to Joonas Kylmälä from comment #7) > Just noting down here as well, if bug 28782 gets pushed then this bug is > fixed as well. Yes, I think we should favor bug 28782's solution over this one. Or we based it on top of this one to make this patch backportable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29257] Redundant slash in the URL appear during item level hold placing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29257 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@iki.fi --- Comment #7 from Joonas Kylmälä --- Just noting down here as well, if bug 28782 gets pushed then this bug is fixed as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29257] Redundant slash in the URL appear during item level hold placing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29257 Andrew Nugged changed: What|Removed |Added CC||nug...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29257] Redundant slash in the URL appear during item level hold placing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29257 --- Comment #6 from David Cook --- (In reply to David Cook from comment #5) > I haven't looked into this in-depth, but I'm wary of this one, especially in > the context of item-specific multi-holds. > > I'm not going to look into it right now, but just sharing my thoughts. It > would be worth expanding this test plan to different hold scenarios. I've taken a bit more of a look in light of bug 28782, and it looks the slashes are only important for the OPAC and not for the Staff Interface, so my objection withdrawn. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29257] Redundant slash in the URL appear during item level hold placing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29257 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28782 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29257] Redundant slash in the URL appear during item level hold placing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29257 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #5 from David Cook --- I haven't looked into this in-depth, but I'm wary of this one, especially in the context of item-specific multi-holds. I'm not going to look into it right now, but just sharing my thoughts. It would be worth expanding this test plan to different hold scenarios. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29257] Redundant slash in the URL appear during item level hold placing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29257 David Nind changed: What|Removed |Added Attachment #126411|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 126412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126412&action=edit Bug 29257: Redundant slash in the URL appear during item level hold placing The solution was to get rid of adding slash to $biblionumbers directly and join slash only in place when it's needed. How to test: 1. Search for an item; 2. Select single item, click 'Place hold'; 3. Enter a patron card number; 4. Complete hold placing by clicking 'Place hold'; 5. Note that after redirection to URL ended with slash (after biblionumber): e.g.: `request.pl?biblionumbers=233/` 6. Apply the patch 7. Repeat steps 1-4 8 Note that after redirection to the page with hold list, URL doesn't contain slash after biblionumber parameter: e.g.: `request.pl?biblionumbers=233 Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29257] Redundant slash in the URL appear during item level hold placing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29257 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29257] Redundant slash in the URL appear during item level hold placing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29257 Andrii Veremeienko changed: What|Removed |Added Blocks||29259 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29259 [Bug 29259] Url contains slash '/' instead of encoded slash '%2F' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29257] Redundant slash in the URL appear during item level hold placing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29257 Andrii Veremeienko changed: What|Removed |Added Attachment #126410|0 |1 is obsolete|| --- Comment #3 from Andrii Veremeienko --- Created attachment 126411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126411&action=edit Bug 29257: Redundant slash in the URL appear during item level hold placing The solution was to get rid of adding slash to $biblionumbers directly and join slash only in place when it's needed. How to test: 1. Search for an item; 2. Select single item, click 'Place hold'; 3. Enter a patron card number; 4. Complete hold placing by clicking 'Place hold'; 5. Note that after redirection to URL ended with slash (after biblionumber): e.g.: `request.pl?biblionumbers=233/` 6. Apply the patch 7. Repeat steps 1-4 8 Note that after redirection to the page with hold list, URL doesn't contain slash after biblionumber parameter: e.g.: `request.pl?biblionumbers=233 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29257] Redundant slash in the URL appear during item level hold placing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29257 Andrii Veremeienko changed: What|Removed |Added Attachment #126409|0 |1 is obsolete|| --- Comment #2 from Andrii Veremeienko --- Created attachment 126410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126410&action=edit Bug 29257: Redundant slash in the URL appear during item level hold placing The solution was to get rid of adding slash to $biblionumbers directly and join slash only in place when it's needed. How to test: 1. Search for an item; 2. Select single item, click 'Place hold'; 3. Enter a patron card number; 4. Complete hold placing by clicking 'Place hold'; 5. Note that after redirection to the page with hold list, URL doesn't contain slash after biblionumber parameter; E.g.: request.pl?biblionumbers=233 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29257] Redundant slash in the URL appear during item level hold placing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29257 Andrii Veremeienko changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29257] Redundant slash in the URL appear during item level hold placing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29257 --- Comment #1 from Andrii Veremeienko --- Created attachment 126409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126409&action=edit Bug 29257: Redundant slash in the URL appear during item level hold placing The solution was to get rid of adding slash to $biblionumbers directly and join slash only in place when it's needed. How to test: 1. Search for an item; 2. Select single item, click 'Place hold'; 3. Enter a patron card number; 4. Complete hold placing by clicking 'Place hold'; 5. Note that after redirection to the page with hold list, URL doesn't contain slash after biblionumber parameter; E.g.: request.pl?biblionumbers=233 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29257] Redundant slash in the URL appear during item level hold placing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29257 Andrii Veremeienko changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |andriive...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
