[Koha-bugs] [Bug 29273] Warning not caught in tests for plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29273 Kyle M Hall changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to master|RESOLVED CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29273] Warning not caught in tests for plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29273 --- Comment #11 from Jonathan Druart --- (In reply to Jonathan Druart from comment #10) > Created attachment 127643 [details] [review] > Bug 29273: Fix failing tests Pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29273] Warning not caught in tests for plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29273 --- Comment #10 from Jonathan Druart --- Created attachment 127643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127643=edit Bug 29273: Fix failing tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29273] Warning not caught in tests for plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29273 --- Comment #9 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29273] Warning not caught in tests for plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29273 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||21.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29273] Warning not caught in tests for plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29273 Joonas Kylmälä changed: What|Removed |Added Attachment #126582|0 |1 is obsolete|| --- Comment #8 from Joonas Kylmälä --- Created attachment 127605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127605=edit Bug 29273: Remove warnings from plugin tests This patch is suggesting to move the broken test plugins into a separate directory. t/lib/plugins and t/lib/bad_plugins Signed-off-by: David Nind JK: Add executable bit to Broken.t Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29273] Warning not caught in tests for plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29273 Joonas Kylmälä changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29273] Warning not caught in tests for plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29273 Jonathan Druart changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29273] Warning not caught in tests for plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29273 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29273] Warning not caught in tests for plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29273 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29273] Warning not caught in tests for plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29273 --- Comment #7 from Jonathan Druart --- You need that line 333 PERL5LIB="$KOHA_HOME:$KOHA_HOME/lib" in debian/scripts/koha-functions.sh See commit 40089a0a538dffca7ee5bd619b902b9830e4460c Bug 28519: Put CGI::Session::Serialize::yamlxs in lib directory -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29273] Warning not caught in tests for plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29273 --- Comment #6 from Katrin Fischer --- I am still having local issues with yamlxs, so can't finish here right now :( Leaving that here in case someone can help me fix: t/db_dependent/Koha/Plugins/Plugins.t 6/61 new(): failed: couldn't load CGI::Session::Serialize::yamlxs: Can't locate CGI/Session/Serialize/yamlxs.pm in @INC (you may need to install the CGI::Session::Serialize::yamlxs module) (@INC contains: /home/vagrant/kohaclone /home/vagrant/qa-test-tools /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1 /usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base t/db_dependent/Koha/Plugins/../../../lib/plugins) at (eval 1739) line 2. # Looks like your test exited with 2 just after 38. t/db_dependent/Koha/Plugins/Plugins.t Dubious, test returned 2 (wstat 512, 0x200) Failed 23/61 subtests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29273] Warning not caught in tests for plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29273 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #5 from David Nind --- Tested by making sure tests pass bother before and after patch applied. Hope that is sufficient. Tests pass before and after apply patch for existing tests: prove t/db_dependent/Koha/Plugins/Barcode_transform_hooks.t prove t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t prove t/db_dependent/Koha/Plugins/Circulation_hooks.t prove t/db_dependent/Koha/Plugins/Holds_hooks.t prove t/db_dependent/Koha/Plugins/Patron.t prove t/db_dependent/Koha/Plugins/Plugins.t Tests pass for new test: prove t/db_dependent/Koha/Plugins/Broken.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29273] Warning not caught in tests for plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29273 David Nind changed: What|Removed |Added Attachment #126567|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 126582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126582=edit Bug 29273: Remove warnings from plugin tests This patch is suggesting to move the broken test plugins into a separate directory. t/lib/plugins and t/lib/bad_plugins Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29273] Warning not caught in tests for plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29273 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29273] Warning not caught in tests for plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29273 Jonathan Druart changed: What|Removed |Added Attachment #126503|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 126567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126567=edit Bug 29273: Remove warnings from plugin tests This patch is suggesting to move the broken test plugins into a separate directory. t/lib/plugins and t/lib/bad_plugins -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29273] Warning not caught in tests for plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29273 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22709 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29273] Warning not caught in tests for plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29273 Jonathan Druart changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #2 from Jonathan Druart --- There are still warnings raised by calls to item_barcode_transform patron_barcode_transform. I am not sure how to deal with them correctly. Those hooks should actually be disabled when we don't want to test their behaviour. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29273] Warning not caught in tests for plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29273 Jonathan Druart changed: What|Removed |Added Blocks||25515 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25515 [Bug 25515] Remove warnings and errors from tests output -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29273] Warning not caught in tests for plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29273 --- Comment #1 from Jonathan Druart --- Created attachment 126503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126503=edit Bug 29273: Remove warnings from plugin tests This patch is suggesting to move the broken test plugins into a separate directory. t/lib/plugins and t/lib/bad_plugins -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29273] Warning not caught in tests for plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29273 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
