[Koha-bugs] [Bug 29275] issuehistory.pl is very slow when there are many historical issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 --- Comment #16 from Tomás Cohen Arazi --- (In reply to Victor Grousset/tuxayo from comment #8) > A diff between current_checkouts and old_checkouts functions show that they > have a lot of duplication. > Is there a way to deduplicate without making something messy? > I wonder if there is a way to assign old_checkouts as a copy of > current_checkouts and then re assign so it it's properties to add and change > stuff. > The only difference is the URL param and a render function. Not just that. But I made a function to avoid duplication. > Also a call to encodeURIComponent() might be missing in current_checkouts Solved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29275] issuehistory.pl is very slow when there are many historical issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 --- Comment #15 from Tomás Cohen Arazi --- Created attachment 127703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127703&action=edit Bug 29275: (follow-up) Remove use of CountSubscriptionFromBiblionumber Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29275] issuehistory.pl is very slow when there are many historical issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 --- Comment #14 from Tomás Cohen Arazi --- Created attachment 127702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127702&action=edit Bug 29275: Use the API to fetch checkouts information This patch changes issuehistory.pl so it leverages on the API for fetching checkouts information in the template. Workflow changes: This development splits the 'current' checkouts and the 'past' checkouts in two different tables. Terminology could be revisited by native english speakers. To test: 1. Have records with and without current/past checkouts 2. Notice how the Checkouts history tab presents the information on each case. => SUGGESTION: Keep each of them open on separate tabs for comparing 3. Apply this patchset and its dependencies 4. Restart plack, run: $ koha-plack --restart kohadev 5. Follow the same steps you followed for those open tabs, in new ones => SUCCESS: What you see makes sense, information is displayed as it used to, with the different tables now. 6. Try searching on the datatables => SUCCESS: Search works correctly! 7. Revisit the new texts I added => SUGGESTION: If you have better wordings, submit a patch, or just comment on the bug so I do it inline. 8. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29275] issuehistory.pl is very slow when there are many historical issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 Tomás Cohen Arazi changed: What|Removed |Added Attachment #126634|0 |1 is obsolete|| Attachment #126635|0 |1 is obsolete|| Attachment #126636|0 |1 is obsolete|| --- Comment #13 from Tomás Cohen Arazi --- Created attachment 127701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127701&action=edit Bug 29275: Add $patron_to_html to render patron information in JS Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29275] issuehistory.pl is very slow when there are many historical issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29275] issuehistory.pl is very slow when there are many historical issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 --- Comment #12 from Victor Grousset/tuxayo --- And it has been pushed :D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29275] issuehistory.pl is very slow when there are many historical issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 Bug 29275 depends on bug 29290, which changed state. Bug 29290 Summary: Add routes to fetch checkouts for a given biblio https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29290 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29275] issuehistory.pl is very slow when there are many historical issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 --- Comment #11 from Tomás Cohen Arazi --- I didn't submit the follow-up because the RM mentioned bug 28859, which is expected to be pushed first. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29275] issuehistory.pl is very slow when there are many historical issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 --- Comment #10 from Tomás Cohen Arazi --- (In reply to Victor Grousset/tuxayo from comment #8) > A diff between current_checkouts and old_checkouts functions show that they > have a lot of duplication. > Is there a way to deduplicate without making something messy? > I wonder if there is a way to assign old_checkouts as a copy of > current_checkouts and then re assign so it it's properties to add and change > stuff. > The only difference is the URL param and a render function. I tried, but things get a bit harder to understand and I didn't feel like the trade-off justified a generalization. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29275] issuehistory.pl is very slow when there are many historical issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |ASSIGNED --- Comment #9 from Tomás Cohen Arazi --- (In reply to Victor Grousset/tuxayo from comment #8) > A diff between current_checkouts and old_checkouts functions show that they > have a lot of duplication. > Is there a way to deduplicate without making something messy? > I wonder if there is a way to assign old_checkouts as a copy of > current_checkouts and then re assign so it it's properties to add and change > stuff. > The only difference is the URL param and a render function. > > Also a call to encodeURIComponent() might be missing in current_checkouts Thanks! Fixing! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29275] issuehistory.pl is very slow when there are many historical issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29275] issuehistory.pl is very slow when there are many historical issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 Victor Grousset/tuxayo changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #8 from Victor Grousset/tuxayo --- A diff between current_checkouts and old_checkouts functions show that they have a lot of duplication. Is there a way to deduplicate without making something messy? I wonder if there is a way to assign old_checkouts as a copy of current_checkouts and then re assign so it it's properties to add and change stuff. The only difference is the URL param and a render function. Also a call to encodeURIComponent() might be missing in current_checkouts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29275] issuehistory.pl is very slow when there are many historical issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 Victor Grousset/tuxayo changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #7 from Victor Grousset/tuxayo --- cases tested to get all the strings and behaviors I could thing of - never checked out and no current checkout - never checked out and a current checkout - a past checkout and no current checkout - more than 10 past checkout (for pagination) and a current checkout strings make sense -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29275] issuehistory.pl is very slow when there are many historical issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #126628|0 |1 is obsolete|| --- Comment #6 from Victor Grousset/tuxayo --- Created attachment 126636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126636&action=edit Bug 29275: (follow-up) Remove use of CountSubscriptionFromBiblionumber Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29275] issuehistory.pl is very slow when there are many historical issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #126627|0 |1 is obsolete|| --- Comment #5 from Victor Grousset/tuxayo --- Created attachment 126635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126635&action=edit Bug 29275: Use the API to fetch checkouts information This patch changes issuehistory.pl so it leverages on the API for fetching checkouts information in the template. Workflow changes: This development splits the 'current' checkouts and the 'past' checkouts in two different tables. Terminology could be revisited by native english speakers. To test: 1. Have records with and without current/past checkouts 2. Notice how the Checkouts history tab presents the information on each case. => SUGGESTION: Keep each of them open on separate tabs for comparing 3. Apply this patchset and its dependencies 4. Restart plack, run: $ koha-plack --restart kohadev 5. Follow the same steps you followed for those open tabs, in new ones => SUCCESS: What you see makes sense, information is displayed as it used to, with the different tables now. 6. Try searching on the datatables => SUCCESS: Search works correctly! 7. Revisit the new texts I added => SUGGESTION: If you have better wordings, submit a patch, or just comment on the bug so I do it inline. 8. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29275] issuehistory.pl is very slow when there are many historical issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #126626|0 |1 is obsolete|| --- Comment #4 from Victor Grousset/tuxayo --- Created attachment 126634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126634&action=edit Bug 29275: Add $patron_to_html to render patron information in JS Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29275] issuehistory.pl is very slow when there are many historical issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 Tomás Cohen Arazi changed: What|Removed |Added CC||vic...@tuxayo.net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29275] issuehistory.pl is very slow when there are many historical issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff CC||jonathan.druart+koha@gmail. ||com, ||k...@bywatersolutions.com, ||martin.renvoize@ptfs-europe ||.com, ||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29275] issuehistory.pl is very slow when there are many historical issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 126628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126628&action=edit Bug 29275: (follow-up) Remove use of CountSubscriptionFromBiblionumber Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29275] issuehistory.pl is very slow when there are many historical issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 126627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126627&action=edit Bug 29275: Use the API to fetch checkouts information This patch changes issuehistory.pl so it leverages on the API for fetching checkouts information in the template. Workflow changes: This development splits the 'current' checkouts and the 'past' checkouts in two different tables. Terminology could be revisited by native english speakers. To test: 1. Have records with and without current/past checkouts 2. Notice how the Checkouts history tab presents the information on each case. => SUGGESTION: Keep each of them open on separate tabs for comparing 3. Apply this patchset and its dependencies 4. Restart plack, run: $ koha-plack --restart kohadev 5. Follow the same steps you followed for those open tabs, in new ones => SUCCESS: What you see makes sense, information is displayed as it used to, with the different tables now. 6. Try searching on the datatables => SUCCESS: Search works correctly! 7. Revisit the new texts I added => SUGGESTION: If you have better wordings, submit a patch, or just comment on the bug so I do it inline. 8. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29275] issuehistory.pl is very slow when there are many historical issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 126626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126626&action=edit Bug 29275: Add $patron_to_html to render patron information in JS Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29275] issuehistory.pl is very slow when there are many historical issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 Tomás Cohen Arazi changed: What|Removed |Added Depends on||29290 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29290 [Bug 29290] Add routes to fetch checkouts for a given biblio -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29275] issuehistory.pl is very slow when there are many historical issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 Tomás Cohen Arazi changed: What|Removed |Added Version|21.05 |master Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | Status|NEW |ASSIGNED CC||tomasco...@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
