[Koha-bugs] [Bug 29280] Add star ratings to OPAC lists display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29280 --- Comment #22 from Jonathan Druart --- Quick note: bug 33953 introduces Koha::Biblio->ratings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29280] Add star ratings to OPAC lists display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29280 --- Comment #21 from Katrin Fischer --- How can we move forward here? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29280] Add star ratings to OPAC lists display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29280 --- Comment #20 from Lucas Gass --- I filed Bug 29749 to clean up OpacStarRatings a bit. If it is pushed it will make adding OpacStarRatings to lists easier. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29280] Add star ratings to OPAC lists display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29280 --- Comment #19 from Lucas Gass --- (In reply to Jonathan Druart from comment #18) > (In reply to Lucas Gass from comment #17) > > (In reply to Lucas Gass from comment #16) > > > (In reply to Jonathan Druart from comment #15) > > > > Code is copy/pasted from somewhere else. I cannot push it like that. > > > > Are you asking me to put the repeated code in an include? > > Yes, please? It can be done on a separate bug report if you prefer. No need for a separate bug, I will do it on this one! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29280] Add star ratings to OPAC lists display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29280 --- Comment #18 from Jonathan Druart --- (In reply to Lucas Gass from comment #17) > (In reply to Lucas Gass from comment #16) > > (In reply to Jonathan Druart from comment #15) > > > Code is copy/pasted from somewhere else. I cannot push it like that. > > Are you asking me to put the repeated code in an include? Yes, please? It can be done on a separate bug report if you prefer. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29280] Add star ratings to OPAC lists display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29280 --- Comment #17 from Lucas Gass --- (In reply to Lucas Gass from comment #16) > (In reply to Jonathan Druart from comment #15) > > Code is copy/pasted from somewhere else. I cannot push it like that. Are you asking me to put the repeated code in an include? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29280] Add star ratings to OPAC lists display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29280 --- Comment #16 from Lucas Gass --- (In reply to Jonathan Druart from comment #15) > Code is copy/pasted from somewhere else. I cannot push it like that. I took most of this code from the OPACStarRatings on the results page. What needs to be amended? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29280] Add star ratings to OPAC lists display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29280 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Failed QA CC||jonathan.druart+koha@gmail. ||com --- Comment #15 from Jonathan Druart --- Code is copy/pasted from somewhere else. I cannot push it like that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29280] Add star ratings to OPAC lists display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29280 Katrin Fischer changed: What|Removed |Added Attachment #127190|0 |1 is obsolete|| --- Comment #14 from Katrin Fischer --- Created attachment 127202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127202=edit Bug 29280: (follow-up) Move OpacStarRating logic to template Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29280] Add star ratings to OPAC lists display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29280 Katrin Fischer changed: What|Removed |Added Attachment #126900|0 |1 is obsolete|| --- Comment #13 from Katrin Fischer --- Created attachment 127201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127201=edit Bug 29280: (follow-up) add event handler when clicking on star ratings Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29280] Add star ratings to OPAC lists display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29280 Katrin Fischer changed: What|Removed |Added Attachment #126899|0 |1 is obsolete|| --- Comment #12 from Katrin Fischer --- Created attachment 127200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127200=edit Bug 29280: Add OpacStarRatings to opac-shelves.tt To test: -Apply patch and restart everything -Set the system preference 'OpacStarRatings' to 'results, detail, lists, and patron' -Build a public lists with some items that have ratings -View the list page and you should see the ratings appear -Make sure that the ratings and the number of votes are acurate -Ratings on the opac-shelves should look and function just like those on the OPAC results page -Turn the 'OpacStarRatings' system pref to 'only detials' and 'no', making sure they do not show in the lists display Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29280] Add star ratings to OPAC lists display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29280 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29280] Add star ratings to OPAC lists display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29280 --- Comment #11 from Lucas Gass --- Created attachment 127190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127190=edit Bug 29280: (follow-up) Move OpacStarRating logic to template -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29280] Add star ratings to OPAC lists display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29280 Lucas Gass changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29280] Add star ratings to OPAC lists display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29280
--- Comment #10 from Lucas Gass ---
(In reply to Katrin Fischer from comment #9)
> Sorry, not trying to throw this out, but:
>
> +$template->param(
> +OpacStarRatings => C4::Context->preference("OpacStarRatings")
> +);
> +
>
> Should we not remove this in favor of using TT in the template?
Indeed, we should!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29280] Add star ratings to OPAC lists display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29280 Katrin Fischer changed: What|Removed |Added Summary|Add OPACStarRatings to |Add star ratings to OPAC |opac-shelves.tt |lists display -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
