[Koha-bugs] [Bug 29283] Cannot delete basket with cancelled order for deleted biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29283 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29283] Cannot delete basket with cancelled order for deleted biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29283 --- Comment #11 from Marcel de Rooy --- Opened bug 29658 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29283] Cannot delete basket with cancelled order for deleted biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29283 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=29658 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29283] Cannot delete basket with cancelled order for deleted biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29283
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
--- Comment #10 from Marcel de Rooy ---
Found something similar:
Cannot insert order: Mandatory parameter biblionumber is missing at
/usr/share/koha/acqui/cancelorder.pl line 60.
at /usr/share/perl/5.28/Carp.pm line 289
Carp::croak('Cannot insert order: Mandatory parameter biblionumber is
missing') called at /usr/share/koha/Koha/Acquisition/Order.pm line 79
Koha::Acquisition::Order::store('Koha::Acquisition::Order=HASH(0x55f3760e2860)')
called at /usr/share/koha/Koha/Acquisition/Order.pm line 189
Koha::Acquisition::Order::cancel('Koha::Acquisition::Order=HASH(0x55f3760e2860)',
'HASH(0x55f375a17ec0)') called at /usr/share/koha/acqui/cancelorder.pl line 60
cancelorder L60 (20.11) shows
my $order = Koha::Acquisition::Orders->find($ordernumber);
L60 $order->cancel({ reason => $reason, delete_biblio => $delete_biblio });
I am not sure how to recreate this one actually. I found it in the logs.
The only way I found is opening the basket twice. Delete order in the first
tab, and now delete it in the second. The second tab will crash.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29283] Cannot delete basket with cancelled order for deleted biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29283 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #9 from Victor Grousset/tuxayo --- Missing dependencies for 20.05.x, not affected after testing, no backport. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29283] Cannot delete basket with cancelled order for deleted biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29283 Fridolin Somers changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in|| --- Comment #8 from Fridolin Somers --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29283] Cannot delete basket with cancelled order for deleted biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29283 --- Comment #7 from Fridolin Somers --- Depends on Bug 23166 which added filter_by_current() -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29283] Cannot delete basket with cancelled order for deleted biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29283 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Depends on||23166 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 [Bug 23166] Simplify code related to orders in catalogue/*detail.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29283] Cannot delete basket with cancelled order for deleted biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29283 Kyle M Hall changed: What|Removed |Added Version(s)|21.11.00|21.11.00,21.05.05 released in|| CC||k...@bywatersolutions.com Status|Pushed to master|Pushed to stable --- Comment #6 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29283] Cannot delete basket with cancelled order for deleted biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29283 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29283] Cannot delete basket with cancelled order for deleted biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29283 Jonathan Druart changed: What|Removed |Added Version(s)||21.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29283] Cannot delete basket with cancelled order for deleted biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29283 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29283] Cannot delete basket with cancelled order for deleted biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29283 --- Comment #4 from Joonas Kylmälä --- Created attachment 127135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127135=edit Bug 29283: (QA follow-up) Remove code duplication We have already a search filter for active orders. Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29283] Cannot delete basket with cancelled order for deleted biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29283 Joonas Kylmälä changed: What|Removed |Added Attachment #126589|0 |1 is obsolete|| --- Comment #3 from Joonas Kylmälä --- Created attachment 127134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127134=edit Bug 29283: Don't attempt to cancel cancelled orders When deleting a basket we cancel all the contained orders - when a basket contains an order that was previously cancelled this can cause an error if the biblio was deleted When picking the orders to cancel, we should limit our search to those not already cancelled. To test: - have a basket with at least one order - click "Cancel order and delete catalog record", confirm cancellation of order and deletion of bib - click "Delete basket", confirm deletion - get error "Cannot insert order: Mandatory parameter biblionumber is missing at /kohadevbox/koha/acqui/basket.pl line 136. at /usr/share/perl/5.28/Carp.pm line 289" - apply patch - restart - delete the basket - success! Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29283] Cannot delete basket with cancelled order for deleted biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29283 Joonas Kylmälä changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29283] Cannot delete basket with cancelled order for deleted biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29283 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@iki.fi QA Contact|testo...@bugs.koha-communit |joonas.kylm...@iki.fi |y.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29283] Cannot delete basket with cancelled order for deleted biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29283 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #126585|0 |1 is obsolete|| --- Comment #2 from Andrew Fuerste-Henry --- Created attachment 126589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126589=edit Bug 29283: Don't attempt to cancel cancelled orders When deleting a basket we cancel all the contained orders - when a basket contains an order that was previously cancelled this can cause an error if the biblio was deleted When picking the orders to cancel, we should limit our search to those not already cancelled. To test: - have a basket with at least one order - click "Cancel order and delete catalog record", confirm cancellation of order and deletion of bib - click "Delete basket", confirm deletion - get error "Cannot insert order: Mandatory parameter biblionumber is missing at /kohadevbox/koha/acqui/basket.pl line 136. at /usr/share/perl/5.28/Carp.pm line 289" - apply patch - restart - delete the basket - success! Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29283] Cannot delete basket with cancelled order for deleted biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29283 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29283] Cannot delete basket with cancelled order for deleted biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29283 --- Comment #1 from Nick Clemens --- Created attachment 126585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126585=edit Bug 29283: Don't attempt to cancel cancelled orders When deleting a basket we cancel all the contained orders - when a basket contains an order that was previously cancelled this can cause an error if the biblio was deleted When picking the orders to cancel, we should limit our search to those not already cancelled. To test: - have a basket with at least one order - click "Cancel order and delete catalog record", confirm cancellation of order and deletion of bib - click "Delete basket", confirm deletion - get error "Cannot insert order: Mandatory parameter biblionumber is missing at /kohadevbox/koha/acqui/basket.pl line 136. at /usr/share/perl/5.28/Carp.pm line 289" - apply patch - restart - delete the basket - success! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29283] Cannot delete basket with cancelled order for deleted biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29283 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
