[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-12-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Pushed to oldstable |RESOLVED
 CC||vic...@tuxayo.net
 Resolution|--- |FIXED

--- Comment #26 from Victor Grousset/tuxayo  ---
Missing dependencies for 20.11.x, it shouldn't be affected, no backport.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-12-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Version(s)|22.05.00,21.11.01   |22.05.00,21.11.01,21.05.08
released in||
 Status|Pushed to stable|Pushed to oldstable

--- Comment #25 from Andrew Fuerste-Henry  ---
Pushed to 21.05.x for 21.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-12-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Pushed to master|Pushed to stable
 Version(s)|22.05.00|22.05.00,21.11.01
released in||

--- Comment #24 from Kyle M Hall  ---
Pushed to 21.11.x for 21.11.01

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-12-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com
  Text to go in the||Up until Koha 20.11 the
  release notes||pickup location when
   ||placing item-level holds
   ||was the currently logged-in
   ||library.
   ||
   ||From Koha 21.05
   ||the holding branch was used
   ||as the default.
   ||
   ||This
   ||restores the previous
   ||behaviour so that the
   ||logged-in library (if a
   ||valid pickup location) is
   ||selected as the default
   ||pickup location for
   ||item-level holds. When it
   ||is not, an empty dropdown
   ||is used as a fallback.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-12-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

--- Comment #23 from Fridolin Somers  ---
Pushed to master for 22.05, thanks to everybody involved 濾

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-12-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

Fridolin Somers  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||22.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #22 from Martin Renvoize  ---
This all appears to make sense and passes the QA scripts.. I believe it
resolves the regression and doesn't cause any new ones.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

Martin Renvoize  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe
   |y.org   |.com
 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #128372|0   |1
is obsolete||

--- Comment #21 from Martin Renvoize  ---
Created attachment 128407
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128407=edit
Bug 29349: (follow-up) Fix width of item level dropdowns

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #128370|0   |1
is obsolete||

--- Comment #20 from Martin Renvoize  ---
Created attachment 128406
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128406=edit
Bug 29349: Do not assume holding branch is a valid pickup location

The original code for pickup locations when placing item-level holds
picked the currently logged-in library.

We made things more robust, as the logged-in library might not be a
valid pickup location for the patron and item. But it was wrongly chosen
to use the holding branch as the default.

A more robust approach is needed, and this precedence is picked this
time (it could be configuration-driven in the future):

- Logged-in library
- Empty

To test:
1. Pick a biblio with various valid pickup locations, some not including
   the logged-in library.
2. Pick a patron for placing the hold
=> FAIL: Notice that (when valid pickup location) the holding branch is
always chosen
3. Apply this patch
4. Repeat 2
=> SUCCESS: If valid pickup location, the logged-in branch is picked as
default for item-type level. When it is not, an empty dropdown is used
as a fallback.
5. Sign off :-D

Signed-off-by: Lucas Gass 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

--- Comment #19 from Tomás Cohen Arazi  ---
Signed on the follow-up. Thanks, Lucas!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #128315|0   |1
is obsolete||

--- Comment #18 from Tomás Cohen Arazi  ---
Created attachment 128372
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128372=edit
Bug 29349: (follow-up) Fix width of item level dropdowns

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-12-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-12-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

Lucas Gass  changed:

   What|Removed |Added

 Attachment #128300|0   |1
is obsolete||

--- Comment #17 from Lucas Gass  ---
Created attachment 128370
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128370=edit
Bug 29349: Do not assume holding branch is a valid pickup location

The original code for pickup locations when placing item-level holds
picked the currently logged-in library.

We made things more robust, as the logged-in library might not be a
valid pickup location for the patron and item. But it was wrongly chosen
to use the holding branch as the default.

A more robust approach is needed, and this precedence is picked this
time (it could be configuration-driven in the future):

- Logged-in library
- Empty

To test:
1. Pick a biblio with various valid pickup locations, some not including
   the logged-in library.
2. Pick a patron for placing the hold
=> FAIL: Notice that (when valid pickup location) the holding branch is
always chosen
3. Apply this patch
4. Repeat 2
=> SUCCESS: If valid pickup location, the logged-in branch is picked as
default for item-type level. When it is not, an empty dropdown is used
as a fallback.
5. Sign off :-D

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

--- Comment #16 from Christopher Brannon  ---
(In reply to Donna from comment #10)
> From a workflow point of view, logged in makes sense as the first choice.  I
> feel the second option should be blank.  That indicates to staff that there
> is something unusual about this hold, and they need to verify the pickup
> location.  If we make alpha the second choice then we will be back at square
> one with staff placing holds for pickups at locations that may never fill. 
> The idea behind this change originally was to prevent unfillable holds, so
> we need to keep that in mind.
> 
> I think the main issue was that users did not fully understand why the
> change was made. We just need to make sure that it is clearly explained why
> the change is being made.

+1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

--- Comment #15 from Lucas Gass  ---
Created attachment 128315
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128315=edit
Bug 29349: (follow-up) Fix width of item level dropdowns

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-12-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

--- Comment #14 from Tomás Cohen Arazi  ---
(In reply to Donna from comment #10)
> From a workflow point of view, logged in makes sense as the first choice.  I
> feel the second option should be blank.  That indicates to staff that there
> is something unusual about this hold, and they need to verify the pickup
> location.  If we make alpha the second choice then we will be back at square
> one with staff placing holds for pickups at locations that may never fill. 
> The idea behind this change originally was to prevent unfillable holds, so
> we need to keep that in mind.
> 
> I think the main issue was that users did not fully understand why the
> change was made. We just need to make sure that it is clearly explained why
> the change is being made.

Agreed, patch adjusted.

If we need more options for special use cases, we will need to consider
separate bug, and more complex configurations.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-12-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #128233|0   |1
is obsolete||

--- Comment #13 from Tomás Cohen Arazi  ---
Created attachment 128300
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128300=edit
Bug 29349: Do not assume holding branch is a valid pickup location

The original code for pickup locations when placing item-level holds
picked the currently logged-in library.

We made things more robust, as the logged-in library might not be a
valid pickup location for the patron and item. But it was wrongly chosen
to use the holding branch as the default.

A more robust approach is needed, and this precedence is picked this
time (it could be configuration-driven in the future):

- Logged-in library
- Empty

To test:
1. Pick a biblio with various valid pickup locations, some not including
   the logged-in library.
2. Pick a patron for placing the hold
=> FAIL: Notice that (when valid pickup location) the holding branch is
always chosen
3. Apply this patch
4. Repeat 2
=> SUCCESS: If valid pickup location, the logged-in branch is picked as
default for item-type level. When it is not, an empty dropdown is used
as a fallback.
5. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-12-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

--- Comment #12 from Katrin Fischer  ---
(In reply to Lucas Gass from comment #11)
> (In reply to Donna from comment #10)
> > From a workflow point of view, logged in makes sense as the first choice.  I
> > feel the second option should be blank.  That indicates to staff that there
> > is something unusual about this hold, and they need to verify the pickup
> > location.  If we make alpha the second choice then we will be back at square
> > one with staff placing holds for pickups at locations that may never fill. 
> > The idea behind this change originally was to prevent unfillable holds, so
> > we need to keep that in mind.
> > 
> > I think the main issue was that users did not fully understand why the
> > change was made. We just need to make sure that it is clearly explained why
> > the change is being made.
> 
> +1

+1 :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-12-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

--- Comment #11 from Lucas Gass  ---
(In reply to Donna from comment #10)
> From a workflow point of view, logged in makes sense as the first choice.  I
> feel the second option should be blank.  That indicates to staff that there
> is something unusual about this hold, and they need to verify the pickup
> location.  If we make alpha the second choice then we will be back at square
> one with staff placing holds for pickups at locations that may never fill. 
> The idea behind this change originally was to prevent unfillable holds, so
> we need to keep that in mind.
> 
> I think the main issue was that users did not fully understand why the
> change was made. We just need to make sure that it is clearly explained why
> the change is being made.

+1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-12-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

--- Comment #10 from Donna  ---
From a workflow point of view, logged in makes sense as the first choice.  I
feel the second option should be blank.  That indicates to staff that there is
something unusual about this hold, and they need to verify the pickup location.
 If we make alpha the second choice then we will be back at square one with
staff placing holds for pickups at locations that may never fill.  The idea
behind this change originally was to prevent unfillable holds, so we need to
keep that in mind.

I think the main issue was that users did not fully understand why the change
was made. We just need to make sure that it is clearly explained why the change
is being made.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

--- Comment #9 from Phil Ringnalda  ---
Alphabetically-first is also used for bib-level holds in the case where either
the logged-in library isn't a valid pickup location at all, or is not a valid
pickup location for any of the items.

Should we also change that to blank, guessing without having yet had feedback
from people using local hold groups that alphabetically-first is a bad idea, or
should we take this patch to restore the previous behavior for people who do
not use local hold groups while retaining consistent behavior between bib-level
and item-level for people who do use them, and then find out from feedback
whether alphabetically-first for people who do use them is worse than blank?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

--- Comment #8 from Lucas Gass  ---
Thanks Tomas. 

I am wondering if we should change how this falls back if the pickup location
is not valid. I think it should be:

- Logged-in library
- Holding branch
- Empty/blank

Instead of defaulting to the first choice alphabetically for the 3rd fallback
we should set no value. This seems like it would be a rare occurrence that the
logged in library and the holding branch are not valid pickup locations but if
it does happen I think it can cause confusion. By leaving it empty it forces
librarians to make a decision and I think in this case that is good.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

Tomás Cohen Arazi  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=28919

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

--- Comment #7 from Tomás Cohen Arazi  ---
Created attachment 128233
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128233=edit
Bug 29349: Do not assume holding branch is a valid pickup location

The original code for pickup locations when placing item-level holds
picked the currently logged-in library.

We made things more robust, as the logged-in library might not be a
valid pickup location for the patron and item. But it was wrongly chosen
to use the holding branch as the default.

A more robust approach is needed, and this precedence is picked this
time (it could be configuration-driven in the future):

- Logged-in library
- Holding branch
- The first valid pickup location the above are not valid

To test:
1. Pick a biblio with various valid pickup locations, some not including
   the logged-in library.
2. Pick a patron for placing the hold
=> FAIL: Notice that (when valid pickup location) the holding branch is
always chosen
3. Apply this patch
4. Repeat 2
=> SUCCESS: If valid pickup location, the logged-in branch is picked as
default for item-type level. When it is not, the holding branch is
picked, and if not, some of the valid pickup locations is selected (i.e.
there's no empty dropdowns)
5. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

Todd Goatley  changed:

   What|Removed |Added

 CC||tgoat...@gmail.com

--- Comment #6 from Todd Goatley  ---
We have received requests from libraries asking that this please be fixed as
soon as possible.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

Stacey Nix  changed:

   What|Removed |Added

 CC||snix@coastlinelibrarynetwor
   ||k.org

--- Comment #5 from Stacey Nix  ---
We are also a consortium and we need to be able to have item level hold set to
send them to the pickup location chosen by the patron.  It is currently setting
it at the pickup location as the home library and that does not work for us at
all.  Please fix this and set it back the way it was!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

Carolyn Hughesman  changed:

   What|Removed |Added

 CC||chughes...@cclsny.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-12-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com
   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-12-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

Phil Ringnalda  changed:

   What|Removed |Added

 Depends on||28338


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28338
[Bug 28338] Validate item holdability and pickup location separately
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-11-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

Phil Ringnalda  changed:

   What|Removed |Added

 CC||p...@chetcolibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

--- Comment #4 from Christopher Brannon  ---
From a consortium point of view, it is always going to be about where the
patron is going to pick up.  I know that there are already settings that define
where items should default to pickup, and this should really adhere to those
existing settings.  I'm not sure why a pickup location should change if the
hold is bib-level or item-level.  That seems a bit nit-picky and tedious to
manage.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

--- Comment #3 from Lucas Gass  ---
I meant items home location, not items hold location

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #2 from Lucas Gass  ---
Does this need to be a configuration option? I'd imagine some libraries would
like those item level dropdowns to default to the items hold location.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

Michelle Carrillo  changed:

   What|Removed |Added

 CC||mcarri...@roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-11-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

Nathan Walker  changed:

   What|Removed |Added

 CC||nathan.walker@citruslibrari
   ||es.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-10-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||regression

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-10-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

Christopher Brannon  changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org

--- Comment #1 from Christopher Brannon  ---
This is a drastic setback.  This needs to be fixed ASAP!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-10-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

Andrew Fuerste-Henry  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=23659

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-10-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

Donna  changed:

   What|Removed |Added

 CC||bwsdo...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/