[Koha-bugs] [Bug 29390] Authorised values: Why not adding the FK on the way?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29390 --- Comment #15 from Marcel de Rooy --- Created attachment 152734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152734=edit Bug 29390: Remove unexisting Unititle from marc21_framework_DEFAULT This applies to new installs only. If you run the dbrev, you may have seen: Found the following bad authorised values categories in marc_tag_structure: Unititle Have set these values in marc_tag_structure to NULL No separate test plan. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29390] Authorised values: Why not adding the FK on the way?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29390 --- Comment #14 from Marcel de Rooy --- Created attachment 152733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152733=edit Bug 29390: Rename atomicupdate file Renamed bug number too. Added a count since an existing FK or an error may impact the count (not to mention running the dbrev multiple times). Remove Dumper. Test plan: If running it previously worked, run it again and see 0 added. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29390] Authorised values: Why not adding the FK on the way?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29390 --- Comment #13 from Marcel de Rooy --- Created attachment 152732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152732=edit Bug 29390: Fix syntax error in atomic update Test plan: Run dbrev or new install. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29390] Authorised values: Why not adding the FK on the way?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29390 --- Comment #12 from Marcel de Rooy --- Created attachment 152731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152731=edit Bug 29390: Add a few missing FK constraints to authorised values Test plan: See next patch. Resolving syntax error here. Run dbrev or new install. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29390] Authorised values: Why not adding the FK on the way?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29390 Marcel de Rooy changed: What|Removed |Added Attachment #127214|0 |1 is obsolete|| Attachment #127215|0 |1 is obsolete|| Attachment #128985|0 |1 is obsolete|| --- Comment #11 from Marcel de Rooy --- Created attachment 152730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152730=edit Bug 29390: Allow to check on FK existence with field name Sometimes easier (or even safer) to check for FK on specific field name rather than constraint name (which may be created automatically). Test plan: Run t/db_dependent/Installer.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29390] Authorised values: Why not adding the FK on the way?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29390 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29390] Authorised values: Why not adding the FK on the way?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29390 --- Comment #10 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #9) > Ping? Working on this right now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29390] Authorised values: Why not adding the FK on the way?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29390 --- Comment #9 from Katrin Fischer --- Ping? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29390] Authorised values: Why not adding the FK on the way?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29390 --- Comment #8 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #7) > (In reply to Marcel de Rooy from comment #6) > > Coming back here soon. > > Still interested in working on this? Yes. Sorry, it dropped a bit on my list. But it is still there ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29390] Authorised values: Why not adding the FK on the way?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29390 --- Comment #7 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #6) > Coming back here soon. Still interested in working on this? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29390] Authorised values: Why not adding the FK on the way?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29390 Bug 29390 depends on bug 29336, which changed state. Bug 29336 Summary: Some authorised_value FKs are too short https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 What|Removed |Added Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29390] Authorised values: Why not adding the FK on the way?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29390 --- Comment #6 from Marcel de Rooy --- Coming back here soon. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29390] Authorised values: Why not adding the FK on the way?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29390 --- Comment #5 from Jonathan Druart --- Created attachment 128985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128985=edit Bug 29390: Fix syntax error in atomic update -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29390] Authorised values: Why not adding the FK on the way?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29390 --- Comment #4 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #3) > Any advice, Jonathan, as to best way to proceed here ? About? The atomic updates look good to me. There are some typos I am going to fix. One thing maybe: installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml: authorised_value: Unititle "Unititle" does not exist in the AV list of the sample data. What else would be needed? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29390] Authorised values: Why not adding the FK on the way?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29390 Marcel de Rooy changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl |ity.org | CC||jonathan.druart+koha@gmail. ||com Status|NEW |ASSIGNED --- Comment #3 from Marcel de Rooy --- Any advice, Jonathan, as to best way to proceed here ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29390] Authorised values: Why not adding the FK on the way?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29390 --- Comment #2 from Marcel de Rooy --- Created attachment 127215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127215=edit Bug 29390: Add a few missing FK constraints to authorised values Test plan: Run dbrev or new install. WORK IN PROGRESS -- POSTPONED 02-11-2021 * Fix constraint names * Fix table order -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29390] Authorised values: Why not adding the FK on the way?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29390 --- Comment #1 from Marcel de Rooy --- Created attachment 127214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127214=edit Bug 29390: Allow to check on FK existence with field name Sometimes easier (or even safer) to check for FK on specific field name rather than constraint name (which may be created automatically). Test plan: Run t/db_dependent/Installer.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29390] Authorised values: Why not adding the FK on the way?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29390 Marcel de Rooy changed: What|Removed |Added Blocks||5334 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 [Bug 5334] Omnibus: Add explicit foreign key constraints -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29390] Authorised values: Why not adding the FK on the way?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29390 Marcel de Rooy changed: What|Removed |Added Depends on||29336 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 [Bug 29336] Some authorised_value FKs are too short -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
