[Koha-bugs] [Bug 29407] Make the pickup locations dropdown JS reusable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 Kyle M Hall changed: What|Removed |Added Resolution|--- |FIXED CC||k...@bywatersolutions.com Status|Pushed to master|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29407] Make the pickup locations dropdown JS reusable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 Bug 29407 depends on bug 29404, which changed state. Bug 29404 Summary: Add infinite scrolling to pickup location dropdowns https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29404 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29407] Make the pickup locations dropdown JS reusable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 --- Comment #8 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29407] Make the pickup locations dropdown JS reusable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 Jonathan Druart changed: What|Removed |Added Version(s)||21.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29407] Make the pickup locations dropdown JS reusable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #7 from Martin Renvoize --- Nice bit of code cleanup and DRYing out. No regressions found, QA script is happy, and code is clear. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29407] Make the pickup locations dropdown JS reusable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 Martin Renvoize changed: What|Removed |Added Attachment #127316|0 |1 is obsolete|| --- Comment #6 from Martin Renvoize --- Created attachment 127319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127319=edit Bug 29407: Make the pickup locations dropdown JS reusable This patch generates a function to be used in places where select2 dropdowns are usesd for choosing pickup locations. This cleans repeated/almost identical code introduced by different bugs. To test: 1. Make sure choosing pickup locations works 2. Apply this patch 3. Repeat 1 => SUCCESS: No functional changes 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29407] Make the pickup locations dropdown JS reusable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 Nick Clemens changed: What|Removed |Added Attachment #127278|0 |1 is obsolete|| --- Comment #5 from Nick Clemens --- Created attachment 127316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127316=edit Bug 29407: Make the pickup locations dropdown JS reusable This patch generates a function to be used in places where select2 dropdowns are usesd for choosing pickup locations. This cleans repeated/almost identical code introduced by different bugs. To test: 1. Make sure choosing pickup locations works 2. Apply this patch 3. Repeat 1 => SUCCESS: No functional changes 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29407] Make the pickup locations dropdown JS reusable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29407] Make the pickup locations dropdown JS reusable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 --- Comment #4 from Tomás Cohen Arazi --- Small style fixes in the comments. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29407] Make the pickup locations dropdown JS reusable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 Tomás Cohen Arazi changed: What|Removed |Added Attachment #127277|0 |1 is obsolete|| --- Comment #3 from Tomás Cohen Arazi --- Created attachment 127278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127278=edit Bug 29407: Make the pickup locations dropdown JS reusable This patch generates a function to be used in places where select2 dropdowns are usesd for choosing pickup locations. This cleans repeated/almost identical code introduced by different bugs. To test: 1. Make sure choosing pickup locations works 2. Apply this patch 3. Repeat 1 => SUCCESS: No functional changes 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29407] Make the pickup locations dropdown JS reusable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 Tomás Cohen Arazi changed: What|Removed |Added Attachment #127269|0 |1 is obsolete|| --- Comment #2 from Tomás Cohen Arazi --- Created attachment 127277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127277=edit Bug 29407: Make the pickup locations dropdown JS reusable This patch generates a function to be used in places where select2 dropdowns are usesd for choosing pickup locations. This cleans repeated/almost identical code introduced by different bugs. To test: 1. Make sure choosing pickup locations works 2. Apply this patch 3. Repeat 1 => SUCCESS: No functional changes 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29407] Make the pickup locations dropdown JS reusable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 Tomás Cohen Arazi changed: What|Removed |Added Blocks||29397 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29397 [Bug 29397] Add a select2 wrapper for the API -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29407] Make the pickup locations dropdown JS reusable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 Tomás Cohen Arazi changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com, ||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29407] Make the pickup locations dropdown JS reusable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 127269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127269=edit Bug 29407: Make the pickup locations dropdown JS reusable This patch generates a function to be used in places where select2 dropdowns are usesd for choosing pickup locations. This cleans repeated/almost identical code introduced by different bugs. To test: 1. Make sure choosing pickup locations works 2. Apply this patch 3. Repeat 1 => SUCCESS: No functional changes 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29407] Make the pickup locations dropdown JS reusable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 Tomás Cohen Arazi changed: What|Removed |Added Depends on||29404 Status|NEW |Needs Signoff Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29404 [Bug 29404] Add infinite scrolling to pickup location dropdowns -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
