[Koha-bugs] [Bug 29418] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 Tomás Cohen Arazi changed: What|Removed |Added Version|21.11 |21.05 Summary|Zebra clean_search_term |Error searching for |does not clean search and |analytics in detail view |so results in error | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29418] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29418] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 Tomás Cohen Arazi changed: What|Removed |Added Attachment #134865|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29418] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 Tomás Cohen Arazi changed: What|Removed |Added Attachment #134866|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29418] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 --- Comment #22 from Tomás Cohen Arazi --- Created attachment 137023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137023&action=edit Bug 29418: Fix error searching for analytics in detail view This patch fixes the problem of searching for analytics when the title contains reserved characters like ? To test: 1. Have a record with ? in the title 2. Open the detail view (staff) => FAIL: tells there's an error checking for analytics 3. Open the detail view (OPAC) => FAIL: tells there's an error checking for analytics 4. Apply this patch and restart all 5. Repeat 2 and 3 => SUCCESS: Link shows correctly! 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29418] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 --- Comment #23 from Katrin Fischer --- I tried with Elasticsearch and Zebra on master, but the error was not shown, is this specific to 21.05? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29418] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 --- Comment #24 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #23) > I tried with Elasticsearch and Zebra on master, but the error was not shown, > is this specific to 21.05? Yes. 21.11 got the Koha::Biblio->get_marc_components method with it's own bugfix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29418] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29418] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 Katrin Fischer changed: What|Removed |Added Attachment #137023|0 |1 is obsolete|| --- Comment #25 from Katrin Fischer --- Created attachment 137048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137048&action=edit Bug 29418: Fix error searching for analytics in detail view This patch fixes the problem of searching for analytics when the title contains reserved characters like ? To test: 1. Have a record with ? in the title 2. Open the detail view (staff) => FAIL: tells there's an error checking for analytics 3. Open the detail view (OPAC) => FAIL: tells there's an error checking for analytics 4. Apply this patch and restart all 5. Repeat 2 and 3 => SUCCESS: Link shows correctly! 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29418] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #26 from David Nind --- This is now signed off by Katrin, but here are my testing notes for what they are worth! I'm not very familiar with analytical records, and I wasn't sure whether the ? should be in the host record or the child/analytical record. I tried combinations for the host record and the child/analytical record, and for both. I haven't changed the bug status. (Hopefully, I recorded my observations correctly!) Testing notes using koha-testing-docker === Starting 21.05.x instance: a) For Koha repository, git checkout 21.05.x b) Edit koha-testing-docker .env file and change IMAGE=master to IMAGE=21.05 Set up an analytical record: a) Enable the EasyAnalyticalRecords system preference b) For any record, select Edit > Link to host record - choose any other record (I tested with a record that had an item already attached to it) c) For the record chosen as the host item, add a ? to the title Used two records for testing: - Host record: Programming Perl (biblionumber = 262) - Child/analytical record: Perl best practices (biblionumber = 5) Before the patch is applied ~~~ 1. If only the host record has a ? in the title: - Viewing the host record in the staff interface - error displayed before the title: "There was an error searching for analytic records, please see the logs for details." - Viewing the host record in the OPAC - no visible error message displayed (like in the staff interface), but there is an error message in the /var/log/koha/kohadev/plack-opac-error.log log file: [2022/07/03 22:39:46] [WARN] CCL parsing error (10014) Embedded truncation not supported ZOOM for query: Host-item=(Programming ? Perl /) at /kohadevbox/koha/C4/Search.pm line 241. [2022/07/03 22:39:46] [WARN] Warning from simple_search_compat: CCL parsing error (10014) Embedded truncation not supported ZOOM at /kohadevbox/koha/opac/opac-detail.pl line 208. 2. If only the child/analytical record has a ? in the title: - Staff interface: . Host record displays 'Analytics: Show analytics' . Clicking on 'Show analytics' link displays the child/analytical record . Error displayed before the title in the child/analytical record: "There was an error searching for analytic records, please see the logs for details." - Viewing the host record in the OPAC . no error displayed . displays 'Analytics: Show analytics' . clicking on show analytics: child/analytical record displayed with no error, but error in the logs as per 1 - Viewing the child/analytical record in the OPAC: . no error displayed . but error in the logs as per 1 3. Both the host and child/analytical record have a ? in the title: . same as 1 for both the host and child/analytical record After the patch is applied ~~ 1. If only the host record has a ? in the title: - Staff interface: . Host record shows 'Analytics: Show analytics', no error messages . Clicking on the 'Show analytics' link: No results match your search for 'Host-item:(Programming ? Perl )'. . Error in the /var/log/koha/kohadev/plack-intranet-error.log log file: [2022/07/03 23:40:01] [WARN] WARNING: query problem with Host-item=(Programming ? Perl ) ZOOM error 10014 "CCL parsing error" (addinfo: "Embedded truncation not supported") from diag-set 'ZOOM' at /kohadevbox/koha/C4/Search.pm line 349. - OPAC: . Host record shows 'Analytics: Show analytics' . Error message in the /var/log/koha/kohadev/plack-opac-error.log log file: [2022/07/03 23:41:25] [WARN] WARNING: query problem with Host-item=(Programming ? Perl ) ZOOM error 10014 "CCL parsing error" (addinfo: "Embedded truncation not supported") from diag-set 'ZOOM' at /kohadevbox/koha/C4/Search.pm line 349. [2022/07/03 23:41:25] [WARN] Use of uninitialized value $times in subtraction (-) at /kohadevbox/koha/C4/Search.pm line 1709. 2. If only the child/analytical record has a ? in the title: works as expected, no errors in the log 3. Both the host and child/analytical record has a ?: - Staff interface and OPAC: . Host record shows 'Analytics: Show analytics' . Clicking on the 'Show analytics' link: No results match your search for 'Host-item:(Programming ? Perl )'. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29418] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 --- Comment #27 from Katrin Fischer --- Hm, strange. The hos record having a ? case worked for me. Vut I had added the ? a the end of the string, maybe it could make a difference? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29418] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 --- Comment #28 from David Nind --- (In reply to Katrin Fischer from comment #27) > Hm, strange. The hos record having a ? case worked for me. Vut I had added > the ? a the end of the string, maybe it could make a difference? I had added the ? in the middle of the title. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29418] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |ASSIGNED --- Comment #29 from Tomás Cohen Arazi --- (In reply to David Nind from comment #28) > (In reply to Katrin Fischer from comment #27) > > Hm, strange. The hos record having a ? case worked for me. Vut I had added > > the ? a the end of the string, maybe it could make a difference? > > I had added the ? in the middle of the title. Hi, the internal analytics search works correctly, but a follow-up is required for the XSLT to generate a good link. I overlooked it. Working on it now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29418] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29418] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 Tomás Cohen Arazi changed: What|Removed |Added Attachment #137048|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29418] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 --- Comment #30 from Tomás Cohen Arazi --- Created attachment 137135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137135&action=edit Bug 29418: Unit tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29418] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 --- Comment #31 from Tomás Cohen Arazi --- Created attachment 137136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137136&action=edit Bug 29418: Make clean_search_term escape double quotes We noticed that several characters will break Zebra queries. So search terms need to be quoted for things to work. In this context, double quotes inside search terms are problematic because double quotes are what we use for quoting strings. This patch makes the clean_search_term method escape double quotes. To test: 1. Apply the unit tests patch 2. Run: $ kshell k$ prove t/Koha/SearchEngine/Zebra/QueryBuilder.t => FAIL: It doesn't work as it should! 3. Apply this patch 4. Repeat 2 => SUCCESS: It does the job! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29418] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 --- Comment #32 from Tomás Cohen Arazi --- Created attachment 137137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137137&action=edit Bug 29418: Make detail rendering use the cleaned-up title for searching This patch makes both staff and OPAC detail pages generate a valid search link so you can trace related records in the Show analytics link. To test: 1. Pick a bibliographic record (I chose 'Unconditional' from the sample data 2. Add " and ? to the title statement. I changed it to 'Uncond"itional?¿' 3. Add a child record to it 4. Open the detail page for the host record => FAIL: It doesn't show the 'Show analytics' link 5. Repeat 4 for the same record, in the OPAC => FAIL: It doesn't show the 'Show analytics' link 6. Apply this patch 7. Repeat 4 and 5. => SUCCESS: Links are shown! 8. Follow the links => SUCCESS: The links take you to the right resultset! 9. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29418] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29418] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 David Nind changed: What|Removed |Added Attachment #137135|0 |1 is obsolete|| --- Comment #33 from David Nind --- Created attachment 137138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137138&action=edit Bug 29418: Unit tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29418] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 David Nind changed: What|Removed |Added Attachment #137136|0 |1 is obsolete|| --- Comment #34 from David Nind --- Created attachment 137139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137139&action=edit Bug 29418: Make clean_search_term escape double quotes We noticed that several characters will break Zebra queries. So search terms need to be quoted for things to work. In this context, double quotes inside search terms are problematic because double quotes are what we use for quoting strings. This patch makes the clean_search_term method escape double quotes. To test: 1. Apply the unit tests patch 2. Run: $ kshell k$ prove t/Koha/SearchEngine/Zebra/QueryBuilder.t => FAIL: It doesn't work as it should! 3. Apply this patch 4. Repeat 2 => SUCCESS: It does the job! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29418] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 David Nind changed: What|Removed |Added Attachment #137137|0 |1 is obsolete|| --- Comment #35 from David Nind --- Created attachment 137140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137140&action=edit Bug 29418: Make detail rendering use the cleaned-up title for searching This patch makes both staff and OPAC detail pages generate a valid search link so you can trace related records in the Show analytics link. To test: 1. Pick a bibliographic record (I chose 'Unconditional' from the sample data 2. Add " and ? to the title statement. I changed it to 'Uncond"itional?¿' 3. Add a child record to it 4. Open the detail page for the host record => FAIL: It doesn't show the 'Show analytics' link 5. Repeat 4 for the same record, in the OPAC => FAIL: It doesn't show the 'Show analytics' link 6. Apply this patch 7. Repeat 4 and 5. => SUCCESS: Links are shown! 8. Follow the links => SUCCESS: The links take you to the right resultset! 9. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29418] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 --- Comment #36 from Tomás Cohen Arazi --- Created attachment 137142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137142&action=edit Bug 29418: (follow-up) Fix links generated in XSLTs This patch addresses the case of links that are generated on the XSLT side, those linking to host records using 773$t and 773$a. To test: 1. Repeat the test plan from the other patches 2. When sitting on the detail view of the host record, click on the link to open the child. => SUCCESS: The link works, because of the previous patches 3. Click on the 'In:' link so the search takes you to the host record => FAIL: The link leads no results 4. Apply this patch 5. Restart all 6. Reload the child record page and click on the link => SUCCESS: Voila! The host record is retrieved! 7. Bonus points: Retry the full test plan, but add a " or ? to the author in both host and child records => SUCCESS: Things don't work before this patch, and work afterwards. 8. Sign off :-D Sponsored-by: Theke Solutions Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29418] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 Tomás Cohen Arazi changed: What|Removed |Added Assignee|n...@bywatersolutions.com |tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29418] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 Martin Renvoize changed: What|Removed |Added Attachment #137138|0 |1 is obsolete|| --- Comment #37 from Martin Renvoize --- Created attachment 137171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137171&action=edit Bug 29418: Unit tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29418] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 Martin Renvoize changed: What|Removed |Added Attachment #137139|0 |1 is obsolete|| --- Comment #38 from Martin Renvoize --- Created attachment 137172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137172&action=edit Bug 29418: Make clean_search_term escape double quotes We noticed that several characters will break Zebra queries. So search terms need to be quoted for things to work. In this context, double quotes inside search terms are problematic because double quotes are what we use for quoting strings. This patch makes the clean_search_term method escape double quotes. To test: 1. Apply the unit tests patch 2. Run: $ kshell k$ prove t/Koha/SearchEngine/Zebra/QueryBuilder.t => FAIL: It doesn't work as it should! 3. Apply this patch 4. Repeat 2 => SUCCESS: It does the job! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29418] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 Martin Renvoize changed: What|Removed |Added Attachment #137140|0 |1 is obsolete|| --- Comment #39 from Martin Renvoize --- Created attachment 137173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137173&action=edit Bug 29418: Make detail rendering use the cleaned-up title for searching This patch makes both staff and OPAC detail pages generate a valid search link so you can trace related records in the Show analytics link. To test: 1. Pick a bibliographic record (I chose 'Unconditional' from the sample data 2. Add " and ? to the title statement. I changed it to 'Uncond"itional?¿' 3. Add a child record to it 4. Open the detail page for the host record => FAIL: It doesn't show the 'Show analytics' link 5. Repeat 4 for the same record, in the OPAC => FAIL: It doesn't show the 'Show analytics' link 6. Apply this patch 7. Repeat 4 and 5. => SUCCESS: Links are shown! 8. Follow the links => SUCCESS: The links take you to the right resultset! 9. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29418] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 Martin Renvoize changed: What|Removed |Added Attachment #137142|0 |1 is obsolete|| --- Comment #40 from Martin Renvoize --- Created attachment 137174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137174&action=edit Bug 29418: (follow-up) Fix links generated in XSLTs This patch addresses the case of links that are generated on the XSLT side, those linking to host records using 773$t and 773$a. To test: 1. Repeat the test plan from the other patches 2. When sitting on the detail view of the host record, click on the link to open the child. => SUCCESS: The link works, because of the previous patches 3. Click on the 'In:' link so the search takes you to the host record => FAIL: The link leads no results 4. Apply this patch 5. Restart all 6. Reload the child record page and click on the link => SUCCESS: Voila! The host record is retrieved! 7. Bonus points: Retry the full test plan, but add a " or ? to the author in both host and child records => SUCCESS: Things don't work before this patch, and work afterwards. 8. Sign off :-D Sponsored-by: Theke Solutions Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29418] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #41 from Martin Renvoize --- Nice work Tomas, this is a great solution for the 21.05 series. I think we need the follow-up in 21.11+ too however.. and the approach of passing through the analytics_query as a variable (although actually all we pass here is the escaped title) make sense to me for a master additional too.. DRY our code out by passing the constructed and escaped analytics query from our biblio method rather than re-constructing a version in the xslts. All in all.. PQA for this branch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29418] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 --- Comment #42 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #41) > Nice work Tomas, this is a great solution for the 21.05 series. > > I think we need the follow-up in 21.11+ too however.. and the approach of > passing through the analytics_query as a variable (although actually all we > pass here is the escaped title) make sense to me for a master additional > too.. DRY our code out by passing the constructed and escaped analytics > query from our biblio method rather than re-constructing a version in the > xslts. This problem is present in (at least) master, and it doesn't need just the follow-up. I'll file a bug for master to avoid mixing things. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29418] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 Tomás Cohen Arazi changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31106 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29418] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Status|Passed QA |Pushed to oldoldstable Version(s)||21.05.17 released in|| --- Comment #43 from Victor Grousset/tuxayo --- Backported: Pushed to 21.05.x branch for 21.05.17 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29418] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 --- Comment #44 from Tomás Cohen Arazi --- (In reply to Victor Grousset/tuxayo from comment #43) > Backported: Pushed to 21.05.x branch for 21.05.17 Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
