[Koha-bugs] [Bug 29658] Crash on cancelling cancelled order

2021-12-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=29283

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29658] Crash on cancelling cancelled order

2021-12-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29658] Crash on cancelling cancelled order

2021-12-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658

Marcel de Rooy  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29658] Crash on cancelling cancelled order

2021-12-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658

--- Comment #1 from Marcel de Rooy  ---
Created attachment 128364
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128364&action=edit
Bug 29658: Fix crash on cancelling cancelled order

Found this crash in our 20.11 logs:
Cannot insert order: Mandatory parameter biblionumber is missing at
/usr/share/koha/acqui/cancelorder.pl line 60.
 at /usr/share/perl/5.28/Carp.pm line 289
Carp::croak('Cannot insert order: Mandatory parameter biblionumber is
missing') called at /usr/share/koha/Koha/Acquisition/Order.pm line 79
   
Koha::Acquisition::Order::store('Koha::Acquisition::Order=HASH(0x55f3760e2860)')
called at /usr/share/koha/Koha/Acquisition/Order.pm line 189
   
Koha::Acquisition::Order::cancel('Koha::Acquisition::Order=HASH(0x55f3760e2860)',
'HASH(0x55f375a17ec0)') called at /usr/share/koha/acqui/cancelorder.pl line 60

Not sure how to reproduce this one as it happened. But might be related to
repeated clicking, backspacing etc.

Test plan:
Create a new basket and order.
Open this same basket in two browser tabs.
Cancel the order line (delete catalog record) in tab 1.
Go to second tab, try again.
Without this patch, it will crash. With this patch, an error message.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29658] Crash on cancelling cancelled order

2021-12-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29658] Crash on cancelling cancelled order

2021-12-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658

Marcel de Rooy  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29658] Crash on cancelling cancelled order

2021-12-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658

--- Comment #2 from Marcel de Rooy  ---
Hmm, this even opens up new possibilities like:

Can't call method "edi_order" on an undefined value at
/usr/share/koha/acqui/basket.pl line 381

Probably by trying to delete a deleted basket?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29658] Crash on cancelling cancelled order

2021-12-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658

--- Comment #3 from Marcel de Rooy  ---
(In reply to Marcel de Rooy from comment #2)
> Hmm, this even opens up new possibilities like:
> 
> Can't call method "edi_order" on an undefined value at
> /usr/share/koha/acqui/basket.pl line 381
> 
> Probably by trying to delete a deleted basket?

Not sure about that. Cant exactly reproduce. Lets resolve that somewhere else..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29658] Crash on cancelling cancelled order

2021-12-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658

Marcel de Rooy  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29658] Crash on cancelling cancelled order

2022-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658

Séverine Queune  changed:

   What|Removed |Added

 CC||severine.que...@bulac.fr

--- Comment #4 from Séverine Queune  ---
Hi Marcel,
I couldn't reproduce bug on master (devbox).
When I follow test plan, I don't crash on cancelling order a second time.
I checked data on aqorders table and saw that informations saved with the first
cancel action are updated after the second cancel.
I pass my turn on that patch, sorry :/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29658] Crash on cancelling cancelled order

2022-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658

Joonas Kylmälä  changed:

   What|Removed |Added

 CC||joonas.kylm...@iki.fi

--- Comment #5 from Joonas Kylmälä  ---
(In reply to Séverine Queune from comment #4)
> Hi Marcel,
> I couldn't reproduce bug on master (devbox).
> When I follow test plan, I don't crash on cancelling order a second time.
> I checked data on aqorders table and saw that informations saved with the
> first cancel action are updated after the second cancel.
> I pass my turn on that patch, sorry :/

To reproduce you need to add the order to a biblio with 0 items and click twice
 "Cancel order and delete catalog record".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29658] Crash on cancelling cancelled order

2022-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||da...@davidnind.com

--- Comment #6 from David Nind  ---
I was able to reproduce using the tip from Joonas is comment #5 - in
koha-testing-docker I added an order to the basket for record 5 (Perl best
practices) as it has no items.

However, the patch no longer applies 8-(..

git bz apply 29658

Bug 29658 - Crash on cancelling cancelled order

128364 - Bug 29658: Fix crash on cancelling cancelled order

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 29658: Fix crash on cancelling cancelled order
Using index info to reconstruct a base tree...
M   acqui/cancelorder.pl
M   koha-tmpl/intranet-tmpl/prog/en/modules/acqui/cancelorder.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/cancelorder.tt
Auto-merging acqui/cancelorder.pl
CONFLICT (content): Merge conflict in acqui/cancelorder.pl
error: Failed to merge in the changes.
Patch failed at 0001 Bug 29658: Fix crash on cancelling cancelled order

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29658] Crash on cancelling cancelled order

2022-05-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29658] Crash on cancelling cancelled order

2022-07-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658

--- Comment #7 from Ray Delahunty  ---
I’m not sure I understand what ‘cancelling a cancelled order’ actually means
here. We are having a fiscal period close clean-up, and I too receive an
internal server error when I try to delete a basket when all the orders on it
have been cancelled and one or more (or all) of the biblios in the orders have
been deleted. Is this the same thing as is being reported here, or should I
raise a separate bug report? The error I see in our production Koha is simply
‘Internal server error’ but in our test Koha I see: ‘Cannot insert order:
Mandatory parameter biblionumber is missing at
/home/koha/kohaclone/acqui/basket.pl line 141’.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29658] Crash on cancelling cancelled order

2022-07-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658

--- Comment #8 from Marcel de Rooy  ---
(In reply to Ray Delahunty from comment #7)
> I’m not sure I understand what ‘cancelling a cancelled order’ actually means
> here. We are having a fiscal period close clean-up, and I too receive an
> internal server error when I try to delete a basket when all the orders on
> it have been cancelled and one or more (or all) of the biblios in the orders
> have been deleted. Is this the same thing as is being reported here, or
> should I raise a separate bug report? The error I see in our production Koha
> is simply ‘Internal server error’ but in our test Koha I see: ‘Cannot insert
> order: Mandatory parameter biblionumber is missing at
> /home/koha/kohaclone/acqui/basket.pl line 141’.

I should still have a closer look to get this going again but at first sight I
believe that we are talking about the same bug here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29658] Crash on cancelling cancelled order

2022-07-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658

Ray Delahunty  changed:

   What|Removed |Added

 CC||r.delahu...@arts.ac.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29658] Crash on cancelling cancelled order

2022-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29658] Crash on cancelling cancelled order

2022-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #128364|0   |1
is obsolete||

--- Comment #9 from Marcel de Rooy  ---
Created attachment 139126
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139126&action=edit
Bug 29658: Fix crash on cancelling cancelled order

Found this crash in our 20.11 logs:
Cannot insert order: Mandatory parameter biblionumber is missing at
/usr/share/koha/acqui/cancelorder.pl line 60.
 at /usr/share/perl/5.28/Carp.pm line 289
Carp::croak('Cannot insert order: Mandatory parameter biblionumber is
missing') called at /usr/share/koha/Koha/Acquisition/Order.pm line 79
   
Koha::Acquisition::Order::store('Koha::Acquisition::Order=HASH(0x55f3760e2860)')
called at /usr/share/koha/Koha/Acquisition/Order.pm line 189
   
Koha::Acquisition::Order::cancel('Koha::Acquisition::Order=HASH(0x55f3760e2860)',
'HASH(0x55f375a17ec0)') called at /usr/share/koha/acqui/cancelorder.pl line 60

Not sure how to reproduce this one as it happened. But might be related to
repeated clicking, backspacing etc.

Test plan:
Create a new basket and order.
Open this same basket in two browser tabs.
Cancel the order line (delete catalog record) in tab 1.
Go to second tab, try again.
Without this patch, it will crash. With this patch, an error message.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29658] Crash on cancelling cancelled order

2022-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658

--- Comment #10 from Marcel de Rooy  ---
(In reply to Ray Delahunty from comment #7)
> I’m not sure I understand what ‘cancelling a cancelled order’ actually means
> here. We are having a fiscal period close clean-up, and I too receive an
> internal server error when I try to delete a basket when all the orders on
> it have been cancelled and one or more (or all) of the biblios in the orders
> have been deleted. Is this the same thing as is being reported here, or
> should I raise a separate bug report? The error I see in our production Koha
> is simply ‘Internal server error’ but in our test Koha I see: ‘Cannot insert
> order: Mandatory parameter biblionumber is missing at
> /home/koha/kohaclone/acqui/basket.pl line 141’.

Could you test the rebase please ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29658] Crash on cancelling cancelled order

2022-08-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658

--- Comment #11 from Ray Delahunty  ---
I tested using a sandbox provisioned at 22.06 and have had no problems deleting
baskets where the order has been cancelled and the biblio has been deleted. I
tried routine workflow and also following the test plan. I did not receive any
errors- the basket was just deleted without any fuss. When I run the same
workflow in our 21.11 production system I receive the 'Internal server error'
as before. I will ask that our support company apply the patch on our test
server and will try again once that is done.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29658] Crash on cancelling cancelled order

2022-08-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658

Joonas Kylmälä  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29658] Crash on cancelling cancelled order

2022-08-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658

Joonas Kylmälä  changed:

   What|Removed |Added

 Attachment #139126|0   |1
is obsolete||

--- Comment #12 from Joonas Kylmälä  ---
Created attachment 139930
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139930&action=edit
Bug 29658: Fix crash on cancelling cancelled order

Found this crash in our 20.11 logs:
Cannot insert order: Mandatory parameter biblionumber is missing at
/usr/share/koha/acqui/cancelorder.pl line 60.
 at /usr/share/perl/5.28/Carp.pm line 289
Carp::croak('Cannot insert order: Mandatory parameter biblionumber is
missing') called at /usr/share/koha/Koha/Acquisition/Order.pm line 79
   
Koha::Acquisition::Order::store('Koha::Acquisition::Order=HASH(0x55f3760e2860)')
called at /usr/share/koha/Koha/Acquisition/Order.pm line 189
   
Koha::Acquisition::Order::cancel('Koha::Acquisition::Order=HASH(0x55f3760e2860)',
'HASH(0x55f375a17ec0)') called at /usr/share/koha/acqui/cancelorder.pl line 60

Not sure how to reproduce this one as it happened. But might be related to
repeated clicking, backspacing etc.

Test plan:
Create a new basket and order.
Open this same basket in two browser tabs.
Cancel the order line (delete catalog record) in tab 1.
Go to second tab, try again.
Without this patch, it will crash. With this patch, an error message.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Joonas Kylmälä 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29658] Crash on cancelling cancelled order

2022-08-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658

--- Comment #13 from Marcel de Rooy  ---
(In reply to Joonas Kylmälä from comment #12)
> Signed-off-by: Joonas Kylmälä 

Thx Joonas!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29658] Crash on cancelling cancelled order

2022-09-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
 QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe
   |y.org   |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29658] Crash on cancelling cancelled order

2022-09-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #139930|0   |1
is obsolete||

--- Comment #14 from Martin Renvoize  ---
Created attachment 140472
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140472&action=edit
Bug 29658: Fix crash on cancelling cancelled order

Found this crash in our 20.11 logs:
Cannot insert order: Mandatory parameter biblionumber is missing at
/usr/share/koha/acqui/cancelorder.pl line 60.
 at /usr/share/perl/5.28/Carp.pm line 289
Carp::croak('Cannot insert order: Mandatory parameter biblionumber is
missing') called at /usr/share/koha/Koha/Acquisition/Order.pm line 79
   
Koha::Acquisition::Order::store('Koha::Acquisition::Order=HASH(0x55f3760e2860)')
called at /usr/share/koha/Koha/Acquisition/Order.pm line 189
   
Koha::Acquisition::Order::cancel('Koha::Acquisition::Order=HASH(0x55f3760e2860)',
'HASH(0x55f375a17ec0)') called at /usr/share/koha/acqui/cancelorder.pl line 60

Not sure how to reproduce this one as it happened. But might be related to
repeated clicking, backspacing etc.

Test plan:
Create a new basket and order.
Open this same basket in two browser tabs.
Cancel the order line (delete catalog record) in tab 1.
Go to second tab, try again.
Without this patch, it will crash. With this patch, an error message.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Joonas Kylmälä 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29658] Crash on cancelling cancelled order

2022-09-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #15 from Martin Renvoize  ---
Simple fix, no regressions. Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29658] Crash on cancelling cancelled order

2022-09-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Version(s)||22.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29658] Crash on cancelling cancelled order

2022-09-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658

--- Comment #16 from Tomás Cohen Arazi  ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29658] Crash on cancelling cancelled order

2022-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658

--- Comment #17 from Marcel de Rooy  ---
(In reply to Martin Renvoize from comment #15)
> Simple fix, no regressions. Passing QA

Thanks. Even simple fixes can be long on the way ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29658] Crash on cancelling cancelled order

2022-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Version(s)|22.11.00|22.11.00, 22.05.07
released in||
 Status|Pushed to master|Pushed to stable

--- Comment #18 from Lucas Gass  ---
Backported to 22.05.x for upcoming 22.05.07 release

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29658] Crash on cancelling cancelled order

2022-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658

Arthur Suzuki  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 CC||arthur.suz...@biblibre.com
 Version(s)|22.11.00, 22.05.07  |22.11.00, 22.05.07,
released in||21.11.14

--- Comment #19 from Arthur Suzuki  ---
applied to 21.11 for 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29658] Crash on cancelling cancelled order

2022-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net
 Resolution|--- |FIXED
 Status|Pushed to oldstable |RESOLVED

--- Comment #20 from Victor Grousset/tuxayo  ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/