[Koha-bugs] [Bug 29705] Test suite has some IssuingRules left-overs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29705 --- Comment #10 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29705] Test suite has some IssuingRules left-overs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29705 Fridolin Somers changed: What|Removed |Added Version(s)||22.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29705] Test suite has some IssuingRules left-overs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29705 Katrin Fischer changed: What|Removed |Added Attachment #134439|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 134682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134682=edit Bug 29705: In test suite merge IssuingRules with CirculationRules After Bug 18936, in test suite, there is still t/db_dependent/Koha/IssuingRules.t and t/db_dependent/Koha/IssuingRules/ This patch moves IssuingRules.t inside CirculationRules.t and renames dir t/db_dependent/Koha/IssuingRules. And adds DB transation in each first-level subtest. Also renames in : use constant GUESSED_ITEMTYPES_KEY => 'Koha_IssuingRules_last_guess'; Test plan : Run prove t/db_dependent/Koha/CirculationRules.t prove t/db_dependent/Koha/CirculationRules/* prove t/db_dependent/Circulation/maxsuspensiondays.t Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29705] Test suite has some IssuingRules left-overs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29705 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29705] Test suite has some IssuingRules left-overs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29705 --- Comment #8 from Katrin Fischer --- I tried testing here, but the QA test tools get stuck again having me end up on qa-current-commit branch with untracekd files in t/db_dependent/Koha/CirculationRules/ :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29705] Test suite has some IssuingRules left-overs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29705 David Nind changed: What|Removed |Added Attachment #129464|0 |1 is obsolete|| --- Comment #7 from David Nind --- Created attachment 134439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134439=edit Bug 29705: In test suite merge IssuingRules with CirculationRules After Bug 18936, in test suite, there is still t/db_dependent/Koha/IssuingRules.t and t/db_dependent/Koha/IssuingRules/ This patch moves IssuingRules.t inside CirculationRules.t and renames dir t/db_dependent/Koha/IssuingRules. And adds DB transation in each first-level subtest. Also renames in : use constant GUESSED_ITEMTYPES_KEY => 'Koha_IssuingRules_last_guess'; Test plan : Run prove t/db_dependent/Koha/CirculationRules.t prove t/db_dependent/Koha/CirculationRules/* prove t/db_dependent/Circulation/maxsuspensiondays.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29705] Test suite has some IssuingRules left-overs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29705 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29705] Test suite has some IssuingRules left-overs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29705 Fridolin Somers changed: What|Removed |Added Attachment #129138|0 |1 is obsolete|| --- Comment #6 from Fridolin Somers --- Created attachment 129464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129464=edit Bug 29705: In test suite merge IssuingRules with CirculationRules After Bug 18936, in test suite, there is still t/db_dependent/Koha/IssuingRules.t and t/db_dependent/Koha/IssuingRules/ This patch moves IssuingRules.t inside CirculationRules.t and renames dir t/db_dependent/Koha/IssuingRules. And adds DB transation in each first-level subtest. Also renames in : use constant GUESSED_ITEMTYPES_KEY => 'Koha_IssuingRules_last_guess'; Test plan : Run prove t/db_dependent/Koha/CirculationRules.t prove t/db_dependent/Koha/CirculationRules/* prove t/db_dependent/Circulation/maxsuspensiondays.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29705] Test suite has some IssuingRules left-overs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29705 Fridolin Somers changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29705] Test suite has some IssuingRules left-overs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29705 --- Comment #5 from Fridolin Somers --- (In reply to Fridolin Somers from comment #4) > Oups > > t/db_dependent/Koha/IssuingRules.t fails. > We can remove the file. > > And there is still > t/db_dependent/Koha/IssuingRules/guess_article_requestable_itemtypes.t. > We should simply rename forder. I mean t/db_dependent/Circulation/IssuingRules I move maxsuspensiondays.t to parent folder and remove IssuingRules folder -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29705] Test suite has some IssuingRules left-overs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29705 Fridolin Somers changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #4 from Fridolin Somers --- Oups t/db_dependent/Koha/IssuingRules.t fails. We can remove the file. And there is still t/db_dependent/Koha/IssuingRules/guess_article_requestable_itemtypes.t. We should simply rename forder. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29705] Test suite has some IssuingRules left-overs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29705 Jonathan Druart changed: What|Removed |Added Attachment #129045|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 129138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129138=edit Bug 29705: In test suite merge IssuingRules with CirculationRules After Bug 18936, in test suite, there is still t/db_dependent/Koha/IssuingRules.t and t/db_dependent/Koha/IssuingRules/ This patch moves IssuingRules.t inside CirculationRules.t and renames dir t/db_dependent/Koha/IssuingRules. And adds DB transation in each first-level subtest. Also renames in : use constant GUESSED_ITEMTYPES_KEY => 'Koha_IssuingRules_last_guess'; Test plan : Run prove t/db_dependent/Koha/CirculationRules.t and prove t/db_dependent/Koha/CirculationRules/* Signed-off-by: Samu Heiskanen Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29705] Test suite has some IssuingRules left-overs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29705 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29705] Test suite has some IssuingRules left-overs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29705 Samu Heiskanen changed: What|Removed |Added Attachment #128577|0 |1 is obsolete|| --- Comment #2 from Samu Heiskanen --- Created attachment 129045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129045=edit Bug 29705: In test suite merge IssuingRules with CirculationRules After Bug 18936, in test suite, there is still t/db_dependent/Koha/IssuingRules.t and t/db_dependent/Koha/IssuingRules/ This patch moves IssuingRules.t inside CirculationRules.t and renames dir t/db_dependent/Koha/IssuingRules. And adds DB transation in each first-level subtest. Also renames in : use constant GUESSED_ITEMTYPES_KEY => 'Koha_IssuingRules_last_guess'; Test plan : Run prove t/db_dependent/Koha/CirculationRules.t and prove t/db_dependent/Koha/CirculationRules/* Signed-off-by: Samu Heiskanen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29705] Test suite has some IssuingRules left-overs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29705 Samu Heiskanen changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29705] Test suite has some IssuingRules left-overs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29705 --- Comment #1 from Fridolin Somers --- Created attachment 128577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128577=edit Bug 29705: In test suite merge IssuingRules with CirculationRules After Bug 18936, in test suite, there is still t/db_dependent/Koha/IssuingRules.t and t/db_dependent/Koha/IssuingRules/ This patch moves IssuingRules.t inside CirculationRules.t and renames dir t/db_dependent/Koha/IssuingRules. And adds DB transation in each first-level subtest. Also renames in : use constant GUESSED_ITEMTYPES_KEY => 'Koha_IssuingRules_last_guess'; Test plan : Run prove t/db_dependent/Koha/CirculationRules.t and prove t/db_dependent/Koha/CirculationRules/* -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29705] Test suite has some IssuingRules left-overs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29705 Fridolin Somers changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29705] Test suite has some IssuingRules left-overs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29705 Fridolin Somers changed: What|Removed |Added Assignee|ch...@bigballofwax.co.nz|fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29705] Test suite has some IssuingRules left-overs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29705 Fridolin Somers changed: What|Removed |Added Depends on||18936 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 [Bug 18936] Move issuingrules into circulation_rules -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
