[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Martin Renvoize changed: What|Removed |Added Blocks|30385 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30385 [Bug 30385] Standardize our swagger yaml spec files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Martin Renvoize changed: What|Removed |Added Blocks||30542 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30542 [Bug 30542] Use x-koha-embed parameter definition -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Martin Renvoize changed: What|Removed |Added Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #68 from Martin Renvoize --- Follow-up pushed as RM assistant to get people back up and running. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Martin Renvoize changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #67 from Martin Renvoize --- *** Bug 30537 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Tomás Cohen Arazi changed: What|Removed |Added Blocks||30536 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 [Bug 30536] Embeds should be defined in a single place -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Tomás Cohen Arazi changed: What|Removed |Added Keywords||additional_work_needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #66 from Tomás Cohen Arazi --- Created attachment 133285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133285&action=edit Bug 29810: Fix patron embed definitions Due to a race and a bad rebase, the patrons embeds added on bug 30063 didn't get copied to the parameters secition, thus breaking embedding. To test: 1. In master, open the patron search page and the inspector 2. Perform a search => FAIL: No results => FAIL: There's an error 500 in the API response, mentioning embedding is not allowed 3. Apply this patch 4. Restart all 6. Repeat 2 => SUCCESS: Results are back! => SUCCESS: No more API errors 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #65 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Fridolin Somers changed: What|Removed |Added Version(s)||22.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #64 from Tomás Cohen Arazi --- (In reply to Fridolin Somers from comment #55) > Sorry does not apply anymore since Bug 30394 > Rebase looks easy but i prefer it is done the author ;) Done :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #63 from Tomás Cohen Arazi --- Created attachment 133070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133070&action=edit Bug 29810: Add 'x-koha-embed' to reserved words The maintainers of Mojolicious::Plugin::OpenAPI and friends fixed the problem with using collectionFormat for Headers in the upstream library. However, this highlighted an outstanding issue in our code when I ran the unit tests. We have not been stripping x-koha-embed at the query level as it did not exist in the reserved_words list. This patch resolves that and gets the acquisitions_orders test passing again. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #62 from Tomás Cohen Arazi --- Created attachment 133069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133069&action=edit Bug 29810: Document x-koha-embed header on orders endpoints Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #61 from Tomás Cohen Arazi --- Created attachment 133068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133068&action=edit Bug 29810: Document x-koha-embed header on libraries endpoints Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #60 from Tomás Cohen Arazi --- Created attachment 133067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133067&action=edit Bug 29810: Document x-koha-embed header on cash registers endpoints Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #59 from Tomás Cohen Arazi --- Created attachment 133066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133066&action=edit Bug 29810: Document x-koha-embed header on biblios endpoints Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #58 from Tomás Cohen Arazi --- Created attachment 133065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133065&action=edit Bug 29810: Document x-koha-embed header on checkouts endpoints Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #57 from Tomás Cohen Arazi --- Created attachment 133064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133064&action=edit Bug 29810: Document x-koha-embed header on patrons endpoints Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #56 from Tomás Cohen Arazi --- Created attachment 133063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133063&action=edit Bug 29810: Add summary of x-koha-embed header to api spec Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Tomás Cohen Arazi changed: What|Removed |Added Attachment #132348|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Tomás Cohen Arazi changed: What|Removed |Added Attachment #132347|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Tomás Cohen Arazi changed: What|Removed |Added Attachment #132346|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Tomás Cohen Arazi changed: What|Removed |Added Attachment #132345|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Tomás Cohen Arazi changed: What|Removed |Added Attachment #132344|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Tomás Cohen Arazi changed: What|Removed |Added Attachment #132343|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Tomás Cohen Arazi changed: What|Removed |Added Attachment #132342|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Tomás Cohen Arazi changed: What|Removed |Added Attachment #132341|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Tomás Cohen Arazi changed: What|Removed |Added Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Fridolin Somers changed: What|Removed |Added Status|Passed QA |Patch doesn't apply CC||fridolin.som...@biblibre.co ||m --- Comment #55 from Fridolin Somers --- Sorry does not apply anymore since Bug 30394 Rebase looks easy but i prefer it is done the author ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Bug 29810 depends on bug 30194, which changed state. Bug 30194 Summary: Update required JSON::Validator version https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30194 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #54 from Jonathan Druart --- Created attachment 132348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132348&action=edit Bug 29810: Add 'x-koha-embed' to reserved words The maintainers of Mojolicious::Plugin::OpenAPI and friends fixed the problem with using collectionFormat for Headers in the upstream library. However, this highlighted an outstanding issue in our code when I ran the unit tests. We have not been stripping x-koha-embed at the query level as it did not exist in the reserved_words list. This patch resolves that and gets the acquisitions_orders test passing again. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #53 from Jonathan Druart --- Created attachment 132347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132347&action=edit Bug 29810: Document x-koha-embed header on orders endpoints Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #52 from Jonathan Druart --- Created attachment 132346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132346&action=edit Bug 29810: Document x-koha-embed header on libraries endpoints Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #51 from Jonathan Druart --- Created attachment 132345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132345&action=edit Bug 29810: Document x-koha-embed header on cash registers endpoints Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #50 from Jonathan Druart --- Created attachment 132344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132344&action=edit Bug 29810: Document x-koha-embed header on biblios endpoints Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #49 from Jonathan Druart --- Created attachment 132343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132343&action=edit Bug 29810: Document x-koha-embed header on checkouts endpoints Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #48 from Jonathan Druart --- Created attachment 132342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132342&action=edit Bug 29810: Document x-koha-embed header on patrons endpoints Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Jonathan Druart changed: What|Removed |Added Attachment #132255|0 |1 is obsolete|| Attachment #132256|0 |1 is obsolete|| Attachment #132257|0 |1 is obsolete|| Attachment #132258|0 |1 is obsolete|| Attachment #132259|0 |1 is obsolete|| Attachment #132260|0 |1 is obsolete|| Attachment #132261|0 |1 is obsolete|| Attachment #132262|0 |1 is obsolete|| --- Comment #47 from Jonathan Druart --- Created attachment 132341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132341&action=edit Bug 29810: Add summary of x-koha-embed header to api spec Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #46 from Jonathan Druart --- We should have a test and make it a requirement. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Jonathan Druart changed: What|Removed |Added Blocks||30385 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30385 [Bug 30385] Standardize our swagger yaml spec files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Tomás Cohen Arazi changed: What|Removed |Added QA Contact||jonathan.druart+koha@gmail. ||com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #45 from Tomás Cohen Arazi --- Great work, love where we are headed to. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #44 from Tomás Cohen Arazi --- Created attachment 132262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132262&action=edit Bug 29810: Add 'x-koha-embed' to reserved words The maintainers of Mojolicious::Plugin::OpenAPI and friends fixed the problem with using collectionFormat for Headers in the upstream library. However, this highlighted an outstanding issue in our code when I ran the unit tests. We have not been stripping x-koha-embed at the query level as it did not exist in the reserved_words list. This patch resolves that and gets the acquisitions_orders test passing again. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #43 from Tomás Cohen Arazi --- Created attachment 132261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132261&action=edit Bug 29810: Document x-koha-embed header on orders endpoints Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #42 from Tomás Cohen Arazi --- Created attachment 132260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132260&action=edit Bug 29810: Document x-koha-embed header on libraries endpoints Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #41 from Tomás Cohen Arazi --- Created attachment 132259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132259&action=edit Bug 29810: Document x-koha-embed header on cash registers endpoints Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #40 from Tomás Cohen Arazi --- Created attachment 132258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132258&action=edit Bug 29810: Document x-koha-embed header on biblios endpoints Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #39 from Tomás Cohen Arazi --- Created attachment 132257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132257&action=edit Bug 29810: Document x-koha-embed header on checkouts endpoints Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #38 from Tomás Cohen Arazi --- Created attachment 132256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132256&action=edit Bug 29810: Document x-koha-embed header on patrons endpoints Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #37 from Tomás Cohen Arazi --- Created attachment 132255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132255&action=edit Bug 29810: Add summary of x-koha-embed header to api spec Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Tomás Cohen Arazi changed: What|Removed |Added Attachment #132223|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Tomás Cohen Arazi changed: What|Removed |Added Attachment #132230|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Tomás Cohen Arazi changed: What|Removed |Added Attachment #132229|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Tomás Cohen Arazi changed: What|Removed |Added Attachment #132228|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Tomás Cohen Arazi changed: What|Removed |Added Attachment #132227|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Tomás Cohen Arazi changed: What|Removed |Added Attachment #132226|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Tomás Cohen Arazi changed: What|Removed |Added Attachment #132225|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Tomás Cohen Arazi changed: What|Removed |Added Attachment #132224|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Martin Renvoize changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com, m...@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #36 from Martin Renvoize --- Woopie, this now all works! This collectionFormat issue I had with headers was quickly fixed upstream with the release of JSON::Validator 5.08 (which also bumped Mojolicious::Plugin::OpenAPI to v5.05). Could we get those packaged whilst you are in the packaging mindset for these modules Mason? With that in mind, the test plan is to read the documentation added in the patches and confirm it is current and meaningful. Once you've done that, ensure you have the latest modules at mentioned above (cpanm Mojolicous::Plugin::OpenAPI should do the trick if your testing before it's been packaged) and then run the API test suit.. prove t/db_dependant/api/v1/*. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Martin Renvoize changed: What|Removed |Added Attachment #132167|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #35 from Martin Renvoize --- Created attachment 132230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132230&action=edit Bug 29810: Add 'x-koha-embed' to reserved words The maintainers of Mojolicious::Plugin::OpenAPI and friends fixed the problem with using collectionFormat for Headers in the upstream library. However, this highlighted an outstanding issue in our code when I ran the unit tests. We have not been stripping x-koha-embed at the query level as it did not exist in the reserved_words list. This patch resolves that and gets the acquisitions_orders test passing again. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Martin Renvoize changed: What|Removed |Added Attachment #132166|0 |1 is obsolete|| --- Comment #34 from Martin Renvoize --- Created attachment 132229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132229&action=edit Bug 29810: Document x-koha-embed header on orders endpoints Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Martin Renvoize changed: What|Removed |Added Attachment #132165|0 |1 is obsolete|| --- Comment #33 from Martin Renvoize --- Created attachment 132228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132228&action=edit Bug 29810: Document x-koha-embed header on libraries endpoints Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Martin Renvoize changed: What|Removed |Added Attachment #132164|0 |1 is obsolete|| --- Comment #32 from Martin Renvoize --- Created attachment 132227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132227&action=edit Bug 29810: Document x-koha-embed header on cash registers endpoints Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Martin Renvoize changed: What|Removed |Added Attachment #132163|0 |1 is obsolete|| --- Comment #31 from Martin Renvoize --- Created attachment 132226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132226&action=edit Bug 29810: Document x-koha-embed header on biblios endpoints Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Martin Renvoize changed: What|Removed |Added Attachment #132162|0 |1 is obsolete|| --- Comment #30 from Martin Renvoize --- Created attachment 132225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132225&action=edit Bug 29810: Document x-koha-embed header on checkouts endpoints Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Martin Renvoize changed: What|Removed |Added Attachment #132161|0 |1 is obsolete|| --- Comment #29 from Martin Renvoize --- Created attachment 132224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132224&action=edit Bug 29810: Document x-koha-embed header on patrons endpoints Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Martin Renvoize changed: What|Removed |Added Attachment #132160|0 |1 is obsolete|| --- Comment #28 from Martin Renvoize --- Created attachment 132223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132223&action=edit Bug 29810: Add summary of x-koha-embed header to api spec Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #27 from Martin Renvoize --- Looks like collectionFormat still isn't working as expected for these headers :(... I've added a slight modification to one of the failing tests in the final patch to highlight the issue.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #26 from Martin Renvoize --- Created attachment 132167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132167&action=edit Debugging Tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Martin Renvoize changed: What|Removed |Added Attachment #132137|0 |1 is obsolete|| --- Comment #25 from Martin Renvoize --- Created attachment 132166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132166&action=edit Bug 29810: Document x-koha-embed header on orders endpoints -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Martin Renvoize changed: What|Removed |Added Attachment #132136|0 |1 is obsolete|| --- Comment #24 from Martin Renvoize --- Created attachment 132165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132165&action=edit Bug 29810: Document x-koha-embed header on libraries endpoints -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Martin Renvoize changed: What|Removed |Added Attachment #132135|0 |1 is obsolete|| --- Comment #23 from Martin Renvoize --- Created attachment 132164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132164&action=edit Bug 29810: Document x-koha-embed header on cash registers endpoints -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Martin Renvoize changed: What|Removed |Added Attachment #132134|0 |1 is obsolete|| --- Comment #22 from Martin Renvoize --- Created attachment 132163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132163&action=edit Bug 29810: Document x-koha-embed header on biblios endpoints -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Martin Renvoize changed: What|Removed |Added Attachment #132133|0 |1 is obsolete|| --- Comment #21 from Martin Renvoize --- Created attachment 132162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132162&action=edit Bug 29810: Document x-koha-embed header on checkouts endpoints -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Martin Renvoize changed: What|Removed |Added Attachment #132132|0 |1 is obsolete|| --- Comment #20 from Martin Renvoize --- Created attachment 132161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132161&action=edit Bug 29810: Document x-koha-embed header on patrons endpoints -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Martin Renvoize changed: What|Removed |Added Attachment #132131|0 |1 is obsolete|| --- Comment #19 from Martin Renvoize --- Created attachment 132160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132160&action=edit Bug 29810: Add summary of x-koha-embed header to api spec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Martin Renvoize changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #18 from Martin Renvoize --- Rebased against bug 30194 and ready for testing again :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Martin Renvoize changed: What|Removed |Added Attachment #129073|0 |1 is obsolete|| --- Comment #17 from Martin Renvoize --- Created attachment 132137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132137&action=edit Bug 29810: Document x-koha-embed header on orders endpoints -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Martin Renvoize changed: What|Removed |Added Attachment #129072|0 |1 is obsolete|| --- Comment #16 from Martin Renvoize --- Created attachment 132136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132136&action=edit Bug 29810: Document x-koha-embed header on libraries endpoints -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Martin Renvoize changed: What|Removed |Added Attachment #129071|0 |1 is obsolete|| --- Comment #15 from Martin Renvoize --- Created attachment 132135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132135&action=edit Bug 29810: Document x-koha-embed header on cash registers endpoints -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Martin Renvoize changed: What|Removed |Added Attachment #129070|0 |1 is obsolete|| --- Comment #14 from Martin Renvoize --- Created attachment 132134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132134&action=edit Bug 29810: Document x-koha-embed header on biblios endpoints -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Martin Renvoize changed: What|Removed |Added Attachment #129069|0 |1 is obsolete|| --- Comment #13 from Martin Renvoize --- Created attachment 132133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132133&action=edit Bug 29810: Document x-koha-embed header on checkouts endpoints -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Martin Renvoize changed: What|Removed |Added Attachment #129068|0 |1 is obsolete|| --- Comment #12 from Martin Renvoize --- Created attachment 132132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132132&action=edit Bug 29810: Document x-koha-embed header on patrons endpoints -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Martin Renvoize changed: What|Removed |Added Attachment #129067|0 |1 is obsolete|| --- Comment #11 from Martin Renvoize --- Created attachment 132131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132131&action=edit Bug 29810: Add summary of x-koha-embed header to api spec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Martin Renvoize changed: What|Removed |Added Depends on||30194 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30194 [Bug 30194] Adapt Koha for JSON::Validator@5.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #10 from Martin Renvoize --- Grr.. looks like collectionFormat support requires a newer version of JSON::Validator so this breaks our embeds -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Martin Renvoize changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Martin Renvoize changed: What|Removed |Added Text to go in the||This patch adds release notes||documentation of the ||different embed options the ||REST API provides. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #9 from Martin Renvoize --- Created attachment 129073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129073&action=edit Bug 29810: Document x-koha-embed header on orders endpoints -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #8 from Martin Renvoize --- Created attachment 129072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129072&action=edit Bug 29810: Document x-koha-embed header on libraries endpoints -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #7 from Martin Renvoize --- Created attachment 129071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129071&action=edit Bug 29810: Document x-koha-embed header on cash registers endpoints -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #6 from Martin Renvoize --- Created attachment 129070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129070&action=edit Bug 29810: Document x-koha-embed header on biblios endpoints -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
