[Koha-bugs] [Bug 29969] Cannot update hold list after holds cancelled in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29969 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28782 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29969] Cannot update hold list after holds cancelled in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29969 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29969] Cannot update hold list after holds cancelled in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29969 --- Comment #1 from Jonathan Druart --- Created attachment 129948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129948&action=edit Bug 29969: Prevent crash if 'Update holds' clicked after bulk cancellation If you cancel holds in bulk, the list is not updated as we enqueued the task. But the "Update hold(s)" button will explode if clicked. Test plan: Place several holds on a bib record Use the "Cancel selected" link to cancel holds in bulk The job is enqueued and the hold list still show the holds you cancelled Click "Update holds" => Without this patch you get an ugly 500 Can't call method "found" on an undefined value at /kohadevbox/koha/C4/Reserves.pm line 1060 => With this patch applied the table is refresh, no crash (and there is a warning in the log, that may not be necessary) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29969] Cannot update hold list after holds cancelled in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29969 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29969] Cannot update hold list after holds cancelled in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29969 David Nind changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||da...@davidnind.com --- Comment #2 from David Nind --- Patch no longer applies 8-(... Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 29969: Prevent crash if 'Update holds' clicked after bulk cancellation error: sha1 information is lacking or useless (C4/Reserves.pm). error: could not build fake ancestor Patch failed at 0001 Bug 29969: Prevent crash if 'Update holds' clicked after bulk cancellation hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29969] Cannot update hold list after holds cancelled in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29969 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29969] Cannot update hold list after holds cancelled in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29969 Jonathan Druart changed: What|Removed |Added Attachment #129948|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 129990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129990&action=edit Bug 29969: Prevent crash if 'Update holds' clicked after bulk cancellation If you cancel holds in bulk, the list is not updated as we enqueued the task. But the "Update hold(s)" button will explode if clicked. Test plan: Place several holds on a bib record Use the "Cancel selected" link to cancel holds in bulk The job is enqueued and the hold list still show the holds you cancelled Click "Update holds" => Without this patch you get an ugly 500 Can't call method "found" on an undefined value at /kohadevbox/koha/C4/Reserves.pm line 1060 => With this patch applied the table is refresh, no crash (and there is a warning in the log, that may not be necessary) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29969] Cannot update hold list after holds cancelled in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29969 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29969] Cannot update hold list after holds cancelled in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29969 Tomás Cohen Arazi changed: What|Removed |Added CC||and...@bywatersolutions.com ||, ||k...@bywatersolutions.com, ||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29969] Cannot update hold list after holds cancelled in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29969 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29969] Cannot update hold list after holds cancelled in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29969 Tomás Cohen Arazi changed: What|Removed |Added Attachment #129990|0 |1 is obsolete|| --- Comment #4 from Tomás Cohen Arazi --- Created attachment 130017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130017&action=edit Bug 29969: Prevent crash if 'Update holds' clicked after bulk cancellation If you cancel holds in bulk, the list is not updated as we enqueued the task. But the "Update hold(s)" button will explode if clicked. Test plan: Place several holds on a bib record Use the "Cancel selected" link to cancel holds in bulk The job is enqueued and the hold list still show the holds you cancelled Click "Update holds" => Without this patch you get an ugly 500 Can't call method "found" on an undefined value at /kohadevbox/koha/C4/Reserves.pm line 1060 => With this patch applied the table is refresh, no crash (and there is a warning in the log, that may not be necessary) Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29969] Cannot update hold list after holds cancelled in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29969 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29969] Cannot update hold list after holds cancelled in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29969 --- Comment #5 from Nick Clemens --- Created attachment 130865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130865&action=edit Bug 30089: (bug 29844 follow-up) Fix placing holds - OPAC The method Koha::AuthorisedValues->authorised_value is not covered by tests! Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29969] Cannot update hold list after holds cancelled in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29969 Fridolin Somers changed: What|Removed |Added Patch complexity|--- |Small patch CC||fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29969] Cannot update hold list after holds cancelled in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29969 --- Comment #6 from Fridolin Somers --- (In reply to Nick Clemens from comment #5) > Created attachment 130865 [details] [review] > Bug 30089: (bug 29844 follow-up) Fix placing holds - OPAC > > The method Koha::AuthorisedValues->authorised_value is not covered by tests! > > Signed-off-by: Tomas Cohen Arazi > > Signed-off-by: Nick Clemens Ich, wrong bug Nick :D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29969] Cannot update hold list after holds cancelled in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29969 Fridolin Somers changed: What|Removed |Added Attachment #130865|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29969] Cannot update hold list after holds cancelled in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29969 Fridolin Somers changed: What|Removed |Added Version(s)||22.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29969] Cannot update hold list after holds cancelled in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29969 --- Comment #7 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29969] Cannot update hold list after holds cancelled in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29969 Andrew Fuerste-Henry changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to master|RESOLVED --- Comment #8 from Andrew Fuerste-Henry --- Missing dependency, not backported to 21.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
