[Koha-bugs] [Bug 30133] Pagination broken on pickup_locations routes when AllowHoldPolicyOverride=1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30133 Tomás Cohen Arazi changed: What|Removed |Added Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #26 from Tomás Cohen Arazi --- (In reply to Victor Grousset/tuxayo from comment #25) > About backporting to 20.11.x, this depend on bug 27931, right? 20.11.x > doesn't seem to have the route used in the tests so it shouldn't be affected > at all. That's right! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30133] Pagination broken on pickup_locations routes when AllowHoldPolicyOverride=1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30133 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #25 from Victor Grousset/tuxayo --- About backporting to 20.11.x, this depend on bug 27931, right? 20.11.x doesn't seem to have the route used in the tests so it shouldn't be affected at all. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30133] Pagination broken on pickup_locations routes when AllowHoldPolicyOverride=1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30133 Andrew Fuerste-Henry changed: What|Removed |Added Version(s)|22.05.00,21.11.03 |22.05.00,21.11.03,21.05.13 released in|| Status|Pushed to stable|Pushed to oldstable --- Comment #24 from Andrew Fuerste-Henry --- Pushed to 21.05.x for 21.05.13 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30133] Pagination broken on pickup_locations routes when AllowHoldPolicyOverride=1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30133 Kyle M Hall changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||k...@bywatersolutions.com Version(s)|22.05.00|22.05.00,21.11.03 released in|| --- Comment #23 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30133] Pagination broken on pickup_locations routes when AllowHoldPolicyOverride=1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30133 --- Comment #22 from Tomás Cohen Arazi --- (In reply to Fridolin Somers from comment #21) > Pushed to master for 22.05, thanks to everybody involved 濾 \o/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30133] Pagination broken on pickup_locations routes when AllowHoldPolicyOverride=1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30133 --- Comment #21 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30133] Pagination broken on pickup_locations routes when AllowHoldPolicyOverride=1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30133 Fridolin Somers changed: What|Removed |Added Version(s)||22.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30133] Pagination broken on pickup_locations routes when AllowHoldPolicyOverride=1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30133 --- Comment #20 from Tomás Cohen Arazi --- Created attachment 130957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130957=edit Bug 30133: (follow-up) Update objects.search POD Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30133] Pagination broken on pickup_locations routes when AllowHoldPolicyOverride=1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30133 --- Comment #19 from Jonathan Druart --- Created attachment 130956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130956=edit Bug 30133: Fix pagination in /biblios/:bibio_id/pickup_locations This patch does the same thing we did for items on the previous patch, but for biblios. The tests are almost the same as well. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/biblios.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30133] Pagination broken on pickup_locations routes when AllowHoldPolicyOverride=1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30133 --- Comment #18 from Jonathan Druart --- Created attachment 130955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130955=edit Bug 30133: Simplify code This patch simplifies the code, and also fixes a problem with branchcode comparisson failing, highlighted when running the tests To test: 1. Apply the regression tests 2. Run: $ kshell k$ prove t/db_dependent/api/v1/items.t => FAIL: Tests fail. Notably: - Link header pagination is wrong - X-*Total-Count headers have two values (dupicated) 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30133] Pagination broken on pickup_locations routes when AllowHoldPolicyOverride=1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30133 --- Comment #17 from Jonathan Druart --- Created attachment 130954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130954=edit Bug 30133: Avoid calling c->objects->search twice Calling this twice sets double pagination headers, which messes up the page for the requests and retrieves on ly the end of the list This patch simply avoids a doulbe call TO DO: must implement same for Biblio->pickup_locations and cover with tests this also returns all as needing override Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30133] Pagination broken on pickup_locations routes when AllowHoldPolicyOverride=1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30133 Jonathan Druart changed: What|Removed |Added Attachment #130890|0 |1 is obsolete|| Attachment #130891|0 |1 is obsolete|| Attachment #130892|0 |1 is obsolete|| Attachment #130893|0 |1 is obsolete|| --- Comment #16 from Jonathan Druart --- Created attachment 130953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130953=edit Bug 30133: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30133] Pagination broken on pickup_locations routes when AllowHoldPolicyOverride=1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30133 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30133] Pagination broken on pickup_locations routes when AllowHoldPolicyOverride=1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30133 Tomás Cohen Arazi changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de, ||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30133] Pagination broken on pickup_locations routes when AllowHoldPolicyOverride=1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30133 Tomás Cohen Arazi changed: What|Removed |Added Summary|Pagination broken on|Pagination broken on |pickup_location routes when |pickup_locations routes |AllowHoldPolicyOverride=1 |when ||AllowHoldPolicyOverride=1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
