[Koha-bugs] [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #10 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 Andrew Fuerste-Henry changed: What|Removed |Added Version(s)|22.05.00,21.11.04 |22.05.00,21.11.04,21.05.13 released in|| Status|Pushed to stable|Pushed to oldstable CC||and...@bywatersolutions.com --- Comment #9 from Andrew Fuerste-Henry --- Pushed to 21.05.x for 21.05.13 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 Kyle M Hall changed: What|Removed |Added Version(s)|22.05.00|22.05.00,21.11.04 released in|| Status|Pushed to master|Pushed to stable --- Comment #8 from Kyle M Hall --- Pushed to 21.11.x for 21.11.04 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 Kyle M Hall changed: What|Removed |Added Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 Kyle M Hall changed: What|Removed |Added Status|REOPENED|Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 Kyle M Hall changed: What|Removed |Added Resolution|FIXED |--- Severity|enhancement |minor Status|RESOLVED|REOPENED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 Kyle M Hall changed: What|Removed |Added Status|Pushed to master|RESOLVED CC||k...@bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 --- Comment #7 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 Fridolin Somers changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA QA Contact||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 --- Comment #6 from Martin Renvoize --- Created attachment 131023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131023&action=edit Bug 30153: (QA follow-up) Fix unit tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 --- Comment #5 from Martin Renvoize --- This a trivial patch, and given I've just QA'd bug 25616 now it's been brought to my attention, I'm going to go ahead and QA this one too. Unit test update inbound, then it'll be a pass. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 Martin Renvoize changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25616 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 Martin Renvoize changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 Martin Renvoize changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 Martin Renvoize changed: What|Removed |Added Attachment #131014|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #4 from Martin Renvoize --- I tested against Zebra and found no obvious regressions, ES issue is resolved... Signing off. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153
--- Comment #3 from Martin Renvoize ---
Created attachment 131016
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131016&action=edit
Bug 30153: Use uppercase AND to join query parts
C4::Search->FindDuplicate joins title and author using 'and'
(lowercase). When this query is passed on to ElasticSearch, it
interprets the lowercase 'and' as a term to search for, because the
operator has to be in uppercases ('AND').
Test plan:
* Reproduce the bug:
- Set SearchEngine to ElasticSearch (and make sure you have the data
indexed etc)
- Find an existing book, note the title (245a) and the author (100a)
- Create a new book (Cataloging -> New Record)
- Fill in the same title and author using the same data as in an
existing book (and any other fields that might be required)
- Click "save"
=> A new book will be created, the Duplicate Finder has failed
* Apply the patch
* Check if it's working now:
- Create a new book (Cataloging -> New Record)
- Fill in the same title and author using the same data as in an
existing book (and any other fields that might be required)
- Click "save"
- The DuplicateFinder should now report the already exising book
Maybe we should also check if Zebra does not have any problems with the
uppercase 'AND'? In that case, repeat the above steps, but set
SearchEngine to Zebra :-)
Sponsored-by: Steiermärkische Landesbibliothek
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Depends on||27928 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27928 [Bug 27928] FindDuplicate is hardcoded to use Zebra -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 Thomas Klausner changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 --- Comment #2 from Thomas Klausner --- Created attachment 131014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131014&action=edit Use uppercase AND to join query parts Fix Bug 30153 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 --- Comment #1 from Thomas Klausner --- See Also 27928 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
