[Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 Katrin Fischer changed: What|Removed |Added Summary|Koha does not currently |Support authority records |support authority records |with common subject |with common subject |headings from different |headings from different |thesaurus |thesaurus | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 Katrin Fischer changed: What|Removed |Added Attachment #137900|0 |1 is obsolete|| --- Comment #38 from Katrin Fischer --- Created attachment 139854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139854&action=edit Bug 30280: Elasticsearch - Add 040f to Subject-heading-thesaurus-conventions (new) authority mapping index field (MARC21) This patch adds 040 $f to a new field Subject-heading-thesaurus-conventions authority index mapping. To test: 1) Apply patch 2) Reindex using rebuild_elasticsearch.pl -r If you don't have access to a terminal (in a sandbox for example) 2a) Go to Administration > Search engine configuration, click "Reset mappings" and confirm 2b) Then reindex Sponsored-by: Lund University Library, Sweden Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 Katrin Fischer changed: What|Removed |Added Attachment #137901|0 |1 is obsolete|| --- Comment #39 from Katrin Fischer --- Created attachment 139855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139855&action=edit 30280: Add support for subject headings from different thesaurus when using Elasticsearch This patch allows subject headings from different thesaurus to co-exist in Koha. Test plan: 1. Enable Elasticsearch as the search engine (SearchEngine system preference = Elasticsearch) and reindex (koha-elasticsearch --rebuild -d -b -a kohadev). 2. Load sample authority records attached to the bug (in this case the authorities.mrc file was saved in the koha directory - adjust file location as appropriate): misc/migration_tools/bulkmarcimport.pl -v -a -file authorities.mrc -insert -c=MARC21 3. Load the sample bibliographic record attached to the bug: misc/migration_tools/bulkmarcimport.pl -v -b -file biblios.mrc -insert -c=MARC21 4. Search for ISBN 0704328623 and verify that the subject terms are not linked to any authority records (if you hover over the link terms, all links should look like ../cgi-bin/koha/catalogue/search.pl?q=su:"subjectterm" - none should have any ?q=an:XXX (where XXX = authority record ids) in the link). 5. Apply the patches. 6. Reset the Elasticsearch mappings (Administration > Catalog > Search engine configuration (Elasticsearch)). 7. Reindex: koha-elasticsearch --rebuild -d -b -a kohadev 8. Link bibliographic records to authority records: misc/link_bibs_to_authorities.pl -v -l 9. Repeat the search in step 4 (or refresh the record details page) and verify that the first three Feminism headings[1] are linked to an authority record (should have ?q=an:XXX (where XXX = different authority record IDs for the various feminism authority records linked to a specific thesaurus)). 10. Reindex: koha-elasticsearch --rebuild -d -b -a kohadev [1] Links for subject terms for step 9 in order are (the authority ids may be different depending on how ou are testing): Subject(s:) Feminism | feminism | Feminism | Feminism | Idéhistoria | Litteratur http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=an:1709 http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=an:1710 http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=an:1708 http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=su:"Feminism"; http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=su:"Idéhistoria"; http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=su:"Litteratur"; MARC info: 650 #7 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element Feminism 0 Authority record control number or standard number https://id.kb.se/term/sao/Feminism 2 Source of heading or term sao 650 #7 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element feminism 2 Source of heading or term bnb 650 #0 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element Feminism 650 #4 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element Feminism 650 #4 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element Idéhistoria 650 #4 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element Litteratur Note: The fourth Feminism term has second indicator 4 which means "Source not specified". So this term is only a local term and does not belong to any specific thesaurus and thus not linked. To specify a source of a term, the second indicator must be set as 7. The source of heading is then specified in subfield 2. Sponsored-by: Lund University Library, Sweden Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 Katrin Fischer changed: What|Removed |Added Attachment #137902|0 |1 is obsolete|| --- Comment #40 from Katrin Fischer --- Created attachment 139856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139856&action=edit Bug 30280: (follow-up) Removing tab character in Heading.pm Sponsored-by: Lund University Library, Sweden Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #41 from Katrin Fischer --- Thx for the great work on the test plan and sample data, this makes it much easier to test :) I am happy to add another sign-off, but for this to go through QA, we will also need unit tests to cover the changes in the .pm files. Please let us know if we can help with that! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 --- Comment #42 from Katrin Fischer --- You can switch back to signed off directly once the unit tests are done! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 Nick Clemens (kidclamp) changed: What|Removed |Added Blocks||35125 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35125 [Bug 35125] AutoCreateAuthorities creates separate authorities when thesaurus differs, even with LinkerConsiderThesaurus set to Don't -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 --- Comment #59 from David Cook --- (In reply to Katrin Fischer from comment #57) > The problem is, we broke things with this one for people and a lot of > libraries - we need to find a fix. I've had reports about linking problems (with Zebra), and it looks like this bug is the root cause. Very frustrating. In theory Nick has fixed the problem via bug 33277 and bug 33557 although I haven't confirmed for sure yet. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 Lucas Gass changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to master|RESOLVED CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 Phil Ringnalda changed: What|Removed |Added Blocks||32916 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32916 [Bug 32916] [Bug 30280 follow-up] Problems in linking authorities to biblio fields (MARC 21) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 Nick Clemens changed: What|Removed |Added Blocks||33159 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33159 [Bug 33159] Thesaurus is not defined by second indicator for controlled fields outside of 6XX -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 --- Comment #43 from Frank Hansen --- (In reply to Katrin Fischer from comment #41) > Thx for the great work on the test plan and sample data, this makes it much > easier to test :) > > I am happy to add another sign-off, but for this to go through QA, we will > also need unit tests to cover the changes in the .pm files. Please let us > know if we can help with that! Yes, there are already existing tests in these files: t/db_dependent/Linker_Default.t t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t They need some minor changes so they will PASS tests. This test outputs warnings even if it says OK: t/db_dependent/Linker_FirstMatch.t Use of uninitialized value $thesaurus in concatenation (.) or string at /kohadevbox/koha/C4/Linker/Default.pm line 38. Use of uninitialized value $thesaurus in concatenation (.) or string at /kohadevbox/koha/C4/Linker/Default.pm line 79. Use of uninitialized value $thesaurus in concatenation (.) or string at /kohadevbox/koha/C4/Linker/Default.pm line 80. Use of uninitialized value $thesaurus in concatenation (.) or string at /kohadevbox/koha/C4/Linker/Default.pm line 81. Use of uninitialized value $thesaurus in concatenation (.) or string at /kohadevbox/koha/C4/Linker/Default.pm line 82. t/db_dependent/Linker_FirstMatch.t .. ok All tests successful. These warnings doesn't appear in t/db_dependent/Linker_Default.t I would like to add a few more test to t/db_dependent/Linker_Default.t to cover my changes in unit test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 Frank Hansen changed: What|Removed |Added Attachment #139855|0 |1 is obsolete|| Attachment #139856|0 |1 is obsolete|| --- Comment #44 from Frank Hansen --- Created attachment 140040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140040&action=edit 30280: Add support for subject headings from different thesaurus when using Elasticsearch This patch allows subject headings from different thesaurus to co-exist in Koha. Test plan: 1. Enable Elasticsearch as the search engine (SearchEngine system preference = Elasticsearch) and reindex (koha-elasticsearch --rebuild -d -b -a kohadev). 2. Load sample authority records attached to the bug (in this case the authorities.mrc file was saved in the koha directory - adjust file location as appropriate): misc/migration_tools/bulkmarcimport.pl -v -a -file authorities.mrc -insert -c=MARC21 3. Load the sample bibliographic record attached to the bug: misc/migration_tools/bulkmarcimport.pl -v -b -file biblios.mrc -insert -c=MARC21 4. Search for ISBN 0704328623 and verify that the subject terms are not linked to any authority records (if you hover over the link terms, all links should look like ../cgi-bin/koha/catalogue/search.pl?q=su:"subjectterm" - none should have any ?q=an:XXX (where XXX = authority record ids) in the link). 5. Apply the patches. 6. Reset the Elasticsearch mappings (Administration > Catalog > Search engine configuration (Elasticsearch)). 7. Reindex: koha-elasticsearch --rebuild -d -b -a kohadev 8. Link bibliographic records to authority records: misc/link_bibs_to_authorities.pl -v -l 9. Repeat the search in step 4 (or refresh the record details page) and verify that the first three Feminism headings[1] are linked to an authority record (should have ?q=an:XXX (where XXX = different authority record IDs for the various feminism authority records linked to a specific thesaurus)). 10. Reindex: koha-elasticsearch --rebuild -d -b -a kohadev [1] Links for subject terms for step 9 in order are (the authority ids may be different depending on how ou are testing): Subject(s:) Feminism | feminism | Feminism | Feminism | Idéhistoria | Litteratur http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=an:1709 http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=an:1710 http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=an:1708 http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=su:"Feminism"; http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=su:"Idéhistoria"; http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=su:"Litteratur"; MARC info: 650 #7 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element Feminism 0 Authority record control number or standard number https://id.kb.se/term/sao/Feminism 2 Source of heading or term sao 650 #7 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element feminism 2 Source of heading or term bnb 650 #0 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element Feminism 650 #4 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element Feminism 650 #4 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element Idéhistoria 650 #4 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element Litteratur Note: The fourth Feminism term has second indicator 4 which means "Source not specified". So this term is only a local term and does not belong to any specific thesaurus and thus not linked. To specify a source of a term, the second indicator must be set as 7. The source of heading is then specified in subfield 2. Sponsored-by: Lund University Library, Sweden Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 --- Comment #45 from Frank Hansen --- Created attachment 140041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140041&action=edit Bug 30280: (follow-up) Removing tab character in Heading.pm Sponsored-by: Lund University Library, Sweden Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 Frank Hansen changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 --- Comment #46 from Frank Hansen --- Created attachment 140042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140042&action=edit Bug 30280 - Unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 Frank Hansen changed: What|Removed |Added Attachment #140040|0 |1 is obsolete|| Attachment #140041|0 |1 is obsolete|| Attachment #140042|0 |1 is obsolete|| --- Comment #47 from Frank Hansen --- Created attachment 140044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140044&action=edit Bug 30280: Add support for subject headings from different thesaurus when using Elasticsearch This patch allows subject headings from different thesaurus to co-exist in Koha. Test plan: 1. Enable Elasticsearch as the search engine (SearchEngine system preference = Elasticsearch) and reindex (koha-elasticsearch --rebuild -d -b -a kohadev). 2. Load sample authority records attached to the bug (in this case the authorities.mrc file was saved in the koha directory - adjust file location as appropriate): misc/migration_tools/bulkmarcimport.pl -v -a -file authorities.mrc -insert -c=MARC21 3. Load the sample bibliographic record attached to the bug: misc/migration_tools/bulkmarcimport.pl -v -b -file biblios.mrc -insert -c=MARC21 4. Search for ISBN 0704328623 and verify that the subject terms are not linked to any authority records (if you hover over the link terms, all links should look like ../cgi-bin/koha/catalogue/search.pl?q=su:"subjectterm" - none should have any ?q=an:XXX (where XXX = authority record ids) in the link). 5. Apply the patches. 6. Reset the Elasticsearch mappings (Administration > Catalog > Search engine configuration (Elasticsearch)). 7. Reindex: koha-elasticsearch --rebuild -d -b -a kohadev 8. Link bibliographic records to authority records: misc/link_bibs_to_authorities.pl -v -l 9. Repeat the search in step 4 (or refresh the record details page) and verify that the first three Feminism headings[1] are linked to an authority record (should have ?q=an:XXX (where XXX = different authority record IDs for the various feminism authority records linked to a specific thesaurus)). 10. Reindex: koha-elasticsearch --rebuild -d -b -a kohadev [1] Links for subject terms for step 9 in order are (the authority ids may be different depending on how ou are testing): Subject(s:) Feminism | feminism | Feminism | Feminism | Idéhistoria | Litteratur http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=an:1709 http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=an:1710 http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=an:1708 http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=su:"Feminism"; http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=su:"Idéhistoria"; http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=su:"Litteratur"; MARC info: 650 #7 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element Feminism 0 Authority record control number or standard number https://id.kb.se/term/sao/Feminism 2 Source of heading or term sao 650 #7 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element feminism 2 Source of heading or term bnb 650 #0 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element Feminism 650 #4 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element Feminism 650 #4 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element Idéhistoria 650 #4 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element Litteratur Note: The fourth Feminism term has second indicator 4 which means "Source not specified". So this term is only a local term and does not belong to any specific thesaurus and thus not linked. To specify a source of a term, the second indicator must be set as 7. The source of heading is then specified in subfield 2. Sponsored-by: Lund University Library, Sweden Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 --- Comment #48 from Frank Hansen --- Created attachment 140045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140045&action=edit Bug 30280: (follow-up) Removing tab character in Heading.pm Sponsored-by: Lund University Library, Sweden Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 --- Comment #49 from Frank Hansen --- Created attachment 140046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140046&action=edit Bug 30280: Add Unit tests Sponsored-by: Lund University Library, Sweden -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 Katrin Fischer changed: What|Removed |Added Attachment #139854|0 |1 is obsolete|| --- Comment #50 from Katrin Fischer --- Created attachment 140284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140284&action=edit Bug 30280: Elasticsearch - Add 040f to Subject-heading-thesaurus-conventions (new) authority mapping index field (MARC21) This patch adds 040 $f to a new field Subject-heading-thesaurus-conventions authority index mapping. To test: 1) Apply patch 2) Reindex using rebuild_elasticsearch.pl -r If you don't have access to a terminal (in a sandbox for example) 2a) Go to Administration > Search engine configuration, click "Reset mappings" and confirm 2b) Then reindex Sponsored-by: Lund University Library, Sweden Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 Katrin Fischer changed: What|Removed |Added Attachment #140044|0 |1 is obsolete|| --- Comment #51 from Katrin Fischer --- Created attachment 140285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140285&action=edit Bug 30280: Add support for subject headings from different thesaurus when using Elasticsearch This patch allows subject headings from different thesaurus to co-exist in Koha. Test plan: 1. Enable Elasticsearch as the search engine (SearchEngine system preference = Elasticsearch) and reindex (koha-elasticsearch --rebuild -d -b -a kohadev). 2. Load sample authority records attached to the bug (in this case the authorities.mrc file was saved in the koha directory - adjust file location as appropriate): misc/migration_tools/bulkmarcimport.pl -v -a -file authorities.mrc -insert -c=MARC21 3. Load the sample bibliographic record attached to the bug: misc/migration_tools/bulkmarcimport.pl -v -b -file biblios.mrc -insert -c=MARC21 4. Search for ISBN 0704328623 and verify that the subject terms are not linked to any authority records (if you hover over the link terms, all links should look like ../cgi-bin/koha/catalogue/search.pl?q=su:"subjectterm" - none should have any ?q=an:XXX (where XXX = authority record ids) in the link). 5. Apply the patches. 6. Reset the Elasticsearch mappings (Administration > Catalog > Search engine configuration (Elasticsearch)). 7. Reindex: koha-elasticsearch --rebuild -d -b -a kohadev 8. Link bibliographic records to authority records: misc/link_bibs_to_authorities.pl -v -l 9. Repeat the search in step 4 (or refresh the record details page) and verify that the first three Feminism headings[1] are linked to an authority record (should have ?q=an:XXX (where XXX = different authority record IDs for the various feminism authority records linked to a specific thesaurus)). 10. Reindex: koha-elasticsearch --rebuild -d -b -a kohadev [1] Links for subject terms for step 9 in order are (the authority ids may be different depending on how ou are testing): Subject(s:) Feminism | feminism | Feminism | Feminism | Idéhistoria | Litteratur http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=an:1709 http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=an:1710 http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=an:1708 http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=su:"Feminism"; http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=su:"Idéhistoria"; http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=su:"Litteratur"; MARC info: 650 #7 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element Feminism 0 Authority record control number or standard number https://id.kb.se/term/sao/Feminism 2 Source of heading or term sao 650 #7 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element feminism 2 Source of heading or term bnb 650 #0 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element Feminism 650 #4 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element Feminism 650 #4 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element Idéhistoria 650 #4 - SUBJECT ADDED ENTRY--TOPICAL TERM a Topical term or geographic name entry element Litteratur Note: The fourth Feminism term has second indicator 4 which means "Source not specified". So this term is only a local term and does not belong to any specific thesaurus and thus not linked. To specify a source of a term, the second indicator must be set as 7. The source of heading is then specified in subfield 2. Sponsored-by: Lund University Library, Sweden Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 Katrin Fischer changed: What|Removed |Added Attachment #140045|0 |1 is obsolete|| --- Comment #52 from Katrin Fischer --- Created attachment 140286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140286&action=edit Bug 30280: (follow-up) Removing tab character in Heading.pm Sponsored-by: Lund University Library, Sweden Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 Katrin Fischer changed: What|Removed |Added Attachment #140046|0 |1 is obsolete|| --- Comment #53 from Katrin Fischer --- Created attachment 140287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140287&action=edit Bug 30280: Add Unit tests Sponsored-by: Lund University Library, Sweden Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 --- Comment #54 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 Phil Ringnalda changed: What|Removed |Added Blocks||31924 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31924 [Bug 31924] AutoLinkBiblios broken by patch from Bug 30280 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 Phil Ringnalda changed: What|Removed |Added Blocks||31925 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31925 [Bug 31925] AutoCreateAuthorities needs to preserve subject heading thesaurus to not create duplicate authority records -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 --- Comment #55 from Katrin Fischer --- hi Frank, could you maybe have a look at the new bugs in Blocks? bug 31924 and bug 31925. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 --- Comment #56 from Frank Hansen --- (In reply to Katrin Fischer from comment #55) > hi Frank, could you maybe have a look at the new bugs in Blocks? bug 31924 > and bug 31925. Hi Katrin, Well 31924 is probably a Zebra related issue. I got the impression that linking of subject headings based on thesaurus already works with Zebra. It is at least that's what I thought when I read this in the authority-koha-indexdefs.xml file: Subject-heading-thesaurus:w Here is already a reference to 040$f which is a crucial part when it comes to other thesaurus. But I see that the linking does not work at all in Zebra. Here at Lund University, we are only using ElasticSearch. In fact, we Zebra is not running at all. So it is difficult for me to test Zebra in real life. I'n not an expert on Zebra. Probably the new subject-heading-thesaurus-conventions index needs to be set up in Zebra as well. I'm not 100% certain how to do that. As for 31925, that's the next step. We don't use AutoLinkBiblios because it doesn't work. We import the subject headings from different thesaurus from Royal Library (Libris). So for avoid 30280 to being too complex, I have focused on getting the thesaurus based subject heading linking to work. Since AutoLinkBiblios only creates LCSH subject headings we cannot use this. But it would be awesome to get it to work later on. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 --- Comment #57 from Katrin Fischer --- The problem is, we broke things with this one for people and a lot of libraries - we need to find a fix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 --- Comment #58 from Frank Hansen --- (In reply to Katrin Fischer from comment #57) > The problem is, we broke things with this one for people and a lot of > libraries - we need to find a fix. Katrin, I have been working on a fix to make it compatible with Zebra. There is some code to be uploaded as well. The patch should work in theory but I can get Zebra to work as expected. But it work nicely with Elasticsearch. Do you want me to submit the patch here or to Bug 31924? I will definitely need some help with setting up the search field correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com Blocks||33277, 33557 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 [Bug 33277] Correctly handle linking subfields with no defined thesaurus https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33557 [Bug 33557] Add a system preference to disable/enable thesaurus checking during authority linking -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
