[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Martin Renvoize changed: What|Removed |Added CC|martin.renvoize@ptfs-europe | |.com| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Aleisha Amohia changed: What|Removed |Added Blocks||33260 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 [Bug 33260] Show message queue on staff interface and make notices printable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.08 released in|| --- Comment #55 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.08 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Status|Pushed to master|Pushed to stable Version(s)|24.05.00|24.05.00,23.11.02 released in|| --- Comment #54 from Fridolin Somers --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 --- Comment #53 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Katrin Fischer changed: What|Removed |Added Version(s)||24.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 --- Comment #52 from Katrin Fischer --- (In reply to Martin Renvoize from comment #51) > Already did, it's in the tree ;) Thanks! Also for the quick feedback. Testing this one right now, hopefully finishing a little later. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 --- Comment #51 from Martin Renvoize --- Already did, it's in the tree ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287
--- Comment #50 from Katrin Fischer ---
(In reply to Martin Renvoize from comment #49)
> (In reply to Marcel de Rooy from comment #44)
> > +sub html_content {
> > +http://www.w3.org/1999/xhtml";>
> >
> > Teasing a bit: but who says that this text is English ?
>
> That's actually a really good point.. I didn't consider that at all.. but we
> really aught to be able to do better, I would have thought.
Could you please file a separate bug for that? I think it makes sense to deal
with this separately.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287
--- Comment #49 from Martin Renvoize ---
(In reply to Marcel de Rooy from comment #44)
> +sub html_content {
> +http://www.w3.org/1999/xhtml";>
>
> Teasing a bit: but who says that this text is English ?
That's actually a really good point.. I didn't consider that at all.. but we
really aught to be able to do better, I would have thought.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Marcel de Rooy changed: What|Removed |Added Attachment #158895|0 |1 is obsolete|| --- Comment #48 from Marcel de Rooy --- Created attachment 159434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159434&action=edit Bug 30287: (follow-up) Make unit test more reliable in ktd This patch mocks NoticeCSS earlier to ensure we're not inadvertantly failing due to a local setup in ktd having added to the preference. Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Marcel de Rooy changed: What|Removed |Added Attachment #158894|0 |1 is obsolete|| --- Comment #47 from Marcel de Rooy --- Created attachment 159433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159433&action=edit Bug 30287: (follow-up) Unit test for html_content This patch adds a unit test for the new `html_content` method introduced to Koha::Notice::Template in the previous patch. Test 1) Run the new unit test ;P Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Marcel de Rooy changed: What|Removed |Added Attachment #158893|0 |1 is obsolete|| --- Comment #46 from Marcel de Rooy --- Created attachment 159432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159432&action=edit Bug 30287: (follow-up) Add content wrap matching send time This patch adds a new method to the Koha::Notice::Message class to wrap content in the same way we currently do at email send time. We then update the notice preview to use this method so we're embedding NoticeCSS into that iframe. This means the generated preview should now exactly match how your notice will display in email clients including any CSS you may have placed within NoticeCSS. Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Marcel de Rooy changed: What|Removed |Added Attachment #158892|0 |1 is obsolete|| --- Comment #45 from Marcel de Rooy --- Created attachment 159431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159431&action=edit Bug 30287: Conditionally render notice preview This patch adds conditional formatting based on whether the notice was generated from an HTML template or a plaintext one. We simply drop the 'html_line_break' filter for the case where the notice should already be html formatted. I was tempted to replace the html_line_break for plaintext formatted notices too as I believe this closer resembles how we actually output such generated notices.. but I decided that should be for another bug. Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287
--- Comment #44 from Marcel de Rooy ---
+sub html_content {
+http://www.w3.org/1999/xhtml";>
Teasing a bit: but who says that this text is English ?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 --- Comment #43 from Katrin Fischer --- (In reply to Marcel de Rooy from comment #42) > Looking here. > This feels a bit like an enhancement ? The original bug wasn't, but it might have grown a bit. The problem was that the display in Koha was not matching the email in terms of line breaks. This caused confusion when testing etc. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | Status|Signed Off |BLOCKED --- Comment #42 from Marcel de Rooy --- Looking here. This feels a bit like an enhancement ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 --- Comment #41 from Martin Renvoize --- Thank you for all the testing David.. it's always a pleasure to work on something your testing :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 --- Comment #40 from David Nind --- Thanks for your perseverance Martin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 David Nind changed: What|Removed |Added Attachment #158873|0 |1 is obsolete|| --- Comment #39 from David Nind --- Created attachment 158895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158895&action=edit Bug 30287: (follow-up) Make unit test more reliable in ktd This patch mocks NoticeCSS earlier to ensure we're not inadvertantly failing due to a local setup in ktd having added to the preference. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 David Nind changed: What|Removed |Added Attachment #158872|0 |1 is obsolete|| --- Comment #38 from David Nind --- Created attachment 158894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158894&action=edit Bug 30287: (follow-up) Unit test for html_content This patch adds a unit test for the new `html_content` method introduced to Koha::Notice::Template in the previous patch. Test 1) Run the new unit test ;P Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 David Nind changed: What|Removed |Added Attachment #158871|0 |1 is obsolete|| --- Comment #37 from David Nind --- Created attachment 158893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158893&action=edit Bug 30287: (follow-up) Add content wrap matching send time This patch adds a new method to the Koha::Notice::Message class to wrap content in the same way we currently do at email send time. We then update the notice preview to use this method so we're embedding NoticeCSS into that iframe. This means the generated preview should now exactly match how your notice will display in email clients including any CSS you may have placed within NoticeCSS. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 David Nind changed: What|Removed |Added Attachment #158870|0 |1 is obsolete|| --- Comment #36 from David Nind --- Created attachment 158892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158892&action=edit Bug 30287: Conditionally render notice preview This patch adds conditional formatting based on whether the notice was generated from an HTML template or a plaintext one. We simply drop the 'html_line_break' filter for the case where the notice should already be html formatted. I was tempted to replace the html_line_break for plaintext formatted notices too as I believe this closer resembles how we actually output such generated notices.. but I decided that should be for another bug. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31714 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Martin Renvoize changed: What|Removed |Added Blocks||35267 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267 [Bug 35267] Add further CSS options for Notices -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #35 from Martin Renvoize --- QA script is happier now and the test should pass even with git whitespace munging. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Martin Renvoize changed: What|Removed |Added Attachment #158869|0 |1 is obsolete|| --- Comment #34 from Martin Renvoize --- Created attachment 158873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158873&action=edit Bug 30287: (follow-up) Make unit test more reliable in ktd This patch mocks NoticeCSS earlier to ensure we're not inadvertantly failing due to a local setup in ktd having added to the preference. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Martin Renvoize changed: What|Removed |Added Attachment #158656|0 |1 is obsolete|| --- Comment #33 from Martin Renvoize --- Created attachment 158872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158872&action=edit Bug 30287: (follow-up) Unit test for html_content This patch adds a unit test for the new `html_content` method introduced to Koha::Notice::Template in the previous patch. Test 1) Run the new unit test ;P -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Martin Renvoize changed: What|Removed |Added Attachment #158655|0 |1 is obsolete|| --- Comment #32 from Martin Renvoize --- Created attachment 158871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158871&action=edit Bug 30287: (follow-up) Add content wrap matching send time This patch adds a new method to the Koha::Notice::Message class to wrap content in the same way we currently do at email send time. We then update the notice preview to use this method so we're embedding NoticeCSS into that iframe. This means the generated preview should now exactly match how your notice will display in email clients including any CSS you may have placed within NoticeCSS. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Martin Renvoize changed: What|Removed |Added Attachment #158654|0 |1 is obsolete|| --- Comment #31 from Martin Renvoize --- Created attachment 158870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158870&action=edit Bug 30287: Conditionally render notice preview This patch adds conditional formatting based on whether the notice was generated from an HTML template or a plaintext one. We simply drop the 'html_line_break' filter for the case where the notice should already be html formatted. I was tempted to replace the html_line_break for plaintext formatted notices too as I believe this closer resembles how we actually output such generated notices.. but I decided that should be for another bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Martin Renvoize changed: What|Removed |Added Attachment #158834|0 |1 is obsolete|| --- Comment #30 from Martin Renvoize --- Created attachment 158869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158869&action=edit Bug 30287: (follow-up) Make unit test more reliable in ktd This patch mocks NoticeCSS earlier to ensure we're not inadvertantly failing due to a local setup in ktd having added to the preference. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=35279 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=33478 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=33260 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 --- Comment #29 from David Nind --- (In reply to Martin Renvoize from comment #28) > Hi David, > > I'm really struggling to replicate your test failure with that final > follow-up. Did you take any other steps not listed in your test plan? I've > followed it all through and the test just won't fail for me :( It's still failing for me - same message. I'm all up-to-date - git pulls for koha and KTD, ktd pull, apply patches, restart_all. I haven't done anything in the UI, or set up email sending. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 --- Comment #28 from Martin Renvoize --- Hi David, I'm really struggling to replicate your test failure with that final follow-up. Did you take any other steps not listed in your test plan? I've followed it all through and the test just won't fail for me :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 David Nind changed: What|Removed |Added Text to go in the|This fixes the display of n |This fixes notice previews release notes||for patrons in the staff ||interface (Patrons > ||[Patron account] > ||Notices), where HTML is ||used in the email notices. ||For example, previously if ||s were used then the ||preview would match the ||email sent, however, using ||s would add extra lines ||in the preview. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 David Nind changed: What|Removed |Added Text to go in the||This fixes the display of n release notes|| Status|Needs Signoff |Failed QA --- Comment #27 from David Nind --- Hi Martin. It wouldn't hurt adding something like a little alert in the Modal when NoticeCSS is detected that the content may not display correctly in all email clients. But as you say, this should be a separate bug. Alternatively or in addition, we could add a note to the NoticeCSS documentation about this. I'm assuming that it works fine for printed notices, and it doesn't always work with emails is because of the vagaries of HTML email and different email clients. Tests are still failing for me: kohadev-koha@kohadevbox:koha(bz30287)$ prove t/db_dependent/Koha/Notice/Message.t t/db_dependent/Koha/Notice/Message.t .. # Failed test 'html_content returned the correct html wrapped letter' # at t/db_dependent/Koha/Notice/Message.t line 92. # got: 'http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd";> # http://www.w3.org/1999/xhtml";> # # uLrVEOWv9 # # # # # This is a test template using borrower 55 # # # ' # expected: 'http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd";> # http://www.w3.org/1999/xhtml";> # # uLrVEOWv9 # # # # # This is a test template using borrower 55 # # # ' # Looks like you failed 1 test of 2. t/db_dependent/Koha/Notice/Message.t .. 1/1 # Failed test 'html_content() tests' # at t/db_dependent/Koha/Notice/Message.t line 118. # Looks like you failed 1 test of 1. t/db_dependent/Koha/Notice/Message.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests Test Summary Report --- t/db_dependent/Koha/Notice/Message.t (Wstat: 256 Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 1 Files=1, Tests=1, 1 wallclock secs ( 0.01 usr 0.01 sys + 0.89 cusr 0.18 csys = 1.09 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 --- Comment #26 from Martin Renvoize --- (In reply to Martin Renvoize from comment #25) > Do you think it worth a little alert in the Modal when NoticeCSS is detected > that the content may not display correctly in all email clients? If we do want this, I think it should be a new bug... I just looked at it and because we're using iFrames here's it's not as trivial as first thought. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 --- Comment #25 from Martin Renvoize --- Do you think it worth a little alert in the Modal when NoticeCSS is detected that the content may not display correctly in all email clients? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 --- Comment #24 from Martin Renvoize --- Created attachment 158834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158834&action=edit Bug 30287: (follow-up) Make unit test more reliable in ktd This patch mocks NoticeCSS earlier to ensure we're not inadvertantly failing due to a local setup in ktd having added to the preference. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 --- Comment #23 from Martin Renvoize --- I see now.. the test relies on NoticeCSS being empty prior to run.. I'll make it a little more reliable now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 --- Comment #22 from Martin Renvoize --- That's fantastic testing David, thankyou! I must admit, I was coding a little blind. As you've highlighted here, we were already displaying "most" notices correctly, it was only certain constructs that looked odd, but narrowing down which one's wasn't clear to me (you've proved that without was one case and I'm sure there are some others where this patch will help too). As for NoticeCSS, thanks for confirming my suspicions there too.. I wanted to make sure we covered it in the preview, but I am aware that using linked css sheets in emails is 'variable at best'.. I'm keen to keep working through the notices code and add options for embedding css at the top of the email as aposed to adding a linked sheet. Finally.. I'll take a look at the tests.. I wonder if there's a rebase issue crept in, they were working when I tested before uploading. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 David Nind changed: What|Removed |Added CC||da...@davidnind.com Status|Needs Signoff |Failed QA --- Comment #21 from David Nind --- I've tested, using the test plan below. I hope this covers things. Feel free to add other notices that better reflect the changes. I think everything works as expected, however the tests fail - see [3]. Test plan: 1. Setup KTD so it can send emails.[1] 2. Add an email to a patron's account (I used Henry Acevedo) and the koha user. 3. Add an email address to KohaAdminEmailAddress. 4. Edit patron so that email messages are sent for holds filled, item check-in, and item checkout. 5. Generate and send notices:[2] 5.1 Send the welcome email (Patron account > More > Send welcome email 5.2 Place and fill a hold so that is waiting for pickup 5.3 Checkout the held item to the patron 5.4 Check in the item checked out 5.5 Enable two-factor authentication (TwoFactorAuthentication system preference) for the koha user under Patrons > [Patron account] > More > Manage two-factor authentication 5.6 Enable UseEmailReceipts system preference, add a manual invoice, and then pay it 5.7 Change the password for the patron (using Edit the patron, rather than Change password) 5.8 Run misc/cronjobs/process_message_queue.pl 6. Compare the emails received and the notice previews under notices for the patron - see [2] for what to expect. 7. Apply the patch, flush_memcached, and restart_all. 8. Repeat steps 5 and 6 - the preview for the notices should either still match or be better (extra lines remove in previews), as noted in [2]. 9. Check that the new tests pass: prove t/db_dependent/Koha/Notice/Message.t [1] To test sending emails using a Google account: 1. Set up an App password for your Google Account 2. Edit /etc/koha/sites/kohadev/koha-conf.xml file and add this configuration near the end (where = your Google email address; = your APP password, not your Google account password): smtp.gmail.com 587 5 STARTTLS GOOGLEACCOUNTUSER GOOGLEAPPPASSWORD 1 [2] These notices were tested (includes any notes about before and after): - WELCOME (HTML - uses s): before - both email and preview match; after - both email and preview match - HOLD (plaintext): before - both email and preview match; after - both email and preview match - CHECKOUT (plaintext): before - both email and preview match (no lines between paragraphs); after - both email and preview match - CHECKIN (plaintext): before - both email and preview match (no lines between paragraphs); after - both email and preview match - 2FA_ENABLE (HTML - uses tags): before - the email mesage is fine, the preview has extra blank lines between paragraphs; after - the email mesage is fine (no change), the preview is now displayed correctly with no extra blank lines between paragraphs - ACCOUNT_PAYMENT (plaintext): before - both email and preview match; after - both email and preview match; - PASSWORD_CHANGE (plaintext): before - email and preview match; after - email and preview match (note: sent directly, not through the message queue, but shows in notices) [3] The tests fail for me after the patches are applied: kohadev-koha@kohadevbox:koha(bz30287)$ prove t/db_dependent/Koha/Notice/Message.t t/db_dependent/Koha/Notice/Message.t .. # Failed test 'html_content returned the correct html wrapped letter' # at t/db_dependent/Koha/Notice/Message.t line 91. # got: 'http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd";> # http://www.w3.org/1999/xhtml";> # # fyOGZoKQa # # http://127.0.0.1:8081/intranet-tmpl/prog/css/notices.css";> # # # This is a test template using borrower 55 # # # ' # expected: 'http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd";> # http://www.w3.org/1999/xhtml";> # # fyOGZoKQa # # # # # This is a test template using borrower 55 # # # ' # Looks like you failed 1 test of 2. t/db_dependent/Koha/Notice/Message.t .. 1/1 # Failed test 'html_content() tests' # at t/db_dependent/Koha/Notice/Message.t line 117. # Looks like you failed 1 test of 1. t/db_dependent/Koha/Notice/Message.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests Test Summary Report --- t/db_dependent/Koha/Notice/Message.t (Wstat: 256 Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 1 Files=1, Tests=1, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.94 cusr 0.15 csys = 1.11 CPU) Result: FAIL Other testing notes: 1. I tried to test sending the cart and a list (I realised after that these are sent these are sent direct, and not i
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Katrin Fischer changed: What|Removed |Added Keywords||release-notes-needed --- Comment #20 from Katrin Fischer --- Can we please have a test plan? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Martin Renvoize changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 koha-US bug tracker changed: What|Removed |Added CC||bugzi...@koha-us.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Martin Renvoize changed: What|Removed |Added Summary|Notices using HTML renders |Notices using HTML render |differently in notices.pl |differently in notices.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
