[Koha-bugs] [Bug 30398] Reindent invoices template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30398 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30398] Reindent invoices template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30398 --- Comment #10 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30398] Reindent invoices template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30398 Fridolin Somers changed: What|Removed |Added Version(s)||22.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30398] Reindent invoices template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30398 --- Comment #9 from Kyle M Hall --- Created attachment 132860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132860&action=edit Bug 30398: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Séverine Queune Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30398] Reindent invoices template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30398 Kyle M Hall changed: What|Removed |Added Attachment #132788|0 |1 is obsolete|| Attachment #132789|0 |1 is obsolete|| --- Comment #8 from Kyle M Hall --- Created attachment 132859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132859&action=edit Bug 30398: Reindent invoices template This patch updates the invoices template so that the indentation is consistent. To test, apply the patch and go to Acquisitions. - Locate a vendor which has multiple invoices associated with it. - View the vendor details, and click the "Invoices" link in the sidebar. - The display of invoices should look correct. The DataTable should work correctly. - Test the search filters in the sidebar to confirm that they work too. Signed-off-by: Séverine Queune Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30398] Reindent invoices template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30398 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30398] Reindent invoices template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30398 --- Comment #7 from Séverine Queune --- Oups... Seemed I completely miss something at the first testing... Works as expected ! Thanks for the advice, I'll open new bug for the proposal :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30398] Reindent invoices template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30398 Séverine Queune changed: What|Removed |Added Attachment #132481|0 |1 is obsolete|| --- Comment #6 from Séverine Queune --- Created attachment 132789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132789&action=edit Bug 30398: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Séverine Queune -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30398] Reindent invoices template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30398 Séverine Queune changed: What|Removed |Added Attachment #132480|0 |1 is obsolete|| --- Comment #5 from Séverine Queune --- Created attachment 132788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132788&action=edit Bug 30398: Reindent invoices template This patch updates the invoices template so that the indentation is consistent. To test, apply the patch and go to Acquisitions. - Locate a vendor which has multiple invoices associated with it. - View the vendor details, and click the "Invoices" link in the sidebar. - The display of invoices should look correct. The DataTable should work correctly. - Test the search filters in the sidebar to confirm that they work too. Signed-off-by: Séverine Queune -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30398] Reindent invoices template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30398 Séverine Queune changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30398] Reindent invoices template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30398 --- Comment #4 from Owen Leonard --- It's worth filing a separate bug if you have ideas for updating the form. The point of this patch is just to fix the format of the markup, so there should be no visible changes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30398] Reindent invoices template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30398 Séverine Queune changed: What|Removed |Added CC||severine.que...@bulac.fr --- Comment #3 from Séverine Queune --- Wouldn't be useful to have a 'Clear' button next to the 'Search' one ? The form seems a little bit long : would it be possible to collapse the 'Shipment date' and 'Billing date' forms and only develop them when clicking on the title, like it's possible in the patron registration account with CollapseFieldsPatronAddForm syspref ? Maybe a silly proposal... All the other points are ok for me :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30398] Reindent invoices template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30398 Owen Leonard changed: What|Removed |Added Blocks||30400 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30400 [Bug 30400] Convert invoices page tabs to Bootstrap -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30398] Reindent invoices template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30398 --- Comment #2 from Owen Leonard --- Created attachment 132481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132481&action=edit Bug 30398: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30398] Reindent invoices template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30398 --- Comment #1 from Owen Leonard --- Created attachment 132480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132480&action=edit Bug 30398: Reindent invoices template This patch updates the invoices template so that the indentation is consistent. To test, apply the patch and go to Acquisitions. - Locate a vendor which has multiple invoices associated with it. - View the vendor details, and click the "Invoices" link in the sidebar. - The display of invoices should look correct. The DataTable should work correctly. - Test the search filters in the sidebar to confirm that they work too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30398] Reindent invoices template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30398 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/