[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-11-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

Arthur Suzuki  changed:

   What|Removed |Added

 CC||arthur.suz...@biblibre.com

--- Comment #38 from Arthur Suzuki  ---
depends on 27344, seems i can't apply that one on 21.11.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-11-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|22.11.00|22.11.00, 22.05.07
released in||

--- Comment #37 from Lucas Gass  ---
Backported to 22.05.x for upcoming 22.05.07 release

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-11-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

--- Comment #36 from Nick Clemens  ---
Created attachment 142860
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142860=edit
Bug 30462: [22.05.x] Separate Queued and Complete jobs

This patch updates the background jobs management page to display
queued and completed jobs in their own tabs on the page.

JD Amended patch:
Fix QA failures:
 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/admin/background_jobs.tt
   FAIL   forbidden patterns
forbidden pattern: trailing space char (line 158)
forbidden pattern: trailing space char (line 256)
Signed-off-by: Jonathan Druart 

Signed-off-by: Kyle M Hall 

Bug 30462: (follow-up) Limit completed to 60 minutes

This follow-up reduces the completed jobs list to only those jobs
completed within the last 60 minutes.

Signed-off-by: Jonathan Druart 

Signed-off-by: Kyle M Hall 

Bug 30462: Remove 'Ended' column for current jobs

This column will always be empty

Signed-off-by: Jonathan Druart 

Signed-off-by: Kyle M Hall 

Bug 30462: Fix display of the complete jobs

We want to display the jobs terminated in the last hour, not today.

Signed-off-by: Jonathan Druart 

Signed-off-by: Kyle M Hall 

Bug 30462: (QA follow-up) Tab name change

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 CC||lu...@bywatersolutions.com
 Resolution|--- |FIXED

--- Comment #35 from Lucas Gass  ---
Enhancement will not be backported for 22.05.x series

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-09-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

--- Comment #34 from Tomás Cohen Arazi  ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-09-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Version(s)||22.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-09-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

--- Comment #33 from Tomás Cohen Arazi  ---
Created attachment 140353
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140353=edit
Bug 30462: (QA follow-up) Tab name change

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-09-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

--- Comment #32 from Kyle M Hall  ---
Created attachment 140148
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140148=edit
Bug 30462: Fix display of the complete jobs

We want to display the jobs terminated in the last hour, not today.

Signed-off-by: Jonathan Druart 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-09-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

--- Comment #31 from Kyle M Hall  ---
Created attachment 140147
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140147=edit
Bug 30462: Remove 'Ended' column for current jobs

This column will always be empty

Signed-off-by: Jonathan Druart 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-09-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

--- Comment #30 from Kyle M Hall  ---
Created attachment 140146
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140146=edit
Bug 30462: (follow-up) Limit completed to 60 minutes

This follow-up reduces the completed jobs list to only those jobs
completed within the last 60 minutes.

Signed-off-by: Jonathan Druart 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-09-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #136001|0   |1
is obsolete||
 Attachment #136002|0   |1
is obsolete||
 Attachment #136003|0   |1
is obsolete||
 Attachment #136004|0   |1
is obsolete||

--- Comment #29 from Kyle M Hall  ---
Created attachment 140145
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140145=edit
Bug 30462: Separate Queued and Complete jobs

This patch updates the background jobs management page to display
queued and completed jobs in their own tabs on the page.

JD Amended patch:
Fix QA failures:
 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/admin/background_jobs.tt
   FAIL   forbidden patterns
forbidden pattern: trailing space char (line 158)
forbidden pattern: trailing space char (line 256)
Signed-off-by: Jonathan Druart 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-09-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-07-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

--- Comment #28 from Jonathan Druart  ---
(In reply to Katrin Fischer from comment #27)
> Can I please have a test plan for this one? I don't know much about the
> background jobs yet, so I wonder what the best way would be to ensure I have
> a completed and a queued job?

You can use one of these methods:
1. batch mod a long list of items
2. add a sleep in the ->process method of one of the Koha::BackgroundJob
modules
3. modify in DB directly to simulate a running job: set status="new",
ended_on=null

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

--- Comment #27 from Katrin Fischer  ---
Can I please have a test plan for this one? I don't know much about the
background jobs yet, so I wonder what the best way would be to ensure I have a
completed and a queued job?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-06-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||30982


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982
[Bug 30982] Use the REST API for background job list view
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-06-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

--- Comment #26 from Jonathan Druart  ---
(In reply to Martin Renvoize from comment #21)
> I think this should be enough to backport and get us out of the current hole
> we are in.. I don't think we should completely hide index jobs for now.
> 
> I think further work should be done in new bugs linked off this one to
> refine the whole interface and convert to API-driven tables allowing for
> more full-fledged filters.

We will certainly need to provide a new patch to backport anyway. Now we don't
see previous jobs.

I don't think this is correct, but SO to make the discussion move forward.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-06-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

--- Comment #25 from Jonathan Druart  ---
Created attachment 136004
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136004=edit
Bug 30462: Fix display of the complete jobs

We want to display the jobs terminated in the last hour, not today.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-06-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

--- Comment #24 from Jonathan Druart  ---
Created attachment 136003
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136003=edit
Bug 30462: Remove 'Ended' column for current jobs

This column will always be empty

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-06-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

--- Comment #23 from Jonathan Druart  ---
Created attachment 136002
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136002=edit
Bug 30462: (follow-up) Limit completed to 60 minutes

This follow-up reduces the completed jobs list to only those jobs
completed within the last 60 minutes.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-06-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #135750|0   |1
is obsolete||
 Attachment #135938|0   |1
is obsolete||

--- Comment #22 from Jonathan Druart  ---
Created attachment 136001
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136001=edit
Bug 30462: Separate Queued and Complete jobs

This patch updates the background jobs management page to display
queued and completed jobs in their own tabs on the page.

JD Amended patch:
Fix QA failures:
 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/admin/background_jobs.tt
   FAIL   forbidden patterns
forbidden pattern: trailing space char (line 158)
forbidden pattern: trailing space char (line 256)
Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-06-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-06-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

--- Comment #21 from Martin Renvoize  ---
I think this should be enough to backport and get us out of the current hole we
are in.. I don't think we should completely hide index jobs for now.

I think further work should be done in new bugs linked off this one to refine
the whole interface and convert to API-driven tables allowing for more
full-fledged filters.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-06-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

--- Comment #20 from Martin Renvoize  ---
Created attachment 135938
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135938=edit
Bug 30462: (follow-up) Limit completed to 60 minutes

This follow-up reduces the completed jobs list to only those jobs
completed within the last 60 minutes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

--- Comment #19 from David Cook  ---
(In reply to Jonathan Druart from comment #17)
> Wouldn't it better to fetch the queued jobs only by default? Thinking about
> perfs if there are too many entries.

I was thinking about that as well. 

So long as there is a timestamp index, I reckon we show the queued jobs and
maybe the last 60 minutes of completed jobs (no indexing jobs though), and that
should be good?

A database admin or Reports user can look up indexing jobs more directly if
they want to double-check that the indexing is running correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

--- Comment #18 from Jonathan Druart  ---
Or maybe simply remove the tabs and have a "see all" link/checkbox to display
all the jobs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

--- Comment #17 from Jonathan Druart  ---
Wouldn't it better to fetch the queued jobs only by default? Thinking about
perfs if there are too many entries.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|jonathan.druart+koha@gmail. |martin.renvoize@ptfs-europe
   |com |.com

--- Comment #16 from Jonathan Druart  ---
I am seeing this: https://snipboard.io/atirmJ.jpg

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #135583|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|rel_22_05_candidate |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

--- Comment #15 from Martin Renvoize  ---
This serves as an alternative.. instead of cleaning up the tasks from inside
the job I split out Queued and Completed jobs into their own tabs.

I'm tempted to go further and add a checkbox for displaying 'System initiated'
jobs along with the 'User initiated' jobs and hide the system ones by default.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #135749|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

--- Comment #14 from Martin Renvoize  ---
Created attachment 135750
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135750=edit
Bug 30462: Separate Queued and Complete jobs

This patch updates the background jobs management page to display
queued and completed jobs in their own tabs on the page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

--- Comment #13 from Martin Renvoize  ---
Created attachment 135749
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135749=edit
Bug 30462: Separate Running and Complete jobs

This patch updates the background jobs management page to display
running and completed jobs in their own tabs on the page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

--- Comment #12 from Katrin Fischer  ---
(In reply to Martin Renvoize from comment #11)
> I took a quick look at the code and realised we're not using APIs or
> KohaTable here yet.. that has become a stretch goal for me, but we need
> something quick here.  I'll have a go at doing it the old fashioned way here
> today as an alternative option, but if that proves too big a goal I think
> the patch here gets us out of a hole in the short term.

I'd say hide them all by default and maybe have an option to see them if
necessary (maybe like we do for transactions on the accounting table?)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

--- Comment #11 from Martin Renvoize  ---
I took a quick look at the code and realised we're not using APIs or KohaTable
here yet.. that has become a stretch goal for me, but we need something quick
here.  I'll have a go at doing it the old fashioned way here today as an
alternative option, but if that proves too big a goal I think the patch here
gets us out of a hole in the short term.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-06-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

--- Comment #10 from David Cook  ---
(In reply to Martin Renvoize from comment #9)
> I also think perhaps we could be hiding completed tasks by default on top of
> hiding system tasks.

Oh there's a good idea too. Maybe hiding completed tasks over a certain age
though? Sometimes I think you'd want to see a recently completed task?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-06-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

--- Comment #9 from Martin Renvoize  ---
I'm with David on this one.. I think we should be hiding 'system tasks' from
the UI by default and I don't think the task should be cleaning up after
itself, rather we should add cleanup to cleanup_database.pl.

I also think perhaps we could be hiding completed tasks by default on top of
hiding system tasks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #8 from David Cook  ---
+1 to hiding the indexing tasks from the general view

I don't know about deleting them immediately. On one hand, I'm in favour of
this and it would be useful for some other background tasks I have in mind
(like OAI-PMH harvesting of records). On the other hand, it does make it harder
to track background tasks when troubleshooting.

Could we hide them from the interface and then rely on cleanup_database.pl to
clean up the successful indexing tasks nightly? 

That way users don't see useless tasks, but administrators could double-check.

The other issue I see with this one is that the behaviour is encoded in
Koha/BackgroundJob/UpdateElasticIndex.pm specifically rather than in the
general task management. Doesn't that open up the door for inconsistent
behaviours among different background jobs? 

Not opposed to the current patch. Just asking some questions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #135570|0   |1
is obsolete||

--- Comment #7 from Tomás Cohen Arazi  ---
Created attachment 135583
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135583=edit
Bug 30462: Delete the update_elastic_index jobs when done

One entry per reindexation will generate a lot of rows in this table and
the UI will become unusable.
We should either hide them by default or simply remove them from the DB.
This patch implements the second option.

Test plan:
Edit a bibliographic record
If you are fast enough you should see a "new" jobs in the
background_jobs DB table
When done/finished, the rows will be deleted from the DB

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Keywords||rel_22_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com,
   ||n...@bywatersolutions.com

--- Comment #6 from Tomás Cohen Arazi  ---
I think you can do better with the commit subject heh.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail.
   |ity.org |com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

--- Comment #5 from Jonathan Druart  ---
Created attachment 135570
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135570=edit
B

Bug 30462: Delete the update_elastic_index jobs when done

One entry per reindexation will generate a lot of rows in this table and
the UI will become unusable.
We should either hide them by default or simply remove them from the DB.
This patch implements the second option.

Test plan:
Edit a bibliographic record
If you are fast enough you should see a "new" jobs in the
background_jobs DB table
When done/finished, the rows will be deleted from the DB

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-06-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

--- Comment #4 from Andrew Nugged  ---
More: more days passed, more testing on production. I see huge and very
uncomfortable pollution in the "background jobs" table/page - all flooded with
"reindexing".

I propose even more: what if we will make configurable parameter to ERASE
successful reindex jobs on finish? The rest jobs might stay. Or that parameter
will be even more flexible so we can configure what jobs should be wiped-out on
the "errorless finish" state.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-05-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

Andrew Nugged  changed:

   What|Removed |Added

 CC||nug...@gmail.com

--- Comment #3 from Andrew Nugged  ---
bringing our experience from piloting production with the current master.
It's even not that "very busy day" and vacations week,
but in the "Background jobs" page we have roughly 3-10 reindexing records per
minute on that page, and that's also not that biggest library too.

that makes that page unusable - it is just polluted with a lot of noise.



I'd say we should make filtering in Background Jobs and show by default:

- unfinished only + number of totals,

- then hide index updates as well or allow users to filter out later by job
type.

- + maybe count stats (oh I dream we use minion with it's statistics graphs one
day :) -
https://raw.github.com/mojolicious/minion/main/examples/admin.png?raw=true
(https://docs.mojolicious.org/Minion))

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462
Bug 30462 depends on bug 27344, which changed state.

Bug 27344 Summary: Implement Elastic's update_index_background using 
Koha::BackgroundJob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-05-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #2 from Martin Renvoize  ---
Yes :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-05-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #1 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #0)
> We will certainly end up with lot of indexation tasks. Shouldn't we hide
> them by default when we list the tasks on Home > Administration > Background
> jobs ?

Yes!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/