[Koha-bugs] [Bug 30483] Do not allow NULL in issues.borrowernumber and issues.itemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30483
--- Comment #16 from Marcel de Rooy ---
(In reply to Pablo López Liotti from comment #15)
> Hi, I'm upgrading a Koha 21.05 in Debian 9.5 to Koha 22.05.
>
> After I do command line upgrade of koha-common, the intranet shows web
> install.
> Here, in tables structure update, the process stop with this message:
>
> Updating database structure
> Update errors :
>
> Upgrade to 22.05.06.001 [13:31:19]: Bug 30483 - Make issues.borrowernumber
> and itemnumber NOT NULL
> ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Cannot change
> column 'borrowernumber': used in a foreign key constraint 'issues_ibfk_1' at
> /usr/share/koha/lib/C4/Installer.pm line 739
>
> Now, what can I do?
> Thks
See bug 32399. There is a fix.
And it should have been pushed already to 22.05. But somehow it wasnt.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30483] Do not allow NULL in issues.borrowernumber and issues.itemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30483
Pablo López Liotti changed:
What|Removed |Added
CC||palio...@mdp.edu.ar
--- Comment #15 from Pablo López Liotti ---
Hi, I'm upgrading a Koha 21.05 in Debian 9.5 to Koha 22.05.
After I do command line upgrade of koha-common, the intranet shows web install.
Here, in tables structure update, the process stop with this message:
Updating database structure
Update errors :
Upgrade to 22.05.06.001 [13:31:19]: Bug 30483 - Make issues.borrowernumber and
itemnumber NOT NULL
ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Cannot change column
'borrowernumber': used in a foreign key constraint 'issues_ibfk_1' at
/usr/share/koha/lib/C4/Installer.pm line 739
Now, what can I do?
Thks
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30483] Do not allow NULL in issues.borrowernumber and issues.itemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30483 tony-the-hawk changed: What|Removed |Added CC||antonio.fa...@unito.it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30483] Do not allow NULL in issues.borrowernumber and issues.itemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30483 --- Comment #14 from Marcel de Rooy --- Follow-up on bug 32399 to prevent failures. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30483] Do not allow NULL in issues.borrowernumber and issues.itemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30483 Katrin Fischer changed: What|Removed |Added Blocks||32399 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32399 [Bug 32399] Database update for bug 30483 is failing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30483] Do not allow NULL in issues.borrowernumber and issues.itemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30483 Victor Grousset/tuxayo changed: What|Removed |Added Resolution|--- |FIXED CC||vic...@tuxayo.net Status|Pushed to stable|RESOLVED --- Comment #13 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30483] Do not allow NULL in issues.borrowernumber and issues.itemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30483 Lucas Gass changed: What|Removed |Added Version(s)|22.11.00|22.11.00, 22.05.07 released in|| CC||lu...@bywatersolutions.com Status|Pushed to master|Pushed to stable --- Comment #12 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.07 release -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30483] Do not allow NULL in issues.borrowernumber and issues.itemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30483 --- Comment #11 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30483] Do not allow NULL in issues.borrowernumber and issues.itemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30483 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30483] Do not allow NULL in issues.borrowernumber and issues.itemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30483 --- Comment #10 from Joonas Kylmälä --- Created attachment 139925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139925&action=edit Bug 30483: (DBIx schema) Changes to Issue.pm Compare with results of update_dbix_class_files.pl. Signed-off-by: Martin Renvoize Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30483] Do not allow NULL in issues.borrowernumber and issues.itemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30483 Joonas Kylmälä changed: What|Removed |Added Attachment #139682|0 |1 is obsolete|| Attachment #139683|0 |1 is obsolete|| --- Comment #9 from Joonas Kylmälä --- Created attachment 139924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139924&action=edit Bug 30483: Make issues.borrowernumber and itemnumber NOT NULL Note: This change does NOT apply to old_issues, where constraints may result in nullifying these columns. Test plan: Run dbrev. Try checkout, checkin. Signed-off-by: Martin Renvoize Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30483] Do not allow NULL in issues.borrowernumber and issues.itemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30483 Joonas Kylmälä changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30483] Do not allow NULL in issues.borrowernumber and issues.itemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30483 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@iki.fi QA Contact|testo...@bugs.koha-communit |joonas.kylm...@iki.fi |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30483] Do not allow NULL in issues.borrowernumber and issues.itemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30483 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||martin.renvoize@ptfs-europe ||.com --- Comment #8 from Martin Renvoize --- Makes sense to me.. Signing off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30483] Do not allow NULL in issues.borrowernumber and issues.itemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30483 Martin Renvoize changed: What|Removed |Added Attachment #139195|0 |1 is obsolete|| --- Comment #7 from Martin Renvoize --- Created attachment 139683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139683&action=edit Bug 30483: (DBIx schema) Changes to Issue.pm Compare with results of update_dbix_class_files.pl. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30483] Do not allow NULL in issues.borrowernumber and issues.itemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30483 Martin Renvoize changed: What|Removed |Added Attachment #133079|0 |1 is obsolete|| --- Comment #6 from Martin Renvoize --- Created attachment 139682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139682&action=edit Bug 30483: Make issues.borrowernumber and itemnumber NOT NULL Note: This change does NOT apply to old_issues, where constraints may result in nullifying these columns. Test plan: Run dbrev. Try checkout, checkin. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30483] Do not allow NULL in issues.borrowernumber and issues.itemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30483 --- Comment #5 from Marcel de Rooy --- Note from a discussion on IRC: We do not anonymize active issues. So no problem there. And if we mark an item as lost but not returned, the issue should still have an itemnumber and a borrowernumber. So no problem too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30483] Do not allow NULL in issues.borrowernumber and issues.itemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30483 --- Comment #4 from Marcel de Rooy --- Note: You may observe that DBIx drops the LEFT join_type here. There is no reason to be worried about that. If a FK column allows NULL values, DBIx sets it to LEFT. We remove the NULL here and DBIx now defaults to INNER again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30483] Do not allow NULL in issues.borrowernumber and issues.itemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30483 Marcel de Rooy changed: What|Removed |Added Summary|Should |Do not allow NULL in |issues.borrowernumber and |issues.borrowernumber and |issues.itemnumber be NOT|issues.itemnumber |NULL ? | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
