[Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 Martin Renvoize changed: What|Removed |Added Blocks||34269 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 [Bug 34269] Regression in circulation rules for 'similar' patron categories -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 --- Comment #4 from Katrin Fischer --- Hi, should this be Needs Signoff? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 Shi Yao Wang changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 Blou changed: What|Removed |Added Patch complexity|--- |Trivial patch Assignee|koha-b...@lists.koha-commun |shi-yao.w...@inlibro.com |ity.org | --- Comment #5 from Blou --- no interest? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 Emmanuel Bétemps changed: What|Removed |Added CC||e.bete...@gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #6 from Emmanuel Bétemps --- Hi, I just testried on a sandbox and it doesn't work step 11 displays the same results as in steps 8 & 9 : All/All rule is modified when I edit the All/Books rule -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 --- Comment #7 from Katrin Fischer --- Did you install the translations before or after the patch was applied? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 Katrin Fischer changed: What|Removed |Added Status|Patch doesn't apply |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 --- Comment #8 from Emmanuel Bétemps --- (In reply to Katrin Fischer from comment #7) > Did you install the translations before or after the patch was applied? I just followed the test plan : translation (french) installed before applying the patch. I can try applying the patch before installing the language. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 --- Comment #9 from Emmanuel Bétemps --- I tested applying the patch and, after, installing the language. Patch works better but some things bother me 1.I click on "Circulation and fines rules" 2.I click on the Edit button to modify "All / Books" 3. I save my changes -> I really modify "All / Books" -> the bottom line (i.e the one where we write our changes) resets But sometimes, if I don't want to save my changes, I click on another line to edit (Koha asks me then if I am sure) but it doesn't change the bottom line. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 Shi Yao Wang changed: What|Removed |Added Attachment #133404|0 |1 is obsolete|| --- Comment #10 from Shi Yao Wang --- Created attachment 139718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139718&action=edit Bug 30517: Translation breaks editing parent type circulation rule fix Test plan: 1. Install another language in the staff interface 1. in commandline: `cd misc/translator/; ./translate install xx-XX` 2. Check the box of the language in the 'language' system preference and save 3. Refresh and you should be able to choose languages 2. Create an item type with a parent 1. Go to Administration > Item types 2. Create a new item type or modify an existing one, assigning a parent type (I created a 'Children's books' type and assigned 'Books' as its parent) 3. Create a circulation rule for the parent type (I created All/Books, with 10 checkouts allowed) 4. Create a circulation rule for All/All (I created All/All with 30 checkouts allowed) 5. In English, click on "Edit" next to the parent type rule (All/Books) --> Note that the item type in the bottom row (the modifiable row) is changed to 'Books (All)' 6. Modify the number of checkouts allowed (e.g. 99) --> The All/Books rule is modified 7. Switch the interface to the other language 8. Click on "Edit" next to the parent type rule (All/Books) --> Note that the item type in the bottom row stays on 'All' 9. Modify the number of checkouts allowed (e.g. 88) --> The All/All rule is modified 10. Apply the patch, translate again and refresh the page 11. Do step 8-9 again and notice it now behaves as it should -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 --- Comment #11 from Shi Yao Wang --- Updated the test plan to make it a bit more clear. (In reply to Emmanuel Bétemps from comment #9) > I tested applying the patch and, after, installing the language. > > Patch works better but some things bother me > > > 1.I click on "Circulation and fines rules" > 2.I click on the Edit button to modify "All / Books" > 3. I save my changes > -> I really modify "All / Books" > -> the bottom line (i.e the one where we write our changes) resets > > But sometimes, if I don't want to save my changes, I click on another line > to edit (Koha asks me then if I am sure) but it doesn't change the bottom > line. I do not seem to have this problem. What I did after the test plan: 1- Go to Administration -> Circulation and fines rules 2- Click edit button for "All / Books" 3- Modify "Checkouts allowed" to a different number 4- Click on edit button for "All / All" without saving 5- Click ok on the confirmation popup 6- Bottom line's information change to "All / All" circulation rule values -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 --- Comment #12 from Katrin Fischer --- (In reply to Emmanuel Bétemps from comment #9) > I tested applying the patch and, after, installing the language. > > Patch works better but some things bother me > > > 1.I click on "Circulation and fines rules" > 2.I click on the Edit button to modify "All / Books" > 3. I save my changes > -> I really modify "All / Books" > -> the bottom line (i.e the one where we write our changes) resets > > But sometimes, if I don't want to save my changes, I click on another line > to edit (Koha asks me then if I am sure) but it doesn't change the bottom > line. When you install a language it copies the templates and files. So if you install the patch first, you'll look at unchanged/old templates that don't have the patch. You probably also need to make sure that "all" has been translated to something else in that language. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 --- Comment #13 from Katrin Fischer --- > > When you install a language it copies the templates and files. So if you > install the patch first, you'll look at unchanged/old templates that don't > have the patch. > You probably also need to make sure that "all" has been translated to > something else in that language. That should have read...: so if you install the language first... because installing the patch will then only update the English files and not trigger updating the translated files as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 Shi Yao Wang changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 Emmanuel Bétemps changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #14 from Emmanuel Bétemps --- Hi, Patch doesn't apply (I followed the test plan in comment #10) Screenshot confirms I (really) just need to know if I must install language or patch first :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 --- Comment #15 from Emmanuel Bétemps --- Created attachment 140091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140091&action=edit Bottom line doesn't edit the chosen line -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 --- Comment #16 from Shi Yao Wang --- (In reply to Emmanuel Bétemps from comment #14) > Hi, > > Patch doesn't apply (I followed the test plan in comment #10) > Screenshot confirms > > I (really) just need to know if I must install language or patch first :) Hi, thanks for testing again. TLDR: `./translate install xx-XX` before and after the patch You need to install the language at step 1: >1. Install another language in the staff interface > 1. in commandline: `cd misc/translator/; ./translate install xx-XX` > 2. Check the box of the language in the 'language' system preference >and save > 3. Refresh and you should be able to choose languages apply the patch at step 10: >10. Apply the patch, translate again and refresh the page and do step 1.1 again to refresh translations (that's what I meant by "translate again" here). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 ByWater Sandboxes changed: What|Removed |Added Attachment #139718|0 |1 is obsolete|| --- Comment #17 from ByWater Sandboxes --- Created attachment 140193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140193&action=edit Bug 30517: Translation breaks editing parent type circulation rule fix Test plan: 1. Install another language in the staff interface 1. in commandline: `cd misc/translator/; ./translate install xx-XX` 2. Check the box of the language in the 'language' system preference and save 3. Refresh and you should be able to choose languages 2. Create an item type with a parent 1. Go to Administration > Item types 2. Create a new item type or modify an existing one, assigning a parent type (I created a 'Children's books' type and assigned 'Books' as its parent) 3. Create a circulation rule for the parent type (I created All/Books, with 10 checkouts allowed) 4. Create a circulation rule for All/All (I created All/All with 30 checkouts allowed) 5. In English, click on "Edit" next to the parent type rule (All/Books) --> Note that the item type in the bottom row (the modifiable row) is changed to 'Books (All)' 6. Modify the number of checkouts allowed (e.g. 99) --> The All/Books rule is modified 7. Switch the interface to the other language 8. Click on "Edit" next to the parent type rule (All/Books) --> Note that the item type in the bottom row stays on 'All' 9. Modify the number of checkouts allowed (e.g. 88) --> The All/All rule is modified 10. Apply the patch, translate again and refresh the page 11. Do step 8-9 again and notice it now behaves as it should Signed-off-by: Emmanuel Bétemps -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 Emmanuel Bétemps changed: What|Removed |Added Status|Patch doesn't apply |Signed Off --- Comment #18 from Emmanuel Bétemps --- (In reply to Shi Yao Wang from comment #16) > apply the patch at step 10: > >10. Apply the patch, translate again and refresh the page > > and do step 1.1 again to refresh translations (that's what I meant by > "translate again" here). my bad ! I didn't understand I had to install translation twice (once before and once after installing the patch) 'translate again' meant to me 'change the language of the interface' thanks for your patience & explanations :) Emmanuel Bétemps -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to oldoldoldstable |RESOLVED --- Comment #26 from wainuiwitikap...@catalyst.net.nz --- (In reply to wainuiwitikapark from comment #25) > Not released in 21.05.22 Reverted from 21.05 branch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 --- Comment #1 from Caroline Cyr La Rose --- This is the string that is causing the problem #. %1$s: itemtypeloo.translated_description | html #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:374 #, c-format msgid "%s (All)" msgstr "%s (Toutes)" If I add fuzzy to the last commented line and reapply the translation, the problem goes away. #. %1$s: itemtypeloo.translated_description | html #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:374 #, fuzzy,c-format msgid "%s (All)" msgstr "%s (Toutes)" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 Caroline Cyr La Rose changed: What|Removed |Added CC||philippe.blo...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 --- Comment #2 from Shi Yao Wang --- Created attachment 133364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133364&action=edit Bug 30517: Translation breaks editing parent type circulation rule fix Test plan: 1. Install another language in the staff interface 1. ./translate install xx-XX 2. Check the box of the language in the 'language' system preference 3. Refresh 2. Create an item type with a parent 1. Go to Administration > Item types 2. Create a new item type or modify an existing one, assigning a parent type (I created a 'Children's books' type and assigned 'Books' as its parent) 3. Create a circulation rule for the parent type (I created All/Books, with 10 checkouts allowed) 4. Create a circulation rule for All/All (I created All/All with 30 checkouts allowed) 5. In English, click on "Edit" next to the parent type rule (All/Books) --> Note that the item type in the bottom row (the modifiable row) is changed to 'Books (All)' 6. Modify the number of checkouts allowed (e.g. 99) --> The All/Books rule is modified 7. Switch the interface to the other language 8. Click on "Edit" next to the parent type rule (All/Books) --> Note that the item type in the bottom row stays on 'All' 9. Modify the number of checkouts allowed (e.g. 88) --> The All/All rule is modified 10. Apply the patch and refresh 11. Do step 8-9 again and notice it now behaves as it should -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 Shi Yao Wang changed: What|Removed |Added CC||shi-yao.w...@inlibro.com Attachment #133364|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 --- Comment #3 from Shi Yao Wang --- Created attachment 133404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133404&action=edit Bug 30517: Translation breaks editing parent type circulation rule fix Test plan: 1. Install another language in the staff interface 1. ./translate install xx-XX 2. Check the box of the language in the 'language' system preference 3. Refresh 2. Create an item type with a parent 1. Go to Administration > Item types 2. Create a new item type or modify an existing one, assigning a parent type (I created a 'Children's books' type and assigned 'Books' as its parent) 3. Create a circulation rule for the parent type (I created All/Books, with 10 checkouts allowed) 4. Create a circulation rule for All/All (I created All/All with 30 checkouts allowed) 5. In English, click on "Edit" next to the parent type rule (All/Books) --> Note that the item type in the bottom row (the modifiable row) is changed to 'Books (All)' 6. Modify the number of checkouts allowed (e.g. 99) --> The All/Books rule is modified 7. Switch the interface to the other language 8. Click on "Edit" next to the parent type rule (All/Books) --> Note that the item type in the bottom row stays on 'All' 9. Modify the number of checkouts allowed (e.g. 88) --> The All/All rule is modified 10. Apply the patch and refresh 11. Do step 8-9 again and notice it now behaves as it should -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 Katrin Fischer changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 Katrin Fischer changed: What|Removed |Added Attachment #140193|0 |1 is obsolete|| --- Comment #19 from Katrin Fischer --- Created attachment 141202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141202&action=edit Bug 30517: Translation breaks editing parent type circulation rule fix Test plan: 1. Install another language in the staff interface 1. in commandline: `cd misc/translator/; ./translate install xx-XX` 2. Check the box of the language in the 'language' system preference and save 3. Refresh and you should be able to choose languages 2. Create an item type with a parent 1. Go to Administration > Item types 2. Create a new item type or modify an existing one, assigning a parent type (I created a 'Children's books' type and assigned 'Books' as its parent) 3. Create a circulation rule for the parent type (I created All/Books, with 10 checkouts allowed) 4. Create a circulation rule for All/All (I created All/All with 30 checkouts allowed) 5. In English, click on "Edit" next to the parent type rule (All/Books) --> Note that the item type in the bottom row (the modifiable row) is changed to 'Books (All)' 6. Modify the number of checkouts allowed (e.g. 99) --> The All/Books rule is modified 7. Switch the interface to the other language 8. Click on "Edit" next to the parent type rule (All/Books) --> Note that the item type in the bottom row stays on 'All' 9. Modify the number of checkouts allowed (e.g. 88) --> The All/All rule is modified 10. Apply the patch, translate again and refresh the page 11. Do step 8-9 again and notice it now behaves as it should Signed-off-by: Emmanuel Bétemps Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | --- Comment #20 from Katrin Fischer --- Overall I am not super happy about the way we rely on a regex here, but have not managed to break behavior in my tests. So this fix works and that's the most important as this bug has been there for too long causing potential data loss. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 --- Comment #21 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|22.11.00|22.11.00, 22.05.08 released in|| CC||lu...@bywatersolutions.com --- Comment #22 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.08 release -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 Arthur Suzuki changed: What|Removed |Added Status|Pushed to oldstable |Pushed to oldoldstable CC||arthur.suz...@biblibre.com Version(s)|22.11.00, 22.05.08 |22.11.00, 22.05.08, released in||21.11.15 --- Comment #23 from Arthur Suzuki --- applied to 21.11 for 21.11.15 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added CC||wainuiwitikapark@catalyst.n ||et.nz Status|Pushed to oldoldstable |Pushed to oldoldoldstable Version(s)|22.11.00, 22.05.08, |22.11.00, 22.05.08, released in|21.11.15|21.11.15, 21.05.22 --- Comment #24 from wainuiwitikap...@catalyst.net.nz --- Backported to 21.05.x for 21.05.22 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Version(s)|22.11.00, 22.05.08, |22.11.00, 22.05.08, released in|21.11.15, 21.05.22 |21.11.15 --- Comment #25 from wainuiwitikap...@catalyst.net.nz --- Not released in 21.05.22 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
