[Koha-bugs] [Bug 30903] CSV import of quotes broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 David Nind changed: What|Removed |Added CC||da...@davidnind.com Text to go in the||This fixes the import of release notes||quotes from a CSV file for ||the Quote of the Day ||feature. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30903] CSV import of quotes broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 Victor Grousset/tuxayo changed: What|Removed |Added Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #32 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30903] CSV import of quotes broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 Victor Grousset/tuxayo changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|22.11.00, 22.05.04 |22.11.00, 22.05.04, released in||21.11.11 CC||vic...@tuxayo.net --- Comment #31 from Victor Grousset/tuxayo --- note: was backported to 21.11.x for 21.11.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30903] CSV import of quotes broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|22.11.00|22.11.00, 22.05.04 released in|| CC||lu...@bywatersolutions.com --- Comment #30 from Lucas Gass --- Backported to 22.05.x for 22.05.04 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30903] CSV import of quotes broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 --- Comment #29 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30903] CSV import of quotes broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30903] CSV import of quotes broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA CC||martin.renvoize@ptfs-europe ||.com --- Comment #28 from Martin Renvoize --- Fixes the issue at hand, QA scripts are happy. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30903] CSV import of quotes broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 Martin Renvoize changed: What|Removed |Added Attachment #136704|0 |1 is obsolete|| --- Comment #27 from Martin Renvoize --- Created attachment 137178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137178&action=edit Bug 30903: (follow-up) Fix error message class Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30903] CSV import of quotes broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 Martin Renvoize changed: What|Removed |Added Attachment #136703|0 |1 is obsolete|| --- Comment #26 from Martin Renvoize --- Created attachment 137177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137177&action=edit Bug 30903: Fix UI glitch on the quotes upload view Signed-off-by: Fridolin Somers Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30903] CSV import of quotes broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 Martin Renvoize changed: What|Removed |Added Attachment #136702|0 |1 is obsolete|| --- Comment #25 from Martin Renvoize --- Created attachment 137176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137176&action=edit Bug 30903: Fix POST /quote quote_id should not be required Signed-off-by: Fridolin Somers Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30903] CSV import of quotes broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30903] CSV import of quotes broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 David Nind changed: What|Removed |Added Blocks||31063 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31063 [Bug 31063] [OMNIBUS] QOTD tool -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30903] CSV import of quotes broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 David Nind changed: What|Removed |Added Attachment #136439|0 |1 is obsolete|| --- Comment #24 from David Nind --- Created attachment 136704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136704&action=edit Bug 30903: (follow-up) Fix error message class Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30903] CSV import of quotes broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 David Nind changed: What|Removed |Added Attachment #136438|0 |1 is obsolete|| --- Comment #23 from David Nind --- Created attachment 136703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136703&action=edit Bug 30903: Fix UI glitch on the quotes upload view Signed-off-by: Fridolin Somers Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30903] CSV import of quotes broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 David Nind changed: What|Removed |Added Attachment #136437|0 |1 is obsolete|| --- Comment #22 from David Nind --- Created attachment 136702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136702&action=edit Bug 30903: Fix POST /quote quote_id should not be required Signed-off-by: Fridolin Somers Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30903] CSV import of quotes broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30903] CSV import of quotes broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au Severity|critical|normal --- Comment #21 from David Cook --- Downgrading the severity of this one since it's not critical to Koha operations -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30903] CSV import of quotes broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 Fridolin Somers changed: What|Removed |Added Attachment #136384|0 |1 is obsolete|| --- Comment #20 from Fridolin Somers --- Created attachment 136439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136439&action=edit Bug 30903: (follow-up) Fix error message class -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30903] CSV import of quotes broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 Fridolin Somers changed: What|Removed |Added Attachment #136336|0 |1 is obsolete|| --- Comment #19 from Fridolin Somers --- Created attachment 136438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136438&action=edit Bug 30903: Fix UI glitch on the quotes upload view Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30903] CSV import of quotes broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 Fridolin Somers changed: What|Removed |Added Attachment #136383|0 |1 is obsolete|| --- Comment #18 from Fridolin Somers --- Created attachment 136437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136437&action=edit Bug 30903: Fix POST /quote quote_id should not be required Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30903] CSV import of quotes broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #17 from Marcel de Rooy --- Critical ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30903] CSV import of quotes broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 --- Comment #16 from Owen Leonard --- I'm getting this error: POST /api/v1/quotes: unhandled exception (DBIx::Class::Exception)
[Koha-bugs] [Bug 30903] CSV import of quotes broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 --- Comment #15 from Caroline Cyr La Rose --- I created Bug 31012 for the usability problem after uploading the quotes. I created Bug 31014 for the UI problems reported in the description. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30903] CSV import of quotes broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 Caroline Cyr La Rose changed: What|Removed |Added Blocks||31014 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31014 [Bug 31014] Minor UI problems in QOTD editor tool -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30903] CSV import of quotes broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 Caroline Cyr La Rose changed: What|Removed |Added Blocks||31012 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31012 [Bug 31012] Quote import tool should send the user back to quotes pages after importing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30903] CSV import of quotes broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 --- Comment #14 from Fridolin Somers --- (In reply to Caroline Cyr La Rose from comment #6) > 3) The quotes seem to have been imported, if I trust the confirmation > message, but I stayed on the same page and the two options available to me > are "Save quotes", which I already clicked (multiple times because it was > slow) and "Cancel import", which, if clicked, asks me a confirmation if I > really want to cancel and sends me back to the import page with the > Browse/Choose file button. I think once the quotes are imported, we should > be sent back to the main QOTD editor page with the list of quotes already in > the system. > > Caroline Same for me, please report it in a new report. Clicking on "Save quotes" will import them again, clicking on "Cancel import" does not revert the import. I think think after clicking on "Save quotes" we should hide those buttons and propose a link to come back to quotes table. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30903] CSV import of quotes broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 --- Comment #13 from Fridolin Somers --- I signed the 2 first patches. Quotes import works well. But then I generated the error case (by dropping quotes table). It does not appear because its class is "import_errors" instead of "import_error", see my follow-up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30903] CSV import of quotes broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 --- Comment #12 from Fridolin Somers --- Created attachment 136384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136384&action=edit Bug 30903: (follow-up) Fix error message class -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30903] CSV import of quotes broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 Fridolin Somers changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30903] CSV import of quotes broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 Fridolin Somers changed: What|Removed |Added Attachment #135773|0 |1 is obsolete|| --- Comment #11 from Fridolin Somers --- Created attachment 136383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136383&action=edit Bug 30903: Fix POST /quote quote_id should not be required Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30903] CSV import of quotes broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 Fridolin Somers changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30903] CSV import of quotes broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903
--- Comment #10 from Jonathan Druart ---
(In reply to Fridolin Somers from comment #8)
> +$("#messages .import_error").text($("Something went
> wrong, check your CSV file."));
>
> Sure about this code ? Looks not translatable.
> Is it a type with _("bla bla") ?
Yes!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30903] CSV import of quotes broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 Jonathan Druart changed: What|Removed |Added Attachment #135774|0 |1 is obsolete|| --- Comment #9 from Jonathan Druart --- Created attachment 136336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136336&action=edit Bug 30903: Fix UI glitch on the quotes upload view -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30903] CSV import of quotes broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903
Fridolin Somers changed:
What|Removed |Added
CC||fridolin.som...@biblibre.co
||m
--- Comment #8 from Fridolin Somers ---
+$("#messages .import_error").text($("Something went wrong,
check your CSV file."));
Sure about this code ? Looks not translatable.
Is it a type with _("bla bla") ?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30903] CSV import of quotes broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 --- Comment #7 from Jonathan Druart --- I think you are raising too many problems on the same bug :) We should first fix the import error (it's blocking the feature) then focus on the UI glitches (which are not major IMO) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30903] CSV import of quotes broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 --- Comment #6 from Caroline Cyr La Rose --- I tested and here are my comments: 1) The Browse/Choose file button is still off center for some reason, it's at the top of the box, rather than vertically centered. (see attached screenshot https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135781 ) I tried both in Firefox and Chrome and it's at the top in both browsers 2) The editing boxes are still really small, when compared to how they were previously, as illustrated in the manual (currently https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135782 previously https://koha-community.org/manual/latest/en/html/_images/editquote.png ) Again, I tried both in Firefox and Chrome and it's the same 3) The quotes seem to have been imported, if I trust the confirmation message, but I stayed on the same page and the two options available to me are "Save quotes", which I already clicked (multiple times because it was slow) and "Cancel import", which, if clicked, asks me a confirmation if I really want to cancel and sends me back to the import page with the Browse/Choose file button. I think once the quotes are imported, we should be sent back to the main QOTD editor page with the list of quotes already in the system. Caroline -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30903] CSV import of quotes broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 --- Comment #5 from Caroline Cyr La Rose --- Created attachment 135782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135782&action=edit Editing box is very small -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30903] CSV import of quotes broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 --- Comment #4 from Caroline Cyr La Rose --- Created attachment 135781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135781&action=edit Browse button off center from the box -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30903] CSV import of quotes broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30903] CSV import of quotes broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 --- Comment #3 from Jonathan Druart --- Created attachment 135774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135774&action=edit Bug 30903: Fix UI glitch on the quotes upload view -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30903] CSV import of quotes broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 --- Comment #2 from Jonathan Druart --- Created attachment 135773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135773&action=edit Bug 30903: Fix POST /quote quote_id should not be required -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30903] CSV import of quotes broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30903] CSV import of quotes broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 Katrin Fischer changed: What|Removed |Added Severity|enhancement |critical -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30903] CSV import of quotes broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903 --- Comment #1 from Caroline Cyr La Rose --- You can compare with what it used to look like in the screen captures in the manual : https://koha-community.org/manual/21.11/en/html/tools.html#edit-quotes-for-qotd-feature Upload page (step 3) : https://koha-community.org/manual/21.11/en/html/_images/importquotes.png Editing quotes (step 4) : https://koha-community.org/manual/21.11/en/html/_images/editquote.png -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
