[Koha-bugs] [Bug 30944] Recalls - action buttons to cancel recall on various pages do not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30944 --- Comment #10 from Katrin Fischer --- Created attachment 141208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141208=edit Bug 30944: Undo change to ILS-DI documentation The service not implemented by Koha is CancelRecall as specified in: https://old.diglib.org/architectures/ilsdi/DLF_ILS_Discovery_1.0.pdf Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30944] Recalls - action buttons to cancel recall on various pages do not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30944 Katrin Fischer changed: What|Removed |Added Attachment #140411|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 141207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141207=edit Bug 30944: Fix cancel recalls actions This patch fixes the 'cancel selected recalls' button on the biblio details Recalls page, and ensures a correct cancellation reason is logged when cancelling a recall in transit. To test: 1) Ensure UseRecalls is enabled and relevant recalls circulation rules are set 2) Check out Item A to Patron B 3) Log into OPAC as Patron A 4) Search for Item A and place a recall 5) Go back to the staff interface and search for Item A. When viewing the biblio record, go to the recalls tab. 6) Check the checkbox for your recall, and click the button to cancel selected recalls. 7) Confirm your recall is successfully removed and you're redirected to the correct recalls page for this biblio. 8) Go back to the OPAC and place a recall again. This time set the pickup location to a different library, one that you're not logged in at 9) Back in the staff interface, check in Item A and confirm the recall and transfer 10) Go to Circulation -> Recalls to pull. Your recall should show here. Click the button to cancel the recall and revert the transfer 11) Confirm the recall has been cancelled 12) Go to Reports and create a new SQL report with the following SQL: select * from branchtransfers b join items i on b.itemnumber=i.itemnumber where i.barcode = <> 13) Run the report and paste the barcode of Item A in the field 14) Confirm there are two rows returned - the transfer triggered when the recall was confirmed, with a reason of 'Recall' and a cancellation reason of 'RecallCancellation, and the transfer sending the item back home when the recall was cancelled, with a reason of 'RecallCancellation'. Sponsored-by: Catalyst IT Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30944] Recalls - action buttons to cancel recall on various pages do not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30944 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30944] Recalls - action buttons to cancel recall on various pages do not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30944 --- Comment #8 from Katrin Fischer --- Ok, took a while to work through this, but now I think I got it: * Bug 30924 added RecallCancellation to the branchtransfers.reason, but now we are also adding it to cancellation_reason. Makes sense. * The changes to the ilsdi files are not correct. The listings refer to the service defined in the ILS-DI documentation. It is called CancelRecall and should remain like that. See: https://old.diglib.org/architectures/ilsdi/DLF_ILS_Discovery_1.0.pdf. I am providing a follow-up for this. * I've run through the test plan without the change and didn't manage to create an entry to branchtransfers with CancelRecall so no more clean-up should be needed (it looked like the entries were not created properly at all) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30944] Recalls - action buttons to cancel recall on various pages do not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30944 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30944] Recalls - action buttons to cancel recall on various pages do not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30944 --- Comment #7 from David Nind --- Testing notes (using koha-testing-docker): - Setup recalls and replicate the issue as described in comment #1. - Apply the patch and update the database (updatedatabase). - Follow the test plan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30944] Recalls - action buttons to cancel recall on various pages do not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30944 David Nind changed: What|Removed |Added Text to go in the||This fixes the 'cancel' release notes||recall button in several ||places so that it now works ||as expected (including the ||recalls tab in a patron's ||details section, the ||recalls section for a ||record, and the circulation ||recalls queue and recalls ||to pull pages). It also ||ensures a correct ||cancellation reason is ||logged when cancelling a ||recall in transit. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30944] Recalls - action buttons to cancel recall on various pages do not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30944 David Nind changed: What|Removed |Added Attachment #139034|0 |1 is obsolete|| --- Comment #6 from David Nind --- Created attachment 140411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140411=edit Bug 30944: Fix cancel recalls actions This patch fixes the 'cancel selected recalls' button on the biblio details Recalls page, and ensures a correct cancellation reason is logged when cancelling a recall in transit. To test: 1) Ensure UseRecalls is enabled and relevant recalls circulation rules are set 2) Check out Item A to Patron B 3) Log into OPAC as Patron A 4) Search for Item A and place a recall 5) Go back to the staff interface and search for Item A. When viewing the biblio record, go to the recalls tab. 6) Check the checkbox for your recall, and click the button to cancel selected recalls. 7) Confirm your recall is successfully removed and you're redirected to the correct recalls page for this biblio. 8) Go back to the OPAC and place a recall again. This time set the pickup location to a different library, one that you're not logged in at 9) Back in the staff interface, check in Item A and confirm the recall and transfer 10) Go to Circulation -> Recalls to pull. Your recall should show here. Click the button to cancel the recall and revert the transfer 11) Confirm the recall has been cancelled 12) Go to Reports and create a new SQL report with the following SQL: select * from branchtransfers b join items i on b.itemnumber=i.itemnumber where i.barcode = <> 13) Run the report and paste the barcode of Item A in the field 14) Confirm there are two rows returned - the transfer triggered when the recall was confirmed, with a reason of 'Recall' and a cancellation reason of 'RecallCancellation, and the transfer sending the item back home when the recall was cancelled, with a reason of 'RecallCancellation'. Sponsored-by: Catalyst IT Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30944] Recalls - action buttons to cancel recall on various pages do not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30944 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30944] Recalls - action buttons to cancel recall on various pages do not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30944 Aleisha Amohia changed: What|Removed |Added Attachment #139012|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30944] Recalls - action buttons to cancel recall on various pages do not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30944 --- Comment #5 from Aleisha Amohia --- Created attachment 139034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139034=edit Bug 30944: Fix cancel recalls actions This patch fixes the 'cancel selected recalls' button on the biblio details Recalls page, and ensures a correct cancellation reason is logged when cancelling a recall in transit. To test: 1) Ensure UseRecalls is enabled and relevant recalls circulation rules are set 2) Check out Item A to Patron B 3) Log into OPAC as Patron A 4) Search for Item A and place a recall 5) Go back to the staff interface and search for Item A. When viewing the biblio record, go to the recalls tab. 6) Check the checkbox for your recall, and click the button to cancel selected recalls. 7) Confirm your recall is successfully removed and you're redirected to the correct recalls page for this biblio. 8) Go back to the OPAC and place a recall again. This time set the pickup location to a different library, one that you're not logged in at 9) Back in the staff interface, check in Item A and confirm the recall and transfer 10) Go to Circulation -> Recalls to pull. Your recall should show here. Click the button to cancel the recall and revert the transfer 11) Confirm the recall has been cancelled 12) Go to Reports and create a new SQL report with the following SQL: select * from branchtransfers b join items i on b.itemnumber=i.itemnumber where i.barcode = <> 13) Run the report and paste the barcode of Item A in the field 14) Confirm there are two rows returned - the transfer triggered when the recall was confirmed, with a reason of 'Recall' and a cancellation reason of 'RecallCancellation, and the transfer sending the item back home when the recall was cancelled, with a reason of 'RecallCancellation'. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30944] Recalls - action buttons to cancel recall on various pages do not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30944 Aleisha Amohia changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30944] Recalls - action buttons to cancel recall on various pages do not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30944 --- Comment #4 from Aleisha Amohia --- Created attachment 139012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139012=edit Bug 30944: Fix cancelling selected recalls from biblio recalls tab This is a WIP -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30944] Recalls - action buttons to cancel recall on various pages do not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30944 --- Comment #3 from Aleisha Amohia --- Taking a look now! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30944] Recalls - action buttons to cancel recall on various pages do not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30944 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz |ity.org | Status|NEW |ASSIGNED --- Comment #2 from Jonathan Druart --- Aleisha, can you have a look at this bug please? See the previous comment. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30944] Recalls - action buttons to cancel recall on various pages do not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30944 Jonathan Druart changed: What|Removed |Added CC||alei...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30944] Recalls - action buttons to cancel recall on various pages do not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30944 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com Severity|normal |major --- Comment #1 from Jonathan Druart --- (In reply to David Nind from comment #0) >c. In addition, after you press "Cancel...": > - the URL changes to > http://127.0.0.1:8081/cgi-bin/koha/recalls/request.pl > - clicking on normal (or any other tab gives you the message "The > record you requested does not exist ()." > - URL is > http://127.0.0.1:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber= Can be fixed with: diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/recalls/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/recalls/request.tt index 2f4a573cf8d..3fcc9d8ea9e 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/recalls/request.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/recalls/request.tt @@ -29,6 +29,7 @@ [% IF recalls.count %] + Select all [% INCLUDE 'recalls.inc' %] > 3. Once a recall is made, and checked in: >. From Circulation > Recalls > Recalls to pull: select "Cancel recall and > return to: Centerville: generates this error: > >DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st > execute failed: Data truncated for column 'reason' at row 1 at > /kohadevbox/koha/Koha/Object.pm line 170 > at /usr/share/perl5/DBIx/Class/Exception.pm line 77 > . branchtransfers.cancellation_reason does not contain 'RecallCancellation' (but 'CancelRecall') -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30944] Recalls - action buttons to cancel recall on various pages do not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30944 David Nind changed: What|Removed |Added Blocks||29734 See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30924 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29734 [Bug 29734] [OMNIBUS] Recalls for Koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
