[Koha-bugs] [Bug 31013] Reserved words as branchcodes cause search error in Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31013 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #8 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31013] Reserved words as branchcodes cause search error in Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31013 Arthur Suzuki changed: What|Removed |Added CC||arthur.suz...@biblibre.com Status|Pushed to stable|Pushed to oldstable Version(s)|22.11.00, 22.05.04 |22.11.00, 22.05.04, released in||21.11.11 --- Comment #7 from Arthur Suzuki --- pushed to 21.11.x for 21.11.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31013] Reserved words as branchcodes cause search error in Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31013 Lucas Gass changed: What|Removed |Added Version(s)|22.11.00|22.11.00, 22.05.04 released in|| Status|Pushed to master|Pushed to stable CC||lu...@bywatersolutions.com --- Comment #6 from Lucas Gass --- Backported to 22.05.x for 22.05.04 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31013] Reserved words as branchcodes cause search error in Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31013 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #5 from David Cook --- Btw, Nick, you made me chuckle with "Orly" heh. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31013] Reserved words as branchcodes cause search error in Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31013 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31013] Reserved words as branchcodes cause search error in Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31013 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31013] Reserved words as branchcodes cause search error in Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31013 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31013] Reserved words as branchcodes cause search error in Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31013 Martin Renvoize changed: What|Removed |Added QA Contact||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31013] Reserved words as branchcodes cause search error in Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31013 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31013] Reserved words as branchcodes cause search error in Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31013 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize --- Trivial and clear fix with unit tests included.. going straight for QA on this one. QA scripts are happy, testing proves the fix works, Unit tests all passing and changes make sense. Passing QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31013] Reserved words as branchcodes cause search error in Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31013 Martin Renvoize changed: What|Removed |Added Attachment #136412|0 |1 is obsolete|| --- Comment #2 from Martin Renvoize --- Created attachment 136419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136419&action=edit Bug 31013: Quote branchcodes in Elasticsearch limits This patch adds quoting when handling branchcodes in searching in order to prevent errors when branchcodes are reserved words in ES To test: 0 - Be using Elasticsearch with Koha 1 - Add a new branch code:OR name:Orly 2 - Add an item to this branch 3 - Use advanced search to limit search to only Orly 4 - Oh really bad, the search fails! 5 - Apply patch 6 - Repeat search 7 - Oh really good, the search succeeds 8 - prove t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31013] Reserved words as branchcodes cause search error in Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31013 --- Comment #1 from Nick Clemens --- Created attachment 136412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136412&action=edit Bug 31013: Quote branchcodes in Elasticsearch limits This patch adds quoting when handling branchcodes in searching in order to prevent errors when branchcodes are reserved words in ES To test: 0 - Be using Elasticsearch with Koha 1 - Add a new branch code:OR name:Orly 2 - Add an item to this branch 3 - Use advanced search to limit search to only Orly 4 - Oh really bad, the search fails! 5 - Apply patch 6 - Repeat search 7 - Oh really good, the search succeeds 8 - prove t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31013] Reserved words as branchcodes cause search error in Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31013 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
