[Koha-bugs] [Bug 31041] Cashup summary modal printing issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31041 Martin Renvoize changed: What|Removed |Added Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31041] Cashup summary modal printing issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31041 --- Comment #27 from Fridolin Somers --- (In reply to Katrin Fischer from comment #25) > (In reply to Fridolin Somers from comment #24) > > Pushed to 23.05.x for 23.05.06 > > This one cause a problem - you will need bug 35295 as well! Also backported -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31041] Cashup summary modal printing issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31041 --- Comment #26 from Pedro Amorim --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31041] Cashup summary modal printing issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31041 Pedro Amorim changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|23.11.00,23.05.06 |23.11.00,23.05.06,22.11.12 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31041] Cashup summary modal printing issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31041 --- Comment #25 from Katrin Fischer --- (In reply to Fridolin Somers from comment #24) > Pushed to 23.05.x for 23.05.06 This one cause a problem - you will need bug 35295 as well! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31041] Cashup summary modal printing issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31041 Fridolin Somers changed: What|Removed |Added Version(s)|23.11.00|23.11.00,23.05.06 released in|| CC||fridolin.som...@biblibre.co ||m Status|Pushed to master|Pushed to stable --- Comment #24 from Fridolin Somers --- Pushed to 23.05.x for 23.05.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31041] Cashup summary modal printing issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31041 --- Comment #23 from Victor Grousset/tuxayo --- It breaks the check-in pop notifying of holds! :o commit ef880e349f959686a830bda67ec5a295e3d76eb4 Bug 31041: (follow-up) Clean up and generalise Opened bug 35295 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31041] Cashup summary modal printing issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31041 Victor Grousset/tuxayo changed: What|Removed |Added Blocks||35295 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35295 [Bug 35295] No hold modal when checking in an item of a held record -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31041] Cashup summary modal printing issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31041 --- Comment #22 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31041] Cashup summary modal printing issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31041 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31041] Cashup summary modal printing issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31041 --- Comment #21 from Martin Renvoize --- Tested the follow-up and setting to PQA :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31041] Cashup summary modal printing issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31041 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31041] Cashup summary modal printing issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31041 Martin Renvoize changed: What|Removed |Added Attachment #158592|0 |1 is obsolete|| --- Comment #20 from Martin Renvoize --- Created attachment 158647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158647=edit Bug 31041: DO NOT PUSH - Testing Only This patch adds a script to allow easy population of a cashup using KTD. To use it 1) Start up a KTD 2) Enable UseCashRegisters system preference 3) Add a cash register with the name 'TEST' 4) Run this script from the command line 5) Navigate to the register you created to look at the cashups 6) Click on the summary link and print at the bottom of the modal and confirm that the modal prints as expected accross multiple pages without duplications or data lose. 7) Back on the register page, select to view the past months 'Older transactions'. This will lengthen the page significantly 8) Click on the summary link again and print.. Confirm that again the correct number of pages is printed and contain the correct content. This tests both scenarios.. where the background page spans multiple pages and where the modal content requires a scroll. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31041] Cashup summary modal printing issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31041 --- Comment #19 from Martin Renvoize --- Created attachment 158646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158646=edit Bug 31041: Add modal_printer.js asset to registers.tt Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31041] Cashup summary modal printing issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31041 Martin Renvoize changed: What|Removed |Added Attachment #158590|0 |1 is obsolete|| --- Comment #18 from Martin Renvoize --- Created attachment 158645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158645=edit Bug 31041: (follow-up) Clean up and generalise This patch cleans out the print media css rules that were originally added for modalprinting. The window.open method is simpler to maintain and will more reliably print modal content as expected. We factor out the printer code into it's own JS asset that we can apply to other printable modals and then use it in the two existing places where such modals have been defined already (cashup summary and bundle confirmation). Signed-off-by: Martin Renvoize Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31041] Cashup summary modal printing issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31041
Martin Renvoize changed:
What|Removed |Added
Attachment #158589|0 |1
is obsolete||
--- Comment #17 from Martin Renvoize ---
Created attachment 158644
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158644=edit
Bug 31041: Prevent duplicate display of cashup summary when printing
To test:
1. Have POS on.
2. Have some registers and items for sale. Make some sales to 'Cashup'.
3. If you have enough enough lines in the table so that 'register.pl' would
print on 2 or more pages, the summary will be duplicated that same number of
time.
If you are lazy like me and don't want to make that many transaction you can
also add some content to the page like this:
for (let i = 0; i < 100; i++) {
$('#register').append('TEST');
}
4. APPLY PATCH, clear browser cahche
5. Try printing again, you should only get one cashup summary when printing.
Signed-off-by: Juliet Heltibridle
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31041] Cashup summary modal printing issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31041 --- Comment #16 from Martin Renvoize --- Cheers for taking care of the missing inc Lucas, I fell asleep last night before getting to it. :-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31041] Cashup summary modal printing issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31041 --- Comment #15 from Lucas Gass --- Created attachment 158636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158636=edit Bug 31041: add modal_printer.js asset to registers.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31041] Cashup summary modal printing issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31041 Lucas Gass changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31041] Cashup summary modal printing issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31041 Lucas Gass changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #14 from Lucas Gass --- Thanks Martin! This all looks pretty good. However, there is one link in the #registers table ( in the Last cashup column) where the modal will pop-up but when I click 'Print' nothing happens. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31041] Cashup summary modal printing issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31041 Martin Renvoize changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31041] Cashup summary modal printing issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31041 --- Comment #13 from Martin Renvoize --- All working well, QA scripts happy. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31041] Cashup summary modal printing issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31041 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31041] Cashup summary modal printing issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31041 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31041] Cashup summary modal printing issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31041 Martin Renvoize changed: What|Removed |Added Text to go in the||This bugfix updates the release notes||modal printing system to ||trigger a new page for ||dialogue printing. || ||Whilst ||this causes a minor flash ||unsightly content at print ||preview, it significantly ||improves the reliability of ||modal printing where such ||dialogues appear on pages ||containing a lot of content ||or the modals themselves ||contain a enough content to ||require a scroll. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31041] Cashup summary modal printing issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31041 Martin Renvoize changed: What|Removed |Added Attachment #158591|0 |1 is obsolete|| --- Comment #12 from Martin Renvoize --- Created attachment 158592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158592=edit Bug 31041: DO NOT PUSH - Testing Only This patch adds a script to allow easy population of a cashup using KTD. To use it 1) Start up a KTD 2) Enable UseCashRegisters system preference 3) Add a cash register with the name 'TEST' 4) Run this script from the command line 5) Navigate to the register you created to look at the cashups 6) Click on the summary link and print at the bottom of the modal and confirm that the modal prints as expected accross multiple pages without duplications or data lose. 7) Back on the register page, select to view the past months 'Older transactions'. This will lengthen the page significantly 8) Click on the summary link again and print.. Confirm that again the correct number of pages is printed and contain the correct content. This tests both scenarios.. where the background page spans multiple pages and where the modal content requires a scroll. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31041] Cashup summary modal printing issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31041 --- Comment #11 from Martin Renvoize --- Created attachment 158591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158591=edit Bug 31041: DO NOT PUSH - Testing Only This patch adds a script to allow easy population of a cashup using KTD. To use it 1) Start up a KTD 2) Enable UseCashRegisters system preference 3) Add a cash register with the name 'TEST' 4) Run this script from the command line 5) Navigate to the register you created to look at the cashups 6) Click on the summary link and print at the bottom of the modal and confirm that the modal prints as expected accross multiple pages without duplications or data lose. 7) Back on the register page, select to view the past months 'Older transactions'. This will lengthen the page significantly 8) Click on the summary link again and print.. Confirm that again the correct number of pages is printed and contain the correct content. This tests both scenarios.. where the background page spans multiple pages and where the modal content requires a scroll. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31041] Cashup summary modal printing issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31041 --- Comment #10 from Martin Renvoize --- Created attachment 158590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158590=edit Bug 31041: (follow-up) Clean up and generalise This patch cleans out the print media css rules that were originally added for modalprinting. The window.open method is simpler to maintain and will more reliably print modal content as expected. We factor out the printer code into it's own JS asset that we can apply to other printable modals and then use it in the two existing places where such modals have been defined already (cashup summary and bundle confirmation). Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31041] Cashup summary modal printing issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31041
Martin Renvoize changed:
What|Removed |Added
Attachment #158342|0 |1
is obsolete||
--- Comment #9 from Martin Renvoize ---
Created attachment 158589
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158589=edit
Bug 31041: Prevent duplicate display of cashup summary when printing
To test:
1. Have POS on.
2. Have some registers and items for sale. Make some sales to 'Cashup'.
3. If you have enough enough lines in the table so that 'register.pl' would
print on 2 or more pages, the summary will be duplicated that same number of
time.
If you are lazy like me and don't want to make that many transaction you can
also add some content to the page like this:
for (let i = 0; i < 100; i++) {
$('#register').append('TEST');
}
4. APPLY PATCH, clear browser cahche
5. Try printing again, you should only get one cashup summary when printing.
Signed-off-by: Juliet Heltibridle
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31041] Cashup summary modal printing issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31041 --- Comment #8 from Katrin Fischer --- Thx for the help, Juliet :) Since Martin knows this code really well (having written it), I'll leave QA to him. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31041] Cashup summary modal printing issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31041 --- Comment #7 from Martin Renvoize --- This causes the print formatting to change a bit.. I'm not entirely against that, but it is a change. I need to think a bit about how this is implemented. The 'modalprinter' patturn is in use for the bundle confirmation modal as well as this one.. so it would be good to have a standard include for the JS that can be re-used for other printable modals. The basic premise here is.. Open the content of the modal in a new window and then print that.. as apposed the existing "hide everything that's not the modal" method that was in place prior to here.. we could certainly do some cleanup if we decide the 'open new window' approach is prefereable. I think I tried and failed to get the 'hide content' version to work as a fix here in the past so maybe the open window is the best way. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31041] Cashup summary modal printing issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31041 --- Comment #6 from Juliet Heltibridle --- (In reply to Katrin Fischer from comment #5) > I am having some trouble testing here, even with the "cheat" - can you > please add some more instructions on how to test and how to apply the JS? Katrin, are you making sure you are testing this on the register.pl page and not the registers.pl page? The registers.pl page works correctly. To test: 1. Have POS on. 2. Have some registers and items for sale. Make some sales to 'Cashup'. 2b. Record a Cashup 2c. Go to register.pl page (transaction history page) and attempt to print the Cashup summary. 3. If you have enough enough lines in the table so that 'register.pl' would print on 2 or more pages, the summary will be duplicated that same number of time. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31041] Cashup summary modal printing issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31041 Katrin Fischer changed: What|Removed |Added QA Contact|katrin.fisc...@bsz-bw.de|testo...@bugs.koha-communit ||y.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31041] Cashup summary modal printing issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31041 --- Comment #5 from Katrin Fischer --- I am having some trouble testing here, even with the "cheat" - can you please add some more instructions on how to test and how to apply the JS? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31041] Cashup summary modal printing issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31041 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31041] Cashup summary modal printing issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31041 Katrin Fischer changed: What|Removed |Added Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31041] Cashup summary modal printing issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31041 Juliet Heltibridle changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||jheltibri...@rcplib.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31041] Cashup summary modal printing issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31041
ByWater Sandboxes changed:
What|Removed |Added
Attachment #158283|0 |1
is obsolete||
--- Comment #4 from ByWater Sandboxes ---
Created attachment 158342
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158342=edit
Bug 31041: Prevent duplicate display of cashup summary when printing
To test:
1. Have POS on.
2. Have some registers and items for sale. Make some sales to 'Cashup'.
3. If you have enough enough lines in the table so that 'register.pl' would
print on 2 or more pages, the summary will be duplicated that same number of
time.
If you are lazy like me and don't want to make that many transaction you can
also add some content to the page like this:
for (let i = 0; i < 100; i++) {
$('#register').append('TEST');
}
4. APPLY PATCH, clear browser cahche
5. Try printing again, you should only get one cashup summary when printing.
Signed-off-by: Juliet Heltibridle
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31041] Cashup summary modal printing issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31041 Lucas Gass changed: What|Removed |Added CC||oleon...@myacpl.org --- Comment #3 from Lucas Gass --- CC'ing Owen here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31041] Cashup summary modal printing issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31041 Lucas Gass changed: What|Removed |Added Patch complexity|--- |Small patch Assignee|oleon...@myacpl.org |lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31041] Cashup summary modal printing issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31041
--- Comment #2 from Lucas Gass ---
Created attachment 158283
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158283=edit
Bug 31041: Prevent duplicate display of cashup summary when printing
To test:
1. Have POS on.
2. Have some registers and items for sale. Make some sales to 'Cashup'.
3. If you have enough enough lines in the table so that 'register.pl' would
print on 2 or more pages, the summary will be duplicated that same number of
time.
If you are lazy like me and don't want to make that many transaction you can
also add some content to the page like this:
for (let i = 0; i < 100; i++) {
$('#register').append('TEST');
}
4. APPLY PATCH, clear browser cahche
5. Try printing again, you should only get one cashup summary when printing.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31041] Cashup summary modal printing issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31041 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31041] Cashup summary modal printing issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31041
Lucas Gass changed:
What|Removed |Added
CC||lu...@bywatersolutions.com
--- Comment #1 from Lucas Gass ---
I was about to file a bug when I found this one. I have a similar, but not
exactly the same, problem.
We are noticing that the Cashup summary can be duplicated when the register.pl
page prints longer than two pages. From a stackoverflow post:
"The problem is that the content underlying the modal determines how many pages
are printed and if you are trying to print the content of the modal it will
print duplicates equaling the number pages in the underlying document"
https://stackoverflow.com/questions/68206205/same-page-prints-twice-when-using-a-bootstrap-full-screen-modal
So, to recreate:
1. Have POS on.
2. Have some registers and items for sale. Make some sales to 'Cashup'.
3. If you have enough enough lines in the table so that 'register.pl' would
print on 2 or more pages, the summary will be duplicated that same number of
time.
If you are lazy like me and don't want to make that many transaction you can
also add some content to the page like this:
for (let i = 0; i < 100; i++) {
$('#register').append('TEST');
}
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31041] Cashup summary modal printing issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31041 Martin Renvoize changed: What|Removed |Added Blocks||13985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31041] Cashup summary modal printing issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31041 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
