[Koha-bugs] [Bug 31055] Move koha-functions to /usr/sbin instead of koha/bin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31055 Marcel de Rooy changed: What|Removed |Added Resolution|--- |WONTFIX Status|In Discussion |RESOLVED --- Comment #12 from Marcel de Rooy --- Closing this one (again) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31055] Move koha-functions to /usr/sbin instead of koha/bin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31055 --- Comment #11 from Marcel de Rooy --- What is the conclusion of our discussion ? :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31055] Move koha-functions to /usr/sbin instead of koha/bin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31055
--- Comment #10 from wajasu ---
if you colocate the koha-functions.sh next to the other scripts, you can source
them path relative. But if other scripts somewhere else them, they will use
have an absolute path.
Some lib or scripts directory is definitely desired with an absolute path.
Will they be used by maintenance scripts? That you probably don't want in
/usr/sbin.
I didn't find any currently when grepping. Most of our scripts are perl, but
these are bash shell.
A) /usr/share/koha/lib <-- perl code
B) /usr/share/koha/lib/scripts <-- doesn't exist yet
C) /usr/sbin <-- but gets out commands available in system
dir
D) /usr/share/koha/bin <-- This is where koha-functions.sh is now.
(which not on the PATH in KTD. by design?)
I can easily test many of the koha-functions by sourcing the file from
debian/scripts and just calling them in the shell to examine $? and such.
Then I just run the cp_debian_files.pl everytime I make change. Because the
koha-commands are sourcing the absolute path anyway. A pain to fix/test, but
it works.
I tried to add a PREPATH inthe files/templates/defaults.env and change it in my
.env, but alas run.sh is set in stone in the image. Making it less easy to
change (accidentall).
I was trying to put /kohadevbox/koha/debian/scripts prepended to the PATH so I
could edit/test without cp_debian_files.pl but that would only work if run.sh
had PATH=${PREPATH}:/usr/bin/usr/sbin/${PATH}:/kohadevbox/bin and the koha-*
scripts used source ./koha-functions.sh
Maybe making it less painful to test with koha_functions.sh in the same
directory as /usr/sbin is less clunky to fix/test and even explain an easier
test plan (without cp_debian_files.pl).
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31055] Move koha-functions to /usr/sbin instead of koha/bin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31055 --- Comment #9 from David Cook --- I suppose it depends on how pedantic we want to be. But I think Marcel has a good point. It probably makes more sense to use "/usr/sbin" than "/usr/share/koha/bin" since that's where the other koha-* shell code is. Even if someone did run "koha-functions.sh" via $PATH, it wouldn't actually do anything. (Alternatively, we could always have a "/usr/share/koha/bin/scripts" and symlink the /usr/sbin/koha-* stuff to the code in that location. Plus potentially update koha-gitify to symlink /usr/sbin/koha-* stuff as well - at least on Debian/Ubuntu. ) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31055] Move koha-functions to /usr/sbin instead of koha/bin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31055 Tomás Cohen Arazi changed: What|Removed |Added CC||matted-34...@mypacks.net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31055] Move koha-functions to /usr/sbin instead of koha/bin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31055 Tomás Cohen Arazi changed: What|Removed |Added Status|REOPENED|In Discussion --- Comment #8 from Tomás Cohen Arazi --- wajasu was asking for this. Re-opening to keep the discussion flowing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31055] Move koha-functions to /usr/sbin instead of koha/bin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31055 Tomás Cohen Arazi changed: What|Removed |Added Resolution|WONTFIX |--- Status|RESOLVED|REOPENED --- Comment #7 from Tomás Cohen Arazi --- Hi all. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31055] Move koha-functions to /usr/sbin instead of koha/bin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31055 Marcel de Rooy changed: What|Removed |Added Resolution|--- |WONTFIX Status|Needs Signoff |RESOLVED --- Comment #6 from Marcel de Rooy --- It seems that no one is interested in this change. I will no longer spend time on it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31055] Move koha-functions to /usr/sbin instead of koha/bin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31055 --- Comment #5 from Marcel de Rooy --- (In reply to David Cook from comment #4) > Well, koha-functions.sh isn't a command/executable that should be in the > $PATH, so really it shouldn't be in /usr/sbin (or /usr/share/koha/bin > really). > > koha-functions.sh should probably be in /usr/lib/koha or /usr/share/koha/lib > I suppose. Thx David. Yes, you are quite right about that. Pragmatically, I would not mind pushing it along with the real scripts though. And cheatingly we could add some kind of help/usage statement to it, making it a real script too :) The fact that we are storing it in debian/scripts, gave it the .sh extension and copy it to koha/bin does not help either.. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31055] Move koha-functions to /usr/sbin instead of koha/bin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31055 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #4 from David Cook --- (In reply to Marcel de Rooy from comment #0) > For a long time I am copying koha-functions.sh to /usr/share/koha/bin, since > that is the location that the koha-* scripts expect it to be. > It would be easier to put it in sbin too. > > Please tell me if there are valid legitimate reasons to do not so. Well, koha-functions.sh isn't a command/executable that should be in the $PATH, so really it shouldn't be in /usr/sbin (or /usr/share/koha/bin really). koha-functions.sh should probably be in /usr/lib/koha or /usr/share/koha/lib I suppose. For example: /usr/lib/lsb/init-functions /usr/lib/cryptsetup/functions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31055] Move koha-functions to /usr/sbin instead of koha/bin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31055 Marcel de Rooy changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31055] Move koha-functions to /usr/sbin instead of koha/bin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31055 --- Comment #3 from Marcel de Rooy --- Created attachment 136581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136581=edit Bug 31055: Change the source statement in koha scripts All references to koha-functions moved to sbin. git grep -l "bin/koha-functions.sh" | xargs sed -i -e's/usr\/share\/koha\/bin\/koha-functions.sh/usr\/sbin\/koha-functions.sh/g' Test plan: [1] Copy debian scripts to /usr/sbin locally. [2] Remove /usr/share/koha/bin/koha-functions.sh [3] Try a few scripts [4] git grep -E "[^s]bin/koha-funct". No occurrences? Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31055] Move koha-functions to /usr/sbin instead of koha/bin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31055 --- Comment #2 from Marcel de Rooy --- Created attachment 136580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136580=edit Bug 31055: Update install location for koha-functions Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31055] Move koha-functions to /usr/sbin instead of koha/bin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31055 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31055] Move koha-functions to /usr/sbin instead of koha/bin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31055 --- Comment #1 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #0) > For a long time I am copying koha-functions.sh to /usr/share/koha/bin, since > that is the location that the koha-* scripts expect it to be. Talking about a gitified dev package install. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
