[Koha-bugs] [Bug 31105] Holds to pull counts items from other branches when independentbranches is active
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31105
Fridolin Somers changed:
What|Removed |Added
CC||fridolin.som...@biblibre.co
||m
--- Comment #7 from Fridolin Somers ---
-if ( C4::Context->preference('IndependentBranches') ){
+if ( C4::Context->only_my_library() ){
This change seems not related to this problem.
It changes behavior for superlibrarians with IndependentBranches = Yes.
So now behavior is different from waitingreserves.pl
I create a new bug report if we agree.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31105] Holds to pull counts items from other branches when independentbranches is active
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31105 Fridolin Somers changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=35139 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31105] Holds to pull counts items from other branches when independentbranches is active
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31105 Lucas Gass changed: What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31105] Holds to pull counts items from other branches when independentbranches is active
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31105 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31105] Holds to pull counts items from other branches when independentbranches is active
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31105 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31105] Holds to pull counts items from other branches when independentbranches is active
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31105 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 140902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140902=edit Bug 31105: Regression tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31105] Holds to pull counts items from other branches when independentbranches is active
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31105 Kyle M Hall changed: What|Removed |Added Attachment #137859|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall --- Created attachment 139496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139496=edit Bug 31105: Holds to pull counts items from other branches when independentbranches is active Holds to pull should not show items from other branches that shares a record when IndependentBranches is active. Except for superlibrarians. Test plan: 1- Have IndependentBranches set to Yes 2- Have a record with an item from the current branch and another item from a different branch. We will call them branch A and branch B respectively 3- Have a patron from branch A place a hold on that record 4- Have a staff account on branch A and B with the following permissions: - circulate (all) - catalogue 5- Go to circulation > holds to pull 6- Notice under "Libraries" it displays branch A and B. Also, it shows 2 under "Items available" 7- Checkout the item from branch A to another patron 8- Go back to circulation > holds to pull 9- Notice under "Libraries" it displays branch B even though we are in branch A 10- Apply the patch 11- Return the checked out item from step 7 12- Redo step 5 to 9 with superlibrarian privileges and notice nothing changed 13- Redo step 11-12 but using accounts from step 4 and notice Holds to pull only shows information relevant to their branch Signed-off-by: Sally Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31105] Holds to pull counts items from other branches when independentbranches is active
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31105 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31105] Holds to pull counts items from other branches when independentbranches is active
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31105 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31105] Holds to pull counts items from other branches when independentbranches is active
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31105 Victor Grousset/tuxayo changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31105] Holds to pull counts items from other branches when independentbranches is active
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31105 Sally changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||sally.healey@cheshireshared ||services.gov.uk --- Comment #3 from Sally --- Works as described, thanks for the patch! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31105] Holds to pull counts items from other branches when independentbranches is active
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31105 sandbo...@biblibre.com changed: What|Removed |Added Attachment #137181|0 |1 is obsolete|| --- Comment #2 from sandbo...@biblibre.com --- Created attachment 137859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137859=edit Bug 31105: Holds to pull counts items from other branches when independentbranches is active Holds to pull should not show items from other branches that shares a record when IndependentBranches is active. Except for superlibrarians. Test plan: 1- Have IndependentBranches set to Yes 2- Have a record with an item from the current branch and another item from a different branch. We will call them branch A and branch B respectively 3- Have a patron from branch A place a hold on that record 4- Have a staff account on branch A and B with the following permissions: - circulate (all) - catalogue 5- Go to circulation > holds to pull 6- Notice under "Libraries" it displays branch A and B. Also, it shows 2 under "Items available" 7- Checkout the item from branch A to another patron 8- Go back to circulation > holds to pull 9- Notice under "Libraries" it displays branch B even though we are in branch A 10- Apply the patch 11- Return the checked out item from step 7 12- Redo step 5 to 9 with superlibrarian privileges and notice nothing changed 13- Redo step 11-12 but using accounts from step 4 and notice Holds to pull only shows information relevant to their branch Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31105] Holds to pull counts items from other branches when independentbranches is active
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31105 Shi Yao Wang changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31105] Holds to pull counts items from other branches when independentbranches is active
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31105 --- Comment #1 from Shi Yao Wang --- Created attachment 137181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137181=edit Bug 31105: Holds to pull counts items from other branches when independentbranches is active Holds to pull should not show items from other branches that shares a record when IndependentBranches is active. Except for superlibrarians. Test plan: 1- Have IndependentBranches set to Yes 2- Have a record with an item from the current branch and another item from a different branch. We will call them branch A and branch B respectively 3- Have a patron from branch A place a hold on that record 4- Have a staff account on branch A and B with the following permissions: - circulate (all) - catalogue 5- Go to circulation > holds to pull 6- Notice under "Libraries" it displays branch A and B. Also, it shows 2 under "Items available" 7- Checkout the item from branch A to another patron 8- Go back to circulation > holds to pull 9- Notice under "Libraries" it displays branch B even though we are in branch A 10- Apply the patch 11- Return the checked out item from step 7 12- Redo step 5 to 9 with superlibrarian privileges and notice nothing changed 13- Redo step 11-12 but using accounts from step 4 and notice Holds to pull only shows information relevant to their branch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31105] Holds to pull counts items from other branches when independentbranches is active
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31105 Shi Yao Wang changed: What|Removed |Added CC||philippe.blo...@inlibro.com ||, shi-yao.w...@inlibro.com Assignee|koha-b...@lists.koha-commun |shi-yao.w...@inlibro.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
