[Koha-bugs] [Bug 31128] REST API item not_for_loan_status doesn't respect biblio level fallbacks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128 --- Comment #1 from Martin Renvoize --- As discussed on bug 29105 I opted instead to always add an effective_not_for_loan_status field rather than outright replace it... But, I'm really not sure about this approach.. it feels like we're seeking internal processes a lot here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31128] REST API item not_for_loan_status doesn't respect biblio level fallbacks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128 Martin Renvoize changed: What|Removed |Added Depends on||29105 Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 [Bug 29105] Add effective_item_type_id to the api items responses -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31128] REST API item not_for_loan_status doesn't respect biblio level fallbacks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128 --- Comment #2 from Martin Renvoize --- Created attachment 137507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137507&action=edit Bug 31128: Unit tests This patch adds unit tests for the new effective_not_for_loan_status which I add to the items api responses in this patchset. Test plan 1) Run the unit test without applying the next commit, it should fail 2) RUn the test again after applying the next commit, it should pass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31128] REST API item not_for_loan_status doesn't respect biblio level fallbacks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128 --- Comment #3 from Martin Renvoize --- Created attachment 137508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137508&action=edit Bug 31128: Add effective_not_for_loan_status into items response -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31128] REST API item not_for_loan_status doesn't respect biblio level fallbacks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31128] REST API item not_for_loan_status doesn't respect biblio level fallbacks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128 Martin Renvoize changed: What|Removed |Added CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31128] REST API item not_for_loan_status doesn't respect biblio level fallbacks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128 Martin Renvoize changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31128] REST API item not_for_loan_status doesn't respect biblio level fallbacks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31128] REST API item not_for_loan_status doesn't respect biblio level fallbacks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128 Nick Clemens changed: What|Removed |Added Attachment #137507|0 |1 is obsolete|| --- Comment #4 from Nick Clemens --- Created attachment 137574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137574&action=edit Bug 31128: Unit tests This patch adds unit tests for the new effective_not_for_loan_status which I add to the items api responses in this patchset. Test plan 1) Run the unit test without applying the next commit, it should fail 2) RUn the test again after applying the next commit, it should pass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31128] REST API item not_for_loan_status doesn't respect biblio level fallbacks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128 Nick Clemens changed: What|Removed |Added Attachment #137508|0 |1 is obsolete|| --- Comment #5 from Nick Clemens --- Created attachment 137575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137575&action=edit Bug 31128: Add effective_not_for_loan_status into items response -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31128] REST API item not_for_loan_status doesn't respect biblio level fallbacks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128 Nick Clemens changed: What|Removed |Added Attachment #137574|0 |1 is obsolete|| Attachment #137575|0 |1 is obsolete|| --- Comment #6 from Nick Clemens --- Created attachment 137576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137576&action=edit Bug 31128: Unit tests This patch adds unit tests for the new effective_not_for_loan_status which I add to the items api responses in this patchset. Test plan 1) Run the unit test without applying the next commit, it should fail 2) RUn the test again after applying the next commit, it should pass Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31128] REST API item not_for_loan_status doesn't respect biblio level fallbacks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128 --- Comment #7 from Nick Clemens --- Created attachment 137577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137577&action=edit Bug 31128: Add effective_not_for_loan_status into items response Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31128] REST API item not_for_loan_status doesn't respect biblio level fallbacks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Patch complexity|--- |Small patch --- Comment #8 from Victor Grousset/tuxayo --- > ->status_is( 200, 'SWAGGER3.2.2' ) How can we have Swagger version hardcoded in tests and it still works? Searching for "SWAGGER" shows multiple versions allover the tests and yet it still work :o -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31128] REST API item not_for_loan_status doesn't respect biblio level fallbacks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128 David Nind changed: What|Removed |Added Attachment #137576|0 |1 is obsolete|| --- Comment #9 from David Nind --- Created attachment 137593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137593&action=edit Bug 31128: Unit tests This patch adds unit tests for the new effective_not_for_loan_status which I add to the items api responses in this patchset. Test plan 1) Run the unit test without applying the next commit, it should fail 2) RUn the test again after applying the next commit, it should pass Signed-off-by: Nick Clemens Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31128] REST API item not_for_loan_status doesn't respect biblio level fallbacks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128 David Nind changed: What|Removed |Added Attachment #137577|0 |1 is obsolete|| --- Comment #10 from David Nind --- Created attachment 137594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137594&action=edit Bug 31128: Add effective_not_for_loan_status into items response Signed-off-by: Nick Clemens Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31128] REST API item not_for_loan_status doesn't respect biblio level fallbacks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128 --- Comment #11 from Martin Renvoize --- The bit you highlight Victor is actually just a comment rather than test condition. If I'm honest I'm not sure why that was used as the comment in the first place, I just used the president set in the rest of the test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31128] REST API item not_for_loan_status doesn't respect biblio level fallbacks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128 --- Comment #12 from Victor Grousset/tuxayo --- > The bit you highlight Victor is actually just a comment rather than test > condition. Ah, it's just string that pops when the test fails. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/