[Koha-bugs] [Bug 31150] _on or _date for DB date columns?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31150 Jonathan Druart changed: What|Removed |Added Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31150] _on or _date for DB date columns?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31150 --- Comment #1 from Jonathan Druart --- IRC log, 20200723 remind me of our policy on db column name consistency There_isNoCon_sistency! lol! maybe this? https://wiki.koha-community.org/wiki/DBIC_naming_conventions for a date, should end with _on or _date, apparently if above link is not good, let me know and I'll add a warning saying this is not accurate I don't know for you, but I feel like no column should ever be called just "id", but somethingid, so that it's the same in all tables I wrote that guideline I think. oh.. maybe not.. maybe I wrote the corresponding api one I prefer _on.. but don't really like inconsistency within a table but I also don't want to update other fields in the table. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31150] _on or _date for DB date columns?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31150 --- Comment #2 from Martin Renvoize --- Interesting.. I think we've since settled on _date to stay in line with the also recent discussions around api field names as described here: https://wiki.koha-community.org/wiki/Coding_Guidelines_-_API#SWAGGER1.3.4:_mapping We should update the db fields page you linked to link between the two definitions and make sure they're consistent. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31150] _on or _date for DB date columns?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31150 --- Comment #3 from Jonathan Druart --- At 20200129 dev meeting we discussed about _date for the REST API (does it cover timestamp and datetime as well, etc.) https://meetings.koha-community.org/2020/development_irc_meeting_29_january_2020.2020-01-29-14.00.log.txt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31150] _on or _date for DB date columns?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31150 --- Comment #4 from Martin Renvoize --- As for existing inconsistencies.. I'd love to fix those but I always get met with the "This will break reports" argument so in general I've ended up leaving the DB inconsistent and kept the old field names. I did have some partners complaining only a day ago that it's really annoying that our API field names dont match our database field names.. but I do think the API is much more consistent and better named in general... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31150] _on or _date for DB date columns?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31150 --- Comment #5 from Jonathan Druart --- (In reply to Martin Renvoize from comment #2) > Interesting.. I think we've since settled on _date to stay in line with the > also recent discussions around api field names as described here: > https://wiki.koha-community.org/wiki/Coding_Guidelines_-_API#SWAGGER1.3.4: > _mapping > > We should update the db fields page you linked to link between the two > definitions and make sure they're consistent. We never decided either. Hence this bug report. See previous comment. If we move to "*_date", does it include datetime and timestamp, etc. It's not that trivial. And in my mind we decided on "_on", or at least I picked that because it had the more occurrences in the codebase. There is no record of a community decision (at least I didn't find one). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31150] _on or _date for DB date columns?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31150 --- Comment #6 from Martin Renvoize --- Hmm, we dropped the 'DRAFT' part from the API Guidelines wiki page in the evening of 5th Februrary 2020, and I presume I only did that after we voted and agreed to it in a meeting.. I'll go hunting. https://wiki.koha-community.org/w/index.php?title=Coding_Guidelines_-_API&action=historysubmit&diff=24914&oldid=24910 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31150] _on or _date for DB date columns?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31150 --- Comment #7 from Martin Renvoize --- Found it.. we voted https://meetings.koha-community.org/2020/development_irc_meeting_5_february_2020.2020-02-05-20.00.log.html -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31150] _on or _date for DB date columns?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31150 --- Comment #8 from Jonathan Druart --- Yes, that's for the API, not the DB :-) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31150] _on or _date for DB date columns?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31150 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #9 from Fridolin Somers --- I'd say the "xxx_date" may be confusing because it is a data format. Using "xxx_on" is more specific to say "xxx field as been modified on this date". Plus have "created_on", "modified_on", "deleted_on". SQL Comments can always explain more. We will have to discuss some existing occurrences like : reserves.cancellationdate branchtransfers.date* "_on" +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31150] _on or _date for DB date columns?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31150 --- Comment #10 from Martin Renvoize --- DOI we really want to have contradictory guidelines for this.. it's already annoying having API fields named differently in the database.. here your basically suggesting enforcing that.. DB fields must not match API field.. that really doesn't make sense to me. I honestly don't remember the discussion around _on vas _date.. but I do remember we all agreed on one and put it in a guideline to prevent a debate every time we came to adding another API.. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31150] _on or _date for DB date columns?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31150 --- Comment #11 from Fridolin Somers --- Ahhh sorry I had not understood there is an existing guide line : https://wiki.koha-community.org/wiki/Coding_Guidelines_-_API#SWAGGER1.3.4.1_date.2Fdatetime.2Ftimestamp_fields I'm OK to stick to it and apply the same on DB fields. Maybe keep the items.xxx_on as a legacy ;) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31150] _on or _date for DB date columns?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31150 --- Comment #12 from Jonathan Druart --- (In reply to Martin Renvoize from comment #10) > DOI we really want to have contradictory guidelines for this.. it's already > annoying having API fields named differently in the database.. here your > basically suggesting enforcing that.. DB fields must not match API field.. > that really doesn't make sense to me. I honestly don't remember the > discussion around _on vas _date.. but I do remember we all agreed on one and > put it in a guideline to prevent a debate every time we came to adding > another API.. We never agreed on a convention for DB column names, hence this bug report. The guideline is for the REST API. """ Where a field contains a 'date' it should be consistently named *_date as opposed to date_* and it should always return a full datetime. """ As stated before, the problem is that a _date suffix is confusing for other datatypes IMO. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
